[Libosinfo] [PATCHv4 07/11] Automatically remap OsinfoInstallConfig values if needed

[Christophe Fergeau]

On Tue, Dec 18, 2012 at 11:03:24AM +0100, Christophe Fergeau wrote:
> On Tue, Dec 18, 2012 at 03:31:51AM +0200, Zeeshan Ali (Khattak) wrote:
> > On Mon, Dec 17, 2012 at 11:07 PM, Christophe Fergeau
> > <cfergeau at redhat.com> wrote:
> > > Now that OsinfoInstallConfig has access to the
> > > OsinfoInstallConfigParamList for the OsinfoInstallScript that is
> > > being configured,
> > 
> > In the previous patch (06/11) you just added the setter/getter for
> > config params to OsinfoInstallConfig but nothing yet sets the params.
> > Either I'm totally confused or the ordering of these patches is
> > somehow wrong.
> 
> Let's blame the commit log here

With the log changed to:

    OsinfoInstallConfig: Use config-params if set

    Now that OsinfoInstallConfig has a 'config-params' property
    which describes the config parameters when it's set, we can
    use it when it's available. OsinfoInstallConfigParams can indeed
    contain a datamap to be used to translate generic libosinfo values
    to OS-specific values.
    This commit introduces an osinfo_install_config_get_param_value_list
    method that will be used in subsequent commits to get these
    OS-specific values when generating install scripts.

does the patch looks better and in the right place?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20121218/b03d80cb/attachment.sig>