[Libosinfo] [PATCH 4/4] Add install script for RHEL 6.3

[Zeeshan Ali (Khattak)]

On Sat, Dec 29, 2012 at 1:11 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Sat, Dec 29, 2012 at 02:01:08AM +0200, Zeeshan Ali (Khattak) wrote:
>> On Thu, Dec 27, 2012 at 3:09 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Thu, Dec 27, 2012 at 02:55:04PM +0200, Zeeshan Ali (Khattak) wrote:
>> >> On Sun, Dec 23, 2012 at 7:15 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> >> > clearparts is the only command still trying to use target-disk,
>> >> > my guess is that this should be hardcoded to be done on the first disk some
>> >> > how, and 'target-disk' should never appear in this script.
>> >>
>> >> I don't think thats wise. RHEL 7.x will most likely support disk
>> >> arguments to  'part' commands (as Fedora17-18 supports it) and we
>> >> can't have conditions on configuration parameters but only on their
>> >> usage in the templates.
>> >
>> > Well, solve this the way you want, but having target-disk used only with
>> > clearparts in the script is wrong.
>>
>> Its not exactly wrong.
>
> It is wrong, passing 'target-disk' is really uninteresting and won't do
> what the user expects.

Thanks for completely ignoring my arguments.

> Anyway, after reading the RHEL kickstart documentation, I'm not sure why
> you got rid of the --ondisk/--ondrive arguments to the 'part' command as
> they are present in the documentation.

I'll check again..

> Christophe



-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124