[Libosinfo] [libosinfo 2/3] ubuntu: Add 12.10 test data

Christophe Fergeau cfergeau at redhat.com
Thu Apr 18 11:03:46 UTC 2013


On Thu, Apr 18, 2013 at 12:57:49PM +0200, Christophe Fergeau wrote:
> On Wed, Apr 17, 2013 at 06:59:10PM +0300, Zeeshan Ali (Khattak) wrote:
> > ACK. Although these patches adds a lot of lines, I think they should
> > still qualify as trivial especially when its from a person with commit
> > access. Just my two cents.
> 
> Given that the OS database is probably the part of libosinfo that has seen
> the most bugs[1], I don't consider them as trivial and I think they should
> go through review first.

Oh, after rereading this, maybe we are not talking of the same thing.
I'm talking about additions to data/oses, but maybe you were talking
about commits only adding new files to tests/isoinfo/ ?
I agree that the latter can be seen as a trivial patch as long as make
check still passes after the commit.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20130418/12def076/attachment.sig>


More information about the Libosinfo mailing list