From a.shabalin at gmail.com Mon Aug 12 11:32:25 2013 From: a.shabalin at gmail.com (Alexey Shabalin) Date: Mon, 12 Aug 2013 15:32:25 +0400 Subject: [Libosinfo] [PATCH] add ALTLinux support Message-ID: add ALTLinux support -- Alexey Shabalin -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: add-ALTLinux-support.patch Type: application/octet-stream Size: 54261 bytes Desc: not available URL: From a.shabalin at gmail.com Mon Aug 12 11:41:04 2013 From: a.shabalin at gmail.com (Alexey Shabalin) Date: Mon, 12 Aug 2013 15:41:04 +0400 Subject: [Libosinfo] [PATCH] add ALTLinux support Message-ID: add ALTLinux support -- Alexey Shabalin -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: add-ALTLinux-support.patch Type: application/octet-stream Size: 54261 bytes Desc: not available URL: From berrange at redhat.com Tue Aug 13 14:59:20 2013 From: berrange at redhat.com (Daniel P. Berrange) Date: Tue, 13 Aug 2013 15:59:20 +0100 Subject: [Libosinfo] [PATCH] add ALTLinux support In-Reply-To: References: Message-ID: <20130813145920.GP4432@redhat.com> On Mon, Aug 12, 2013 at 03:41:04PM +0400, Alexey Shabalin wrote: > add ALTLinux support Thanks for taking the time to create this patch. Will apply it shortly. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| From cfergeau at redhat.com Tue Aug 27 08:39:02 2013 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 27 Aug 2013 10:39:02 +0200 Subject: [Libosinfo] [libosinfo] Export more missing OsinfoProduct symbols Message-ID: <1377592742-6474-1-git-send-email-cfergeau@redhat.com> They were listed in public header files, but not exported in libosinfo.syms. --- When applying Giuseppe's patch, I've noticed more missing symbols from OsinfoProduct, so I've pushed this patch as a followup under the trivial rule. I'm currently experimenting with abi-compliance-checker to see if it can be used to check that all symbols listed in a public header file are exported, maybe there are better tools for that? Christophe osinfo/libosinfo.syms | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms index c56ff1f..7c191de 100644 --- a/osinfo/libosinfo.syms +++ b/osinfo/libosinfo.syms @@ -421,6 +421,10 @@ LIBOSINFO_0.2.7 { LIBOSINFO_0.2.8 { osinfo_product_get_codename; + osinfo_product_get_eol_date; + osinfo_product_get_eol_date_string; + osinfo_product_get_release_date; + osinfo_product_get_release_date_string; } LIBOSINFO_0.2.7; /* Symbols in next release... -- 1.8.3.1 From cfergeau at redhat.com Tue Aug 27 09:18:47 2013 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 27 Aug 2013 11:18:47 +0200 Subject: [Libosinfo] [libosinfo 1/2] Move osinfo_install_script_add_config_param to private header Message-ID: <1377595128-18185-1-git-send-email-cfergeau@redhat.com> When this method was added, we forgot to add it to the .sym file. It's meant to work with the osinfo_install_script_*_config_param() API, but these methods are not really consistent with the rest of libosinfo API, they belong in an OsinfoInstallConfigParamList class which was added in 789adb2a. We could decide to export this method, but since noone should have been able to use it, it's better to not export it now, and have one less deprecated method in our ABI. --- osinfo/osinfo_install_script.h | 2 -- osinfo/osinfo_install_script_private.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_install_script.h b/osinfo/osinfo_install_script.h index c3ec3c4..c39b786 100644 --- a/osinfo/osinfo_install_script.h +++ b/osinfo/osinfo_install_script.h @@ -185,8 +185,6 @@ gboolean osinfo_install_script_has_config_param_name(const OsinfoInstallScript * OsinfoInstallConfigParam *osinfo_install_script_get_config_param(const OsinfoInstallScript *script, const gchar *name); -void osinfo_install_script_add_config_param(OsinfoInstallScript *script, OsinfoInstallConfigParam *param); - GList *osinfo_install_script_get_config_param_list(const OsinfoInstallScript *script); OsinfoInstallConfigParamList *osinfo_install_script_get_config_params(const OsinfoInstallScript *script); OsinfoPathFormat osinfo_install_script_get_path_format(OsinfoInstallScript *script); diff --git a/osinfo/osinfo_install_script_private.h b/osinfo/osinfo_install_script_private.h index 9a9c17a..adf6320 100644 --- a/osinfo/osinfo_install_script_private.h +++ b/osinfo/osinfo_install_script_private.h @@ -27,6 +27,8 @@ #ifndef __OSINFO_INSTALL_SCRIPT_PRIVATE_H__ #define __OSINFO_INSTALL_SCRIPT_PRIVATE_H__ +void osinfo_install_script_add_config_param(OsinfoInstallScript *script, OsinfoInstallConfigParam *param); + void osinfo_install_script_set_avatar_format(OsinfoInstallScript *script, OsinfoAvatarFormat *avatar); -- 1.8.3.1 From cfergeau at redhat.com Tue Aug 27 09:18:48 2013 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 27 Aug 2013 11:18:48 +0200 Subject: [Libosinfo] [libosinfo 2/2] Export more missing symbols In-Reply-To: <1377595128-18185-1-git-send-email-cfergeau@redhat.com> References: <1377595128-18185-1-git-send-email-cfergeau@redhat.com> Message-ID: <1377595128-18185-2-git-send-email-cfergeau@redhat.com> All these symbols are present in the public headers but not listed in libosinfo.syms. They were found using abi-compliance-checker by comparing one build where the use of the .syms file is disabled (all non-static functions get exported), and one regular build. --- osinfo/libosinfo.syms | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms index 7c191de..ccd7c30 100644 --- a/osinfo/libosinfo.syms +++ b/osinfo/libosinfo.syms @@ -420,6 +420,23 @@ LIBOSINFO_0.2.7 { } LIBOSINFO_0.2.6; LIBOSINFO_0.2.8 { + osinfo_avatar_format_new; + + osinfo_install_config_get_hardware_arch; + osinfo_install_config_get_hostname; + osinfo_install_config_get_reg_login; + osinfo_install_config_get_reg_password; + osinfo_install_config_get_reg_product_key; + + osinfo_install_config_param_get_value_map; + osinfo_install_config_param_set_value_map; + + osinfo_install_script_get_output_prefix; + + osinfo_loader_process_local_path; + osinfo_loader_process_system_path; + osinfo_loader_process_user_path; + osinfo_product_get_codename; osinfo_product_get_eol_date; osinfo_product_get_eol_date_string; -- 1.8.3.1 From mprivozn at redhat.com Tue Aug 27 09:55:26 2013 From: mprivozn at redhat.com (Michal Privoznik) Date: Tue, 27 Aug 2013 11:55:26 +0200 Subject: [Libosinfo] [libosinfo 2/2] Export more missing symbols In-Reply-To: <1377595128-18185-2-git-send-email-cfergeau@redhat.com> References: <1377595128-18185-1-git-send-email-cfergeau@redhat.com> <1377595128-18185-2-git-send-email-cfergeau@redhat.com> Message-ID: <521C778E.5060508@redhat.com> On 27.08.2013 11:18, Christophe Fergeau wrote: > All these symbols are present in the public headers but not listed > in libosinfo.syms. > They were found using abi-compliance-checker by > comparing one build where the use of the .syms file is disabled (all > non-static functions get exported), and one regular build. > --- > osinfo/libosinfo.syms | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms > index 7c191de..ccd7c30 100644 > --- a/osinfo/libosinfo.syms > +++ b/osinfo/libosinfo.syms > @@ -420,6 +420,23 @@ LIBOSINFO_0.2.7 { > } LIBOSINFO_0.2.6; > > LIBOSINFO_0.2.8 { > + osinfo_avatar_format_new; > + > + osinfo_install_config_get_hardware_arch; > + osinfo_install_config_get_hostname; > + osinfo_install_config_get_reg_login; > + osinfo_install_config_get_reg_password; > + osinfo_install_config_get_reg_product_key; > + > + osinfo_install_config_param_get_value_map; > + osinfo_install_config_param_set_value_map; > + > + osinfo_install_script_get_output_prefix; > + > + osinfo_loader_process_local_path; > + osinfo_loader_process_system_path; > + osinfo_loader_process_user_path; > + > osinfo_product_get_codename; > osinfo_product_get_eol_date; > osinfo_product_get_eol_date_string; > ACK series. Michal From zeeshanak at gnome.org Tue Aug 27 17:36:33 2013 From: zeeshanak at gnome.org (Zeeshan Ali (Khattak)) Date: Tue, 27 Aug 2013 20:36:33 +0300 Subject: [Libosinfo] [libosinfo 1/2] Move osinfo_install_script_add_config_param to private header In-Reply-To: <1377595128-18185-1-git-send-email-cfergeau@redhat.com> References: <1377595128-18185-1-git-send-email-cfergeau@redhat.com> Message-ID: On Tue, Aug 27, 2013 at 12:18 PM, Christophe Fergeau wrote: > When this method was added, we forgot to add it to the .sym file. > It's meant to work with the osinfo_install_script_*_config_param() > API, but these methods are not really consistent with the rest of > libosinfo API, they belong in an OsinfoInstallConfigParamList class > which was added in 789adb2a. > We could decide to export this method, but since noone should have > been able to use it, it's better to not export it now, and have one > less deprecated method in our ABI. > --- Sounds right, ACK From cfergeau at redhat.com Tue Aug 27 18:31:13 2013 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 27 Aug 2013 20:31:13 +0200 Subject: [Libosinfo] [libosinfo] Don't install private headers Message-ID: <1377628273-9355-1-git-send-email-cfergeau@redhat.com> --- osinfo/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/osinfo/Makefile.am b/osinfo/Makefile.am index d946b7e..e9acbc4 100644 --- a/osinfo/Makefile.am +++ b/osinfo/Makefile.am @@ -76,7 +76,6 @@ OSINFO_HEADER_FILES = \ osinfo_install_script.h \ osinfo_install_scriptlist.h \ osinfo_product.h \ - osinfo_product_private.h \ osinfo_productfilter.h \ osinfo_productlist.h \ osinfo_platform.h \ @@ -87,7 +86,6 @@ OSINFO_HEADER_FILES = \ osinfo_deployment.h \ osinfo_deploymentlist.h \ osinfo_media.h \ - osinfo_media_private.h \ osinfo_medialist.h \ osinfo_resources.h \ osinfo_resourceslist.h \ @@ -123,6 +121,7 @@ libosinfo_1_0_la_SOURCES = \ osinfo_install_script_private.h \ osinfo_install_scriptlist.c \ osinfo_product.c \ + osinfo_product_private.h \ osinfo_productfilter.c \ osinfo_productlist.c \ osinfo_platform.c \ @@ -132,6 +131,7 @@ libosinfo_1_0_la_SOURCES = \ osinfo_deployment.c \ osinfo_deploymentlist.c \ osinfo_media.c \ + osinfo_media_private.h \ osinfo_medialist.c \ osinfo_resources.c \ osinfo_resourceslist.c \ -- 1.8.3.1 From zeeshanak at gnome.org Tue Aug 27 19:21:35 2013 From: zeeshanak at gnome.org (Zeeshan Ali (Khattak)) Date: Tue, 27 Aug 2013 22:21:35 +0300 Subject: [Libosinfo] [libosinfo] Don't install private headers In-Reply-To: <1377628273-9355-1-git-send-email-cfergeau@redhat.com> References: <1377628273-9355-1-git-send-email-cfergeau@redhat.com> Message-ID: On Tue, Aug 27, 2013 at 9:31 PM, Christophe Fergeau wrote: > --- ACK > osinfo/Makefile.am | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/osinfo/Makefile.am b/osinfo/Makefile.am > index d946b7e..e9acbc4 100644 > --- a/osinfo/Makefile.am > +++ b/osinfo/Makefile.am > @@ -76,7 +76,6 @@ OSINFO_HEADER_FILES = \ > osinfo_install_script.h \ > osinfo_install_scriptlist.h \ > osinfo_product.h \ > - osinfo_product_private.h \ > osinfo_productfilter.h \ > osinfo_productlist.h \ > osinfo_platform.h \ > @@ -87,7 +86,6 @@ OSINFO_HEADER_FILES = \ > osinfo_deployment.h \ > osinfo_deploymentlist.h \ > osinfo_media.h \ > - osinfo_media_private.h \ > osinfo_medialist.h \ > osinfo_resources.h \ > osinfo_resourceslist.h \ > @@ -123,6 +121,7 @@ libosinfo_1_0_la_SOURCES = \ > osinfo_install_script_private.h \ > osinfo_install_scriptlist.c \ > osinfo_product.c \ > + osinfo_product_private.h \ > osinfo_productfilter.c \ > osinfo_productlist.c \ > osinfo_platform.c \ > @@ -132,6 +131,7 @@ libosinfo_1_0_la_SOURCES = \ > osinfo_deployment.c \ > osinfo_deploymentlist.c \ > osinfo_media.c \ > + osinfo_media_private.h \ > osinfo_medialist.c \ > osinfo_resources.c \ > osinfo_resourceslist.c \ -- Regards, Zeeshan Ali (Khattak) FSF member#5124