[Libosinfo] [libosinfo 1/2] Move osinfo_install_script_add_config_param to private header

Christophe Fergeau cfergeau at redhat.com
Tue Aug 27 09:18:47 UTC 2013


When this method was added, we forgot to add it to the .sym file.
It's meant to work with the osinfo_install_script_*_config_param()
API, but these methods are not really consistent with the rest of
libosinfo API, they belong in an OsinfoInstallConfigParamList class
which was added in 789adb2a.
We could decide to export this method, but since noone should have
been able to use it, it's better to not export it now, and have one
less deprecated method in our ABI.
---
 osinfo/osinfo_install_script.h         | 2 --
 osinfo/osinfo_install_script_private.h | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/osinfo/osinfo_install_script.h b/osinfo/osinfo_install_script.h
index c3ec3c4..c39b786 100644
--- a/osinfo/osinfo_install_script.h
+++ b/osinfo/osinfo_install_script.h
@@ -185,8 +185,6 @@ gboolean osinfo_install_script_has_config_param_name(const OsinfoInstallScript *
 
 OsinfoInstallConfigParam *osinfo_install_script_get_config_param(const OsinfoInstallScript *script, const gchar *name);
 
-void osinfo_install_script_add_config_param(OsinfoInstallScript *script, OsinfoInstallConfigParam *param);
-
 GList *osinfo_install_script_get_config_param_list(const OsinfoInstallScript *script);
 OsinfoInstallConfigParamList *osinfo_install_script_get_config_params(const OsinfoInstallScript *script);
 OsinfoPathFormat osinfo_install_script_get_path_format(OsinfoInstallScript *script);
diff --git a/osinfo/osinfo_install_script_private.h b/osinfo/osinfo_install_script_private.h
index 9a9c17a..adf6320 100644
--- a/osinfo/osinfo_install_script_private.h
+++ b/osinfo/osinfo_install_script_private.h
@@ -27,6 +27,8 @@
 #ifndef __OSINFO_INSTALL_SCRIPT_PRIVATE_H__
 #define __OSINFO_INSTALL_SCRIPT_PRIVATE_H__
 
+void osinfo_install_script_add_config_param(OsinfoInstallScript *script, OsinfoInstallConfigParam *param);
+
 void osinfo_install_script_set_avatar_format(OsinfoInstallScript *script,
                                              OsinfoAvatarFormat *avatar);
 
-- 
1.8.3.1




More information about the Libosinfo mailing list