[Libosinfo] [PATCH 3/6] Revert "Add osinfo_install_config_new_for_script"

Daniel P. Berrange berrange at redhat.com
Wed Jan 9 12:37:46 UTC 2013


From: "Daniel P. Berrange" <berrange at redhat.com>

This reverts commit 82784b5f446e2b0cc47704df6ebddff804b4b667.
---
 osinfo/libosinfo.syms          |  1 -
 osinfo/osinfo_install_config.c | 31 -------------------------------
 osinfo/osinfo_install_config.h |  4 ----
 3 files changed, 36 deletions(-)

diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms
index efea371..a32a8b7 100644
--- a/osinfo/libosinfo.syms
+++ b/osinfo/libosinfo.syms
@@ -388,7 +388,6 @@ LIBOSINFO_0.2.3 {
 	osinfo_db_get_datamap_list;
 	osinfo_db_identify_media;
 
-	osinfo_install_config_new_for_script;
 	osinfo_install_config_get_config_params;
 
 	osinfo_install_config_paramlist_get_type;
diff --git a/osinfo/osinfo_install_config.c b/osinfo/osinfo_install_config.c
index 8572e1a..a650014 100644
--- a/osinfo/osinfo_install_config.c
+++ b/osinfo/osinfo_install_config.c
@@ -188,39 +188,8 @@ osinfo_install_config_init (OsinfoInstallConfig *config)
  */
 OsinfoInstallConfig *osinfo_install_config_new(const gchar *id)
 {
-    g_return_val_if_fail(id != NULL, NULL);
-
-    return g_object_new(OSINFO_TYPE_INSTALL_CONFIG, "id", id, NULL);
-}
-
-
-/**
- * osinfo_install_config_new_for_script:
- * @id: the unique identifier
- * @script: the #OsinfoInstallScript we are creating the configuration for
- *
- * Construct a new install configuration associated with @script.
- * OsinfoInstallConfig:config-params will contain the
- * #OsinfoInstallConfigParamList describing the parameters that can be set
- * on the config object when creating a configuration for @script. See
- * osinfo_install_config_new() for a description of the default values that
- * will be set on the newly created #OsinfoInstallConfig.
- *
- * Returns: (transfer full): an install configuration
- */
-OsinfoInstallConfig *osinfo_install_config_new_for_script(const gchar *id,
-                                                          OsinfoInstallScript *script)
-{
-    OsinfoInstallConfigParamList *params;
-
-    g_return_val_if_fail(id != NULL, NULL);
-    g_return_val_if_fail(script != NULL, NULL);
-
-    params = osinfo_install_script_get_config_params(script);
-
     return g_object_new(OSINFO_TYPE_INSTALL_CONFIG,
                         "id", id,
-                        "config-params", params,
                         NULL);
 }
 
diff --git a/osinfo/osinfo_install_config.h b/osinfo/osinfo_install_config.h
index 112860b..caf5518 100644
--- a/osinfo/osinfo_install_config.h
+++ b/osinfo/osinfo_install_config.h
@@ -72,8 +72,6 @@ typedef struct _OsinfoInstallConfig        OsinfoInstallConfig;
 typedef struct _OsinfoInstallConfigClass   OsinfoInstallConfigClass;
 typedef struct _OsinfoInstallConfigPrivate OsinfoInstallConfigPrivate;
 
-#include <osinfo/osinfo_install_script.h>
-
 /* object */
 struct _OsinfoInstallConfig
 {
@@ -97,8 +95,6 @@ struct _OsinfoInstallConfigClass
 GType osinfo_install_config_get_type(void);
 
 OsinfoInstallConfig *osinfo_install_config_new(const gchar *id);
-OsinfoInstallConfig *osinfo_install_config_new_for_script(const gchar *id,
-                                                          OsinfoInstallScript *script);
 
 void osinfo_install_config_set_hardware_arch(OsinfoInstallConfig *config,
                                              const gchar *arch);
-- 
1.8.1




More information about the Libosinfo mailing list