[Libosinfo] [[PATCHv2] 4/7] media: Add variant info API/XML

[Zeeshan Ali (Khattak)]

On Thu, Nov 28, 2013 at 8:24 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Nov 28, 2013 at 01:07:14AM +0000, Zeeshan Ali (Khattak) wrote:
>> +    g_return_val_if_fail(OSINFO_IS_MEDIA(media), NULL);
>> +    os = g_weak_ref_get(&media->priv->os);
>> +    os_variants = osinfo_os_get_variant_list(os);
>> +    g_object_unref (os);
>> +
>> +    ids = osinfo_entity_get_param_value_list(OSINFO_ENTITY(media),
>> +                                             OSINFO_MEDIA_PROP_VARIANT);
>> +    filter = osinfo_filter_new();
>> +    media_variants = osinfo_os_variantlist_new();
>> +    for (node = ids; node != NULL; node = node->next) {
>> +        osinfo_filter_clear_constraints(filter);
>> +        osinfo_filter_add_constraint(filter,
>> +                                     OSINFO_ENTITY_PROP_ID,
>> +                                     (const char *) node->data);
>> +        osinfo_list_add_filtered(OSINFO_LIST(media_variants),
>> +                                 OSINFO_LIST(os_variants),
>> +                                 filter);
>> +    }
>> +    g_object_unref (os_variants);
>
> Spacing is off here (space before '(' )

I missed this but I've corrected this for both cases above, locally.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124