[Libosinfo] [PATCH v2] win7: Put pro n sp1 regex under correct architecture

Christophe Fergeau cfergeau at redhat.com
Thu Apr 24 13:05:52 UTC 2014



----- Mail original -----
> In commit 39f22d2 (win7: Generalize volume-id for professional), I
> generalized the regex of windows 7 professional to include N SP1 but I
> ended up adding the regex for both i386 and x86_64 architectures under
> i386.
> 
> This patch fixes that.
> 

On second though, I'd probably not use a regex at all, but explicitly list every variant. Or we can start trying to decipher the label, I'm fairly sure all volume IDs can be generated using a few regexp.

ACK either way.

Christophe




More information about the Libosinfo mailing list