[Libosinfo] [PATCH 4/4] win2k12r2: Add metadata and a volume id

[Zeeshan Ali (Khattak)]

On Mon, Aug 18, 2014 at 4:50 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> ---

Looks good but commit log made me think you are only adding metadata
to an existing OS entry. I'd rather write:

win: Add info on win2k12r2

Add information on Microsoft Windows Server 2012 R2, including a volume ID.

>  data/oses/windows.xml.in                           | 21 ++++++++++++++++
>  ..._windows_server_2012_r2_x64_dvd_2707946.iso.txt | 29 ++++++++++++++++++++++
>  2 files changed, 50 insertions(+)
>  create mode 100644 test/isodata/windows/win2k12r2/en_windows_server_2012_r2_x64_dvd_2707946.iso.txt
>
> diff --git a/data/oses/windows.xml.in b/data/oses/windows.xml.in
> index 512fe17..285fb28 100644
> --- a/data/oses/windows.xml.in
> +++ b/data/oses/windows.xml.in
> @@ -1038,4 +1038,25 @@
>      <release-date>2012-09-04</release-date>
>    </os>
>
> +  <os id="http://microsoft.com/win/2k12r2">
> +    <short-id>win2k12r2</short-id>
> +    <_name>Microsoft Windows Server 2012 R2</_name>
> +    <version>6.3</version>
> +    <_vendor>Microsoft Corporation</_vendor>
> +    <family>winnt</family>
> +    <distro>win</distro>
> +    <derives-from id="http://microsoft.com/win/2k12"/>
> +    <upgrades id="http://microsoft.com/win/2k12"/>
> +
> +    <release-date>2013-10-18</release-date>
> +
> +    <media arch="x86_64">
> +      <iso>
> +        <volume-id>(IRM_SSS_X64FRE)_</volume-id>
> +        <publisher-id>MICROSOFT CORPORATION</publisher-id>
> +        <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/7/l10n-language">[[:upper:][:digit:]]*_([[:upper:]]*)</l10n-language>
> +      </iso>
> +    </media>
> +  </os>
> +
>  </libosinfo>
> diff --git a/test/isodata/windows/win2k12r2/en_windows_server_2012_r2_x64_dvd_2707946.iso.txt b/test/isodata/windows/win2k12r2/en_windows_server_2012_r2_x64_dvd_2707946.iso.txt
> new file mode 100644
> index 0000000..a38a1d8
> --- /dev/null
> +++ b/test/isodata/windows/win2k12r2/en_windows_server_2012_r2_x64_dvd_2707946.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id:
> +Volume id: IRM_SSS_X64FRE_EN-US_DV5
> +Volume set id: IRM_SSS_X64FRE_EN-US_DV5
> +Publisher id: MICROSOFT CORPORATION
> +Data preparer id: MICROSOFT CORPORATION, ONE MICROSOFT WAY, REDMOND WA 98052, (425) 882-8080
> +Application id: CDIMAGE 2.53 (01/01/2005 TM)
> +Copyright File id:
> +Abstract File id:
> +Bibliographic File id:
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 2084280
> +El Torito VD version 1 found, boot catalog is in sector 22
> +NO Joliet present
> +NO Rock Ridge present
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID 'Microsoft Corporation'
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 8
> +        Bootoff 876 2166
> --
> 1.9.3
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/