[Libosinfo] [PATCH v2 2/4] osinfo_loader: introduce a compiled xpaths cache

[Daniel P. Berrange]

On Tue, Jun 03, 2014 at 08:19:02PM +0200, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  osinfo/osinfo_loader.c | 124 ++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 87 insertions(+), 37 deletions(-)
> 

>  static int
>  osinfo_loader_nodeset(const char *xpath,
> +                      OsinfoLoader *loader,
>                        xmlXPathContextPtr ctxt,
>                        xmlNodePtr **list,
>                        GError **err)
> @@ -127,15 +152,19 @@ osinfo_loader_nodeset(const char *xpath,
>      xmlXPathObjectPtr obj;
>      xmlNodePtr relnode;
>      int ret;
> +    xmlXPathCompExprPtr comp;
>  
>      g_return_val_if_fail(ctxt != NULL, -1);
>      g_return_val_if_fail(xpath != NULL, -1);
> +    g_return_val_if_fail(loader != NULL, NULL);

s/NULL/-1/


ACK with the fix

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|