[Libosinfo] [PATCH v4 3/7] debian: add installer script

[Zeeshan Ali (Khattak)]

On Wed, Mar 5, 2014 at 3:01 PM, Giuseppe Scrivano <gscrivan at redhat.com> wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---

Looks good. One question below.

>  data/install-scripts/Makefile.am |  1 +
>  data/install-scripts/debian.xml  | 73 ++++++++++++++++++++++++++++++++++++++++
>  data/oses/debian.xml.in          | 12 +++++++
>  3 files changed, 86 insertions(+)
>  create mode 100644 data/install-scripts/debian.xml
>
> diff --git a/data/install-scripts/Makefile.am b/data/install-scripts/Makefile.am
> index c310468..442c286 100644
> --- a/data/install-scripts/Makefile.am
> +++ b/data/install-scripts/Makefile.am
> @@ -1,6 +1,7 @@
>
>  databasedir = $(pkgdatadir)/db/install-scripts/
>  database_DATA =     \
> +  debian.xml        \
>    fedora.xml        \
>    rhel.xml          \
>    windows-sif.xml   \
> diff --git a/data/install-scripts/debian.xml b/data/install-scripts/debian.xml
> new file mode 100644
> index 0000000..e826cc1
> --- /dev/null
> +++ b/data/install-scripts/debian.xml
> @@ -0,0 +1,73 @@
> +<libosinfo version="0.0.1">
> +  <install-script id='http://debian.org/scripts/debian/jeos'>
> +    <profile>jeos</profile>
> +    <expected-filename>debian.ks</expected-filename>
> +    <can-pre-install-drivers>true</can-pre-install-drivers>
> +    <config>
> +      <param name="admin-password" policy="optional"/>
> +      <param name="l10n-keyboard" policy="optional" value-map="http://libosinfo.fedorahosted.org/x11-keyboard"/>
> +      <param name="l10n-timezone" policy="optional"/>
> +      <param name="l10n-language" policy="optional"/>
> +    </config>
> +    <supported-injection-method>initrd</supported-injection-method>
> +    <template>
> +      <xsl:stylesheet
> +        xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
> +        version="1.0">
> +
> +        <xsl:output method="text"/>
> +
> +        <xsl:template match="/command-line">
> +            <xsl:text>file=/</xsl:text>
> +            <xsl:value-of select="script/expected-filename"/>
> +            <xsl:text> debian-installer/locale=</xsl:text>
> +            <xsl:value-of select="config/l10n-language"/>
> +            <xsl:text> keyboard-configuration/xkb-keymap=</xsl:text>
> +            <xsl:value-of select="config/l10n-keyboard"/>
> +            <xsl:text> auto-install/enableconsole-setup/ask_detect=false debconf/priority=critical netcfg/choose_interface=auto</xsl:text>

Do you really need to set all the configs on commandline while they
are being set from script itself?


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124