[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH 1/2] win7, winxp, installer: 'ComputerName' must be <= 15 characters



On Wed, May 14, 2014 at 3:09 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> On Tue, May 13, 2014 at 12:50:28PM +0100, Zeeshan Ali (Khattak) wrote:
>> > I'm also not sure substring will do the right thing with
>> > non-ASCII characters, which are potentially encoded as multiple bytes
>> > (the limit is 15 bytes, not 15 chars).
>>
>> That is true. Either I go work on my XSLT-foo and enforce this or we
>> can just document this in set_hostname. Reading this, I'd go for the
>> latter as non-ASCII won't be acceptable on other OSs either:
>>
>> https://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names
>
> Having some function which would be able to validate install script
> parameters, and report an error if the parameter does not fit the
> constraints for the current install script would probably be very
> useful. I'm not exactly sure how this could be done though :(

Sure but me neither. In the meantime, can we go with this patch and
documenting limitation set_hostname?

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]