[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH] debian: Add desktop install-script



On Wed, May 28, 2014 at 1:42 PM, Lasse Schuirmann
<lasse schuirmann gmail com> wrote:
> Hello,

Hi Lasse,

Firstly, please also ensure that jeos profile script works too. It has
only been tested against virt-install.

> the patch below introduces an installation script for debian. I tested
> it with gnome-boxes after applying the patches from
> https://bugzilla.gnome.org/show_bug.cgi?id=730640
>
> It currently installs debian without asking any questions. However
> there are two issues I couldn't solve yet:
>
> 1. The script does install GNOME as the only desktop environment.
>
> As I understand it the desktop package I use in this command:
>  tasksel tasksel/first multiselect standard desktop
> should use the appropriate desktop package for the given ISO. This doesn't work.

As we figured out during our chat, "doesn't work" does not mean
installation breaks but rather than GNOME is always installed. I don't
think its a big issue or at least its not an issue libosinfo should
solve since we are doing the right thing. This would be another bug
worth filing on Debian.

> Furthermore the several debian ISOs (e.g. KDE and lxde) have the same volume ID.
>
> 2. The script does not work without questions when no internet
> connection is present.

Right, as we discussed. We want to add a flag on the installer scripts
that tells apps about this requirement and then we need to honour that
in Boxes. Lets do that before merging this patch and modify this patch
to make use of it.

> +      <!-- Localization options -->

Kudos for dividing the params nicely into multiple blocks.

> +      <param name="l10n-keyboard" policy="optional"
> value-map="http://libosinfo.fedorahosted.org/x11-keyboard"/>
> +      <param name="l10n-language" policy="optional"/>
> +      <param name="l10n-timezone" policy="optional"/>
> +
> +      <!-- User options -->
> +      <param name="user-login" policy="required"/>
> +      <param name="user-fullname" policy="optional"/>
> +      <!-- This MUST be nonempty. Can we enforce this? -->
> +      <param name="user-password" policy="required"/>
> +      <param name="admin-password" policy="required"/>
> +
> +      <!-- Misc -->
> +      <param name="hostname" policy="optional"/>
> +      <param name="domain" policy="optional"/>
> +      <param name="target-disk" policy="optional"/>
> +    </config>
> +    <injection-method>initrd</injection-method>
> +    <template>
> +      <xsl:stylesheet
> +        xmlns:xsl="http://www.w3.org/1999/XSL/Transform";
> +        version="1.0">
> +
> +        <xsl:output method="text"/>
> +
> +        <xsl:template name="target-disk">
> +          <xsl:choose>
> +            <xsl:when test="config/target-disk != ''">
> +              <xsl:value-of select="config/target-disk"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:text>/dev/vda</xsl:text>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
> +        <xsl:template name="hostname">
> +          <xsl:choose>
> +            <xsl:when test="config/hostname != ''">
> +              <xsl:value-of select="config/hostname"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:value-of select="os/short-id"/>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
> +        <xsl:template name="user-fullname">
> +          <xsl:choose>
> +            <xsl:when test="config/user-fullname != ''">
> +              <xsl:value-of select="config/user-fullname"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:value-of select="config/user-login"/>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
> +        <xsl:template name="l10n-language">
> +          <xsl:choose>
> +            <xsl:when test="config/l10n-language != '' and
> config/l10n-language != 'C'">
> +              <xsl:value-of select="config/l10n-language"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:text>en_US</xsl:text>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
> +        <xsl:template name="l10n-keyboard">
> +          <xsl:choose>
> +            <xsl:when test="config/l10n-keyboard != '' and
> config/l10n-keyboard != 'C'">
> +              <xsl:value-of select="config/l10n-keyboard"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:text>us</xsl:text>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
> +        <xsl:template match="/command-line">
> +            <xsl:text>debian-installer/locale=</xsl:text>
> +            <xsl:value-of select="config/l10n-language"/>
> +            <xsl:text> keyboard-configuration/xkb-keymap=</xsl:text>
> +            <xsl:value-of select="config/l10n-keyboard"/>
> +            <xsl:text>
> auto-install/enableconsole-setup/ask_detect=false
> debconf/priority=critical netcfg/choose_interface=auto</xsl:text>
> +        </xsl:template>

Do these have to be passed through commandline and can't be passed
through initrd? If so, do we have this properly setup for JEOS
profile?

> +<xsl:template match="/install-script-config">
> +# For inspiration and explanations see:
> +# http://sfxpt.wordpress.com/2013/06/09/get-the-debianubuntu-ready-and-customized-the-way-you-like-in-10-minutes/
> +
> +
> +### Network
> +d-i netcfg/choose_interface select auto
> +d-i netcfg/get_hostname string <xsl:call-template name="hostname"/>
> +d-i netcfg/get_domain string <xsl:value-of select="config/domain"/>
> +d-i netcfg/disable_dhcp boolean false
> +
> +
> +### Localization
> +d-i debian-installer/locale string <xsl:call-template name="l10n-language"/>
> +d-i console-setup/layoutcode string <xsl:call-template name="l10n-keyboard"/>
> +d-i console-keymaps-at/keymap select <xsl:call-template name="l10n-keyboard"/>
> +d-i console-setup/variantcode string
> +d-i debian-installer/splash boolean false
> +d-i console-setup/ask_detect boolean false
> +
> +
> +### Time
> +d-i clock-setup/ntp boolean true
> +d-i clock-setup/utc boolean true
> +d-i time/zone select <xsl:value-of select="config/l10n-timezone"/>
> +
> +
> +### Account setup
> +
> +## Root
> +d-i passwd/root-login boolean true
> +d-i passwd/root-password password <xsl:value-of
> select="config/admin-password"/>
> +d-i passwd/root-password-again password <xsl:value-of
> select="config/admin-password"/>
> +
> +## User
> +d-i user-setup/allow-password-weak boolean true
> +d-i user-setup/encrypt-home boolean false
> +d-i passwd/user-fullname string <xsl:call-template name="user-fullname"/>
> +d-i passwd/username <xsl:value-of select="config/user-login"/>
> +d-i passwd/user-password password <xsl:value-of select="config/user-password"/>
> +d-i passwd/user-password-again password <xsl:value-of
> select="config/user-password"/>
> +
> +
> +### Partitioning
> +d-i partman-auto/disk string <xsl:call-template name="target-disk"/>
> +d-i partman-auto/method string regular
> +d-i partman-auto/choose_recipe select home
> +d-i partman/default_filesystem string ext4
> +d-i partman-auto/purge_lvm_from_device boolean true
> +# avoid any confirmation
> +d-i partman/choose_partition select finish
> +d-i partman/confirm_write_new_label boolean true
> +d-i partman/confirm_nooverwrite boolean true
> +d-i partman/confirm boolean true
> +
> +
> +### Apt
> +d-i apt-setup/security_host string
> +d-i apt-setup/services-select multiselect
> +d-i apt-setup/volatile_host string
> +d-i apt-setup/security_host string
> +
> +
> +### Software selection
> +d-i base-installer/install-recommends boolean false
> +tasksel tasksel/first multiselect standard desktop
> +
> +
> +### Bootloader
> +
> +## Dont use LILO
> +d-i lilo-installer/skip boolean true
> +
> +## GRUB settings
> +# Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=666974
> +d-i grub-installer/only_debian boolean false
> +d-i grub-installer/bootdev string <xsl:call-template name="target-disk"/>
> +
> +
> +### Cleanup
> +d-i finish-install/reboot_in_progress note
> +d-i cdrom-detect/eject boolean true

Is it so that if you don't eject from script, user will get prompted
about it? If not, I think we better leave this for apps.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]