[Libosinfo] [PATCH 05/10] Recommend osinfo_install_script_generate_*for_media()

[Christophe Fergeau]

On Thu, May 07, 2015 at 05:36:40PM +0100, Zeeshan Ali (Khattak) wrote:
> Recommend the use of the new script generation API that takes an
> identified media object as arugment rather than OS, in the docs.
> ---
>  osinfo/osinfo_install_script.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
> index 66593bb..5b1ee4f 100644
> --- a/osinfo/osinfo_install_script.c
> +++ b/osinfo/osinfo_install_script.c
> @@ -977,6 +977,10 @@ static void osinfo_install_script_generate_async_common(OsinfoInstallScript *scr
>   * Asynchronous variant of #osinfo_install_script_generate(). From the callback,
>   * call #osinfo_install_script_generate_finish() to conclude this call and get
>   * the generated script.
> + *
> + * If you are generating the script for a specific media, it is highly
> + * recommended that you use #osinfo_install_script_generate_for_media_async()
> + * instead.

I'd tend to drop the 'highly', but ACK either way.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20150512/02233a06/attachment.sig>