[Libosinfo] [v3 3/5] fedora,script: Install qemu-guest-agent

[Christophe Fergeau]

On Thu, Nov 19, 2015 at 09:12:33AM -0500, Zeeshan Ali (Khattak) wrote:
> On Mon, Nov 16, 2015 at 3:57 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Fri, Nov 13, 2015 at 01:18:53PM -0500, Zeeshan Ali (Khattak) wrote:
> >> For desktop profile.
> >> ---
> >>  .../fedoraproject.org/fedora-kickstart-desktop.xml.in              | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
> >> index be7a965..8ad2f05 100644
> >> --- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
> >> +++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
> >> @@ -156,6 +156,13 @@ url --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-install-
> >>  xorg-x11-drv-qxl
> >>  spice-vdagent
> >>
> >> +<xsl:choose>
> >> +  <xsl:when test="os/version > 15">
> >> +# Also Qemu agent
> >> +qemu-guest-agent
> >
> > I don't think the comment is needed.
> 
> IMO it's as much needed as the comment above:
> 
> "# QXL driver and SPICE vdagent"

I know there is a not really useful comment above it, but I don't think
that's a good reason for the addition of a new one.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20151119/032b9f68/attachment.sig>