[Libosinfo] [PATCH 1/5] rhel: Add RHEL 7.2 data

[Zeeshan Ali (Khattak)]

On Thu, Nov 19, 2015 at 1:48 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Nov 19, 2015 at 12:17:49PM -0500, Zeeshan Ali (Khattak) wrote:
>> On Thu, Nov 19, 2015 at 8:23 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > ---
>> >  data/os/redhat.com/rhel-7.2.xml.in                 | 84 ++++++++++++++++++++++
>> >  po/POTFILES.in                                     |  1 +
>> >  .../rhel-computenode-7.2-x86_64-dvd.iso.txt        | 29 ++++++++
>> >  .../rhel7.2/rhel-server-7.2-aarch64-dvd.iso.txt    | 29 ++++++++
>> >  .../rhel/rhel7.2/rhel-server-7.2-ppc64-dvd.iso.txt | 16 +++++
>> >  .../rhel7.2/rhel-server-7.2-ppc64le-dvd.iso.txt    | 16 +++++
>> >  .../rhel/rhel7.2/rhel-server-7.2-s390x-dvd.iso.txt | 16 +++++
>> >  .../rhel7.2/rhel-server-7.2-x86_64-dvd.iso.txt     | 29 ++++++++
>> >  8 files changed, 220 insertions(+)
>> >  create mode 100644 data/os/redhat.com/rhel-7.2.xml.in
>> >  create mode 100644 test/isodata/rhel/rhel7.2/rhel-computenode-7.2-x86_64-dvd.iso.txt
>> >  create mode 100644 test/isodata/rhel/rhel7.2/rhel-server-7.2-aarch64-dvd.iso.txt
>> >  create mode 100644 test/isodata/rhel/rhel7.2/rhel-server-7.2-ppc64-dvd.iso.txt
>> >  create mode 100644 test/isodata/rhel/rhel7.2/rhel-server-7.2-ppc64le-dvd.iso.txt
>> >  create mode 100644 test/isodata/rhel/rhel7.2/rhel-server-7.2-s390x-dvd.iso.txt
>> >  create mode 100644 test/isodata/rhel/rhel7.2/rhel-server-7.2-x86_64-dvd.iso.txt
>> >
>> > diff --git a/data/os/redhat.com/rhel-7.2.xml.in b/data/os/redhat.com/rhel-7.2.xml.in
>> > new file mode 100644
>> > index 0000000..2f8e95b
>> > --- /dev/null
>> > +++ b/data/os/redhat.com/rhel-7.2.xml.in
>> > @@ -0,0 +1,84 @@
>> > +<libosinfo version="0.0.1">
>> > +  <os id="http://redhat.com/rhel/7.2">
>> > +    <short-id>rhel7.2</short-id>
>> > +    <_name>Red Hat Enterprise Linux 7.2</_name>
>> > +    <version>7.2</version>
>> > +    <_vendor>Red Hat, Inc</_vendor>
>> > +    <family>linux</family>
>> > +    <distro>rhel</distro>
>> > +    <upgrades id="http://redhat.com/rhel/7.1"/>
>> > +    <derives-from id="http://redhat.com/rhel/7.1"/>
>> > +
>> > +    <media arch="x86_64">
>> > +      <iso>
>> > +        <system-id>LINUX</system-id>
>> > +        <volume-id>.*RHEL-7.2.*x86_64$</volume-id>
>>
>> The '.*' at the beginning and '$' is redundant since we don't expect
>> an exact match. The '$' also make is a bit too specific than needed.
>
> The .* is present in all volume-ids in data/os/redhat.com/rhel* (at
> least the ones I checked), better to send a patch to remove that from
> everywhere if needed imo.
> The $ is needed to differentiate between ppc64 and ppc64le (otherwise
> the ppc64 volume-id would match the ppc64le one). I added it to all
> volume-ids in this file for consistency (and imo clearly marking the
> expected end of the volume-id is not being too specific).

Ah ok. Thanks for explaining. ACK then.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/