[Libosinfo] [PATCH v3 05/12] win8.1: Add professional-vl volume ids (based on isodata info)

[Fabiano Fidêncio]

On Mon, Apr 25, 2016 at 5:38 PM, Zeeshan Ali (Khattak)
<zeeshanak at gnome.org> wrote:
> On Fri, Apr 22, 2016 at 6:34 PM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>> On Fri, Apr 22, 2016 at 2:56 PM, Zeeshan Ali (Khattak)
>> <zeeshanak at gnome.org> wrote:
>>> Hi Fabiano,
>>>
>>> Details should go into description and shortlog should ideally be a 50
>>> character summary.
>>>
>>> On Wed, Apr 20, 2016 at 4:55 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
>>>> From: Fabiano Fidêncio <fabiano at fidencio.org>
>>>>
>>>> After digging a bit into the isodata info provided for Windows 8.1, I
>>>> found out that all volume ids set as professional must be, actually,
>>>> part of the professional-vl. Also, a professional-vl volume id was lost
>>>> in the "Variant unknown" volume ids.
>>>
>>> Hmm.. I'm curious now. If all win7pro media known to us has been VL,
>>> how did you test the non-VL cases then?
>>
>> Win7 has only one VL iso IIRC. I decided to not start doing the
>> differentiation there because there is no practical point (as the
>> installation works well).
>
> At first I was wondering what you are talking about but then I
> realized my mistake: I meant win8.1 here, not win7.
>
>> I download and test Windows 8.1 Pro from MSDN that is not Pro VL. :-)
>
> In the past tense? Not sure I understand.

I downloaded and tested Windows 8.1 Pro from MSDN. It worked.
In another patch I mentioned that I had problems with an Enterprise
version though.
Also mentioned that I'll re-work the series and submit a v3 (solving
the Enterprise issue as well).

>
>>
>>>
>>>> Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
>>>> ---
>>>>  data/os/microsoft.com/win-8.1.xml.in | 14 +++++++-------
>>>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/data/os/microsoft.com/win-8.1.xml.in b/data/os/microsoft.com/win-8.1.xml.in
>>>> index 2c4ed21..1f87f8a 100644
>>>> --- a/data/os/microsoft.com/win-8.1.xml.in
>>>> +++ b/data/os/microsoft.com/win-8.1.xml.in
>>>> @@ -66,19 +66,19 @@
>>>>        </iso>
>>>>      </media>
>>>>
>>>> -    <!-- Professional -->
>>>> +    <!-- Professional VL-->
>>>>      <media arch="i686">
>>>> -      <variant id="professional"/>
>>>> +      <variant id="professional-vl"/>
>>>>        <iso>
>>>> -        <volume-id>(IR1_CPRN?A_X86FREV)_</volume-id>
>>>> +        <volume-id>(IR[M1]_CPRN?A_X86FREV)_</volume-id>
>>>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language">[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>>>        </iso>
>>>>      </media>
>>>>      <media arch="x86_64">
>>>> -      <variant id="professional"/>
>>>> +      <variant id="professional-vl"/>
>>>>        <iso>
>>>> -        <volume-id>(IR1_CPRN?A_X64FREV)_</volume-id>
>>>> +        <volume-id>(IR[M1]_CPRN?A_X64FREV|)_</volume-id>
>>>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language">[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>>>        </iso>
>>>> @@ -114,14 +114,14 @@
>>>>      <!-- Variant unknown -->
>>>>      <media arch="i686">
>>>>        <iso>
>>>> -        <volume-id>(IRM_CENNA_X86FREV|IRM_CENA_X86FREV|IR1_CENA_X86FREV|IRM_CCSNA_X86FRE|IRM_CPRNA_X86FREV|IRM_CPRA_X86FREV|IRM_CCSA_X86FRE|IR3_CCSNA_X86FRE|IR3_CENA_X86FREV)_</volume-id>
>>>> +        <volume-id>(IRM_CENNA_X86FREV|IRM_CENA_X86FREV|IR1_CENA_X86FREV|IRM_CCSNA_X86FRE|IRM_CPRA_X86FREV|IRM_CCSA_X86FRE|IR3_CCSNA_X86FRE|IR3_CENA_X86FREV)_</volume-id>
>>>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language">[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>>>        </iso>
>>>>      </media>
>>>>      <media arch="x86_64">
>>>>        <iso>
>>>> -        <volume-id>(IRM_CENNA_X64FREV|IRM_CENA_X64FREV|IR1_CENA_X64FREV|IRM_CCSNA_X64FRE|IRM_CPRNA_X64FREV|IRM_CPRA_X64FREV|IRM_CCSA_X64FRE|IR3_CCSNA_X64FRE)_</volume-id>
>>>> +        <volume-id>(IRM_CENNA_X64FREV|IRM_CENA_X64FREV|IR1_CENA_X64FREV|IRM_CCSNA_X64FRE|IRM_CPRA_X64FREV|IRM_CCSA_X64FRE|IR3_CCSNA_X64FRE)_</volume-id>
>>>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language">[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>>>        </iso>
>>>> --
>>>> 2.7.3
>>>>
>>>> _______________________________________________
>>>> Libosinfo mailing list
>>>> Libosinfo at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/libosinfo
>>>
>>>
>>>
>>> --
>>> Regards,
>>>
>>> Zeeshan Ali (Khattak)
>>>
>>> _______________________________________________
>>> Libosinfo mailing list
>>> Libosinfo at redhat.com
>>> https://www.redhat.com/mailman/listinfo/libosinfo
>>
>>
>>
>> --
>> Fabiano Fidêncio
>
>
>
> --
> Regards,
>
> Zeeshan Ali (Khattak)