[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH v3 05/12] win8.1: Add professional-vl volume ids (based on isodata info)



On Fri, Apr 22, 2016 at 2:56 PM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> Hi Fabiano,
>
> Details should go into description and shortlog should ideally be a 50
> character summary.

Here we don't agree that much. "(based on isodata info)" is an import
fact for this commit and not just a detail.
Whether it exceeds 50 chars, well, that's a detail. :-)

>
> On Wed, Apr 20, 2016 at 4:55 PM, Fabiano Fidêncio <fidencio redhat com> wrote:
>> From: Fabiano Fidêncio <fabiano fidencio org>
>>
>> After digging a bit into the isodata info provided for Windows 8.1, I
>> found out that all volume ids set as professional must be, actually,
>> part of the professional-vl. Also, a professional-vl volume id was lost
>> in the "Variant unknown" volume ids.
>
> Hmm.. I'm curious now. If all win7pro media known to us has been VL,
> how did you test the non-VL cases then?
>
>> Signed-off-by: Fabiano Fidêncio <fabiano fidencio org>
>> ---
>>  data/os/microsoft.com/win-8.1.xml.in | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/data/os/microsoft.com/win-8.1.xml.in b/data/os/microsoft.com/win-8.1.xml.in
>> index 2c4ed21..1f87f8a 100644
>> --- a/data/os/microsoft.com/win-8.1.xml.in
>> +++ b/data/os/microsoft.com/win-8.1.xml.in
>> @@ -66,19 +66,19 @@
>>        </iso>
>>      </media>
>>
>> -    <!-- Professional -->
>> +    <!-- Professional VL-->
>>      <media arch="i686">
>> -      <variant id="professional"/>
>> +      <variant id="professional-vl"/>
>>        <iso>
>> -        <volume-id>(IR1_CPRN?A_X86FREV)_</volume-id>
>> +        <volume-id>(IR[M1]_CPRN?A_X86FREV)_</volume-id>
>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language";>[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>        </iso>
>>      </media>
>>      <media arch="x86_64">
>> -      <variant id="professional"/>
>> +      <variant id="professional-vl"/>
>>        <iso>
>> -        <volume-id>(IR1_CPRN?A_X64FREV)_</volume-id>
>> +        <volume-id>(IR[M1]_CPRN?A_X64FREV|)_</volume-id>
>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language";>[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>        </iso>
>> @@ -114,14 +114,14 @@
>>      <!-- Variant unknown -->
>>      <media arch="i686">
>>        <iso>
>> -        <volume-id>(IRM_CENNA_X86FREV|IRM_CENA_X86FREV|IR1_CENA_X86FREV|IRM_CCSNA_X86FRE|IRM_CPRNA_X86FREV|IRM_CPRA_X86FREV|IRM_CCSA_X86FRE|IR3_CCSNA_X86FRE|IR3_CENA_X86FREV)_</volume-id>
>> +        <volume-id>(IRM_CENNA_X86FREV|IRM_CENA_X86FREV|IR1_CENA_X86FREV|IRM_CCSNA_X86FRE|IRM_CPRA_X86FREV|IRM_CCSA_X86FRE|IR3_CCSNA_X86FRE|IR3_CENA_X86FREV)_</volume-id>
>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language";>[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>        </iso>
>>      </media>
>>      <media arch="x86_64">
>>        <iso>
>> -        <volume-id>(IRM_CENNA_X64FREV|IRM_CENA_X64FREV|IR1_CENA_X64FREV|IRM_CCSNA_X64FRE|IRM_CPRNA_X64FREV|IRM_CPRA_X64FREV|IRM_CCSA_X64FRE|IR3_CCSNA_X64FRE)_</volume-id>
>> +        <volume-id>(IRM_CENNA_X64FREV|IRM_CENA_X64FREV|IR1_CENA_X64FREV|IRM_CCSNA_X64FRE|IRM_CPRA_X64FREV|IRM_CCSA_X64FRE|IR3_CCSNA_X64FRE)_</volume-id>
>>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language";>[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>>        </iso>
>> --
>> 2.7.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo redhat com
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
>
>
> --
> Regards,
>
> Zeeshan Ali (Khattak)
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo redhat com
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fidêncio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]