[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH v3 05/12] win8.1: Add professional-vl volume ids (based on isodata info)



On Fri, Apr 22, 2016 at 6:38 PM, Fabiano Fidêncio <fabiano fidencio org> wrote:
> On Fri, Apr 22, 2016 at 2:56 PM, Zeeshan Ali (Khattak)
> <zeeshanak gnome org> wrote:
>> Hi Fabiano,
>>
>> Details should go into description and shortlog should ideally be a 50
>> character summary.
>
> Here we don't agree that much. "(based on isodata info)" is an import
> fact for this commit and not just a detail.

I didn't say it is not important detail, but it's still a detail. The
fact that you had to write it in brackets, already tells you that.

> Whether it exceeds 50 chars, well, that's a detail. :-)

It's good to follow conventions whenever possible and in this case
they are very much so, so please do.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]