[Libosinfo] [PATCH] add support for ReactOS

[Daniel P. Berrange]

On Thu, Aug 11, 2016 at 12:02:31PM +0200, Thierry Vignaud wrote:
> notes:
> - it's not possible to differentiate LiveCD from regular installer
> - it's not possible to differentiate between different versions
> - network works OK (as in ping)
> ---
>  data/os/reactos/reactos.xml.in | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 data/os/reactos/reactos.xml.in
> 
> diff --git a/data/os/reactos/reactos.xml.in b/data/os/reactos/reactos.xml.in
> new file mode 100644
> index 0000000..54c62c9
> --- /dev/null
> +++ b/data/os/reactos/reactos.xml.in
> @@ -0,0 +1,38 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<libosinfo version="0.0.1">
> +  <os id="https://www.reactos.org/project-news/reactos-041-released">

The id must match the pattern

   http://vendor-domain/distro-name/version

the loader should be complaining that your ID here is not valid.

> +    <short-id>reactos</short-id>
> +    <name>ReactOS</name>
> +    <version>0.4.1</version>
> +    <vendor>ReactOS</vendor>
> +    <family>winnt</family>
> +    <distro>win</distro>
> +    <derives-from id="http://microsoft.com/win/7"/>
> +<!--
> +https://sourceforge.net/projects/reactos/files/ReactOS/0.4.1/ReactOS-0.4.1-REL-iso.zip/download
> +https://sourceforge.net/projects/reactos/files/ReactOS/0.4.1/ReactOS-0.4.1-REL-live.zip/download
> +-->
> +
> +    <release-date>2009-10-22</release-date>
> +    <eol-date>2015-01-13</eol-date>

These dates seem wrong  - according to

  https://sourceforge.net/projects/reactos/files/ReactOS/

the 0.4.1 relase was not uploaded until 2016/05/23

> +
> +    <media arch="i686">
> +      <iso>
> +	<!-- no way to distinguish Live from regular installer -->
> +        <volume-id>REACTOS</volume-id>

It would be nice to file a bug with reactos asking them to include the
version string + architecture in their volume-ids.

> +        <publisher-id>ReactOS Foundation</publisher-id>
> +      </iso>
> +    </media>
> +    
> +
> +    <resources arch="i686">
> +      <minimum>
> +        <cpu>1000000000</cpu>
> +        <n-cpus>1</n-cpus>
> +        <ram>1073741824</ram>
> +        <storage>4294967296</storage>
> +      </minimum>
> +    </resources>
> +
> +  </os>
> +</libosinfo>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|