From cfergeau at redhat.com Fri Jul 1 08:46:20 2016 From: cfergeau at redhat.com (Christophe Fergeau) Date: Fri, 1 Jul 2016 10:46:20 +0200 Subject: [Libosinfo] [libosinfo] osinfo-query: return failure when no matches are found In-Reply-To: <1467306250-6229-1-git-send-email-fidencio@redhat.com> References: <1467306250-6229-1-git-send-email-fidencio@redhat.com> Message-ID: <20160701084620.GY32126@edamame.cdg.redhat.com> On Thu, Jun 30, 2016 at 07:04:10PM +0200, Fabiano Fid?ncio wrote: > According to `man osinfo-query`: "The exit status will be 0 if matching > entries were found, or 1 if not matches were found". So, let's adapt the > program in order to match the manual. > > Also, this patch was written keeping the current behavior about printing > the Short ID, Name, Version, ID table. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1351718 > > Signed-off-by: Fabiano Fid?ncio > --- > tools/osinfo-query.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/tools/osinfo-query.c b/tools/osinfo-query.c > index 66f49e2..48e792f 100644 > --- a/tools/osinfo-query.c > +++ b/tools/osinfo-query.c > @@ -331,6 +331,9 @@ static gboolean print_results_text(OsinfoList *list, > } > g_print("\n"); > > + if (tmp == NULL) > + goto end; > + You could add a short /* No match /* comment before this if() or the goto. Acked-by: Christophe Fergeau Christophe > while (tmp) { > OsinfoEntity *entity = OSINFO_ENTITY(tmp->data); > > @@ -338,9 +341,10 @@ static gboolean print_results_text(OsinfoList *list, > tmp = tmp->next; > } > > + ret = TRUE; > > +end: > g_list_free(entities); > - ret = TRUE; > // cleanup: > return ret; > } > @@ -458,7 +462,13 @@ gint main(gint argc, gchar **argv) > > osinfo_list_add_filtered(results, entities, filter); > > - print_results_text(results, labels, sortKey); > + if (!print_results_text(results, labels, sortKey)) { > + /* > + * The os wasn't found, no need to print an error, > + * just be sure to return EXIT_FAILURE. > + */ > + goto error; > + } > > ret = EXIT_SUCCESS; > > -- > 2.7.4 > > _______________________________________________ > Libosinfo mailing list > Libosinfo at redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: From fidencio at redhat.com Fri Jul 1 08:57:44 2016 From: fidencio at redhat.com (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=) Date: Fri, 1 Jul 2016 10:57:44 +0200 Subject: [Libosinfo] [libosinfo] osinfo-query: return failure when no matches are found In-Reply-To: <20160701084620.GY32126@edamame.cdg.redhat.com> References: <1467306250-6229-1-git-send-email-fidencio@redhat.com> <20160701084620.GY32126@edamame.cdg.redhat.com> Message-ID: On Fri, Jul 1, 2016 at 10:46 AM, Christophe Fergeau wrote: > On Thu, Jun 30, 2016 at 07:04:10PM +0200, Fabiano Fid?ncio wrote: >> According to `man osinfo-query`: "The exit status will be 0 if matching >> entries were found, or 1 if not matches were found". So, let's adapt the >> program in order to match the manual. >> >> Also, this patch was written keeping the current behavior about printing >> the Short ID, Name, Version, ID table. >> >> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1351718 >> >> Signed-off-by: Fabiano Fid?ncio >> --- >> tools/osinfo-query.c | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/tools/osinfo-query.c b/tools/osinfo-query.c >> index 66f49e2..48e792f 100644 >> --- a/tools/osinfo-query.c >> +++ b/tools/osinfo-query.c >> @@ -331,6 +331,9 @@ static gboolean print_results_text(OsinfoList *list, >> } >> g_print("\n"); >> >> + if (tmp == NULL) >> + goto end; >> + > > You could add a short /* No match /* comment before this if() or the > goto. Suggestion taken, patch pushed! Best Regards, -- Fabiano Fid?ncio From berrange at redhat.com Fri Jul 1 10:03:00 2016 From: berrange at redhat.com (Daniel P. Berrange) Date: Fri, 1 Jul 2016 11:03:00 +0100 Subject: [Libosinfo] ANNOUNCE: libosinfo 0.3.1 release Message-ID: <20160701100300.GD4399@redhat.com> I am happy to announce a new release of libosinfo, version 0.3.1: https://fedorahosted.org/releases/l/i/libosinfo/libosinfo-0.3.1.tar.gz This is signed with key DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) https://fedorahosted.org/releases/l/i/libosinfo/libosinfo-0.3.1.tar.gz.asc All historical releases are available from: http://libosinfo.org/download/ Changes in this release include: - Require glib2 >= 2.36 - Replace GSimpleAsyncResult usage with GTask - Fix VPATH based builds - Don't include autogenerated enum files in dist - Fix build with older GCC versions - Add/improve/fix data for - Debian - SLES/SLED - OpenSUSE - FreeBSD - Windows - RHEL - Ubuntu - Update README content - Fix string comparison for bootable media detection - Fix linker flags for OS-X & solaris - Fix darwin detection code - Fix multiple memory leaks Thanks to everyone who contributed towards this release A special note to downstream vendors/distributors. The next major release of libosinfo will include a major change in the way libosinfo is released and distributed. The current single release will be replaced with three indepedantly released artifacts: - libosinfo - this will continue to provide the libosinfo shared library and most associated command line tools - osinfo-db - this will contain only the database XML files and RNG schema, no code at all. - osinfo-db-tools - a set of command line tools for managing deployment of osinfo-db archives for vendors & users. The libosinfo and osinfo-db-tools releases will be fairly infrequently as they are today. The osinfo-db releases will be done very frequently, with automated releases made available no more than 1 day after updated DB content is submitted to the project. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://libosinfo.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| From marcandre.lureau at redhat.com Tue Jul 5 11:18:43 2016 From: marcandre.lureau at redhat.com (marcandre.lureau at redhat.com) Date: Tue, 5 Jul 2016 13:18:43 +0200 Subject: [Libosinfo] [PATCH 0/2] virtio-gpu & fedora 24 Message-ID: <20160705111845.22409-1-marcandre.lureau@redhat.com> From: Marc-Andr? Lureau Add fedora 24 and virtio-gpu, so Boxes can start creating virgl-enabled VMs :) Marc-Andr? Lureau (2): device: add virtio-gpu fedora: Add F24 info & testcases configure.ac | 1 + data/device/pcisig.com/Makefile.am | 1 + data/device/pcisig.com/pci-1af4-1050.d/Makefile.am | 1 + .../device/pcisig.com/pci-1af4-1050.d/class.xml.in | 6 + data/os/fedoraproject.org/fedora-24.xml.in | 171 +++++++++++++++++++++ data/os/fedoraproject.org/fedora-unknown.xml.in | 12 +- po/POTFILES.in | 1 + .../fedora24/Fedora-Server-dvd-i386-24-1.2.iso.txt | 29 ++++ .../Fedora-Server-dvd-x86_64-24-1.2.iso.txt | 29 ++++ .../Fedora-Server-netinst-i386-24-1.2.iso.txt | 29 ++++ .../Fedora-Server-netinst-x86_64-24-1.2.iso.txt | 29 ++++ .../Fedora-Workstation-Live-i386-24-1.2.iso.txt | 29 ++++ .../Fedora-Workstation-Live-x86_64-24-1.2.iso.txt | 29 ++++ .../Fedora-Workstation-netinst-i386-24-1.2.iso.txt | 29 ++++ ...edora-Workstation-netinst-x86_64-24-1.2.iso.txt | 29 ++++ 15 files changed, 419 insertions(+), 6 deletions(-) create mode 100644 data/device/pcisig.com/pci-1af4-1050.d/Makefile.am create mode 100644 data/device/pcisig.com/pci-1af4-1050.d/class.xml.in create mode 100644 data/os/fedoraproject.org/fedora-24.xml.in create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-dvd-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-dvd-x86_64-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-netinst-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-netinst-x86_64-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-Live-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-Live-x86_64-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-netinst-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-netinst-x86_64-24-1.2.iso.txt -- 2.9.0 From marcandre.lureau at redhat.com Tue Jul 5 11:18:44 2016 From: marcandre.lureau at redhat.com (marcandre.lureau at redhat.com) Date: Tue, 5 Jul 2016 13:18:44 +0200 Subject: [Libosinfo] [PATCH 1/2] device: add virtio-gpu In-Reply-To: <20160705111845.22409-1-marcandre.lureau@redhat.com> References: <20160705111845.22409-1-marcandre.lureau@redhat.com> Message-ID: <20160705111845.22409-2-marcandre.lureau@redhat.com> From: Marc-Andr? Lureau virtio-gpu is a non-legacy device, so device_id is always 0x10 + 0x1040. Signed-off-by: Marc-Andr? Lureau --- configure.ac | 1 + data/device/pcisig.com/Makefile.am | 1 + data/device/pcisig.com/pci-1af4-1050.d/Makefile.am | 1 + data/device/pcisig.com/pci-1af4-1050.d/class.xml.in | 6 ++++++ 4 files changed, 9 insertions(+) create mode 100644 data/device/pcisig.com/pci-1af4-1050.d/Makefile.am create mode 100644 data/device/pcisig.com/pci-1af4-1050.d/class.xml.in diff --git a/configure.ac b/configure.ac index 12ff984..9ac5a51 100644 --- a/configure.ac +++ b/configure.ac @@ -266,6 +266,7 @@ AC_CONFIG_FILES([ data/device/pcisig.com/pci-1af4-1002.d/Makefile data/device/pcisig.com/pci-1af4-1003.d/Makefile data/device/pcisig.com/pci-1af4-1009.d/Makefile + data/device/pcisig.com/pci-1af4-1050.d/Makefile data/device/pcisig.com/pci-1b36-0100.d/Makefile data/device/pcisig.com/pci-8086-100e.d/Makefile data/device/pcisig.com/pci-8086-2415.d/Makefile diff --git a/data/device/pcisig.com/Makefile.am b/data/device/pcisig.com/Makefile.am index 567618a..4fd99e9 100644 --- a/data/device/pcisig.com/Makefile.am +++ b/data/device/pcisig.com/Makefile.am @@ -13,6 +13,7 @@ SUBDIRS = \ pci-1af4-1002.d \ pci-1af4-1003.d \ pci-1af4-1009.d \ + pci-1af4-1050.d \ pci-1b36-0100.d \ pci-8086-100e.d \ pci-8086-2415.d \ diff --git a/data/device/pcisig.com/pci-1af4-1050.d/Makefile.am b/data/device/pcisig.com/pci-1af4-1050.d/Makefile.am new file mode 100644 index 0000000..4ce2491 --- /dev/null +++ b/data/device/pcisig.com/pci-1af4-1050.d/Makefile.am @@ -0,0 +1 @@ +include ../../../Makefile.inc diff --git a/data/device/pcisig.com/pci-1af4-1050.d/class.xml.in b/data/device/pcisig.com/pci-1af4-1050.d/class.xml.in new file mode 100644 index 0000000..4d3ec16 --- /dev/null +++ b/data/device/pcisig.com/pci-1af4-1050.d/class.xml.in @@ -0,0 +1,6 @@ + + + virtio-gpu + video + + -- 2.9.0 From marcandre.lureau at redhat.com Tue Jul 5 11:18:45 2016 From: marcandre.lureau at redhat.com (marcandre.lureau at redhat.com) Date: Tue, 5 Jul 2016 13:18:45 +0200 Subject: [Libosinfo] [PATCH 2/2] fedora: Add F24 info & testcases In-Reply-To: <20160705111845.22409-1-marcandre.lureau@redhat.com> References: <20160705111845.22409-1-marcandre.lureau@redhat.com> Message-ID: <20160705111845.22409-3-marcandre.lureau@redhat.com> From: Marc-Andr? Lureau Fedora 24 with virtio-gpu support. Signed-off-by: Marc-Andr? Lureau --- data/os/fedoraproject.org/fedora-24.xml.in | 171 +++++++++++++++++++++ data/os/fedoraproject.org/fedora-unknown.xml.in | 12 +- po/POTFILES.in | 1 + .../fedora24/Fedora-Server-dvd-i386-24-1.2.iso.txt | 29 ++++ .../Fedora-Server-dvd-x86_64-24-1.2.iso.txt | 29 ++++ .../Fedora-Server-netinst-i386-24-1.2.iso.txt | 29 ++++ .../Fedora-Server-netinst-x86_64-24-1.2.iso.txt | 29 ++++ .../Fedora-Workstation-Live-i386-24-1.2.iso.txt | 29 ++++ .../Fedora-Workstation-Live-x86_64-24-1.2.iso.txt | 29 ++++ .../Fedora-Workstation-netinst-i386-24-1.2.iso.txt | 29 ++++ ...edora-Workstation-netinst-x86_64-24-1.2.iso.txt | 29 ++++ 11 files changed, 410 insertions(+), 6 deletions(-) create mode 100644 data/os/fedoraproject.org/fedora-24.xml.in create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-dvd-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-dvd-x86_64-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-netinst-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Server-netinst-x86_64-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-Live-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-Live-x86_64-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-netinst-i386-24-1.2.iso.txt create mode 100644 test/isodata/fedora/fedora24/Fedora-Workstation-netinst-x86_64-24-1.2.iso.txt diff --git a/data/os/fedoraproject.org/fedora-24.xml.in b/data/os/fedoraproject.org/fedora-24.xml.in new file mode 100644 index 0000000..5c5a801 --- /dev/null +++ b/data/os/fedoraproject.org/fedora-24.xml.in @@ -0,0 +1,171 @@ + + + fedora24 + <_name>Fedora 24 + 24 + <_vendor>Fedora Project + linux + fedora + + + + 2016-06-21 + + + + + + + <_name>Fedora 24 Workstation + + + <_name>Fedora 24 Workstation + + + <_name>Fedora 24 Server + + + <_name>Fedora 24 Server + + + + + + + + https://download.fedoraproject.org/pub/fedora/linux/releases/24/Workstation/i386/iso/Fedora-Workstation-Live-i386-24-1.2.iso + + Fedora-WS-Live-24.* + LINUX + + isolinux/vmlinuz0 + isolinux/initrd0.img + + + + https://download.fedoraproject.org/pub/fedora/linux/releases/24/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-24-1.2.iso + + Fedora-WS-Live-24.* + LINUX + + isolinux/vmlinuz0 + isolinux/initrd0.img + + + + + + https://download.fedoraproject.org/pub/fedora/linux/releases/24/Workstation/i386/iso/Fedora-Workstation-netinst-i386-24-1.2.iso + + Fedora-WS-dvd-i386-24 + LINUX + + isolinux/vmlinuz + isolinux/initrd.img + + + + https://download.fedoraproject.org/pub/fedora/linux/releases/24/Workstation/x86_64/iso/Fedora-Workstation-netinst-x86_64-24-1.2.iso + + Fedora-WS-dvd-x86_64-24 + LINUX + + isolinux/vmlinuz + isolinux/initrd.img + + + + + + + + https://download.fedoraproject.org/pub/fedora/linux/releases/24/Server/i386/iso/Fedora-Server-dvd-i386-24-1.2.iso + + Fedora-S-dvd-i386-24 + LINUX + + 1988413440 + + isolinux/vmlinuz + isolinux/initrd.img + + + + https://download.fedoraproject.org/pub/fedora/linux/releases/24/Server/x86_64/iso/Fedora-Server-dvd-x86_64-24-1.2.iso + + Fedora-S-dvd-x86_64-24 + LINUX + 1867970560 + + isolinux/vmlinuz + isolinux/initrd.img + + + + + + https://download.fedoraproject.org/pub/fedora/linux/releases/24/Server/i386/iso/Fedora-Server-netinst-i386-24-1.2.iso + + Fedora-S-dvd-i386-24 + LINUX + 514893824 + + isolinux/vmlinuz + isolinux/initrd.img + + + + http://download.fedoraproject.org/pub/fedora/linux/releases/24/Server/x86_64/iso/Fedora-Server-netinst-x86_64-24.iso + + Fedora-S-dvd-x86_64-24 + LINUX + 461770752 + + isolinux/vmlinuz + isolinux/initrd.img + + + + + http://download.fedoraproject.org/pub/fedora/linux/releases/24/Server/i386/os/ + + Fedora + 24 + i386 + + + + http://download.fedoraproject.org/pub/fedora/linux/releases/24/Server/x86_64/os/ + + + Fedora + 24 + x86_64 + + + + + + + + 1 + 1000000000 + 1073741824 + 10737418240 + + + + 2147483648 + 21474836480 + + + + +