[Libosinfo] [PATCH 2/2] fedora: Add F24 info & testcases

[Daniel P. Berrange]

On Thu, Jul 07, 2016 at 06:01:41AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Wed, Jul 06, 2016 at 11:45:45AM +0200, Christophe Fergeau wrote:
> > > On Tue, Jul 05, 2016 at 02:31:41PM +0100, Daniel P. Berrange wrote:
> > > > On Tue, Jul 05, 2016 at 01:18:45PM +0200, marcandre.lureau at redhat.com
> > > > wrote:
> > > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > > 
> > > > > Fedora 24 with virtio-gpu support.
> > > > > 
> > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > > ---
> > > > >  data/os/fedoraproject.org/fedora-24.xml.in         | 171
> > > > >  +++++++++++++++++++++
> > > > >  data/os/fedoraproject.org/fedora-unknown.xml.in    |  12 +-
> > > > >  po/POTFILES.in                                     |   1 +
> > > > >  .../fedora24/Fedora-Server-dvd-i386-24-1.2.iso.txt |  29 ++++
> > > > >  .../Fedora-Server-dvd-x86_64-24-1.2.iso.txt        |  29 ++++
> > > > >  .../Fedora-Server-netinst-i386-24-1.2.iso.txt      |  29 ++++
> > > > >  .../Fedora-Server-netinst-x86_64-24-1.2.iso.txt    |  29 ++++
> > > > >  .../Fedora-Workstation-Live-i386-24-1.2.iso.txt    |  29 ++++
> > > > >  .../Fedora-Workstation-Live-x86_64-24-1.2.iso.txt  |  29 ++++
> > > > >  .../Fedora-Workstation-netinst-i386-24-1.2.iso.txt |  29 ++++
> > > > >  ...edora-Workstation-netinst-x86_64-24-1.2.iso.txt |  29 ++++
> > > > >  11 files changed, 410 insertions(+), 6 deletions(-)
> > > > >  create mode 100644 data/os/fedoraproject.org/fedora-24.xml.in
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Server-dvd-i386-24-1.2.iso.txt
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Server-dvd-x86_64-24-1.2.iso.txt
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Server-netinst-i386-24-1.2.iso.txt
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Server-netinst-x86_64-24-1.2.iso.txt
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Workstation-Live-i386-24-1.2.iso.txt
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Workstation-Live-x86_64-24-1.2.iso.txt
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Workstation-netinst-i386-24-1.2.iso.txt
> > > > >  create mode 100644
> > > > >  test/isodata/fedora/fedora24/Fedora-Workstation-netinst-x86_64-24-1.2.iso.txt
> > > > > 
> > > > > diff --git a/data/os/fedoraproject.org/fedora-24.xml.in
> > > > > b/data/os/fedoraproject.org/fedora-24.xml.in
> > > > > new file mode 100644
> > > > > index 0000000..5c5a801
> > > > > --- /dev/null
> > > > > +++ b/data/os/fedoraproject.org/fedora-24.xml.in
> > > > > @@ -0,0 +1,171 @@
> > > > > +<libosinfo version="0.0.1">
> > > > > +  <os id="http://fedoraproject.org/fedora/24">
> > > > > +    <short-id>fedora24</short-id>
> > > > > +    <_name>Fedora 24</_name>
> > > > > +    <version>24</version>
> > > > > +    <_vendor>Fedora Project</_vendor>
> > > > > +    <family>linux</family>
> > > > > +    <distro>fedora</distro>
> > > > > +    <upgrades id="http://fedoraproject.org/fedora/23"/>
> > > > > +    <derives-from id="http://fedoraproject.org/fedora/23"/>
> > > > > +
> > > > > +    <release-date>2016-06-21</release-date>
> > > > > +
> > > > > +    <devices>
> > > > > +      <device id="http://pcisig.com/pci/1af4/1050"/> <!-- virtio-gpu
> > > > > -->
> > > > 
> > > > It looks like virtio-gpu guest kernel driver was introduced in
> > > > kernel 4.2, which means it was present in Fedora 23 already
> > > > (4.2.3 kernel at GA).
> > > > 
> > > > I realise the host side bits were only added in Fedora 24, but
> > > > since this is refering to the guest, i think we want this
> > > > device ID recorded against Fedora 23. Unless there was something
> > > > critically broken in the F23 guest driver that would prevent it
> > > > being used ?
> > > 
> > > The guest driver was fine, last time I tried it was mesa which was not
> > > good enough for virgl support.
> > 
> > Ok, if it is present but broken, we should pretend its not present at
> > all. We did his before with virtio-blk which was present but broken
> > in Fedora 9
> 
> So this patch is fine, right?

Yep, ack to that. It'll conflict with my patches, but I'm happy to resolve
the merge myself.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|