[Libosinfo] [PATCH 5/6] opensuse: Rename autoinst files according to their id

Fabiano Fidêncio fidencio at redhat.com
Thu Jun 2 17:02:08 UTC 2016


On Thu, Jun 2, 2016 at 6:57 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Jun 02, 2016 at 05:55:42PM +0200, Fabiano Fidêncio wrote:
>> On Thu, Jun 2, 2016 at 2:01 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > This causes warnings when running ./test/test-isodetect if they are not
>> > named as expected:
>> >
>> > ** (process:28952): WARNING **: Entity http://opensuse.org/opensuse/autoyast/desktop
>> > should be in file install-script/opensuse.org/opensuse-autoyast-desktop.xml not
>> > install-script/opensuse.org/autoinst-desktop.xml
>>
>> Hmmm. I don't remember seeing these warnings before pushing these patches. :-\
>> Wouldn't be the case to, somehow, make the test fail in case of these warnings?
>
> The test could set warnings to be fatal through g_log_set_fatal_mask().
> However, iirc there were somewhat valid warnings when the database
> layout changed. We can try to make warnings fatals for a while, and
> disable it if it proves to be too much of a pain.

I like the idea and I'd go for it.

>
> Christophe




More information about the Libosinfo mailing list