From berrange at redhat.com Mon Sep 5 14:39:02 2016 From: berrange at redhat.com (Daniel P. Berrange) Date: Mon, 5 Sep 2016 15:39:02 +0100 Subject: [Libosinfo] [PATCH] fedora: Install spice-webdavd dependency In-Reply-To: <1472550729-7480-1-git-send-email-viorel.visaron@gmail.com> References: <1472550729-7480-1-git-send-email-viorel.visaron@gmail.com> Message-ID: <20160905143902.GG24656@redhat.com> On Tue, Aug 30, 2016 at 12:52:09PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > GNOME-Boxes is developing a folder sharing feature which will > need spice-webdavd installed in the guest for it to work. > > Let's make the folder sharing feature available right after > express install in Fedora, by automaticaly installing spice-webdavd, > if available. > --- > data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in > index bd10fba..ba772ab 100644 > --- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in > +++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in > @@ -156,6 +156,10 @@ url --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$release > xorg-x11-drv-qxl > spice-vdagent > > + > +spice-webdavd > + > + > > > qemu-guest-agent ACK and pushed to git master Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| From dking at redhat.com Mon Sep 12 10:09:13 2016 From: dking at redhat.com (David King) Date: Mon, 12 Sep 2016 11:09:13 +0100 Subject: [Libosinfo] [PATCH libosinfo] Remove dead code Message-ID: <20160912100913.GB30290@microserver.cable.virginmedia.net> The while loop above the dead code already contains an error check, so this additional one will never be triggered. Found by Coverity. --- osinfo/osinfo_loader.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c index 46bc633..3168e9b 100644 --- a/osinfo/osinfo_loader.c +++ b/osinfo/osinfo_loader.c @@ -2118,9 +2118,6 @@ static void osinfo_loader_process_list(OsinfoLoader *loader, tmp++; } - if (lerr) - goto cleanup; - /* Phase 2: load data from non-native locations, filtering based * on overrides from native locations */ tmp = dirs; -- 2.7.4 From berrange at redhat.com Mon Sep 12 13:58:36 2016 From: berrange at redhat.com (Daniel P. Berrange) Date: Mon, 12 Sep 2016 14:58:36 +0100 Subject: [Libosinfo] [PATCH osinfo-db] make: add ability to build from non-local dir Message-ID: <1473688716-11002-1-git-send-email-berrange@redhat.com> Add ability to do a VPATH building by doing mkdir build cd build ln -s ../Makefile . make VPATH=.. Signed-off-by: Daniel P. Berrange --- Makefile | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 2223db3..3cffade 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,6 @@ +VPATH = . + TODAY = $(shell date +"%Y%m%d") OSINFO_DB_EXPORT = osinfo-db-export @@ -14,8 +16,8 @@ GETTEXT_PACKAGE = osinfo-db SED = sed -DATA_FILES_IN = $(wildcard data/*/*/*.xml.in) $(wildcard data/*/*/*/*.xml.in) -DATA_FILES = $(DATA_FILES_IN:%.in=%) +DATA_FILES_IN = $(wildcard $(VPATH)/data/*/*/*.xml.in) $(wildcard $(VPATH)/data/*/*/*/*.xml.in) +DATA_FILES = $(DATA_FILES_IN:$(VPATH)/%.in=%) SCHEMA_FILES_IN = data/schema/osinfo.rng.in SCHEMA_FILES = data/schema/osinfo.rng @@ -59,9 +61,11 @@ mingwrpm: mingw-osinfo-db.spec $(ARCHIVE) %.xml: %.xml.in Makefile - $(V_I18N) LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_MERGE_OPTS) -x -u -c po/.intltool-merge-cache po $< $@ + @mkdir -p `dirname $@` po + $(V_I18N) LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_MERGE_OPTS) -x -u -c po/.intltool-merge-cache $(VPATH)/po $< $@ %.rng: %.rng.in Makefile + @mkdir -p `dirname $@` po $(V_GEN) $(SED) -e "s/@VERSION@/$(TODAY)/" < $< > $@ $(ARCHIVE): $(DATA_FILES) $(SCHEMA_FILES) -- 2.7.4 From zeeshanak at gnome.org Tue Sep 13 08:21:45 2016 From: zeeshanak at gnome.org (Zeeshan Ali (Khattak)) Date: Tue, 13 Sep 2016 10:21:45 +0200 Subject: [Libosinfo] [PATCH osinfo-db] make: add ability to build from non-local dir In-Reply-To: <1473688716-11002-1-git-send-email-berrange@redhat.com> References: <1473688716-11002-1-git-send-email-berrange@redhat.com> Message-ID: Hi Daniel, Please push it if it works. On Mon, Sep 12, 2016 at 3:58 PM, Daniel P. Berrange wrote: > Add ability to do a VPATH building by doing > > mkdir build > cd build > ln -s ../Makefile . > make VPATH=.. > > Signed-off-by: Daniel P. Berrange > --- > Makefile | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 2223db3..3cffade 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,4 +1,6 @@ > > +VPATH = . > + > TODAY = $(shell date +"%Y%m%d") > > OSINFO_DB_EXPORT = osinfo-db-export > @@ -14,8 +16,8 @@ GETTEXT_PACKAGE = osinfo-db > > SED = sed > > -DATA_FILES_IN = $(wildcard data/*/*/*.xml.in) $(wildcard data/*/*/*/*.xml.in) > -DATA_FILES = $(DATA_FILES_IN:%.in=%) > +DATA_FILES_IN = $(wildcard $(VPATH)/data/*/*/*.xml.in) $(wildcard $(VPATH)/data/*/*/*/*.xml.in) > +DATA_FILES = $(DATA_FILES_IN:$(VPATH)/%.in=%) > > SCHEMA_FILES_IN = data/schema/osinfo.rng.in > SCHEMA_FILES = data/schema/osinfo.rng > @@ -59,9 +61,11 @@ mingwrpm: mingw-osinfo-db.spec $(ARCHIVE) > > > %.xml: %.xml.in Makefile > - $(V_I18N) LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_MERGE_OPTS) -x -u -c po/.intltool-merge-cache po $< $@ > + @mkdir -p `dirname $@` po > + $(V_I18N) LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_MERGE_OPTS) -x -u -c po/.intltool-merge-cache $(VPATH)/po $< $@ > > %.rng: %.rng.in Makefile > + @mkdir -p `dirname $@` po > $(V_GEN) $(SED) -e "s/@VERSION@/$(TODAY)/" < $< > $@ > > $(ARCHIVE): $(DATA_FILES) $(SCHEMA_FILES) > -- > 2.7.4 > > _______________________________________________ > Libosinfo mailing list > Libosinfo at redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo -- Regards, Zeeshan Ali From berrange at redhat.com Tue Sep 13 09:03:10 2016 From: berrange at redhat.com (Daniel P. Berrange) Date: Tue, 13 Sep 2016 10:03:10 +0100 Subject: [Libosinfo] [PATCH osinfo-db] Add support for DESTDIR Message-ID: <1473757390-5044-1-git-send-email-berrange@redhat.com> The jhbuild system doesn't support plain "make" systems, so we need to pretend to be more automake-like. Adding DESTDIR support lets jhbuild' automake "make install" step work. Signed-off-by: Daniel P. Berrange --- Makefile | 3 ++- autobuild.sh | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3cffade..53a2ea5 100644 --- a/Makefile +++ b/Makefile @@ -6,6 +6,7 @@ TODAY = $(shell date +"%Y%m%d") OSINFO_DB_EXPORT = osinfo-db-export OSINFO_DB_IMPORT = osinfo-db-import +DESTDIR = / OSINFO_DB_TARGET = --user INTLTOOL_MERGE = intltool-merge @@ -48,7 +49,7 @@ INTLTOOL_MERGE_OPTS_1 = all: $(ARCHIVE) osinfo-db.spec mingw-osinfo-db.spec install: $(ARCHIVE) - $(OSINFO_DB_IMPORT) $(OSINFO_DB_TARGET) $(ARCHIVE) + $(OSINFO_DB_IMPORT) --root $(DESTDIR) $(OSINFO_DB_TARGET) $(ARCHIVE) %.spec: %.spec.in Makefile $(V_GEN) $(SED) -e "s/@VERSION@/$(TODAY)/" < $< > $@ diff --git a/autobuild.sh b/autobuild.sh index d3b8cf4..d82b0ef 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -22,7 +22,7 @@ case $MAKEFLAGS in esac make -make install OSINFO_DB_TARGET="--system --root $AUTOBUILD_INSTALL_ROOT" +make install DESTDIR="$AUTOBUILD_INSTALL_ROOT" OSINFO_DB_TARGET="--system" if [ -n "$AUTOBUILD_COUNTER" ]; then EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" -- 2.7.4 From zeeshanak at gnome.org Tue Sep 13 09:59:27 2016 From: zeeshanak at gnome.org (Zeeshan Ali (Khattak)) Date: Tue, 13 Sep 2016 11:59:27 +0200 Subject: [Libosinfo] [PATCH osinfo-db] Add support for DESTDIR In-Reply-To: <1473757390-5044-1-git-send-email-berrange@redhat.com> References: <1473757390-5044-1-git-send-email-berrange@redhat.com> Message-ID: Hmm.. this would work but it creates an extra directory level, osinfo-db at DESTDIR (when invoked with --system target): /jhbuild/_jhbuild/root-osinfo-db/osinfo-db On Tue, Sep 13, 2016 at 11:03 AM, Daniel P. Berrange wrote: > The jhbuild system doesn't support plain "make" systems, > so we need to pretend to be more automake-like. Adding > DESTDIR support lets jhbuild' automake "make install" > step work. > > Signed-off-by: Daniel P. Berrange > --- > Makefile | 3 ++- > autobuild.sh | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 3cffade..53a2ea5 100644 > --- a/Makefile > +++ b/Makefile > @@ -6,6 +6,7 @@ TODAY = $(shell date +"%Y%m%d") > OSINFO_DB_EXPORT = osinfo-db-export > OSINFO_DB_IMPORT = osinfo-db-import > > +DESTDIR = / > OSINFO_DB_TARGET = --user > > INTLTOOL_MERGE = intltool-merge > @@ -48,7 +49,7 @@ INTLTOOL_MERGE_OPTS_1 = > all: $(ARCHIVE) osinfo-db.spec mingw-osinfo-db.spec > > install: $(ARCHIVE) > - $(OSINFO_DB_IMPORT) $(OSINFO_DB_TARGET) $(ARCHIVE) > + $(OSINFO_DB_IMPORT) --root $(DESTDIR) $(OSINFO_DB_TARGET) $(ARCHIVE) > > %.spec: %.spec.in Makefile > $(V_GEN) $(SED) -e "s/@VERSION@/$(TODAY)/" < $< > $@ > diff --git a/autobuild.sh b/autobuild.sh > index d3b8cf4..d82b0ef 100755 > --- a/autobuild.sh > +++ b/autobuild.sh > @@ -22,7 +22,7 @@ case $MAKEFLAGS in > esac > > make > -make install OSINFO_DB_TARGET="--system --root $AUTOBUILD_INSTALL_ROOT" > +make install DESTDIR="$AUTOBUILD_INSTALL_ROOT" OSINFO_DB_TARGET="--system" > > if [ -n "$AUTOBUILD_COUNTER" ]; then > EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" > -- > 2.7.4 > > _______________________________________________ > Libosinfo mailing list > Libosinfo at redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo -- Regards, Zeeshan Ali From berrange at redhat.com Tue Sep 13 10:06:20 2016 From: berrange at redhat.com (Daniel P. Berrange) Date: Tue, 13 Sep 2016 11:06:20 +0100 Subject: [Libosinfo] [PATCH osinfo-db] Add support for DESTDIR In-Reply-To: References: <1473757390-5044-1-git-send-email-berrange@redhat.com> Message-ID: <20160913100620.GL30949@redhat.com> On Tue, Sep 13, 2016 at 11:59:27AM +0200, Zeeshan Ali (Khattak) wrote: > Hmm.. this would work but it creates an extra directory level, > osinfo-db at DESTDIR (when invoked with --system target): > > /jhbuild/_jhbuild/root-osinfo-db/osinfo-db Are your sure that's not related to configure args you used when building osinfo-db-tools. The osinfo-db-import command will merely concatenate the default --system path with the --root path. So eg if I see the default system path: $ osinfo-db-path --system /usr/share/osinfo And use a --root of /tmp/jhbuild: $ osinfo-db-import --root /tmp/jhbuild --system osinfo-db-20160913.tar.xz It'll end up installing in $ ls /tmp/jhbuild/usr/share/osinfo/ datamap device install-script os platform schema VERSION So whatever path you are getting is a result of of args you passed for DESTDIR and/or previous configure args used for osinfo-db-tools build > On Tue, Sep 13, 2016 at 11:03 AM, Daniel P. Berrange > wrote: > > The jhbuild system doesn't support plain "make" systems, > > so we need to pretend to be more automake-like. Adding > > DESTDIR support lets jhbuild' automake "make install" > > step work. > > > > Signed-off-by: Daniel P. Berrange > > --- > > Makefile | 3 ++- > > autobuild.sh | 2 +- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 3cffade..53a2ea5 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -6,6 +6,7 @@ TODAY = $(shell date +"%Y%m%d") > > OSINFO_DB_EXPORT = osinfo-db-export > > OSINFO_DB_IMPORT = osinfo-db-import > > > > +DESTDIR = / > > OSINFO_DB_TARGET = --user > > > > INTLTOOL_MERGE = intltool-merge > > @@ -48,7 +49,7 @@ INTLTOOL_MERGE_OPTS_1 = > > all: $(ARCHIVE) osinfo-db.spec mingw-osinfo-db.spec > > > > install: $(ARCHIVE) > > - $(OSINFO_DB_IMPORT) $(OSINFO_DB_TARGET) $(ARCHIVE) > > + $(OSINFO_DB_IMPORT) --root $(DESTDIR) $(OSINFO_DB_TARGET) $(ARCHIVE) > > > > %.spec: %.spec.in Makefile > > $(V_GEN) $(SED) -e "s/@VERSION@/$(TODAY)/" < $< > $@ > > diff --git a/autobuild.sh b/autobuild.sh > > index d3b8cf4..d82b0ef 100755 > > --- a/autobuild.sh > > +++ b/autobuild.sh > > @@ -22,7 +22,7 @@ case $MAKEFLAGS in > > esac > > > > make > > -make install OSINFO_DB_TARGET="--system --root $AUTOBUILD_INSTALL_ROOT" > > +make install DESTDIR="$AUTOBUILD_INSTALL_ROOT" OSINFO_DB_TARGET="--system" > > > > if [ -n "$AUTOBUILD_COUNTER" ]; then > > EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" > > -- Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| From zeeshanak at gnome.org Tue Sep 13 11:10:11 2016 From: zeeshanak at gnome.org (Zeeshan Ali (Khattak)) Date: Tue, 13 Sep 2016 13:10:11 +0200 Subject: [Libosinfo] [PATCH osinfo-db] Add support for DESTDIR In-Reply-To: <20160913100620.GL30949@redhat.com> References: <1473757390-5044-1-git-send-email-berrange@redhat.com> <20160913100620.GL30949@redhat.com> Message-ID: Hi, On Tue, Sep 13, 2016 at 12:06 PM, Daniel P. Berrange wrote: > On Tue, Sep 13, 2016 at 11:59:27AM +0200, Zeeshan Ali (Khattak) wrote: >> Hmm.. this would work but it creates an extra directory level, >> osinfo-db at DESTDIR (when invoked with --system target): >> >> /jhbuild/_jhbuild/root-osinfo-db/osinfo-db > > Are your sure that's not related to configure args you used > when building osinfo-db-tools. That's just it. jhbuild is expecting osinfo-db to install standard system paths (usr, lib etc) under the DESTDIR and doesn't know the path depends on another package. -- Regards, Zeeshan Ali From mxie at redhat.com Tue Sep 20 10:25:02 2016 From: mxie at redhat.com (Ming Xie) Date: Tue, 20 Sep 2016 06:25:02 -0400 (EDT) Subject: [Libosinfo] Improve the size of default memory for rhel6 guest to 2048M In-Reply-To: <1003499400.1022519.1474366521199.JavaMail.zimbra@redhat.com> Message-ID: <1073915578.1027614.1474367102026.JavaMail.zimbra@redhat.com> Hi All, I meet a problem that guest can't boot into rhel6 after installation or rhel6 can't be installed in guest if the guest has only 1GB memory and has no swap partition, I know this is not bug because rhel6 systems with low memory(1 GB and less) and less than the recommended amount of swap space may have issues ranging from low responsivity up to and including complete inability to boot after the installation https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Installation_Guide/sn-Supported_Installation_Hardware-x86.html I see virt-manager built for rhel7 could adjust memory to 4096M when create windows guest , but the default memory size always will be set as 1024M when create linux guest in virt-manager, customers may don't know rhel6 need to create swap if memory < =1GB, I think the default memory size 1GB is not appropriate when create rhel6 guest in virt-manager, besides, virtualbox has a related bug about this h ttps://www.virtualbox.org/ticket/8490 , customer has thought default memory setting is too low to install rhel6 in guest Could we improve the size of default memory for rhel6 guest to 2048M so that customer doesn't need to care about whether need to create a swap partition if mem < 1G and it will reduce the risk of failure installation in rhel6 guest Thanks Regards XieMing -------------- next part -------------- An HTML attachment was scrubbed... URL: From berrange at redhat.com Tue Sep 20 10:36:16 2016 From: berrange at redhat.com (Daniel P. Berrange) Date: Tue, 20 Sep 2016 11:36:16 +0100 Subject: [Libosinfo] Improve the size of default memory for rhel6 guest to 2048M In-Reply-To: <1073915578.1027614.1474367102026.JavaMail.zimbra@redhat.com> References: <1003499400.1022519.1474366521199.JavaMail.zimbra@redhat.com> <1073915578.1027614.1474367102026.JavaMail.zimbra@redhat.com> Message-ID: <20160920103616.GC25490@redhat.com> On Tue, Sep 20, 2016 at 06:25:02AM -0400, Ming Xie wrote: > Hi All, > > I meet a problem that guest can't boot into rhel6 after installation > or rhel6 can't be installed in guest if the guest has only 1GB memory > and has no swap partition, I know this is not bug because rhel6 systems > with low memory(1 GB and less) and less than the recommended amount of > swap space may have issues ranging from low responsivity up to and > including complete inability to boot after the installation > > https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Installation_Guide/sn-Supported_Installation_Hardware-x86.html > I see virt-manager built for rhel7 could adjust memory to 4096M when > create windows guest , but the default memory size always will be set > as 1024M when create linux guest in virt-manager, customers may don't > know rhel6 need to create swap if memory < =1GB, I think the default > memory size 1GB is not appropriate when create rhel6 guest in > virt-manager, besides, virtualbox has a related bug about this > ttps://www.virtualbox.org/ticket/8490 , customer has thought default > memory setting is too low to install rhel6 in guest > Could we improve the size of default memory for rhel6 guest to 2048M > so that customer doesn't need to care about whether need to create a > swap partition if mem < 1G and it will reduce the risk of failure > installation in rhel6 guest Yes, I don't know why we have set the recommended level at 1GB, as it is clearly too low to be useful. We currently have the min ram set at 512 MB: 1 536870912 400000000 1073741824 9663676416 Based on this: https://access.redhat.com/articles/rhel-limits 512 MB is only acceptable for i386, x86_64 requires 1 GB min and PPC wants 2 GB. So we clearly need to update the RHEL6 limits both minimum and recommended. Could you submit a patch for the various RHEL XML files to update these limits. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| From mxie at redhat.com Wed Sep 21 02:26:54 2016 From: mxie at redhat.com (Ming Xie) Date: Tue, 20 Sep 2016 22:26:54 -0400 (EDT) Subject: [Libosinfo] Improve the size of default memory for rhel6 guest to 2048M In-Reply-To: <20160920103616.GC25490@redhat.com> References: <1003499400.1022519.1474366521199.JavaMail.zimbra@redhat.com> <1073915578.1027614.1474367102026.JavaMail.zimbra@redhat.com> <20160920103616.GC25490@redhat.com> Message-ID: <423356903.1474246.1474424814982.JavaMail.zimbra@redhat.com> Hi Daniel, Thank for your reply, because I have no experience on writing patch, I have turned David for help, he will help me to prepare or submit patches. Best Regards XieMing ----- Original Message ----- From: "Daniel P. Berrange" To: "Ming Xie" Cc: libosinfo at redhat.com, phrdina at redhat.com, tzheng at redhat.com, juzhou at redhat.com, "Xiaodai Wang" , lhuang at redhat.com, "David King" Sent: Tuesday, September 20, 2016 6:36:16 PM Subject: Re: [Libosinfo] Improve the size of default memory for rhel6 guest to 2048M On Tue, Sep 20, 2016 at 06:25:02AM -0400, Ming Xie wrote: > Hi All, > > I meet a problem that guest can't boot into rhel6 after installation > or rhel6 can't be installed in guest if the guest has only 1GB memory > and has no swap partition, I know this is not bug because rhel6 systems > with low memory(1 GB and less) and less than the recommended amount of > swap space may have issues ranging from low responsivity up to and > including complete inability to boot after the installation > > https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Installation_Guide/sn-Supported_Installation_Hardware-x86.html > I see virt-manager built for rhel7 could adjust memory to 4096M when > create windows guest , but the default memory size always will be set > as 1024M when create linux guest in virt-manager, customers may don't > know rhel6 need to create swap if memory < =1GB, I think the default > memory size 1GB is not appropriate when create rhel6 guest in > virt-manager, besides, virtualbox has a related bug about this > ttps://www.virtualbox.org/ticket/8490 , customer has thought default > memory setting is too low to install rhel6 in guest > Could we improve the size of default memory for rhel6 guest to 2048M > so that customer doesn't need to care about whether need to create a > swap partition if mem < 1G and it will reduce the risk of failure > installation in rhel6 guest Yes, I don't know why we have set the recommended level at 1GB, as it is clearly too low to be useful. We currently have the min ram set at 512 MB: 1 536870912 400000000 1073741824 9663676416 Based on this: https://access.redhat.com/articles/rhel-limits 512 MB is only acceptable for i386, x86_64 requires 1 GB min and PPC wants 2 GB. So we clearly need to update the RHEL6 limits both minimum and recommended. Could you submit a patch for the various RHEL XML files to update these limits. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|