From cfergeau at redhat.com Tue Feb 7 16:11:08 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 7 Feb 2017 17:11:08 +0100 Subject: [Libosinfo] [PATCH 0/3] Add openSUSE 42.2 and SLE-12-SP2 isodata In-Reply-To: <1485363001-8908-1-git-send-email-carnold@suse.com> References: <1485363001-8908-1-git-send-email-carnold@suse.com> Message-ID: <20170207161108.ztdfuf6c53woozwb@edamame.cdg.redhat.com> Hey, Acked-by: Christophe Fergeau Finally pushed this, thanks! Christophe On Wed, Jan 25, 2017 at 09:49:58AM -0700, Charles Arnold wrote: > Add data for openSUSE 42.2 > Add data for SLE-12-SP2 Desktop > Add data for SLE-12-SP2 Server > > Charles Arnold (3): > Add openSUSE Leap 42.2 data > Add SLES-12-SP2 data > Add SLED-12-SP2 data > > .../openSUSE-Leap-42.2-DVD-x86_64.iso.txt | 29 ++++++++++++++++++++++ > .../SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt | 29 ++++++++++++++++++++++ > .../SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt | 29 ++++++++++++++++++++++ > .../SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt | 16 ++++++++++++ > .../SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt | 29 ++++++++++++++++++++++ > .../SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt | 29 ++++++++++++++++++++++ > 6 files changed, 161 insertions(+) > create mode 100644 test/isodata/opensuse/opensuse42.2/openSUSE-Leap-42.2-DVD-x86_64.iso.txt > create mode 100644 test/isodata/sled/sled12sp2/SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt > create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt > create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt > create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt > create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt > > -- > 1.8.5.6 > > _______________________________________________ > Libosinfo mailing list > Libosinfo at redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From cfergeau at redhat.com Tue Feb 7 16:18:25 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 7 Feb 2017 17:18:25 +0100 Subject: [Libosinfo] [osinfo-db 1/2] rhel: enclose strings used for shell ifs in quotes In-Reply-To: <20170117152415.GE71679@aloka.lostca.se> References: <20170116182956.15510-1-fabiano@fidencio.org> <20170117152415.GE71679@aloka.lostca.se> Message-ID: <20170207161825.y7b4oenpdyevvxkf@edamame.cdg.redhat.com> On Tue, Jan 17, 2017 at 03:24:16PM +0000, Debarshi Ray wrote: > Hey, > > On Mon, Jan 16, 2017 at 07:29:55PM +0100, Fabiano Fid??ncio wrote: > > useradd -G wheel # Add user > > -if test -z ; then > > +if test -z ""; then > > passwd -d # Make user account passwordless > > else > > echo |passwd --stdin > > fi > > > > -if test -z ; then > > +if test -z ""; then > > passwd -d root # Make root account passwordless > > else > > echo |passwd --stdin root > > fi > > > > # Set user avatar > > -if test -n ; then > > +if test -n ""; then > > mkdir /mnt/unattended-media > > mount /mnt/unattended-media > > cp /mnt/unattended-media /home//.face > > Nested double quotes! So far it has generated valid Kickstart files, but > I don't know if that is by accident or by design. I think these files are valid XML files, so I would not be surprised if this was parsed as some text containing a " some other text with another " in other word, not an issue for an XML parser. Christophe -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From cfergeau at redhat.com Tue Feb 7 16:18:47 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 7 Feb 2017 17:18:47 +0100 Subject: [Libosinfo] [osinfo-db 1/2] rhel: enclose strings used for shell ifs in quotes In-Reply-To: References: <20170116182956.15510-1-fabiano@fidencio.org> <20170117152415.GE71679@aloka.lostca.se> Message-ID: <20170207161847.t2c4kxnioxk44era@edamame.cdg.redhat.com> On Tue, Jan 17, 2017 at 04:35:47PM +0100, Fabiano Fid?ncio wrote: > On Tue, Jan 17, 2017 at 4:35 PM, Fabiano Fid?ncio wrote: > > On Tue, Jan 17, 2017 at 4:24 PM, Debarshi Ray wrote: > >> Hey, > >> > >> On Mon, Jan 16, 2017 at 07:29:55PM +0100, Fabiano Fid??ncio wrote: > >>> useradd -G wheel # Add user > >>> -if test -z ; then > >>> +if test -z ""; then > >>> passwd -d # Make user account passwordless > >>> else > >>> echo |passwd --stdin > >>> fi > >>> > >>> -if test -z ; then > >>> +if test -z ""; then > >>> passwd -d root # Make root account passwordless > >>> else > >>> echo |passwd --stdin root > >>> fi > >>> > >>> # Set user avatar > >>> -if test -n ; then > >>> +if test -n ""; then > >>> mkdir /mnt/unattended-media > >>> mount /mnt/unattended-media > >>> cp /mnt/unattended-media /home//.face > >> > >> Nested double quotes! So far it has generated valid Kickstart files, but > >> I don't know if that is by accident or by design. > > > > I'll replace one of the " by ' before pushing in case this is the only problem. > > Better be safe than sorry here. > > > > Thanks for the catch! > > And, of course, the comments apply to the Fedora patch as well :-) For the two patches, Acked-by: Christophe Fergeau -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From cfergeau at redhat.com Tue Feb 7 17:03:53 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Tue, 7 Feb 2017 18:03:53 +0100 Subject: [Libosinfo] [PATCH] Marginally simplify the code to create and run a GMainLoop In-Reply-To: <20170117142941.5412-1-rishi.is@lostca.se> References: <20170117142941.5412-1-rishi.is@lostca.se> Message-ID: <20170207170353.pfn5uwgvfz3ybks2@edamame.cdg.redhat.com> On Tue, Jan 17, 2017 at 03:29:41PM +0100, Debarshi Ray wrote: > From: Debarshi Ray > > Even though g_main_loop_new accepts a is_running parameter, it isn't > very important since g_main_loop_run will set it to TRUE anyway. There > is no requirement that it should be set before calling g_main_loop_run. > The vast majority of GMainLoop users simply ignore the is_running > parameter unless they are doing something out of the ordinary. Hey, looking for example at osinfo_install_script_generate(), which is GMainLoop *loop = g_main_loop_new(g_main_context_get_thread_default(), TRUE); OsinfoInstallScriptGenerateSyncData data = { loop, NULL, NULL, NULL }; osinfo_install_script_generate_async(script, os, config, cancellable, osinfo_install_script_generate_done, &data); if (g_main_loop_is_running(loop)) g_main_loop_run(loop); Isn't the way it's currently done going to catch cases when osinfo_install_script_generate_done (and thus g_main_loop_quit()) ends up being called synchronously at the moment osinfo_install_script_generate_async() is called, while with your change, we'd wait forever for a g_main_loop_quit() which never comes? Christophe -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From cfergeau at redhat.com Wed Feb 8 10:16:20 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Wed, 8 Feb 2017 11:16:20 +0100 Subject: [Libosinfo] [PATCH] Marginally simplify the code to create and run a GMainLoop In-Reply-To: <20170207170353.pfn5uwgvfz3ybks2@edamame.cdg.redhat.com> References: <20170117142941.5412-1-rishi.is@lostca.se> <20170207170353.pfn5uwgvfz3ybks2@edamame.cdg.redhat.com> Message-ID: <20170208101620.q7e4squumv6jkox4@edamame.cdg.redhat.com> On Tue, Feb 07, 2017 at 06:03:53PM +0100, Christophe Fergeau wrote: > On Tue, Jan 17, 2017 at 03:29:41PM +0100, Debarshi Ray wrote: > > From: Debarshi Ray > > > > Even though g_main_loop_new accepts a is_running parameter, it isn't > > very important since g_main_loop_run will set it to TRUE anyway. There > > is no requirement that it should be set before calling g_main_loop_run. > > The vast majority of GMainLoop users simply ignore the is_running > > parameter unless they are doing something out of the ordinary. > > Hey, looking for example at osinfo_install_script_generate(), which is > > GMainLoop *loop = g_main_loop_new(g_main_context_get_thread_default(), > TRUE); > OsinfoInstallScriptGenerateSyncData data = { > loop, NULL, NULL, NULL > }; > > osinfo_install_script_generate_async(script, > os, > config, > cancellable, > osinfo_install_script_generate_done, > &data); > > if (g_main_loop_is_running(loop)) > g_main_loop_run(loop); > > Isn't the way it's currently done going to catch cases when > osinfo_install_script_generate_done (and thus g_main_loop_quit()) ends up being > called synchronously at the moment osinfo_install_script_generate_async() is > called, while with your change, we'd wait forever for a g_main_loop_quit() > which never comes? Looks like this could cause problems if g_main_loop_quit() can be called before the main loop starts running, I tested with this: #include static gboolean assert_not_reached(gpointer user_data) { g_assert_not_reached(); } int main(int argc, char **argv) { GMainLoop *loop; g_print("first loop test\n"); loop = g_main_loop_new(NULL, TRUE); g_main_loop_quit(loop); g_timeout_add_seconds(1, assert_not_reached, NULL); if (g_main_loop_is_running(loop)) { g_main_loop_run(loop); } g_main_loop_unref(loop); g_print("second loop test\n"); loop = g_main_loop_new(NULL, FALSE); g_main_loop_quit(loop); g_timeout_add_seconds(1, assert_not_reached, NULL); g_main_loop_run(loop); g_main_loop_unref(loop); return 0; } -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From bogorodskiy at gmail.com Wed Feb 8 13:37:27 2017 From: bogorodskiy at gmail.com (Roman Bogorodskiy) Date: Wed, 8 Feb 2017 17:37:27 +0400 Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info In-Reply-To: <20161113075557.56031-1-bogorodskiy@gmail.com> References: <20161113075557.56031-1-bogorodskiy@gmail.com> Message-ID: <20170208133726.GA1578@kloomba> Roman Bogorodskiy wrote: > --- > data/os/freebsd.org/freebsd-11.0.xml.in | 50 +++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 data/os/freebsd.org/freebsd-11.0.xml.in > > diff --git a/data/os/freebsd.org/freebsd-11.0.xml.in b/data/os/freebsd.org/freebsd-11.0.xml.in > new file mode 100644 > index 0000000..9af534f > --- /dev/null > +++ b/data/os/freebsd.org/freebsd-11.0.xml.in ping? Roman Bogorodskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 455 bytes Desc: not available URL: From cfergeau at redhat.com Wed Feb 8 14:02:11 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Wed, 8 Feb 2017 15:02:11 +0100 Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info In-Reply-To: <20170208133726.GA1578@kloomba> References: <20161113075557.56031-1-bogorodskiy@gmail.com> <20170208133726.GA1578@kloomba> Message-ID: <20170208140211.jq5lojrwaieifrux@edamame.cdg.redhat.com> On Wed, Feb 08, 2017 at 05:37:27PM +0400, Roman Bogorodskiy wrote: > Roman Bogorodskiy wrote: > > > --- > > data/os/freebsd.org/freebsd-11.0.xml.in | 50 +++++++++++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 data/os/freebsd.org/freebsd-11.0.xml.in > > > > diff --git a/data/os/freebsd.org/freebsd-11.0.xml.in b/data/os/freebsd.org/freebsd-11.0.xml.in > > new file mode 100644 > > index 0000000..9af534f > > --- /dev/null > > +++ b/data/os/freebsd.org/freebsd-11.0.xml.in > > ping? Hey, thanks for the reminder, ACK and pushed! Would you have iso test data which we could add to libosinfo test suite? (isoinfo -d -i output) Christophe -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From bogorodskiy at gmail.com Wed Feb 8 15:46:50 2017 From: bogorodskiy at gmail.com (Roman Bogorodskiy) Date: Wed, 8 Feb 2017 19:46:50 +0400 Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info In-Reply-To: <20170208140211.jq5lojrwaieifrux@edamame.cdg.redhat.com> References: <20161113075557.56031-1-bogorodskiy@gmail.com> <20170208133726.GA1578@kloomba> <20170208140211.jq5lojrwaieifrux@edamame.cdg.redhat.com> Message-ID: <20170208154649.GC1578@kloomba> Christophe Fergeau wrote: > On Wed, Feb 08, 2017 at 05:37:27PM +0400, Roman Bogorodskiy wrote: > > Roman Bogorodskiy wrote: > > > > > --- > > > data/os/freebsd.org/freebsd-11.0.xml.in | 50 +++++++++++++++++++++++++++++++++ > > > 1 file changed, 50 insertions(+) > > > create mode 100644 data/os/freebsd.org/freebsd-11.0.xml.in > > > > > > diff --git a/data/os/freebsd.org/freebsd-11.0.xml.in b/data/os/freebsd.org/freebsd-11.0.xml.in > > > new file mode 100644 > > > index 0000000..9af534f > > > --- /dev/null > > > +++ b/data/os/freebsd.org/freebsd-11.0.xml.in > > > > ping? > > Hey, thanks for the reminder, ACK and pushed! Would you have iso test > data which we could add to libosinfo test suite? (isoinfo -d -i output) Thanks! I'll add the test, but need to figure out why the existing tests fail. Roman Bogorodskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 455 bytes Desc: not available URL: From bogorodskiy at gmail.com Wed Feb 8 15:50:10 2017 From: bogorodskiy at gmail.com (Roman Bogorodskiy) Date: Wed, 8 Feb 2017 19:50:10 +0400 Subject: [Libosinfo] [libosinfo] check-symsorting: don't hardcode Perl path Message-ID: <20170208155010.32727-1-bogorodskiy@gmail.com> Do not hardcode '/usr/bin/perl' because on FreeBSD and maybe some other systems it's installed in a different prefix, so use '/usr/bin/env perl' instead. --- osinfo/check-symsorting.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl index 470247c..cc7b8d6 100755 --- a/osinfo/check-symsorting.pl +++ b/osinfo/check-symsorting.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # Copyright (C) 2012-2013 Red Hat, Inc. # -- 2.11.0 From berrange at redhat.com Wed Feb 8 16:07:20 2017 From: berrange at redhat.com (Daniel P. Berrange) Date: Wed, 8 Feb 2017 16:07:20 +0000 Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info In-Reply-To: <20170208154649.GC1578@kloomba> References: <20161113075557.56031-1-bogorodskiy@gmail.com> <20170208133726.GA1578@kloomba> <20170208140211.jq5lojrwaieifrux@edamame.cdg.redhat.com> <20170208154649.GC1578@kloomba> Message-ID: <20170208160720.GL3129@redhat.com> On Wed, Feb 08, 2017 at 07:46:50PM +0400, Roman Bogorodskiy wrote: > Christophe Fergeau wrote: > > > On Wed, Feb 08, 2017 at 05:37:27PM +0400, Roman Bogorodskiy wrote: > > > Roman Bogorodskiy wrote: > > > > > > > --- > > > > data/os/freebsd.org/freebsd-11.0.xml.in | 50 +++++++++++++++++++++++++++++++++ > > > > 1 file changed, 50 insertions(+) > > > > create mode 100644 data/os/freebsd.org/freebsd-11.0.xml.in > > > > > > > > diff --git a/data/os/freebsd.org/freebsd-11.0.xml.in b/data/os/freebsd.org/freebsd-11.0.xml.in > > > > new file mode 100644 > > > > index 0000000..9af534f > > > > --- /dev/null > > > > +++ b/data/os/freebsd.org/freebsd-11.0.xml.in > > > > > > ping? > > > > Hey, thanks for the reminder, ACK and pushed! Would you have iso test > > data which we could add to libosinfo test suite? (isoinfo -d -i output) > > Thanks! > > I'll add the test, but need to figure out why the existing tests fail. If tests fail it'll mostly likely be due to the tests picking up outdated content for osinfo-db. Setting OSINFO_SYSTEM_DIR ought to fix it generally. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| From berrange at redhat.com Wed Feb 8 16:13:07 2017 From: berrange at redhat.com (Daniel P. Berrange) Date: Wed, 8 Feb 2017 16:13:07 +0000 Subject: [Libosinfo] [libosinfo] check-symsorting: don't hardcode Perl path In-Reply-To: <20170208155010.32727-1-bogorodskiy@gmail.com> References: <20170208155010.32727-1-bogorodskiy@gmail.com> Message-ID: <20170208161307.GO3129@redhat.com> On Wed, Feb 08, 2017 at 07:50:10PM +0400, Roman Bogorodskiy wrote: > Do not hardcode '/usr/bin/perl' because on FreeBSD and maybe some other > systems it's installed in a different prefix, so use '/usr/bin/env perl' > instead. > --- > osinfo/check-symsorting.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl > index 470247c..cc7b8d6 100755 > --- a/osinfo/check-symsorting.pl > +++ b/osinfo/check-symsorting.pl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/env perl > > # Copyright (C) 2012-2013 Red Hat, Inc. > # Does this matter ? the Makefile.am rule is using $(PERL) to pick the right emulator to run iiuc Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| From bogorodskiy at gmail.com Wed Feb 8 16:25:44 2017 From: bogorodskiy at gmail.com (Roman Bogorodskiy) Date: Wed, 8 Feb 2017 20:25:44 +0400 Subject: [Libosinfo] [libosinfo] check-symsorting: don't hardcode Perl path In-Reply-To: <20170208161307.GO3129@redhat.com> References: <20170208155010.32727-1-bogorodskiy@gmail.com> <20170208161307.GO3129@redhat.com> Message-ID: <20170208162543.GD1578@kloomba> Daniel P. Berrange wrote: > On Wed, Feb 08, 2017 at 07:50:10PM +0400, Roman Bogorodskiy wrote: > > Do not hardcode '/usr/bin/perl' because on FreeBSD and maybe some other > > systems it's installed in a different prefix, so use '/usr/bin/env perl' > > instead. > > --- > > osinfo/check-symsorting.pl | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl > > index 470247c..cc7b8d6 100755 > > --- a/osinfo/check-symsorting.pl > > +++ b/osinfo/check-symsorting.pl > > @@ -1,4 +1,4 @@ > > -#!/usr/bin/perl > > +#!/usr/bin/env perl > > > > # Copyright (C) 2012-2013 Red Hat, Inc. > > # > > Does this matter ? the Makefile.am rule is using $(PERL) to pick the > right emulator to run iiuc Yeah, it looks like that, but it still fails: $ gmake check V=1 Making check in osinfo gmake[1]: Entering directory '/usr/home/novel/code/libosinfo/osinfo' gmake check-am gmake[2]: Entering directory '/usr/home/novel/code/libosinfo/osinfo' gmake check-local gmake[3]: Entering directory '/usr/home/novel/code/libosinfo/osinfo' ./check-symsorting.pl \ . ./libosinfo.syms gmake[3]: ./check-symsorting.pl: Command not found gmake[3]: *** [Makefile:1386: check-symsorting] Error 127 gmake[3]: Leaving directory '/usr/home/novel/code/libosinfo/osinfo' gmake[2]: *** [Makefile:1220: check-am] Error 2 gmake[2]: Leaving directory '/usr/home/novel/code/libosinfo/osinfo' gmake[1]: *** [Makefile:1222: check] Error 2 gmake[1]: Leaving directory '/usr/home/novel/code/libosinfo/osinfo' gmake: *** [Makefile:594: check-recursive] Error 1 And there's no PERL defined in Makefile, only INTLTOOL_PERL. Not sure what bit should define PERL, after a brief look I didn't find that. Roman Bogorodskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 455 bytes Desc: not available URL: From bogorodskiy at gmail.com Wed Feb 8 16:43:16 2017 From: bogorodskiy at gmail.com (Roman Bogorodskiy) Date: Wed, 8 Feb 2017 20:43:16 +0400 Subject: [Libosinfo] [libosinfo v2] Improve Perl-related routines Message-ID: <20170208164316.61216-1-bogorodskiy@gmail.com> * Add a check for the 'perl' program to configure.ac as $(PERL) is used in various places * Do not hardcode '/usr/bin/perl' in check-symsorting.pl because on FreeBSD and maybe some other systems it's installed in a different prefix, so use '/usr/bin/env perl' instead. --- configure.ac | 4 ++++ osinfo/check-symsorting.pl | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7f29df8..eb37f41 100644 --- a/configure.ac +++ b/configure.ac @@ -160,6 +160,10 @@ case $host in esac AM_CONDITIONAL([WITH_LINUX], [test "$with_linux" = "yes"]) +AC_PATH_PROG([PERL], [perl]) +if test -z "$PERL"; then + AC_MSG_ERROR([Failed to find perl.]) +fi GOBJECT_INTROSPECTION_CHECK([0.9.7]) diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl index 470247c..cc7b8d6 100755 --- a/osinfo/check-symsorting.pl +++ b/osinfo/check-symsorting.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # Copyright (C) 2012-2013 Red Hat, Inc. # -- 2.11.0 From bogorodskiy at gmail.com Thu Feb 9 06:43:32 2017 From: bogorodskiy at gmail.com (Roman Bogorodskiy) Date: Thu, 9 Feb 2017 10:43:32 +0400 Subject: [Libosinfo] [libosinfo v2] Improve Perl-related routines In-Reply-To: <20170208164316.61216-1-bogorodskiy@gmail.com> References: <20170208164316.61216-1-bogorodskiy@gmail.com> Message-ID: <20170209064330.GA52333@dev.san.ru> Roman Bogorodskiy wrote: > * Add a check for the 'perl' program to configure.ac as > $(PERL) is used in various places > * Do not hardcode '/usr/bin/perl' in check-symsorting.pl > because on FreeBSD and maybe some other systems it's installed > in a different prefix, so use '/usr/bin/env perl' instead. > --- > configure.ac | 4 ++++ > osinfo/check-symsorting.pl | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 7f29df8..eb37f41 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -160,6 +160,10 @@ case $host in > esac > AM_CONDITIONAL([WITH_LINUX], [test "$with_linux" = "yes"]) > > +AC_PATH_PROG([PERL], [perl]) > +if test -z "$PERL"; then > + AC_MSG_ERROR([Failed to find perl.]) > +fi > > GOBJECT_INTROSPECTION_CHECK([0.9.7]) > > diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl > index 470247c..cc7b8d6 100755 > --- a/osinfo/check-symsorting.pl > +++ b/osinfo/check-symsorting.pl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/env perl > > # Copyright (C) 2012-2013 Red Hat, Inc. > # I've just noticed that there are two more files with the same shebang: ./build-aux/bracket-spacing.pl ./osinfo/check-symfile.pl The second one is used on Linux only, and the first one works as is with the configure check added for perl. So I guess we either should change shebang line for all the three files or keep everything as is for consistency. While the former approach looks more portable in general, I'm not sure if it makes any practical difference as all the scripts are being called using $(PERL) (unless someone decides to run that by hand). Roman Bogorodskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: From john at dev1ce.com Fri Feb 10 18:01:58 2017 From: john at dev1ce.com (John Roman) Date: Fri, 10 Feb 2017 13:01:58 -0500 Subject: [Libosinfo] Gentoo/Funtoo entries request Message-ID: <20170210180158.GA19397@doppelbock.dev1ce.com> Greetings, If possible, I wish to submit a patch to the osinfo tool to provide information on two distributions of Linux, Funtoo and Gentoo. Without proper identification in osinfo, users attempting to provision such systems in libvirtd and virt-install face significant challenges in identifying a variant (generally virtio26) to afford the guest system the appropriate virtio driver. Ive committed code to a repository clone ive made of the osinfo master branch. is there any other consideration outside of the XML entries that needs to be made to complete these entries? From berrange at redhat.com Fri Feb 10 18:22:06 2017 From: berrange at redhat.com (Daniel P. Berrange) Date: Fri, 10 Feb 2017 18:22:06 +0000 Subject: [Libosinfo] Gentoo/Funtoo entries request In-Reply-To: <20170210180158.GA19397@doppelbock.dev1ce.com> References: <20170210180158.GA19397@doppelbock.dev1ce.com> Message-ID: <20170210182206.GD9683@redhat.com> On Fri, Feb 10, 2017 at 01:01:58PM -0500, John Roman wrote: > Greetings, > If possible, I wish to submit a patch to the osinfo tool to provide > information on two distributions of Linux, Funtoo and Gentoo. Without > proper identification in osinfo, users attempting to provision such > systems in libvirtd and virt-install face significant challenges in > identifying a variant (generally virtio26) to afford the guest system > the appropriate virtio driver. > > Ive committed code to a repository clone ive made of the osinfo master > branch. is there any other consideration outside of the XML entries that > needs to be made to complete these entries? In the libosinfo GIT repo, there is a directory test/isodata/ which contains 'isoinfo -i' output for ISO images assocatied with the OS release. Adding such data is welcome, but optional. It is always sufficient to just send patches for the osinfo-db XML files. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| From bogorodskiy at gmail.com Thu Feb 16 14:40:58 2017 From: bogorodskiy at gmail.com (Roman Bogorodskiy) Date: Thu, 16 Feb 2017 18:40:58 +0400 Subject: [Libosinfo] [PATCH v3] Improve Perl-related routines Message-ID: <20170216144058.13556-1-bogorodskiy@gmail.com> * Add a check for the 'perl' program to configure.ac as $(PERL) is used in various places * Do not hardcode '/usr/bin/perl' in perl scripts because on FreeBSD and maybe some other systems it's installed in a different prefix, so use '/usr/bin/env perl' instead. --- build-aux/bracket-spacing.pl | 2 +- configure.ac | 4 ++++ osinfo/check-symfile.pl | 2 +- osinfo/check-symsorting.pl | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/build-aux/bracket-spacing.pl b/build-aux/bracket-spacing.pl index e4ae8f0..655dac0 100755 --- a/build-aux/bracket-spacing.pl +++ b/build-aux/bracket-spacing.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # # bracket-spacing.pl: Report any usage of 'function (..args..)' # Also check for other syntax issues, such as correct use of ';' diff --git a/configure.ac b/configure.ac index 7f29df8..eb37f41 100644 --- a/configure.ac +++ b/configure.ac @@ -160,6 +160,10 @@ case $host in esac AM_CONDITIONAL([WITH_LINUX], [test "$with_linux" = "yes"]) +AC_PATH_PROG([PERL], [perl]) +if test -z "$PERL"; then + AC_MSG_ERROR([Failed to find perl.]) +fi GOBJECT_INTROSPECTION_CHECK([0.9.7]) diff --git a/osinfo/check-symfile.pl b/osinfo/check-symfile.pl index d59a213..4f88300 100755 --- a/osinfo/check-symfile.pl +++ b/osinfo/check-symfile.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # Copyright (C) 2012-2013 Red Hat, Inc. # diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl index 470247c..cc7b8d6 100755 --- a/osinfo/check-symsorting.pl +++ b/osinfo/check-symsorting.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # Copyright (C) 2012-2013 Red Hat, Inc. # -- 2.11.0 From fidencio at redhat.com Sun Feb 19 21:37:12 2017 From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=) Date: Sun, 19 Feb 2017 22:37:12 +0100 Subject: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support Message-ID: <20170219213712.19838-1-fidencio@redhat.com> As reported by Cole Robinson, none of the ubuntu distro metadat reports sypport for the USB tablet device support. After testing old Ubuntu ISOs, seems that 5.04 is the first bootable one that supports it (4.10, the first one, wasn't bootable though). Resolves: rhbz#1423024 Signed-off-by: Fabiano Fid?ncio --- data/os/ubuntu.com/ubuntu-5.04.xml.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/data/os/ubuntu.com/ubuntu-5.04.xml.in b/data/os/ubuntu.com/ubuntu-5.04.xml.in index 1478d17..c6ef675 100644 --- a/data/os/ubuntu.com/ubuntu-5.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-5.04.xml.in @@ -16,6 +16,10 @@ 2005-04-08 2006-10-31 + + + + http://old-releases.ubuntu.com/releases/hoary/ubuntu-5.04-install-i386.iso -- 2.9.3 From cfergeau at redhat.com Mon Feb 20 08:40:08 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Mon, 20 Feb 2017 09:40:08 +0100 Subject: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support In-Reply-To: <20170219213712.19838-1-fidencio@redhat.com> References: <20170219213712.19838-1-fidencio@redhat.com> Message-ID: <20170220084008.5q2oexiawcjufeps@edamame.cdg.redhat.com> On Sun, Feb 19, 2017 at 10:37:12PM +0100, Fabiano Fid?ncio wrote: > As reported by Cole Robinson, none of the ubuntu distro metadat reports > sypport for the USB tablet device support. > > After testing old Ubuntu ISOs, seems that 5.04 is the first bootable one > that supports it (4.10, the first one, wasn't bootable though). > > Resolves: rhbz#1423024 > > Signed-off-by: Fabiano Fid?ncio > --- > data/os/ubuntu.com/ubuntu-5.04.xml.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/data/os/ubuntu.com/ubuntu-5.04.xml.in b/data/os/ubuntu.com/ubuntu-5.04.xml.in > index 1478d17..c6ef675 100644 > --- a/data/os/ubuntu.com/ubuntu-5.04.xml.in > +++ b/data/os/ubuntu.com/ubuntu-5.04.xml.in > @@ -16,6 +16,10 @@ > 2005-04-08 > 2006-10-31 > > + > + > + > + I always forget, are supported devices inherited from one release to the next, or do they have to be explicitly added to each OS version ? Christophe -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From berrange at redhat.com Mon Feb 20 09:30:32 2017 From: berrange at redhat.com (Daniel P. Berrange) Date: Mon, 20 Feb 2017 09:30:32 +0000 Subject: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support In-Reply-To: <20170220084008.5q2oexiawcjufeps@edamame.cdg.redhat.com> References: <20170219213712.19838-1-fidencio@redhat.com> <20170220084008.5q2oexiawcjufeps@edamame.cdg.redhat.com> Message-ID: <20170220093032.GA15874@redhat.com> On Mon, Feb 20, 2017 at 09:40:08AM +0100, Christophe Fergeau wrote: > On Sun, Feb 19, 2017 at 10:37:12PM +0100, Fabiano Fid?ncio wrote: > > As reported by Cole Robinson, none of the ubuntu distro metadat reports > > sypport for the USB tablet device support. > > > > After testing old Ubuntu ISOs, seems that 5.04 is the first bootable one > > that supports it (4.10, the first one, wasn't bootable though). > > > > Resolves: rhbz#1423024 > > > > Signed-off-by: Fabiano Fid?ncio > > --- > > data/os/ubuntu.com/ubuntu-5.04.xml.in | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/data/os/ubuntu.com/ubuntu-5.04.xml.in b/data/os/ubuntu.com/ubuntu-5.04.xml.in > > index 1478d17..c6ef675 100644 > > --- a/data/os/ubuntu.com/ubuntu-5.04.xml.in > > +++ b/data/os/ubuntu.com/ubuntu-5.04.xml.in > > @@ -16,6 +16,10 @@ > > 2005-04-08 > > 2006-10-31 > > > > + > > + > > + > > + > > I always forget, are supported devices inherited from one release to the > next, or do they have to be explicitly added to each OS version ? They're inherited Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| From fabiano at fidencio.org Mon Feb 20 10:07:51 2017 From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=) Date: Mon, 20 Feb 2017 11:07:51 +0100 Subject: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support In-Reply-To: <20170220084008.5q2oexiawcjufeps@edamame.cdg.redhat.com> References: <20170219213712.19838-1-fidencio@redhat.com> <20170220084008.5q2oexiawcjufeps@edamame.cdg.redhat.com> Message-ID: On Mon, Feb 20, 2017 at 9:40 AM, Christophe Fergeau wrote: > On Sun, Feb 19, 2017 at 10:37:12PM +0100, Fabiano Fid?ncio wrote: >> As reported by Cole Robinson, none of the ubuntu distro metadat reports >> sypport for the USB tablet device support. >> >> After testing old Ubuntu ISOs, seems that 5.04 is the first bootable one >> that supports it (4.10, the first one, wasn't bootable though). >> >> Resolves: rhbz#1423024 >> >> Signed-off-by: Fabiano Fid?ncio >> --- >> data/os/ubuntu.com/ubuntu-5.04.xml.in | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/data/os/ubuntu.com/ubuntu-5.04.xml.in b/data/os/ubuntu.com/ubuntu-5.04.xml.in >> index 1478d17..c6ef675 100644 >> --- a/data/os/ubuntu.com/ubuntu-5.04.xml.in >> +++ b/data/os/ubuntu.com/ubuntu-5.04.xml.in >> @@ -16,6 +16,10 @@ >> 2005-04-08 >> 2006-10-31 >> >> + >> + >> + >> + > > I always forget, are supported devices inherited from one release to the > next, or do they have to be explicitly added to each OS version ? They are inherited, Christophe. :-) And I just found out some typos in the commit message. metadat -> metadata sypport -> support Those can be fixed before pushing in case that's the only issue. > > Christophe > > _______________________________________________ > Libosinfo mailing list > Libosinfo at redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo > -- Fabiano Fid?ncio From cfergeau at redhat.com Mon Feb 20 10:19:28 2017 From: cfergeau at redhat.com (Christophe Fergeau) Date: Mon, 20 Feb 2017 11:19:28 +0100 Subject: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support In-Reply-To: References: <20170219213712.19838-1-fidencio@redhat.com> <20170220084008.5q2oexiawcjufeps@edamame.cdg.redhat.com> Message-ID: <20170220101928.4j4ccornl6wjrity@edamame.cdg.redhat.com> On Mon, Feb 20, 2017 at 11:07:51AM +0100, Fabiano Fid?ncio wrote: > On Mon, Feb 20, 2017 at 9:40 AM, Christophe Fergeau wrote: > > On Sun, Feb 19, 2017 at 10:37:12PM +0100, Fabiano Fid?ncio wrote: > >> As reported by Cole Robinson, none of the ubuntu distro metadat reports > >> sypport for the USB tablet device support. > >> > >> After testing old Ubuntu ISOs, seems that 5.04 is the first bootable one > >> that supports it (4.10, the first one, wasn't bootable though). > >> > >> Resolves: rhbz#1423024 > >> > >> Signed-off-by: Fabiano Fid?ncio > >> --- > >> data/os/ubuntu.com/ubuntu-5.04.xml.in | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/data/os/ubuntu.com/ubuntu-5.04.xml.in b/data/os/ubuntu.com/ubuntu-5.04.xml.in > >> index 1478d17..c6ef675 100644 > >> --- a/data/os/ubuntu.com/ubuntu-5.04.xml.in > >> +++ b/data/os/ubuntu.com/ubuntu-5.04.xml.in > >> @@ -16,6 +16,10 @@ > >> 2005-04-08 > >> 2006-10-31 > >> > >> + > >> + > >> + > >> + > > > > I always forget, are supported devices inherited from one release to the > > next, or do they have to be explicitly added to each OS version ? > > They are inherited, Christophe. :-) > > And I just found out some typos in the commit message. > > metadat -> metadata > sypport -> support > > Those can be fixed before pushing in case that's the only issue. Thanks, and yes, that looks good to me, Acked-by: Christophe Fergeau -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From crobinso at redhat.com Tue Feb 21 21:41:29 2017 From: crobinso at redhat.com (Cole Robinson) Date: Tue, 21 Feb 2017 16:41:29 -0500 Subject: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support In-Reply-To: <20170219213712.19838-1-fidencio@redhat.com> References: <20170219213712.19838-1-fidencio@redhat.com> Message-ID: On 02/19/2017 04:37 PM, Fabiano Fid?ncio wrote: > As reported by Cole Robinson, none of the ubuntu distro metadat reports > sypport for the USB tablet device support. > > After testing old Ubuntu ISOs, seems that 5.04 is the first bootable one > that supports it (4.10, the first one, wasn't bootable though). > > Resolves: rhbz#1423024 > > Signed-off-by: Fabiano Fid?ncio > --- > data/os/ubuntu.com/ubuntu-5.04.xml.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/data/os/ubuntu.com/ubuntu-5.04.xml.in b/data/os/ubuntu.com/ubuntu-5.04.xml.in > index 1478d17..c6ef675 100644 > --- a/data/os/ubuntu.com/ubuntu-5.04.xml.in > +++ b/data/os/ubuntu.com/ubuntu-5.04.xml.in > @@ -16,6 +16,10 @@ > 2005-04-08 > 2006-10-31 > > + > + > + > + > > http://old-releases.ubuntu.com/releases/hoary/ubuntu-5.04-install-i386.iso > > I verified the patch fixes my test case. Thanks Fabiano! - Cole From fabiano at fidencio.org Wed Feb 22 13:42:06 2017 From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=) Date: Wed, 22 Feb 2017 14:42:06 +0100 Subject: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support In-Reply-To: References: <20170219213712.19838-1-fidencio@redhat.com> Message-ID: On Tue, Feb 21, 2017 at 10:41 PM, Cole Robinson wrote: > On 02/19/2017 04:37 PM, Fabiano Fid?ncio wrote: >> As reported by Cole Robinson, none of the ubuntu distro metadat reports >> sypport for the USB tablet device support. >> >> After testing old Ubuntu ISOs, seems that 5.04 is the first bootable one >> that supports it (4.10, the first one, wasn't bootable though). >> >> Resolves: rhbz#1423024 >> >> Signed-off-by: Fabiano Fid?ncio >> --- >> data/os/ubuntu.com/ubuntu-5.04.xml.in | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/data/os/ubuntu.com/ubuntu-5.04.xml.in b/data/os/ubuntu.com/ubuntu-5.04.xml.in >> index 1478d17..c6ef675 100644 >> --- a/data/os/ubuntu.com/ubuntu-5.04.xml.in >> +++ b/data/os/ubuntu.com/ubuntu-5.04.xml.in >> @@ -16,6 +16,10 @@ >> 2005-04-08 >> 2006-10-31 >> >> + >> + >> + >> + >> >> http://old-releases.ubuntu.com/releases/hoary/ubuntu-5.04-install-i386.iso >> >> > > I verified the patch fixes my test case. Thanks Fabiano! > > - Cole > > _______________________________________________ > Libosinfo mailing list > Libosinfo at redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo Pushed! https://gitlab.com/libosinfo/osinfo-db/commit/c7d41e34af5fa1706ba11b7cdbad548f9d2fcb33 Best Regards, -- Fabiano Fid?ncio From berrange at redhat.com Wed Feb 22 17:33:22 2017 From: berrange at redhat.com (Daniel P. Berrange) Date: Wed, 22 Feb 2017 17:33:22 +0000 Subject: [Libosinfo] [PATCH] Disable -Wunsafe-loop-optimizations warnings Message-ID: <20170222173322.8933-1-berrange@redhat.com> This warning option is not reporting broken code. Rather it is merely identifying loops which GCC would not be able to optimize fully when using -funsafe-loop-optimizations. In GCC 7 this triggers on the loader code osinfo_loader.c: In function 'osinfo_loader_process_list': osinfo_loader.c:2127:11: error: missed loop optimization, the loop counter may overflow [-Werror=unsafe-loop-optimizations] while (tmp && *tmp) { ^ The warning just needs to be turned off since the code is not broken, and we don't care about the optimization level Signed-off-by: Daniel P. Berrange --- Pushed as a broken build fix for Fedora rawhide m4/libosinfo-compile-warnings.m4 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/m4/libosinfo-compile-warnings.m4 b/m4/libosinfo-compile-warnings.m4 index 9e0469a..1876837 100644 --- a/m4/libosinfo-compile-warnings.m4 +++ b/m4/libosinfo-compile-warnings.m4 @@ -41,6 +41,10 @@ AC_DEFUN([LIBOSINFO_COMPILE_WARNINGS],[ dontwarn="$dontwarn -Wlong-long" # Unused macros are ok dontwarn="$dontwarn -Wunused-macros" + # This isn't warning about code bugs, it is telling + # you about loops which the compiler can't optimize + # due to unpredictable boundary conditions + dontwarn="$dontwarn -Wunsafe-loop-optimizations" # g_clear_object & G_ATOMIC_OP_USE_GCC_BUILTINS causes -- 2.9.3 From berrange at redhat.com Thu Feb 23 17:08:16 2017 From: berrange at redhat.com (Daniel P. Berrange) Date: Thu, 23 Feb 2017 17:08:16 +0000 Subject: [Libosinfo] [PATCH v3] Improve Perl-related routines In-Reply-To: <20170216144058.13556-1-bogorodskiy@gmail.com> References: <20170216144058.13556-1-bogorodskiy@gmail.com> Message-ID: <20170223170816.GU10047@redhat.com> On Thu, Feb 16, 2017 at 06:40:58PM +0400, Roman Bogorodskiy wrote: > * Add a check for the 'perl' program to configure.ac as > $(PERL) is used in various places > * Do not hardcode '/usr/bin/perl' in perl scripts > because on FreeBSD and maybe some other systems it's installed > in a different prefix, so use '/usr/bin/env perl' instead. > --- > build-aux/bracket-spacing.pl | 2 +- > configure.ac | 4 ++++ > osinfo/check-symfile.pl | 2 +- > osinfo/check-symsorting.pl | 2 +- > 4 files changed, 7 insertions(+), 3 deletions(-) ACK, pushed to git. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| From fabiano at fidencio.org Fri Feb 24 09:18:50 2017 From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=) Date: Fri, 24 Feb 2017 10:18:50 +0100 Subject: [Libosinfo] [PATCH] Disable -Wunsafe-loop-optimizations warnings In-Reply-To: <20170222173322.8933-1-berrange@redhat.com> References: <20170222173322.8933-1-berrange@redhat.com> Message-ID: On Wed, Feb 22, 2017 at 6:33 PM, Daniel P. Berrange wrote: > This warning option is not reporting broken code. Rather it is merely > identifying loops which GCC would not be able to optimize fully when > using -funsafe-loop-optimizations. In GCC 7 this triggers on the > loader code > > osinfo_loader.c: In function 'osinfo_loader_process_list': > osinfo_loader.c:2127:11: error: missed loop optimization, the loop counter may overflow [-Werror=unsafe-loop-optimizations] > while (tmp && *tmp) { > ^ > > The warning just needs to be turned off since the code is not broken, > and we don't care about the optimization level > > Signed-off-by: Daniel P. Berrange > --- > > Pushed as a broken build fix for Fedora rawhide > > m4/libosinfo-compile-warnings.m4 | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/m4/libosinfo-compile-warnings.m4 b/m4/libosinfo-compile-warnings.m4 > index 9e0469a..1876837 100644 > --- a/m4/libosinfo-compile-warnings.m4 > +++ b/m4/libosinfo-compile-warnings.m4 > @@ -41,6 +41,10 @@ AC_DEFUN([LIBOSINFO_COMPILE_WARNINGS],[ > dontwarn="$dontwarn -Wlong-long" > # Unused macros are ok > dontwarn="$dontwarn -Wunused-macros" > + # This isn't warning about code bugs, it is telling > + # you about loops which the compiler can't optimize > + # due to unpredictable boundary conditions > + dontwarn="$dontwarn -Wunsafe-loop-optimizations" > > > # g_clear_object & G_ATOMIC_OP_USE_GCC_BUILTINS causes > -- > 2.9.3 > > _______________________________________________ > Libosinfo mailing list > Libosinfo at redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo Acked-by: Fabiano Fid?ncio -- Fabiano Fid?ncio