From fidencio at redhat.com  Fri Jan  6 20:39:11 2017
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Fri,  6 Jan 2017 21:39:11 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Enable repos when installing a
	Server ISO
Message-ID: <20170106203911.23327-1-fidencio@redhat.com>

Fedora installer has been broken since different "working groups" have
been introduced (Fedora 21).

The reason of the breakage is that the "Server" media doesn't contain
all the packages needed to perform the "Workstation" installation done
by the desktop profile.

The only way to solve this issue is by enabling the repos that contain
the needed packages during installation.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
index 1fefebb..ad4d956 100644
--- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
+++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
@@ -129,7 +129,7 @@ logvol swap --fstype swap --name=LogVol01 --vgname=VolGroup00 --size=768 --grow
 logvol / --fstype <xsl:call-template name="rootfs"/> --name=LogVol00 --vgname=VolGroup00 --size=1024 --grow
 reboot
 
-<xsl:if test="contains(media/variant, 'netinst')">
+<xsl:if test="(contains(media/variant, 'netinst') or contains(media/variant, 'server'))">
 repo --name=fedora --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
 repo --name=updates --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=updates-released-f$releasever&amp;arch=$basearch
 url --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
-- 
2.9.3



From fidencio at redhat.com  Fri Jan  6 22:31:48 2017
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Fri,  6 Jan 2017 23:31:48 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Add F25 info
Message-ID: <20170106223149.28604-1-fidencio@redhat.com>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/fedoraproject.org/fedora-25.xml.in | 169 +++++++++++++++++++++++++++++
 1 file changed, 169 insertions(+)
 create mode 100644 data/os/fedoraproject.org/fedora-25.xml.in

diff --git a/data/os/fedoraproject.org/fedora-25.xml.in b/data/os/fedoraproject.org/fedora-25.xml.in
new file mode 100644
index 0000000..5e56623
--- /dev/null
+++ b/data/os/fedoraproject.org/fedora-25.xml.in
@@ -0,0 +1,169 @@
+<libosinfo version="0.0.1">
+<!-- Licensed under the GNU General Public License version 2 or later.
+     See http://www.gnu.org/licenses/ for a copy of the license text -->
+  <os id="http://fedoraproject.org/fedora/25">
+    <short-id>fedora25</short-id>
+    <_name>Fedora 25</_name>
+    <version>25</version>
+    <_vendor>Fedora Project</_vendor>
+    <family>linux</family>
+    <distro>fedora</distro>
+    <upgrades id="http://fedoraproject.org/fedora/24"/>
+    <derives-from id="http://fedoraproject.org/fedora/24"/>
+
+    <release-date>2016-11-22</release-date>
+
+    <variant id="workstation">
+      <_name>Fedora 25 Workstation</_name>
+    </variant>
+    <variant id="workstation-netinst">
+      <_name>Fedora 25 Workstation</_name>
+    </variant>
+    <variant id="server">
+      <_name>Fedora 25 Server</_name>
+    </variant>
+    <variant id="server-netinst">
+      <_name>Fedora 25 Server</_name>
+    </variant>
+
+    <!-- Workstation -->
+
+    <!-- Live -->
+    <media arch="i686" live="true">
+      <variant id="workstation"/>
+      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/i386/iso/Fedora-Workstation-Live-i386-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-WS-Live-25.*</volume-id>
+        <system-id>LINUX</system-id>
+      </iso>
+      <kernel>isolinux/vmlinuz0</kernel>
+      <initrd>isolinux/initrd0.img</initrd>
+    </media>
+    <media arch="x86_64" live="true">
+      <variant id="workstation"/>
+      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-WS-Live-25.*</volume-id>
+        <system-id>LINUX</system-id>
+      </iso>
+      <kernel>isolinux/vmlinuz0</kernel>
+      <initrd>isolinux/initrd0.img</initrd>
+    </media>
+
+    <!-- Network Installer !-->
+    <media arch="i686">
+      <variant id="workstation-netinst"/>
+      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/i386/iso/Fedora-Workstation-netinst-i386-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-WS-dvd-i386-25</volume-id>
+        <system-id>LINUX</system-id>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+    <media arch="x86_64">
+      <variant id="workstation-netinst"/>
+      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/x86_64/iso/Fedora-Workstation-netinst-x86_64-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-WS-dvd-x86_64-25</volume-id>
+        <system-id>LINUX</system-id>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <!-- Server -->
+
+    <!-- DVD -->
+    <media arch="i686">
+      <variant id="server"/>
+      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/i386/iso/Fedora-Server-dvd-i386-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-S-dvd-i386-25</volume-id>
+        <system-id>LINUX</system-id>
+        <!-- We need volume-size to distinguish DVD from netiso here:
+
+             https://fedorahosted.org/rel-eng/ticket/6173
+        -->
+        <volume-size>2113929216</volume-size>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+    <media arch="x86_64">
+      <variant id="server"/>
+      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/x86_64/iso/Fedora-Server-dvd-x86_64-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-S-dvd-x86_64-25</volume-id>
+        <system-id>LINUX</system-id>
+        <volume-size>2018508800</volume-size>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <!-- Network Installer !-->
+    <media arch="i686">
+      <variant id="server-netinst"/>
+      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/i386/iso/Fedora-Server-netinst-i386-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-S-dvd-i386-25</volume-id>
+        <system-id>LINUX</system-id>
+        <volume-size>489684992</volume-size>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+    <media arch="x86_64">
+      <variant id="server-netinst"/>
+      <url>http://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/x86_64/iso/Fedora-Server-netinst-x86_64-25-1.3.iso</url>
+      <iso>
+        <volume-id>Fedora-S-dvd-x86_64-25</volume-id>
+        <system-id>LINUX</system-id>
+        <volume-size>507510784</volume-size>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <tree arch="i686">
+      <variant id="server"/>
+      <url>http://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/i386/os/</url>
+      <treeinfo>
+        <family>Fedora</family>
+        <version>25</version>
+        <arch>i386</arch>
+      </treeinfo>
+    </tree>
+    <tree arch="x86_64">
+      <url>http://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/x86_64/os/</url>
+      <variant id="server"/>
+      <treeinfo>
+        <family>Fedora</family>
+        <version>25</version>
+        <arch>x86_64</arch>
+      </treeinfo>
+    </tree>
+
+    <!-- No install media or tree is provided for Fedora 25 Cloud variant -->
+
+    <resources arch="all">
+      <minimum>
+        <n-cpus>1</n-cpus>
+        <cpu>1000000000</cpu>
+        <ram>1073741824</ram>
+        <storage>10737418240</storage>
+      </minimum>
+
+      <recommended>
+        <ram>2147483648</ram>
+        <storage>21474836480</storage>
+      </recommended>
+    </resources>
+
+    <installer>
+      <script id='http://fedoraproject.org/fedora/kickstart/jeos'/>
+      <script id='http://fedoraproject.org/fedora/kickstart/desktop'/>
+    </installer>
+  </os>
+</libosinfo>
-- 
2.9.3



From fidencio at redhat.com  Fri Jan  6 22:31:49 2017
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Fri,  6 Jan 2017 23:31:49 +0100
Subject: [Libosinfo] [libosinfo] fedora: Add F25 data
In-Reply-To: <20170106223149.28604-1-fidencio@redhat.com>
References: <20170106223149.28604-1-fidencio@redhat.com>
Message-ID: <20170106223149.28604-2-fidencio@redhat.com>

Signed-off-by: Fabiano Fid?ncio <fabianoo at fidencio.org>
---
 .../fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt | 29 ++++++++++++++++++++++
 .../Fedora-Server-dvd-x86_64-25-1.3.iso.txt        | 29 ++++++++++++++++++++++
 .../Fedora-Server-netinst-i386-25-1.3.iso.txt      | 29 ++++++++++++++++++++++
 .../Fedora-Server-netinst-x86_64-25-1.3.iso.txt    | 29 ++++++++++++++++++++++
 .../Fedora-Workstation-Live-i386-25-1.3.iso.txt    | 29 ++++++++++++++++++++++
 .../Fedora-Workstation-Live-x86_64-25-1.3.iso.txt  | 29 ++++++++++++++++++++++
 .../Fedora-Workstation-netinst-i386-25-1.3.iso.txt | 29 ++++++++++++++++++++++
 ...edora-Workstation-netinst-x86_64-25-1.3.iso.txt | 29 ++++++++++++++++++++++
 8 files changed, 232 insertions(+)
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
 create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt

diff --git a/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
new file mode 100644
index 0000000..02c379a
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-S-dvd-i386-25
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1031760
+El Torito VD version 1 found, boot catalog is in sector 414
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 3A56B 238955
diff --git a/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
new file mode 100644
index 0000000..653ea46
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-S-dvd-x86_64-25
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 985545
+El Torito VD version 1 found, boot catalog is in sector 399
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 3C7A8 247720
diff --git a/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
new file mode 100644
index 0000000..bcfee23
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-S-dvd-i386-25
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 239011
+El Torito VD version 1 found, boot catalog is in sector 38
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 3A3ED 238573
diff --git a/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
new file mode 100644
index 0000000..264e73e
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-S-dvd-x86_64-25
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 247797
+El Torito VD version 1 found, boot catalog is in sector 44
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 3BCDB 244955
diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
new file mode 100644
index 0000000..e160a82
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-WS-Live-25-1-3
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 746938
+El Torito VD version 1 found, boot catalog is in sector 40
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 4A00 18944
diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
new file mode 100644
index 0000000..3325283
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-WS-Live-25-1-3
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 703180
+El Torito VD version 1 found, boot catalog is in sector 46
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 4B74 19316
diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
new file mode 100644
index 0000000..1782a48
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-WS-dvd-i386-25
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 265946
+El Torito VD version 1 found, boot catalog is in sector 38
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 40D24 265508
diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
new file mode 100644
index 0000000..a010381
--- /dev/null
+++ b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-WS-dvd-x86_64-25
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 237140
+El Torito VD version 1 found, boot catalog is in sector 44
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 3933A 234298
-- 
2.9.3



From zeeshanak at gnome.org  Sun Jan  8 13:13:14 2017
From: zeeshanak at gnome.org (Zeeshan Ali (Khattak))
Date: Sun, 8 Jan 2017 14:13:14 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Enable repos when installing a
 Server ISO
In-Reply-To: <20170106203911.23327-1-fidencio@redhat.com>
References: <20170106203911.23327-1-fidencio@redhat.com>
Message-ID: <CAAa3hFMS_27N-AkeG1-3WNe2ThaPB6fSP4_iNu7T5B1wnX9YbA@mail.gmail.com>

Hi,

On 6 January 2017 at 21:39, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
> Fedora installer has been broken since different "working groups" have
> been introduced (Fedora 21).

You mean it's been broken for Server? I clearly remember fixing and
testing it for all Fedoras until F24.

> The reason of the breakage is that the "Server" media doesn't contain
> all the packages needed to perform the "Workstation" installation done
> by the desktop profile.

IIRC the decision was to only do "desktop profile" express
installation for netiso, since it doesn't make much sense to install
Desktop for server ISO.

> The only way to solve this issue is by enabling the repos that contain
> the needed packages during installation.
>
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
> index 1fefebb..ad4d956 100644
> --- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
> +++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
> @@ -129,7 +129,7 @@ logvol swap --fstype swap --name=LogVol01 --vgname=VolGroup00 --size=768 --grow
>  logvol / --fstype <xsl:call-template name="rootfs"/> --name=LogVol00 --vgname=VolGroup00 --size=1024 --grow
>  reboot
>
> -<xsl:if test="contains(media/variant, 'netinst')">
> +<xsl:if test="(contains(media/variant, 'netinst') or contains(media/variant, 'server'))">
>  repo --name=fedora --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
>  repo --name=updates --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=updates-released-f$releasever&amp;arch=$basearch
>  url --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
> --
> 2.9.3
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Regards,

Zeeshan Ali



From fabiano at fidencio.org  Sun Jan  8 15:53:43 2017
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sun,  8 Jan 2017 16:53:43 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for
	Workstation
Message-ID: <20170108155343.3410-1-fabiano@fidencio.org>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/fedoraproject.org/fedora-21.xml.in | 8 ++++----
 data/os/fedoraproject.org/fedora-22.xml.in | 8 ++++----
 data/os/fedoraproject.org/fedora-23.xml.in | 8 ++++----
 data/os/fedoraproject.org/fedora-24.xml.in | 8 ++++----
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/data/os/fedoraproject.org/fedora-21.xml.in b/data/os/fedoraproject.org/fedora-21.xml.in
index d7c2870..4004a37 100644
--- a/data/os/fedoraproject.org/fedora-21.xml.in
+++ b/data/os/fedoraproject.org/fedora-21.xml.in
@@ -45,8 +45,8 @@
         <system-id>LINUX</system-id>
         <volume-size>1335937024</volume-size>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
     <media arch="x86_64" live="true">
       <variant id="workstation"/>
@@ -56,8 +56,8 @@
         <system-id>LINUX</system-id>
         <volume-size>1471502336</volume-size>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
 
     <!-- Server -->
diff --git a/data/os/fedoraproject.org/fedora-22.xml.in b/data/os/fedoraproject.org/fedora-22.xml.in
index df1718f..9b693e6 100644
--- a/data/os/fedoraproject.org/fedora-22.xml.in
+++ b/data/os/fedoraproject.org/fedora-22.xml.in
@@ -37,8 +37,8 @@
         <system-id>LINUX</system-id>
         <volume-size>1398321152</volume-size>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
     <media arch="x86_64" live="true">
       <variant id="workstation"/>
@@ -48,8 +48,8 @@
         <system-id>LINUX</system-id>
         <volume-size>1430704128</volume-size>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
 
     <!-- Network Installer !-->
diff --git a/data/os/fedoraproject.org/fedora-23.xml.in b/data/os/fedoraproject.org/fedora-23.xml.in
index b884722..24e0b4c 100644
--- a/data/os/fedoraproject.org/fedora-23.xml.in
+++ b/data/os/fedoraproject.org/fedora-23.xml.in
@@ -49,8 +49,8 @@
         <volume-id>Fedora-Live-WS-i686-23.*</volume-id>
         <system-id>LINUX</system-id>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
     <media arch="x86_64" live="true">
       <variant id="workstation"/>
@@ -59,8 +59,8 @@
         <volume-id>Fedora-Live-WS-x86_64-23.*</volume-id>
         <system-id>LINUX</system-id>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
 
     <!-- Network Installer !-->
diff --git a/data/os/fedoraproject.org/fedora-24.xml.in b/data/os/fedoraproject.org/fedora-24.xml.in
index 1b7f461..e69cccc 100644
--- a/data/os/fedoraproject.org/fedora-24.xml.in
+++ b/data/os/fedoraproject.org/fedora-24.xml.in
@@ -40,8 +40,8 @@
         <volume-id>Fedora-WS-Live-24.*</volume-id>
         <system-id>LINUX</system-id>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
     <media arch="x86_64" live="true">
       <variant id="workstation"/>
@@ -50,8 +50,8 @@
         <volume-id>Fedora-WS-Live-24.*</volume-id>
         <system-id>LINUX</system-id>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
 
     <!-- Network Installer !-->
-- 
2.9.3



From fidencio at redhat.com  Sun Jan  8 18:16:57 2017
From: fidencio at redhat.com (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Sun, 8 Jan 2017 19:16:57 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Enable repos when installing a
 Server ISO
In-Reply-To: <CAAa3hFMS_27N-AkeG1-3WNe2ThaPB6fSP4_iNu7T5B1wnX9YbA@mail.gmail.com>
References: <20170106203911.23327-1-fidencio@redhat.com>
	<CAAa3hFMS_27N-AkeG1-3WNe2ThaPB6fSP4_iNu7T5B1wnX9YbA@mail.gmail.com>
Message-ID: <CAAY6XscZEe0v4tc9YFWi1vYrQgxAb=eU3mOzhjb-6BF26Z+LaA@mail.gmail.com>

On Sun, Jan 8, 2017 at 2:13 PM, Zeeshan Ali (Khattak)
<zeeshanak at gnome.org> wrote:
> Hi,
>
> On 6 January 2017 at 21:39, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
>> Fedora installer has been broken since different "working groups" have
>> been introduced (Fedora 21).
>
> You mean it's been broken for Server? I clearly remember fixing and
> testing it for all Fedoras until F24.

For the Server iso, yes, it doesn't work since Fedora 21.
You probably have tested just the netinst ISO.

>
>> The reason of the breakage is that the "Server" media doesn't contain
>> all the packages needed to perform the "Workstation" installation done
>> by the desktop profile.
>
> IIRC the decision was to only do "desktop profile" express
> installation for netiso, since it doesn't make much sense to install
> Desktop for server ISO.

I sincerely don't understand why it would make sense to do so for
netinst ISO but not for the normal one.
Also, Boxes does recognize the ISO as an express installation target
... and fails when trying to perform that ...

>
>> The only way to solve this issue is by enabling the repos that contain
>> the needed packages during installation.
>>
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
>> index 1fefebb..ad4d956 100644
>> --- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
>> +++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
>> @@ -129,7 +129,7 @@ logvol swap --fstype swap --name=LogVol01 --vgname=VolGroup00 --size=768 --grow
>>  logvol / --fstype <xsl:call-template name="rootfs"/> --name=LogVol00 --vgname=VolGroup00 --size=1024 --grow
>>  reboot
>>
>> -<xsl:if test="contains(media/variant, 'netinst')">
>> +<xsl:if test="(contains(media/variant, 'netinst') or contains(media/variant, 'server'))">
>>  repo --name=fedora --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
>>  repo --name=updates --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=updates-released-f$releasever&amp;arch=$basearch
>>  url --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
>> --
>> 2.9.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
>
>
> --
> Regards,
>
> Zeeshan Ali



From cfergeau at redhat.com  Mon Jan  9 09:16:09 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 9 Jan 2017 10:16:09 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for
 Workstation
In-Reply-To: <20170108155343.3410-1-fabiano@fidencio.org>
References: <20170108155343.3410-1-fabiano@fidencio.org>
Message-ID: <20170109091608.w5ypsntuhmht5u4o@edamame.cdg.redhat.com>

On Sun, Jan 08, 2017 at 04:53:43PM +0100, Fabiano Fid?ncio wrote:
> diff --git a/data/os/fedoraproject.org/fedora-23.xml.in b/data/os/fedoraproject.org/fedora-23.xml.in
> index b884722..24e0b4c 100644
> --- a/data/os/fedoraproject.org/fedora-23.xml.in
> +++ b/data/os/fedoraproject.org/fedora-23.xml.in
> @@ -49,8 +49,8 @@
>          <volume-id>Fedora-Live-WS-i686-23.*</volume-id>
>          <system-id>LINUX</system-id>
>        </iso>
> -      <kernel>isolinux/vmlinuz0</kernel>
> -      <initrd>isolinux/initrd0.img</initrd>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
>      </media>
>      <media arch="x86_64" live="true">
>        <variant id="workstation"/>
> @@ -59,8 +59,8 @@
>          <volume-id>Fedora-Live-WS-x86_64-23.*</volume-id>
>          <system-id>LINUX</system-id>
>        </iso>
> -      <kernel>isolinux/vmlinuz0</kernel>
> -      <initrd>isolinux/initrd0.img</initrd>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
>      </media>
>  

What is this patch based on?

# sha256sum  Fedora-Live-Workstation-x86_64-23-10.iso
a91eca2492ac84909953ef27040f9b61d8525f7ec5e89f6430319f49f9f823fe Fedora-Live-Workstation-x86_64-23-10.iso

(this matches
http://fedora.mirrors.ovh.net/linux/releases/23/Workstation/x86_64/iso/Fedora-Workstation-23-x86_64-CHECKSUM
)
# mount -o loop Fedora-Live-Workstation-x86_64-23-10.iso /media/
# ls -1 /media/isolinux/{initrd*,vmlinuz*}
/media/isolinux/initrd0.img
/media/isolinux/vmlinuz0

The f21 ISO I have locally also uses initrd0/vmlinuz0.


Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170109/8d7986e4/attachment.sig>

From cfergeau at redhat.com  Mon Jan  9 09:26:05 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 9 Jan 2017 10:26:05 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Add F25 info
In-Reply-To: <20170106223149.28604-1-fidencio@redhat.com>
References: <20170106223149.28604-1-fidencio@redhat.com>
Message-ID: <20170109092605.sq5sa5jjsmsad4so@edamame.cdg.redhat.com>

On Fri, Jan 06, 2017 at 11:31:48PM +0100, Fabiano Fid?ncio wrote:
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/os/fedoraproject.org/fedora-25.xml.in | 169 +++++++++++++++++++++++++++++
>  1 file changed, 169 insertions(+)
>  create mode 100644 data/os/fedoraproject.org/fedora-25.xml.in
> 
> diff --git a/data/os/fedoraproject.org/fedora-25.xml.in b/data/os/fedoraproject.org/fedora-25.xml.in
> new file mode 100644
> index 0000000..5e56623
> --- /dev/null
> +++ b/data/os/fedoraproject.org/fedora-25.xml.in
> @@ -0,0 +1,169 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <os id="http://fedoraproject.org/fedora/25">
> +    <short-id>fedora25</short-id>
> +    <_name>Fedora 25</_name>
> +    <version>25</version>
> +    <_vendor>Fedora Project</_vendor>
> +    <family>linux</family>
> +    <distro>fedora</distro>
> +    <upgrades id="http://fedoraproject.org/fedora/24"/>
> +    <derives-from id="http://fedoraproject.org/fedora/24"/>
> +
> +    <release-date>2016-11-22</release-date>
> +
> +    <variant id="workstation">
> +      <_name>Fedora 25 Workstation</_name>
> +    </variant>
> +    <variant id="workstation-netinst">
> +      <_name>Fedora 25 Workstation</_name>
> +    </variant>
> +    <variant id="server">
> +      <_name>Fedora 25 Server</_name>
> +    </variant>
> +    <variant id="server-netinst">
> +      <_name>Fedora 25 Server</_name>
> +    </variant>
> +
> +    <!-- Workstation -->
> +
> +    <!-- Live -->
> +    <media arch="i686" live="true">
> +      <variant id="workstation"/>
> +      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/i386/iso/Fedora-Workstation-Live-i386-25-1.3.iso</url>
> +      <iso>
> +        <volume-id>Fedora-WS-Live-25.*</volume-id>
> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz0</kernel>
> +      <initrd>isolinux/initrd0.img</initrd>
> +    </media>
> +    <media arch="x86_64" live="true">
> +      <variant id="workstation"/>
> +      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-25-1.3.iso</url>
> +      <iso>
> +        <volume-id>Fedora-WS-Live-25.*</volume-id>
> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz0</kernel>
> +      <initrd>isolinux/initrd0.img</initrd>
> +    </media>

Here the '0' are not correct.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170109/b20e9186/attachment.sig>

From cfergeau at redhat.com  Mon Jan  9 09:27:39 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 9 Jan 2017 10:27:39 +0100
Subject: [Libosinfo] [libosinfo] fedora: Add F25 data
In-Reply-To: <20170106223149.28604-2-fidencio@redhat.com>
References: <20170106223149.28604-1-fidencio@redhat.com>
	<20170106223149.28604-2-fidencio@redhat.com>
Message-ID: <20170109092739.fkaa64el4dh4gdbg@edamame.cdg.redhat.com>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Fri, Jan 06, 2017 at 11:31:49PM +0100, Fabiano Fid?ncio wrote:
> Signed-off-by: Fabiano Fid?ncio <fabianoo at fidencio.org>
> ---
>  .../fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt | 29 ++++++++++++++++++++++
>  .../Fedora-Server-dvd-x86_64-25-1.3.iso.txt        | 29 ++++++++++++++++++++++
>  .../Fedora-Server-netinst-i386-25-1.3.iso.txt      | 29 ++++++++++++++++++++++
>  .../Fedora-Server-netinst-x86_64-25-1.3.iso.txt    | 29 ++++++++++++++++++++++
>  .../Fedora-Workstation-Live-i386-25-1.3.iso.txt    | 29 ++++++++++++++++++++++
>  .../Fedora-Workstation-Live-x86_64-25-1.3.iso.txt  | 29 ++++++++++++++++++++++
>  .../Fedora-Workstation-netinst-i386-25-1.3.iso.txt | 29 ++++++++++++++++++++++
>  ...edora-Workstation-netinst-x86_64-25-1.3.iso.txt | 29 ++++++++++++++++++++++
>  8 files changed, 232 insertions(+)
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
> 
> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
> new file mode 100644
> index 0000000..02c379a
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-S-dvd-i386-25
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1031760
> +El Torito VD version 1 found, boot catalog is in sector 414
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 3A56B 238955
> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
> new file mode 100644
> index 0000000..653ea46
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-S-dvd-x86_64-25
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 985545
> +El Torito VD version 1 found, boot catalog is in sector 399
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 3C7A8 247720
> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
> new file mode 100644
> index 0000000..bcfee23
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-S-dvd-i386-25
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 239011
> +El Torito VD version 1 found, boot catalog is in sector 38
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 3A3ED 238573
> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
> new file mode 100644
> index 0000000..264e73e
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-S-dvd-x86_64-25
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 247797
> +El Torito VD version 1 found, boot catalog is in sector 44
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 3BCDB 244955
> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
> new file mode 100644
> index 0000000..e160a82
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-WS-Live-25-1-3
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 746938
> +El Torito VD version 1 found, boot catalog is in sector 40
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 4A00 18944
> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
> new file mode 100644
> index 0000000..3325283
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-WS-Live-25-1-3
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 703180
> +El Torito VD version 1 found, boot catalog is in sector 46
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 4B74 19316
> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
> new file mode 100644
> index 0000000..1782a48
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-WS-dvd-i386-25
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 265946
> +El Torito VD version 1 found, boot catalog is in sector 38
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 40D24 265508
> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
> new file mode 100644
> index 0000000..a010381
> --- /dev/null
> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-WS-dvd-x86_64-25
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 237140
> +El Torito VD version 1 found, boot catalog is in sector 44
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 3933A 234298
> -- 
> 2.9.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170109/888a4045/attachment.sig>

From fidencio at redhat.com  Mon Jan  9 10:01:01 2017
From: fidencio at redhat.com (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Mon, 9 Jan 2017 11:01:01 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for
	Workstation
In-Reply-To: <20170109091608.w5ypsntuhmht5u4o@edamame.cdg.redhat.com>
References: <20170108155343.3410-1-fabiano@fidencio.org>
	<20170109091608.w5ypsntuhmht5u4o@edamame.cdg.redhat.com>
Message-ID: <CAAY6XsdUZDsHSKOQeBU2X4D94Gz-5b3RqedMXUScn681RAGa8A@mail.gmail.com>

On Mon, Jan 9, 2017 at 10:16 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Sun, Jan 08, 2017 at 04:53:43PM +0100, Fabiano Fid?ncio wrote:
>> diff --git a/data/os/fedoraproject.org/fedora-23.xml.in b/data/os/fedoraproject.org/fedora-23.xml.in
>> index b884722..24e0b4c 100644
>> --- a/data/os/fedoraproject.org/fedora-23.xml.in
>> +++ b/data/os/fedoraproject.org/fedora-23.xml.in
>> @@ -49,8 +49,8 @@
>>          <volume-id>Fedora-Live-WS-i686-23.*</volume-id>
>>          <system-id>LINUX</system-id>
>>        </iso>
>> -      <kernel>isolinux/vmlinuz0</kernel>
>> -      <initrd>isolinux/initrd0.img</initrd>
>> +      <kernel>isolinux/vmlinuz</kernel>
>> +      <initrd>isolinux/initrd.img</initrd>
>>      </media>
>>      <media arch="x86_64" live="true">
>>        <variant id="workstation"/>
>> @@ -59,8 +59,8 @@
>>          <volume-id>Fedora-Live-WS-x86_64-23.*</volume-id>
>>          <system-id>LINUX</system-id>
>>        </iso>
>> -      <kernel>isolinux/vmlinuz0</kernel>
>> -      <initrd>isolinux/initrd0.img</initrd>
>> +      <kernel>isolinux/vmlinuz</kernel>
>> +      <initrd>isolinux/initrd.img</initrd>
>>      </media>
>>
>
> What is this patch based on?
>
> # sha256sum  Fedora-Live-Workstation-x86_64-23-10.iso
> a91eca2492ac84909953ef27040f9b61d8525f7ec5e89f6430319f49f9f823fe Fedora-Live-Workstation-x86_64-23-10.iso
>
> (this matches
> http://fedora.mirrors.ovh.net/linux/releases/23/Workstation/x86_64/iso/Fedora-Workstation-23-x86_64-CHECKSUM
> )
> # mount -o loop Fedora-Live-Workstation-x86_64-23-10.iso /media/
> # ls -1 /media/isolinux/{initrd*,vmlinuz*}
> /media/isolinux/initrd0.img
> /media/isolinux/vmlinuz0
>
> The f21 ISO I have locally also uses initrd0/vmlinuz0.

Ouch! I'll re-check then. I've checked with a few Fedora ISOs (24, 25
... and some older ISOs that I had handy at the moment).

Best Regards,
--
Fabiano Fid?ncio



From cfergeau at redhat.com  Mon Jan  9 10:07:43 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 9 Jan 2017 11:07:43 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for
 Workstation
In-Reply-To: <CAAY6XsdUZDsHSKOQeBU2X4D94Gz-5b3RqedMXUScn681RAGa8A@mail.gmail.com>
References: <20170108155343.3410-1-fabiano@fidencio.org>
	<20170109091608.w5ypsntuhmht5u4o@edamame.cdg.redhat.com>
	<CAAY6XsdUZDsHSKOQeBU2X4D94Gz-5b3RqedMXUScn681RAGa8A@mail.gmail.com>
Message-ID: <20170109100743.47e5mexvyddpnijh@edamame.cdg.redhat.com>

On Mon, Jan 09, 2017 at 11:01:01AM +0100, Fabiano Fid?ncio wrote:
> On Mon, Jan 9, 2017 at 10:16 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Sun, Jan 08, 2017 at 04:53:43PM +0100, Fabiano Fid?ncio wrote:
> >> diff --git a/data/os/fedoraproject.org/fedora-23.xml.in b/data/os/fedoraproject.org/fedora-23.xml.in
> >> index b884722..24e0b4c 100644
> >> --- a/data/os/fedoraproject.org/fedora-23.xml.in
> >> +++ b/data/os/fedoraproject.org/fedora-23.xml.in
> >> @@ -49,8 +49,8 @@
> >>          <volume-id>Fedora-Live-WS-i686-23.*</volume-id>
> >>          <system-id>LINUX</system-id>
> >>        </iso>
> >> -      <kernel>isolinux/vmlinuz0</kernel>
> >> -      <initrd>isolinux/initrd0.img</initrd>
> >> +      <kernel>isolinux/vmlinuz</kernel>
> >> +      <initrd>isolinux/initrd.img</initrd>
> >>      </media>
> >>      <media arch="x86_64" live="true">
> >>        <variant id="workstation"/>
> >> @@ -59,8 +59,8 @@
> >>          <volume-id>Fedora-Live-WS-x86_64-23.*</volume-id>
> >>          <system-id>LINUX</system-id>
> >>        </iso>
> >> -      <kernel>isolinux/vmlinuz0</kernel>
> >> -      <initrd>isolinux/initrd0.img</initrd>
> >> +      <kernel>isolinux/vmlinuz</kernel>
> >> +      <initrd>isolinux/initrd.img</initrd>
> >>      </media>
> >>
> >
> > What is this patch based on?
> >
> > # sha256sum  Fedora-Live-Workstation-x86_64-23-10.iso
> > a91eca2492ac84909953ef27040f9b61d8525f7ec5e89f6430319f49f9f823fe Fedora-Live-Workstation-x86_64-23-10.iso
> >
> > (this matches
> > http://fedora.mirrors.ovh.net/linux/releases/23/Workstation/x86_64/iso/Fedora-Workstation-23-x86_64-CHECKSUM
> > )
> > # mount -o loop Fedora-Live-Workstation-x86_64-23-10.iso /media/
> > # ls -1 /media/isolinux/{initrd*,vmlinuz*}
> > /media/isolinux/initrd0.img
> > /media/isolinux/vmlinuz0
> >
> > The f21 ISO I have locally also uses initrd0/vmlinuz0.
> 
> Ouch! I'll re-check then. I've checked with a few Fedora ISOs (24, 25
> ... and some older ISOs that I had handy at the moment).

The f24/f25 images I have are using initrd/vmlinuz, I'd say the older
ones are using initrd0/vmlinuz0? (but I did not make an extensive check).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170109/8b4f30fd/attachment.sig>

From fidencio at redhat.com  Mon Jan  9 10:15:00 2017
From: fidencio at redhat.com (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Mon, 9 Jan 2017 11:15:00 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for
	Workstation
In-Reply-To: <20170109100743.47e5mexvyddpnijh@edamame.cdg.redhat.com>
References: <20170108155343.3410-1-fabiano@fidencio.org>
	<20170109091608.w5ypsntuhmht5u4o@edamame.cdg.redhat.com>
	<CAAY6XsdUZDsHSKOQeBU2X4D94Gz-5b3RqedMXUScn681RAGa8A@mail.gmail.com>
	<20170109100743.47e5mexvyddpnijh@edamame.cdg.redhat.com>
Message-ID: <CAAY6XsfMwBVVswbQyRF+NMreq9mrWL0MLMf9U9kBfYB2VqLjBg@mail.gmail.com>

On Mon, Jan 9, 2017 at 11:07 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, Jan 09, 2017 at 11:01:01AM +0100, Fabiano Fid?ncio wrote:
>> On Mon, Jan 9, 2017 at 10:16 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Sun, Jan 08, 2017 at 04:53:43PM +0100, Fabiano Fid?ncio wrote:
>> >> diff --git a/data/os/fedoraproject.org/fedora-23.xml.in b/data/os/fedoraproject.org/fedora-23.xml.in
>> >> index b884722..24e0b4c 100644
>> >> --- a/data/os/fedoraproject.org/fedora-23.xml.in
>> >> +++ b/data/os/fedoraproject.org/fedora-23.xml.in
>> >> @@ -49,8 +49,8 @@
>> >>          <volume-id>Fedora-Live-WS-i686-23.*</volume-id>
>> >>          <system-id>LINUX</system-id>
>> >>        </iso>
>> >> -      <kernel>isolinux/vmlinuz0</kernel>
>> >> -      <initrd>isolinux/initrd0.img</initrd>
>> >> +      <kernel>isolinux/vmlinuz</kernel>
>> >> +      <initrd>isolinux/initrd.img</initrd>
>> >>      </media>
>> >>      <media arch="x86_64" live="true">
>> >>        <variant id="workstation"/>
>> >> @@ -59,8 +59,8 @@
>> >>          <volume-id>Fedora-Live-WS-x86_64-23.*</volume-id>
>> >>          <system-id>LINUX</system-id>
>> >>        </iso>
>> >> -      <kernel>isolinux/vmlinuz0</kernel>
>> >> -      <initrd>isolinux/initrd0.img</initrd>
>> >> +      <kernel>isolinux/vmlinuz</kernel>
>> >> +      <initrd>isolinux/initrd.img</initrd>
>> >>      </media>
>> >>
>> >
>> > What is this patch based on?
>> >
>> > # sha256sum  Fedora-Live-Workstation-x86_64-23-10.iso
>> > a91eca2492ac84909953ef27040f9b61d8525f7ec5e89f6430319f49f9f823fe Fedora-Live-Workstation-x86_64-23-10.iso
>> >
>> > (this matches
>> > http://fedora.mirrors.ovh.net/linux/releases/23/Workstation/x86_64/iso/Fedora-Workstation-23-x86_64-CHECKSUM
>> > )
>> > # mount -o loop Fedora-Live-Workstation-x86_64-23-10.iso /media/
>> > # ls -1 /media/isolinux/{initrd*,vmlinuz*}
>> > /media/isolinux/initrd0.img
>> > /media/isolinux/vmlinuz0
>> >
>> > The f21 ISO I have locally also uses initrd0/vmlinuz0.
>>
>> Ouch! I'll re-check then. I've checked with a few Fedora ISOs (24, 25
>> ... and some older ISOs that I had handy at the moment).
>
> The f24/f25 images I have are using initrd/vmlinuz, I'd say the older
> ones are using initrd0/vmlinuz0? (but I did not make an extensive check).

I'll do the extensive check and submit a v2.
Thanks for the review and for checking it, Christophe.

>
> Christophe



From zeeshanak at gnome.org  Mon Jan  9 10:45:33 2017
From: zeeshanak at gnome.org (Zeeshan Ali (Khattak))
Date: Mon, 9 Jan 2017 11:45:33 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Enable repos when installing a
 Server ISO
In-Reply-To: <CAAY6XscZEe0v4tc9YFWi1vYrQgxAb=eU3mOzhjb-6BF26Z+LaA@mail.gmail.com>
References: <20170106203911.23327-1-fidencio@redhat.com>
	<CAAa3hFMS_27N-AkeG1-3WNe2ThaPB6fSP4_iNu7T5B1wnX9YbA@mail.gmail.com>
	<CAAY6XscZEe0v4tc9YFWi1vYrQgxAb=eU3mOzhjb-6BF26Z+LaA@mail.gmail.com>
Message-ID: <CAAa3hFOPhmnnkdriWeonb=4BySceE2BspHim2EV-yjsnZ2ycCg@mail.gmail.com>

Hi,

On 8 January 2017 at 19:16, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
> On Sun, Jan 8, 2017 at 2:13 PM, Zeeshan Ali (Khattak)
> <zeeshanak at gnome.org> wrote:
>> Hi,
>>
>> On 6 January 2017 at 21:39, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
>>> Fedora installer has been broken since different "working groups" have
>>> been introduced (Fedora 21).
>>
>> You mean it's been broken for Server? I clearly remember fixing and
>> testing it for all Fedoras until F24.
>
> For the Server iso, yes, it doesn't work since Fedora 21.
> You probably have tested just the netinst ISO.
>
>>
>>> The reason of the breakage is that the "Server" media doesn't contain
>>> all the packages needed to perform the "Workstation" installation done
>>> by the desktop profile.
>>
>> IIRC the decision was to only do "desktop profile" express
>> installation for netiso, since it doesn't make much sense to install
>> Desktop for server ISO.
>
> I sincerely don't understand why it would make sense to do so for
> netinst ISO but not for the normal one.

Because "desktop" profile maps to workstation but workstation didn't
have an installer ISO. Also netiso is very generic so you can argue
both ways for that and you'll be correct. :)

> Also, Boxes does recognize the ISO as an express installation target
> ... and fails when trying to perform that ...

That's a bug then.

>>> The only way to solve this issue is by enabling the repos that contain
>>> the needed packages during installation.

Or we don't offer express installation for Server.

>>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>>> ---
>>>  data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
>>> index 1fefebb..ad4d956 100644
>>> --- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
>>> +++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
>>> @@ -129,7 +129,7 @@ logvol swap --fstype swap --name=LogVol01 --vgname=VolGroup00 --size=768 --grow
>>>  logvol / --fstype <xsl:call-template name="rootfs"/> --name=LogVol00 --vgname=VolGroup00 --size=1024 --grow
>>>  reboot
>>>
>>> -<xsl:if test="contains(media/variant, 'netinst')">
>>> +<xsl:if test="(contains(media/variant, 'netinst') or contains(media/variant, 'server'))">
>>>  repo --name=fedora --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
>>>  repo --name=updates --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=updates-released-f$releasever&amp;arch=$basearch
>>>  url --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&amp;arch=$basearch
>>> --
>>> 2.9.3
>>>
>>> _______________________________________________
>>> Libosinfo mailing list
>>> Libosinfo at redhat.com
>>> https://www.redhat.com/mailman/listinfo/libosinfo
>>
>>
>>
>> --
>> Regards,
>>
>> Zeeshan Ali



-- 
Regards,

Zeeshan Ali



From berrange at redhat.com  Mon Jan  9 10:56:17 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Mon, 9 Jan 2017 10:56:17 +0000
Subject: [Libosinfo] [osinfo-db] fedora: Enable repos when installing a
 Server ISO
In-Reply-To: <CAAa3hFOPhmnnkdriWeonb=4BySceE2BspHim2EV-yjsnZ2ycCg@mail.gmail.com>
References: <20170106203911.23327-1-fidencio@redhat.com>
	<CAAa3hFMS_27N-AkeG1-3WNe2ThaPB6fSP4_iNu7T5B1wnX9YbA@mail.gmail.com>
	<CAAY6XscZEe0v4tc9YFWi1vYrQgxAb=eU3mOzhjb-6BF26Z+LaA@mail.gmail.com>
	<CAAa3hFOPhmnnkdriWeonb=4BySceE2BspHim2EV-yjsnZ2ycCg@mail.gmail.com>
Message-ID: <20170109105616.GD29989@redhat.com>

On Mon, Jan 09, 2017 at 11:45:33AM +0100, Zeeshan Ali (Khattak) wrote:
> Hi,
> 
> On 8 January 2017 at 19:16, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
> > On Sun, Jan 8, 2017 at 2:13 PM, Zeeshan Ali (Khattak)
> > <zeeshanak at gnome.org> wrote:
> >> Hi,
> >>
> >> On 6 January 2017 at 21:39, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
> >>> Fedora installer has been broken since different "working groups" have
> >>> been introduced (Fedora 21).
> >>
> >> You mean it's been broken for Server? I clearly remember fixing and
> >> testing it for all Fedoras until F24.
> >
> > For the Server iso, yes, it doesn't work since Fedora 21.
> > You probably have tested just the netinst ISO.
> >
> >>
> >>> The reason of the breakage is that the "Server" media doesn't contain
> >>> all the packages needed to perform the "Workstation" installation done
> >>> by the desktop profile.
> >>
> >> IIRC the decision was to only do "desktop profile" express
> >> installation for netiso, since it doesn't make much sense to install
> >> Desktop for server ISO.
> >
> > I sincerely don't understand why it would make sense to do so for
> > netinst ISO but not for the normal one.
> 
> Because "desktop" profile maps to workstation but workstation didn't
> have an installer ISO. Also netiso is very generic so you can argue
> both ways for that and you'll be correct. :)
> 
> > Also, Boxes does recognize the ISO as an express installation target
> > ... and fails when trying to perform that ...
> 
> That's a bug then.
> 
> >>> The only way to solve this issue is by enabling the repos that contain
> >>> the needed packages during installation.
> 
> Or we don't offer express installation for Server.

Yeah, IMHO it makese little sense to install the "desktop" profile when
you have the "Server" ISO - the "jeos" profile is really server targetted.

Our XML doesn't express any relationship between media and installers
though - installers are just listed standalone. I wonder if we need to
introduce some kind of relation there to filter it ?


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|



From zeeshanak at gnome.org  Mon Jan  9 11:16:26 2017
From: zeeshanak at gnome.org (Zeeshan Ali (Khattak))
Date: Mon, 9 Jan 2017 12:16:26 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Enable repos when installing a
 Server ISO
Message-ID: <CAAa3hFNBoScwCP6XMfQxEcyKq7x994NiDKAauSuFZNmMOst6bw@mail.gmail.com>

Err.. forgot to reply-all. :(

---------- Forwarded message ----------
From: Zeeshan Ali (Khattak) <zeeshanak at gnome.org>
Date: 9 January 2017 at 12:15
Subject: Re: [Libosinfo] [osinfo-db] fedora: Enable repos when
installing a Server ISO
To: "Daniel P. Berrange" <berrange at redhat.com>


Hi,

On 9 January 2017 at 11:56, Daniel P. Berrange <berrange at redhat.com> wrote:
> On Mon, Jan 09, 2017 at 11:45:33AM +0100, Zeeshan Ali (Khattak) wrote:
>> Hi,
>>
>> On 8 January 2017 at 19:16, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
>> > On Sun, Jan 8, 2017 at 2:13 PM, Zeeshan Ali (Khattak)
>> > <zeeshanak at gnome.org> wrote:
>> >> Hi,
>> >>
>> >> On 6 January 2017 at 21:39, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
>> >>> Fedora installer has been broken since different "working groups" have
>> >>> been introduced (Fedora 21).
>> >>
>> >> You mean it's been broken for Server? I clearly remember fixing and
>> >> testing it for all Fedoras until F24.
>> >
>> > For the Server iso, yes, it doesn't work since Fedora 21.
>> > You probably have tested just the netinst ISO.
>> >
>> >>
>> >>> The reason of the breakage is that the "Server" media doesn't contain
>> >>> all the packages needed to perform the "Workstation" installation done
>> >>> by the desktop profile.
>> >>
>> >> IIRC the decision was to only do "desktop profile" express
>> >> installation for netiso, since it doesn't make much sense to install
>> >> Desktop for server ISO.
>> >
>> > I sincerely don't understand why it would make sense to do so for
>> > netinst ISO but not for the normal one.
>>
>> Because "desktop" profile maps to workstation but workstation didn't
>> have an installer ISO. Also netiso is very generic so you can argue
>> both ways for that and you'll be correct. :)
>>
>> > Also, Boxes does recognize the ISO as an express installation target
>> > ... and fails when trying to perform that ...
>>
>> That's a bug then.
>>
>> >>> The only way to solve this issue is by enabling the repos that contain
>> >>> the needed packages during installation.
>>
>> Or we don't offer express installation for Server.
>
> Yeah, IMHO it makese little sense to install the "desktop" profile when
> you have the "Server" ISO - the "jeos" profile is really server targetted.
>
> Our XML doesn't express any relationship between media and installers
> though - installers are just listed standalone. I wonder if we need to
> introduce some kind of relation there to filter it ?

Yeah. We already have 'variant' on media and we pass this info to
installer. So how about an optional 'variants' attribute on installer,
specifying which variants are supported? App code will have to change
though so only correct installer is picked up but installer generator
should also error out if incorrect combination is used.

--
Regards,

Zeeshan Ali


-- 
Regards,

Zeeshan Ali



From fabiano at fidencio.org  Wed Jan 11 23:26:31 2017
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Thu, 12 Jan 2017 00:26:31 +0100
Subject: [Libosinfo] [osinfo-db] rhel: Add support to registering to the
	subscription-manager
Message-ID: <20170111232631.31903-1-fabiano@fidencio.org>

From: Fabiano Fid?ncio <fidencio at redhat.com>

In case reg-login and reg-password are non-null, perform the
subscription during the %post phase of the kickstart file.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/install-script/redhat.com/rhel-kickstart-desktop.xml.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
index 1b917ee..946f84f 100644
--- a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
+++ b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
@@ -16,6 +16,8 @@
         <param name="avatar-disk" policy="optional"/>
         <param name="target-disk" policy="optional"/>
         <param name="script-disk" policy="required"/>
+        <param name="reg-login" policy="optional"/>
+        <param name="reg-password" policy="optional"/>
     </config>
     <injection-method>cdrom</injection-method>
     <injection-method>disk</injection-method>
@@ -152,6 +154,10 @@ AutomaticLogin=<xsl:value-of select="config/user-login"/>
 [debug]
 " > /etc/gdm/custom.conf
 
+if [ -n <xsl:value-of select="config/reg-login"/> -a -n <xsl:value-of select="config/reg-password"/> ]; then
+    subscription-manager register --username <xsl:value-of select="config/reg-login"/> --password <xsl:value-of select="config/reg-password"/> --auto-attach
+fi
+
 %end
 	</xsl:template>
       </xsl:stylesheet>
-- 
2.9.3



From fabiano at fidencio.org  Thu Jan 12 11:57:51 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 12 Jan 2017 12:57:51 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Add F25 info
In-Reply-To: <20170109092605.sq5sa5jjsmsad4so@edamame.cdg.redhat.com>
References: <20170106223149.28604-1-fidencio@redhat.com>
	<20170109092605.sq5sa5jjsmsad4so@edamame.cdg.redhat.com>
Message-ID: <CAK9pz9LF3G3z220dZKmqcV671XOMifAOuwYhvkwBtatkzDL16g@mail.gmail.com>

On Mon, Jan 9, 2017 at 10:26 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Fri, Jan 06, 2017 at 11:31:48PM +0100, Fabiano Fid?ncio wrote:
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  data/os/fedoraproject.org/fedora-25.xml.in | 169 +++++++++++++++++++++++++++++
>>  1 file changed, 169 insertions(+)
>>  create mode 100644 data/os/fedoraproject.org/fedora-25.xml.in
>>
>> diff --git a/data/os/fedoraproject.org/fedora-25.xml.in b/data/os/fedoraproject.org/fedora-25.xml.in
>> new file mode 100644
>> index 0000000..5e56623
>> --- /dev/null
>> +++ b/data/os/fedoraproject.org/fedora-25.xml.in
>> @@ -0,0 +1,169 @@
>> +<libosinfo version="0.0.1">
>> +<!-- Licensed under the GNU General Public License version 2 or later.
>> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
>> +  <os id="http://fedoraproject.org/fedora/25">
>> +    <short-id>fedora25</short-id>
>> +    <_name>Fedora 25</_name>
>> +    <version>25</version>
>> +    <_vendor>Fedora Project</_vendor>
>> +    <family>linux</family>
>> +    <distro>fedora</distro>
>> +    <upgrades id="http://fedoraproject.org/fedora/24"/>
>> +    <derives-from id="http://fedoraproject.org/fedora/24"/>
>> +
>> +    <release-date>2016-11-22</release-date>
>> +
>> +    <variant id="workstation">
>> +      <_name>Fedora 25 Workstation</_name>
>> +    </variant>
>> +    <variant id="workstation-netinst">
>> +      <_name>Fedora 25 Workstation</_name>
>> +    </variant>
>> +    <variant id="server">
>> +      <_name>Fedora 25 Server</_name>
>> +    </variant>
>> +    <variant id="server-netinst">
>> +      <_name>Fedora 25 Server</_name>
>> +    </variant>
>> +
>> +    <!-- Workstation -->
>> +
>> +    <!-- Live -->
>> +    <media arch="i686" live="true">
>> +      <variant id="workstation"/>
>> +      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/i386/iso/Fedora-Workstation-Live-i386-25-1.3.iso</url>
>> +      <iso>
>> +        <volume-id>Fedora-WS-Live-25.*</volume-id>
>> +        <system-id>LINUX</system-id>
>> +      </iso>
>> +      <kernel>isolinux/vmlinuz0</kernel>
>> +      <initrd>isolinux/initrd0.img</initrd>
>> +    </media>
>> +    <media arch="x86_64" live="true">
>> +      <variant id="workstation"/>
>> +      <url>https://download.fedoraproject.org/pub/fedora/linux/releases/25/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-25-1.3.iso</url>
>> +      <iso>
>> +        <volume-id>Fedora-WS-Live-25.*</volume-id>
>> +        <system-id>LINUX</system-id>
>> +      </iso>
>> +      <kernel>isolinux/vmlinuz0</kernel>
>> +      <initrd>isolinux/initrd0.img</initrd>
>> +    </media>
>
> Here the '0' are not correct.
>
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
>
> Christophe
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>

Fixed and pushed (d18b8ab)!
-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Thu Jan 12 11:59:09 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 12 Jan 2017 12:59:09 +0100
Subject: [Libosinfo] [libosinfo] fedora: Add F25 data
In-Reply-To: <20170109092739.fkaa64el4dh4gdbg@edamame.cdg.redhat.com>
References: <20170106223149.28604-1-fidencio@redhat.com>
	<20170106223149.28604-2-fidencio@redhat.com>
	<20170109092739.fkaa64el4dh4gdbg@edamame.cdg.redhat.com>
Message-ID: <CAK9pz9+GVH+H=40Sfa0nL4ky5y+_NQirLL98mr2Nb0aogkCO0g@mail.gmail.com>

On Mon, Jan 9, 2017 at 10:27 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
>
> On Fri, Jan 06, 2017 at 11:31:49PM +0100, Fabiano Fid?ncio wrote:
>> Signed-off-by: Fabiano Fid?ncio <fabianoo at fidencio.org>
>> ---
>>  .../fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt | 29 ++++++++++++++++++++++
>>  .../Fedora-Server-dvd-x86_64-25-1.3.iso.txt        | 29 ++++++++++++++++++++++
>>  .../Fedora-Server-netinst-i386-25-1.3.iso.txt      | 29 ++++++++++++++++++++++
>>  .../Fedora-Server-netinst-x86_64-25-1.3.iso.txt    | 29 ++++++++++++++++++++++
>>  .../Fedora-Workstation-Live-i386-25-1.3.iso.txt    | 29 ++++++++++++++++++++++
>>  .../Fedora-Workstation-Live-x86_64-25-1.3.iso.txt  | 29 ++++++++++++++++++++++
>>  .../Fedora-Workstation-netinst-i386-25-1.3.iso.txt | 29 ++++++++++++++++++++++
>>  ...edora-Workstation-netinst-x86_64-25-1.3.iso.txt | 29 ++++++++++++++++++++++
>>  8 files changed, 232 insertions(+)
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
>>  create mode 100644 test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
>>
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..02c379a
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Server-dvd-i386-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-S-dvd-i386-25
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 1031760
>> +El Torito VD version 1 found, boot catalog is in sector 414
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 3A56B 238955
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..653ea46
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Server-dvd-x86_64-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-S-dvd-x86_64-25
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 985545
>> +El Torito VD version 1 found, boot catalog is in sector 399
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 3C7A8 247720
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..bcfee23
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Server-netinst-i386-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-S-dvd-i386-25
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 239011
>> +El Torito VD version 1 found, boot catalog is in sector 38
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 3A3ED 238573
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..264e73e
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Server-netinst-x86_64-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-S-dvd-x86_64-25
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 247797
>> +El Torito VD version 1 found, boot catalog is in sector 44
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 3BCDB 244955
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..e160a82
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-i386-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-WS-Live-25-1-3
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 746938
>> +El Torito VD version 1 found, boot catalog is in sector 40
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 4A00 18944
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..3325283
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-Live-x86_64-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-WS-Live-25-1-3
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 703180
>> +El Torito VD version 1 found, boot catalog is in sector 46
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 4B74 19316
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..1782a48
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-i386-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-WS-dvd-i386-25
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 265946
>> +El Torito VD version 1 found, boot catalog is in sector 38
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 40D24 265508
>> diff --git a/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
>> new file mode 100644
>> index 0000000..a010381
>> --- /dev/null
>> +++ b/test/isodata/fedora/fedora25/Fedora-Workstation-netinst-x86_64-25-1.3.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: Fedora-WS-dvd-x86_64-25
>> +Volume set id:
>> +Publisher id:
>> +Data preparer id:
>> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 237140
>> +El Torito VD version 1 found, boot catalog is in sector 44
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID ''
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 3933A 234298
>> --
>> 2.9.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>

Pushed (adb54e5)!

-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Thu Jan 12 12:03:10 2017
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Thu, 12 Jan 2017 13:03:10 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for F24
Message-ID: <20170112120310.12897-1-fabiano@fidencio.org>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/fedoraproject.org/fedora-24.xml.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/data/os/fedoraproject.org/fedora-24.xml.in b/data/os/fedoraproject.org/fedora-24.xml.in
index 1b7f461..e69cccc 100644
--- a/data/os/fedoraproject.org/fedora-24.xml.in
+++ b/data/os/fedoraproject.org/fedora-24.xml.in
@@ -40,8 +40,8 @@
         <volume-id>Fedora-WS-Live-24.*</volume-id>
         <system-id>LINUX</system-id>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
     <media arch="x86_64" live="true">
       <variant id="workstation"/>
@@ -50,8 +50,8 @@
         <volume-id>Fedora-WS-Live-24.*</volume-id>
         <system-id>LINUX</system-id>
       </iso>
-      <kernel>isolinux/vmlinuz0</kernel>
-      <initrd>isolinux/initrd0.img</initrd>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
     </media>
 
     <!-- Network Installer !-->
-- 
2.9.3



From fabiano at fidencio.org  Thu Jan 12 12:04:18 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 12 Jan 2017 13:04:18 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for
	Workstation
In-Reply-To: <CAAY6XsfMwBVVswbQyRF+NMreq9mrWL0MLMf9U9kBfYB2VqLjBg@mail.gmail.com>
References: <20170108155343.3410-1-fabiano@fidencio.org>
	<20170109091608.w5ypsntuhmht5u4o@edamame.cdg.redhat.com>
	<CAAY6XsdUZDsHSKOQeBU2X4D94Gz-5b3RqedMXUScn681RAGa8A@mail.gmail.com>
	<20170109100743.47e5mexvyddpnijh@edamame.cdg.redhat.com>
	<CAAY6XsfMwBVVswbQyRF+NMreq9mrWL0MLMf9U9kBfYB2VqLjBg@mail.gmail.com>
Message-ID: <CAK9pz9+k8t_nvTWHPSOFBYg_giLfGXeP1+=DEiqnnG=y0q-+dQ@mail.gmail.com>

On Mon, Jan 9, 2017 at 11:15 AM, Fabiano Fid?ncio <fidencio at redhat.com> wrote:
> On Mon, Jan 9, 2017 at 11:07 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> On Mon, Jan 09, 2017 at 11:01:01AM +0100, Fabiano Fid?ncio wrote:
>>> On Mon, Jan 9, 2017 at 10:16 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>>> > On Sun, Jan 08, 2017 at 04:53:43PM +0100, Fabiano Fid?ncio wrote:
>>> >> diff --git a/data/os/fedoraproject.org/fedora-23.xml.in b/data/os/fedoraproject.org/fedora-23.xml.in
>>> >> index b884722..24e0b4c 100644
>>> >> --- a/data/os/fedoraproject.org/fedora-23.xml.in
>>> >> +++ b/data/os/fedoraproject.org/fedora-23.xml.in
>>> >> @@ -49,8 +49,8 @@
>>> >>          <volume-id>Fedora-Live-WS-i686-23.*</volume-id>
>>> >>          <system-id>LINUX</system-id>
>>> >>        </iso>
>>> >> -      <kernel>isolinux/vmlinuz0</kernel>
>>> >> -      <initrd>isolinux/initrd0.img</initrd>
>>> >> +      <kernel>isolinux/vmlinuz</kernel>
>>> >> +      <initrd>isolinux/initrd.img</initrd>
>>> >>      </media>
>>> >>      <media arch="x86_64" live="true">
>>> >>        <variant id="workstation"/>
>>> >> @@ -59,8 +59,8 @@
>>> >>          <volume-id>Fedora-Live-WS-x86_64-23.*</volume-id>
>>> >>          <system-id>LINUX</system-id>
>>> >>        </iso>
>>> >> -      <kernel>isolinux/vmlinuz0</kernel>
>>> >> -      <initrd>isolinux/initrd0.img</initrd>
>>> >> +      <kernel>isolinux/vmlinuz</kernel>
>>> >> +      <initrd>isolinux/initrd.img</initrd>
>>> >>      </media>
>>> >>
>>> >
>>> > What is this patch based on?
>>> >
>>> > # sha256sum  Fedora-Live-Workstation-x86_64-23-10.iso
>>> > a91eca2492ac84909953ef27040f9b61d8525f7ec5e89f6430319f49f9f823fe Fedora-Live-Workstation-x86_64-23-10.iso
>>> >
>>> > (this matches
>>> > http://fedora.mirrors.ovh.net/linux/releases/23/Workstation/x86_64/iso/Fedora-Workstation-23-x86_64-CHECKSUM
>>> > )
>>> > # mount -o loop Fedora-Live-Workstation-x86_64-23-10.iso /media/
>>> > # ls -1 /media/isolinux/{initrd*,vmlinuz*}
>>> > /media/isolinux/initrd0.img
>>> > /media/isolinux/vmlinuz0
>>> >
>>> > The f21 ISO I have locally also uses initrd0/vmlinuz0.
>>>
>>> Ouch! I'll re-check then. I've checked with a few Fedora ISOs (24, 25
>>> ... and some older ISOs that I had handy at the moment).
>>
>> The f24/f25 images I have are using initrd/vmlinuz, I'd say the older
>> ones are using initrd0/vmlinuz0? (but I did not make an extensive check).
>
> I'll do the extensive check and submit a v2.
> Thanks for the review and for checking it, Christophe.
>
>>
>> Christophe

You're right. I submitted a new patch just changing the path of
vmlinuz/initrd for F24.

-- 
Fabiano Fid?ncio



From cfergeau at redhat.com  Thu Jan 12 13:35:32 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 12 Jan 2017 14:35:32 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for F24
In-Reply-To: <20170112120310.12897-1-fabiano@fidencio.org>
References: <20170112120310.12897-1-fabiano@fidencio.org>
Message-ID: <20170112133532.mwqdmp5xmdon7rl6@edamame.cdg.redhat.com>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Feel free to mention in the commit log that this used to end in 0 with
older ISOs, but that starting with f24, this changed.

Christophe

On Thu, Jan 12, 2017 at 01:03:10PM +0100, Fabiano Fid?ncio wrote:
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/os/fedoraproject.org/fedora-24.xml.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/data/os/fedoraproject.org/fedora-24.xml.in b/data/os/fedoraproject.org/fedora-24.xml.in
> index 1b7f461..e69cccc 100644
> --- a/data/os/fedoraproject.org/fedora-24.xml.in
> +++ b/data/os/fedoraproject.org/fedora-24.xml.in
> @@ -40,8 +40,8 @@
>          <volume-id>Fedora-WS-Live-24.*</volume-id>
>          <system-id>LINUX</system-id>
>        </iso>
> -      <kernel>isolinux/vmlinuz0</kernel>
> -      <initrd>isolinux/initrd0.img</initrd>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
>      </media>
>      <media arch="x86_64" live="true">
>        <variant id="workstation"/>
> @@ -50,8 +50,8 @@
>          <volume-id>Fedora-WS-Live-24.*</volume-id>
>          <system-id>LINUX</system-id>
>        </iso>
> -      <kernel>isolinux/vmlinuz0</kernel>
> -      <initrd>isolinux/initrd0.img</initrd>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
>      </media>
>  
>      <!-- Network Installer !-->
> -- 
> 2.9.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170112/3347eef2/attachment.sig>

From fabiano at fidencio.org  Sat Jan 14 10:12:18 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Sat, 14 Jan 2017 11:12:18 +0100
Subject: [Libosinfo] [osinfo-db] fedora: Fix initrd/vmlinuz path for F24
In-Reply-To: <20170112133532.mwqdmp5xmdon7rl6@edamame.cdg.redhat.com>
References: <20170112120310.12897-1-fabiano@fidencio.org>
	<20170112133532.mwqdmp5xmdon7rl6@edamame.cdg.redhat.com>
Message-ID: <CAK9pz9JqnZ=VQjnSH-PnLVU65MfNrL2oYEsXehoUk7xF2Wa4HQ@mail.gmail.com>

On Thu, Jan 12, 2017 at 2:35 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
>
> Feel free to mention in the commit log that this used to end in 0 with
> older ISOs, but that starting with f24, this changed.

Followed your suggestion.
Patch pushed: 46dc110

>
> Christophe
>
> On Thu, Jan 12, 2017 at 01:03:10PM +0100, Fabiano Fid?ncio wrote:
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  data/os/fedoraproject.org/fedora-24.xml.in | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/data/os/fedoraproject.org/fedora-24.xml.in b/data/os/fedoraproject.org/fedora-24.xml.in
>> index 1b7f461..e69cccc 100644
>> --- a/data/os/fedoraproject.org/fedora-24.xml.in
>> +++ b/data/os/fedoraproject.org/fedora-24.xml.in
>> @@ -40,8 +40,8 @@
>>          <volume-id>Fedora-WS-Live-24.*</volume-id>
>>          <system-id>LINUX</system-id>
>>        </iso>
>> -      <kernel>isolinux/vmlinuz0</kernel>
>> -      <initrd>isolinux/initrd0.img</initrd>
>> +      <kernel>isolinux/vmlinuz</kernel>
>> +      <initrd>isolinux/initrd.img</initrd>
>>      </media>
>>      <media arch="x86_64" live="true">
>>        <variant id="workstation"/>
>> @@ -50,8 +50,8 @@
>>          <volume-id>Fedora-WS-Live-24.*</volume-id>
>>          <system-id>LINUX</system-id>
>>        </iso>
>> -      <kernel>isolinux/vmlinuz0</kernel>
>> -      <initrd>isolinux/initrd0.img</initrd>
>> +      <kernel>isolinux/vmlinuz</kernel>
>> +      <initrd>isolinux/initrd.img</initrd>
>>      </media>
>>
>>      <!-- Network Installer !-->
>> --
>> 2.9.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fid?ncio



From mprivozn at redhat.com  Mon Jan 16 08:06:49 2017
From: mprivozn at redhat.com (Michal Privoznik)
Date: Mon, 16 Jan 2017 09:06:49 +0100
Subject: [Libosinfo] [PATCH 0/2] Two trivial fixes
Message-ID: <cover.1484553870.git.mprivozn@redhat.com>

BTW: the test-isodetect test is still failing for me (surprisingly).

Michal Privoznik (2):
  docs: Fix couple of warnings
  gitignore: Ignore tags

 .gitignore                      | 1 +
 osinfo/osinfo_install_script.c  | 2 ++
 osinfo/osinfo_install_script.h  | 4 ----
 osinfo/osinfo_product_private.h | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

-- 
2.11.0



From mprivozn at redhat.com  Mon Jan 16 08:06:50 2017
From: mprivozn at redhat.com (Michal Privoznik)
Date: Mon, 16 Jan 2017 09:06:50 +0100
Subject: [Libosinfo] [PATCH 1/2] docs: Fix couple of warnings
In-Reply-To: <cover.1484553870.git.mprivozn@redhat.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
Message-ID: <8c1487771c22e9abb361338bbd36e5e2df00e52a.1484553870.git.mprivozn@redhat.com>

Firstly, two functions
(osinfo_install_script_has_config_param_{name,list}) don't
document their arguments.  Secondly, gtk-doc requires enum
documentation to be in one block with no empty lines in it.
Then at last, private enums are marked as <private> not <skip>.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 osinfo/osinfo_install_script.c  | 2 ++
 osinfo/osinfo_install_script.h  | 4 ----
 osinfo/osinfo_product_private.h | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
index 9206101..8fcde0f 100644
--- a/osinfo/osinfo_install_script.c
+++ b/osinfo/osinfo_install_script.c
@@ -283,6 +283,7 @@ gboolean osinfo_install_script_has_config_param_name(const OsinfoInstallScript *
 
 /**
  * osinfo_install_script_get_config_param_list:
+ * @script: the install script
  *
  * Get the list of valid config parameters for @script.
  *
@@ -297,6 +298,7 @@ GList *osinfo_install_script_get_config_param_list(const OsinfoInstallScript *sc
 
 /**
  * osinfo_install_script_get_config_params:
+ * @script: the install script
  *
  * Get the list of valid config parameters for @script.
  *
diff --git a/osinfo/osinfo_install_script.h b/osinfo/osinfo_install_script.h
index c494192..61bf0e4 100644
--- a/osinfo/osinfo_install_script.h
+++ b/osinfo/osinfo_install_script.h
@@ -93,17 +93,14 @@ typedef enum {
 
 /**
  * OsinfoDeviceDriverSigningReq:
- *
  * @OSINFO_DEVICE_DRIVER_SIGNING_REQ_NONE: Script do not require device drivers
  * to be signed.
- *
  * @OSINFO_DEVICE_DRIVER_SIGNING_REQ_STRICT: Script must only be given signed
  * device drivers. Some scripts will allow overriding this requirement through
  * #osinfo_install_config_set_driver_signing function. You can query if a
  * script supports this by checking if
  * #OSINFO_INSTALL_CONFIG_PROP_DRIVER_SIGNING configuration parameter is used
  * by the script in question (or other scripts in the same profile).
- *
  * @OSINFO_DEVICE_DRIVER_SIGNING_REQ_WARN: A warning will be issued by OS
  * installer if device drivers are not signed and most probably require user
  * input (and thus breaking unattended installation). See
@@ -118,7 +115,6 @@ typedef enum {
 
 /**
  * OsinfoInstallScriptInjectionMethod:
- *
  * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_CDROM: Support injection of the
  * installation script trough a CD-ROM.
  * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_DISK: Support injection of the
diff --git a/osinfo/osinfo_product_private.h b/osinfo/osinfo_product_private.h
index c4ecdd5..49cf0a2 100644
--- a/osinfo/osinfo_product_private.h
+++ b/osinfo/osinfo_product_private.h
@@ -29,7 +29,7 @@
 
 typedef void (*OsinfoProductForeach)(OsinfoProduct *product, gpointer user_data);
 
-typedef enum { /*< skip >*/
+typedef enum { /*< private >*/
     OSINFO_PRODUCT_FOREACH_FLAG_DERIVES_FROM = 1 << 0,
     OSINFO_PRODUCT_FOREACH_FLAG_UPGRADES = 1 << 1,
     OSINFO_PRODUCT_FOREACH_FLAG_CLONES = 1 << 2,
-- 
2.11.0



From mprivozn at redhat.com  Mon Jan 16 08:06:51 2017
From: mprivozn at redhat.com (Michal Privoznik)
Date: Mon, 16 Jan 2017 09:06:51 +0100
Subject: [Libosinfo] [PATCH 2/2] gitignore: Ignore tags
In-Reply-To: <cover.1484553870.git.mprivozn@redhat.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
Message-ID: <34a2dd8b634b0d4aad16d4829ffa43c280790e52.1484553870.git.mprivozn@redhat.com>

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 1cc9e2f..1dee69e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -32,6 +32,7 @@ intltool-update.in
 libtool
 m4
 stamp-h1
+tags
 test/test-skeleton
 test/test-skeleton.sh
 osinfo/libosinfo.pc
-- 
2.11.0



From cfergeau at redhat.com  Mon Jan 16 08:45:44 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 16 Jan 2017 09:45:44 +0100
Subject: [Libosinfo] [PATCH 1/2] docs: Fix couple of warnings
In-Reply-To: <8c1487771c22e9abb361338bbd36e5e2df00e52a.1484553870.git.mprivozn@redhat.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
	<8c1487771c22e9abb361338bbd36e5e2df00e52a.1484553870.git.mprivozn@redhat.com>
Message-ID: <20170116084544.edl3jlcgslkyipeb@edamame.cdg.redhat.com>

On Mon, Jan 16, 2017 at 09:06:50AM +0100, Michal Privoznik wrote:
> Firstly, two functions
> (osinfo_install_script_has_config_param_{name,list}) don't
> document their arguments.  Secondly, gtk-doc requires enum
> documentation to be in one block with no empty lines in it.
> Then at last, private enums are marked as <private> not <skip>.

Looks good to me.. 
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  osinfo/osinfo_install_script.c  | 2 ++
>  osinfo/osinfo_install_script.h  | 4 ----
>  osinfo/osinfo_product_private.h | 2 +-
>  3 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
> index 9206101..8fcde0f 100644
> --- a/osinfo/osinfo_install_script.c
> +++ b/osinfo/osinfo_install_script.c
> @@ -283,6 +283,7 @@ gboolean osinfo_install_script_has_config_param_name(const OsinfoInstallScript *
>  
>  /**
>   * osinfo_install_script_get_config_param_list:
> + * @script: the install script
>   *
>   * Get the list of valid config parameters for @script.
>   *
> @@ -297,6 +298,7 @@ GList *osinfo_install_script_get_config_param_list(const OsinfoInstallScript *sc
>  
>  /**
>   * osinfo_install_script_get_config_params:
> + * @script: the install script
>   *
>   * Get the list of valid config parameters for @script.
>   *
> diff --git a/osinfo/osinfo_install_script.h b/osinfo/osinfo_install_script.h
> index c494192..61bf0e4 100644
> --- a/osinfo/osinfo_install_script.h
> +++ b/osinfo/osinfo_install_script.h
> @@ -93,17 +93,14 @@ typedef enum {
>  
>  /**
>   * OsinfoDeviceDriverSigningReq:
> - *
>   * @OSINFO_DEVICE_DRIVER_SIGNING_REQ_NONE: Script do not require device drivers
>   * to be signed.
> - *
>   * @OSINFO_DEVICE_DRIVER_SIGNING_REQ_STRICT: Script must only be given signed
>   * device drivers. Some scripts will allow overriding this requirement through
>   * #osinfo_install_config_set_driver_signing function. You can query if a
>   * script supports this by checking if
>   * #OSINFO_INSTALL_CONFIG_PROP_DRIVER_SIGNING configuration parameter is used
>   * by the script in question (or other scripts in the same profile).
> - *
>   * @OSINFO_DEVICE_DRIVER_SIGNING_REQ_WARN: A warning will be issued by OS
>   * installer if device drivers are not signed and most probably require user
>   * input (and thus breaking unattended installation). See
> @@ -118,7 +115,6 @@ typedef enum {
>  
>  /**
>   * OsinfoInstallScriptInjectionMethod:
> - *
>   * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_CDROM: Support injection of the
>   * installation script trough a CD-ROM.
>   * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_DISK: Support injection of the
> diff --git a/osinfo/osinfo_product_private.h b/osinfo/osinfo_product_private.h
> index c4ecdd5..49cf0a2 100644
> --- a/osinfo/osinfo_product_private.h
> +++ b/osinfo/osinfo_product_private.h
> @@ -29,7 +29,7 @@
>  
>  typedef void (*OsinfoProductForeach)(OsinfoProduct *product, gpointer user_data);
>  
> -typedef enum { /*< skip >*/
> +typedef enum { /*< private >*/
>      OSINFO_PRODUCT_FOREACH_FLAG_DERIVES_FROM = 1 << 0,
>      OSINFO_PRODUCT_FOREACH_FLAG_UPGRADES = 1 << 1,
>      OSINFO_PRODUCT_FOREACH_FLAG_CLONES = 1 << 2,
> -- 
> 2.11.0
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170116/9d67885b/attachment.sig>

From cfergeau at redhat.com  Mon Jan 16 08:46:12 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 16 Jan 2017 09:46:12 +0100
Subject: [Libosinfo] [PATCH 0/2] Two trivial fixes
In-Reply-To: <cover.1484553870.git.mprivozn@redhat.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
Message-ID: <20170116084612.7rxz2jiciohe7ybn@edamame.cdg.redhat.com>

On Mon, Jan 16, 2017 at 09:06:49AM +0100, Michal Privoznik wrote:
> BTW: the test-isodetect test is still failing for me (surprisingly).

What is the failure? Could it be caused by an outdated osinfo-db?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170116/3aaabdba/attachment.sig>

From cfergeau at redhat.com  Mon Jan 16 08:45:02 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 16 Jan 2017 09:45:02 +0100
Subject: [Libosinfo] [PATCH 2/2] gitignore: Ignore tags
In-Reply-To: <34a2dd8b634b0d4aad16d4829ffa43c280790e52.1484553870.git.mprivozn@redhat.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
	<34a2dd8b634b0d4aad16d4829ffa43c280790e52.1484553870.git.mprivozn@redhat.com>
Message-ID: <20170116084502.ruen7nqgv24ud3oc@edamame.cdg.redhat.com>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Mon, Jan 16, 2017 at 09:06:51AM +0100, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 1cc9e2f..1dee69e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -32,6 +32,7 @@ intltool-update.in
>  libtool
>  m4
>  stamp-h1
> +tags
>  test/test-skeleton
>  test/test-skeleton.sh
>  osinfo/libosinfo.pc
> -- 
> 2.11.0
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170116/71304bb4/attachment.sig>

From fabiano at fidencio.org  Mon Jan 16 09:52:01 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Mon, 16 Jan 2017 10:52:01 +0100
Subject: [Libosinfo] [PATCH 0/2] Two trivial fixes
In-Reply-To: <20170116084612.7rxz2jiciohe7ybn@edamame.cdg.redhat.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
	<20170116084612.7rxz2jiciohe7ybn@edamame.cdg.redhat.com>
Message-ID: <CAK9pz9+tLXEzYZQq30iUG5ACg9LRJA1YwOBdQm1odUeWgsCC=Q@mail.gmail.com>

On Mon, Jan 16, 2017 at 9:46 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, Jan 16, 2017 at 09:06:49AM +0100, Michal Privoznik wrote:
>> BTW: the test-isodetect test is still failing for me (surprisingly).
>
> What is the failure? Could it be caused by an outdated osinfo-db?

Hmm. Fails here as well and I have the latest osinfo-db installed.

[ffidenci at cat libosinfo]$ cat test/test-isodetect.log
Running suite(s): List
0%: Checks: 14, Failures: 14, Errors: 0
test-isodetect.c:354:F:Core:test_fedora:0: ISO
yarrow-i386-disc1.iso.txt was not matched by OS fedora1
test-isodetect.c:354:F:Core:test_rhel:0: ISO
rhel-server-5.10-i386-dvd.iso.txt was not matched by OS rhel5.10
test-isodetect.c:354:F:Core:test_ubuntu:0: ISO
ubuntu-12.04-alternate-amd64.iso.txt was not matched by OS ubuntu12.04
test-isodetect.c:354:F:Core:test_debian:0: ISO
debian-6.0.4-i386-CD-1.iso.txt was not matched by OS debian6
test-isodetect.c:354:F:Core:test_windows:0: ISO
en_windows_server_2012_r2_x64_dvd_2707946.iso.txt was not matched by
OS win2k12r2
test-isodetect.c:354:F:Core:test_freebsd:0: ISO
FreeBSD-10.3-RELEASE-amd64-dvd1.iso.txt was not matched by OS
freebsd10.3
test-isodetect.c:354:F:Core:test_openbsd:0: ISO openbsd-4.2-amd64.txt
was not matched by OS openbsd4.2
test-isodetect.c:354:F:Core:test_opensuse:0: ISO
openSUSE-42.1-DVD-x86_64.iso.txt was not matched by OS opensuse42.1
test-isodetect.c:354:F:Core:test_centos:0: ISO
CentOS-6.2-i386-bin-DVD1.iso.txt was not matched by OS centos6.2
test-isodetect.c:354:F:Core:test_gnome:0: ISO GNOME-3.7.92.iso.txt was
not matched by OS gnome3.8
test-isodetect.c:354:F:Core:test_altlinux:0: ISO
altlinux-4.0.0-terminal-i586-en-cd.iso.txt was not matched by OS
altlinux4.0
test-isodetect.c:354:F:Core:test_mageia:0: ISO mageia-dual-1.iso.txt
was not matched by OS mageia1
test-isodetect.c:354:F:Core:test_sles:0: ISO
SLES-11-SP1-DVD-i586-GM-DVD1.iso.txt was not matched by OS sles11sp1
test-isodetect.c:354:F:Core:test_sled:0: ISO
SLED-11-SP2-DVD-i586-GM-DVD1.iso.txt was not matched by OS sled11sp2
FAIL test-isodetect (exit status: 1)


-- 
Fabiano Fid?ncio



From berrange at redhat.com  Mon Jan 16 10:08:54 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Mon, 16 Jan 2017 10:08:54 +0000
Subject: [Libosinfo] [PATCH 0/2] Two trivial fixes
In-Reply-To: <CAK9pz9+tLXEzYZQq30iUG5ACg9LRJA1YwOBdQm1odUeWgsCC=Q@mail.gmail.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
	<20170116084612.7rxz2jiciohe7ybn@edamame.cdg.redhat.com>
	<CAK9pz9+tLXEzYZQq30iUG5ACg9LRJA1YwOBdQm1odUeWgsCC=Q@mail.gmail.com>
Message-ID: <20170116100854.GE13096@redhat.com>

On Mon, Jan 16, 2017 at 10:52:01AM +0100, Fabiano Fid?ncio wrote:
> On Mon, Jan 16, 2017 at 9:46 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Mon, Jan 16, 2017 at 09:06:49AM +0100, Michal Privoznik wrote:
> >> BTW: the test-isodetect test is still failing for me (surprisingly).
> >
> > What is the failure? Could it be caused by an outdated osinfo-db?
> 
> Hmm. Fails here as well and I have the latest osinfo-db installed.

Those errors rather suggest you have old data installed somewhere
that is being found. Perhaps in $HOME or /etc/ - it definitely
isn't finding the new osinfo-db data


There *is* a single genuine failure in the test, however, that was caused
when the patches to add F25 were added last week, caused by incorrect
volume size data AFAICT

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|



From berrange at redhat.com  Mon Jan 16 10:11:02 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Mon, 16 Jan 2017 10:11:02 +0000
Subject: [Libosinfo] [PATCH] Fix volume sizes in F25 server media
Message-ID: <20170116101102.19956-1-berrange@redhat.com>

The volume size recorded neds to be the result of volume-size
multiplied by block size, from the ISO media, not the size of
the actual ISO file itself.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 data/os/fedoraproject.org/fedora-25.xml.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/data/os/fedoraproject.org/fedora-25.xml.in b/data/os/fedoraproject.org/fedora-25.xml.in
index 012aa1e..e42a106 100644
--- a/data/os/fedoraproject.org/fedora-25.xml.in
+++ b/data/os/fedoraproject.org/fedora-25.xml.in
@@ -85,7 +85,7 @@
 
              https://fedorahosted.org/rel-eng/ticket/6173
         -->
-        <volume-size>2113929216</volume-size>
+	<volume-size>2113044480</volume-size>
       </iso>
       <kernel>isolinux/vmlinuz</kernel>
       <initrd>isolinux/initrd.img</initrd>
@@ -96,7 +96,7 @@
       <iso>
         <volume-id>Fedora-S-dvd-x86_64-25</volume-id>
         <system-id>LINUX</system-id>
-        <volume-size>2018508800</volume-size>
+        <volume-size>2018396160</volume-size>
       </iso>
       <kernel>isolinux/vmlinuz</kernel>
       <initrd>isolinux/initrd.img</initrd>
@@ -109,7 +109,7 @@
       <iso>
         <volume-id>Fedora-S-dvd-i386-25</volume-id>
         <system-id>LINUX</system-id>
-        <volume-size>489684992</volume-size>
+        <volume-size>489494528</volume-size>
       </iso>
       <kernel>isolinux/vmlinuz</kernel>
       <initrd>isolinux/initrd.img</initrd>
@@ -120,7 +120,7 @@
       <iso>
         <volume-id>Fedora-S-dvd-x86_64-25</volume-id>
         <system-id>LINUX</system-id>
-        <volume-size>507510784</volume-size>
+        <volume-size>507488256</volume-size>
       </iso>
       <kernel>isolinux/vmlinuz</kernel>
       <initrd>isolinux/initrd.img</initrd>
-- 
2.9.3



From fabiano at fidencio.org  Mon Jan 16 10:19:54 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Mon, 16 Jan 2017 11:19:54 +0100
Subject: [Libosinfo] [PATCH] Fix volume sizes in F25 server media
In-Reply-To: <20170116101102.19956-1-berrange@redhat.com>
References: <20170116101102.19956-1-berrange@redhat.com>
Message-ID: <CAK9pz9+3ywn+=qrWihdLNj5w4pPTBP2v2=S6ChXOU-cDXox2XA@mail.gmail.com>

On Mon, Jan 16, 2017 at 11:11 AM, Daniel P. Berrange
<berrange at redhat.com> wrote:
> The volume size recorded neds to be the result of volume-size
> multiplied by block size, from the ISO media, not the size of
> the actual ISO file itself.

Oh, my bad. I wasn't aware of that.
Surprisingly that's the only ISO breaking the tests.

>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  data/os/fedoraproject.org/fedora-25.xml.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/data/os/fedoraproject.org/fedora-25.xml.in b/data/os/fedoraproject.org/fedora-25.xml.in
> index 012aa1e..e42a106 100644
> --- a/data/os/fedoraproject.org/fedora-25.xml.in
> +++ b/data/os/fedoraproject.org/fedora-25.xml.in
> @@ -85,7 +85,7 @@
>
>               https://fedorahosted.org/rel-eng/ticket/6173
>          -->
> -        <volume-size>2113929216</volume-size>
> +       <volume-size>2113044480</volume-size>
>        </iso>
>        <kernel>isolinux/vmlinuz</kernel>
>        <initrd>isolinux/initrd.img</initrd>
> @@ -96,7 +96,7 @@
>        <iso>
>          <volume-id>Fedora-S-dvd-x86_64-25</volume-id>
>          <system-id>LINUX</system-id>
> -        <volume-size>2018508800</volume-size>
> +        <volume-size>2018396160</volume-size>
>        </iso>
>        <kernel>isolinux/vmlinuz</kernel>
>        <initrd>isolinux/initrd.img</initrd>
> @@ -109,7 +109,7 @@
>        <iso>
>          <volume-id>Fedora-S-dvd-i386-25</volume-id>
>          <system-id>LINUX</system-id>
> -        <volume-size>489684992</volume-size>
> +        <volume-size>489494528</volume-size>
>        </iso>
>        <kernel>isolinux/vmlinuz</kernel>
>        <initrd>isolinux/initrd.img</initrd>
> @@ -120,7 +120,7 @@
>        <iso>
>          <volume-id>Fedora-S-dvd-x86_64-25</volume-id>
>          <system-id>LINUX</system-id>
> -        <volume-size>507510784</volume-size>
> +        <volume-size>507488256</volume-size>
>        </iso>
>        <kernel>isolinux/vmlinuz</kernel>
>        <initrd>isolinux/initrd.img</initrd>
> --
> 2.9.3
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo


Acked-by: Fabiano Fid?ncio <fabiano at fidencio.org>

-- 
Fabiano Fid?ncio



From rishi.is at lostca.se  Mon Jan 16 16:28:52 2017
From: rishi.is at lostca.se (Debarshi Ray)
Date: Mon, 16 Jan 2017 16:28:52 +0000
Subject: [Libosinfo] [osinfo-db] rhel: Add support to registering to the
 subscription-manager
In-Reply-To: <20170111232631.31903-1-fabiano@fidencio.org>
References: <20170111232631.31903-1-fabiano@fidencio.org>
Message-ID: <20170116162852.GB71679@aloka.lostca.se>

Hey,

On Thu, Jan 12, 2017 at 12:26:31AM +0100, Fabiano Fid??ncio wrote:
> diff --git a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
> index 1b917ee..946f84f 100644
> --- a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
> +++ b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
> @@ -16,6 +16,8 @@
>          <param name="avatar-disk" policy="optional"/>
>          <param name="target-disk" policy="optional"/>
>          <param name="script-disk" policy="required"/>
> +        <param name="reg-login" policy="optional"/>
> +        <param name="reg-password" policy="optional"/>
>      </config>
>      <injection-method>cdrom</injection-method>
>      <injection-method>disk</injection-method>
> @@ -152,6 +154,10 @@ AutomaticLogin=<xsl:value-of select="config/user-login"/>
>  [debug]
>  " > /etc/gdm/custom.conf
>  
> +if [ -n <xsl:value-of select="config/reg-login"/> -a -n <xsl:value-of select="config/reg-password"/> ]; then

We need to enclose the strings in quotes because [ -n -a -n ] will
evaluate to TRUE. Try these:
  $ if [ -n ]; then echo foo; fi
  foo
  $ if [ -n "" ]; then echo foo; fi
  $

Cheers,
Rishi



From rishi.is at lostca.se  Mon Jan 16 16:57:04 2017
From: rishi.is at lostca.se (Debarshi Ray)
Date: Mon, 16 Jan 2017 16:57:04 +0000
Subject: [Libosinfo] [osinfo-db] rhel: Add support to registering to the
 subscription-manager
In-Reply-To: <20170116162852.GB71679@aloka.lostca.se>
References: <20170111232631.31903-1-fabiano@fidencio.org>
	<20170116162852.GB71679@aloka.lostca.se>
Message-ID: <20170116165703.GC71679@aloka.lostca.se>

On Mon, Jan 16, 2017 at 04:28:52PM +0000, Debarshi Ray wrote:
> On Thu, Jan 12, 2017 at 12:26:31AM +0100, Fabiano Fid??ncio wrote:
> > +if [ -n <xsl:value-of select="config/reg-login"/> -a -n <xsl:value-of select="config/reg-password"/> ]; then
> 
> We need to enclose the strings in quotes because [ -n -a -n ] will
> evaluate to TRUE. Try these:
>   $ if [ -n ]; then echo foo; fi
>   foo
>   $ if [ -n "" ]; then echo foo; fi
>   $

For reference:
http://tldp.org/LDP/abs/html/comparison-ops.html



From fabiano at fidencio.org  Mon Jan 16 18:29:32 2017
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Mon, 16 Jan 2017 19:29:32 +0100
Subject: [Libosinfo] [osinfo-db v2] rhel: Add support to registering to the
	subscription-manager
Message-ID: <20170116182932.15400-1-fabiano@fidencio.org>

From: Fabiano Fid?ncio <fidencio at redhat.com>

In case reg-login and reg-password are non-null, perform the
subscription during the %post phase of the kickstart file.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/install-script/redhat.com/rhel-kickstart-desktop.xml.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
index 1b917ee..336c746 100644
--- a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
+++ b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
@@ -16,6 +16,8 @@
         <param name="avatar-disk" policy="optional"/>
         <param name="target-disk" policy="optional"/>
         <param name="script-disk" policy="required"/>
+        <param name="reg-login" policy="optional"/>
+        <param name="reg-password" policy="optional"/>
     </config>
     <injection-method>cdrom</injection-method>
     <injection-method>disk</injection-method>
@@ -152,6 +154,10 @@ AutomaticLogin=<xsl:value-of select="config/user-login"/>
 [debug]
 " > /etc/gdm/custom.conf
 
+if [ -n "<xsl:value-of select="config/reg-login"/>" -a -n "<xsl:value-of select="config/reg-password"/>" ]; then
+    subscription-manager register --username <xsl:value-of select="config/reg-login"/> --password <xsl:value-of select="config/reg-password"/> --auto-attach
+fi
+
 %end
 	</xsl:template>
       </xsl:stylesheet>
-- 
2.9.3



From fabiano at fidencio.org  Mon Jan 16 18:29:55 2017
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Mon, 16 Jan 2017 19:29:55 +0100
Subject: [Libosinfo] [osinfo-db 1/2] rhel: enclose strings used for shell
	ifs in quotes
Message-ID: <20170116182956.15510-1-fabiano@fidencio.org>

It's necessary when doing if test -n <xsl:value-of ...> as `if test -n `
will simply return true.

For those `if test -z ` it's not strictly necessary, but doesn't hurt
having it there.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/install-script/redhat.com/rhel-kickstart-desktop.xml.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
index 336c746..e14a67b 100644
--- a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
+++ b/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
@@ -118,20 +118,20 @@ qemu-guest-agent
 %post --erroronfail
 
 useradd -G wheel <xsl:value-of select="config/user-login"/> # Add user
-if test -z <xsl:value-of select="config/user-password"/>; then
+if test -z "<xsl:value-of select="config/user-password"/>"; then
     passwd -d <xsl:value-of select="config/user-login"/> # Make user account passwordless
 else
     echo <xsl:value-of select="config/user-password"/> |passwd --stdin <xsl:value-of select="config/user-login"/>
 fi
 
-if test -z <xsl:value-of select="config/admin-password"/>; then
+if test -z "<xsl:value-of select="config/admin-password"/>"; then
     passwd -d root # Make root account passwordless
 else
     echo <xsl:value-of select="config/admin-password"/> |passwd --stdin root
 fi
 
 # Set user avatar
-if test -n <xsl:value-of select="config/avatar-location"/>; then
+if test -n "<xsl:value-of select="config/avatar-location"/>"; then
 mkdir /mnt/unattended-media
 mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
 cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /home/<xsl:value-of select="config/user-login"/>/.face
-- 
2.9.3



From fabiano at fidencio.org  Mon Jan 16 18:29:56 2017
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Mon, 16 Jan 2017 19:29:56 +0100
Subject: [Libosinfo] [osinfo-db 2/2] fedora: enclose strings used for shell
	ifs in quotes
In-Reply-To: <20170116182956.15510-1-fabiano@fidencio.org>
References: <20170116182956.15510-1-fabiano@fidencio.org>
Message-ID: <20170116182956.15510-2-fabiano@fidencio.org>

It's necessary when doing if test -n <xsl:value-of ...> as `if test -n `
will simply return true.

For those `if test -z ` it's not strictly necessary, but doesn't hurt
having it there.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 .../fedoraproject.org/fedora-kickstart-desktop.xml.in               | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
index 1fefebb..58f8d93 100644
--- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
+++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in
@@ -173,20 +173,20 @@ qemu-guest-agent
 %post --erroronfail
 
 useradd -G wheel <xsl:value-of select="config/user-login"/> # Add user
-if test -z <xsl:value-of select="config/user-password"/>; then
+if test -z "<xsl:value-of select="config/user-password"/>"; then
     passwd -d <xsl:value-of select="config/user-login"/> # Make user account passwordless
 else
     echo <xsl:value-of select="config/user-password"/> |passwd --stdin <xsl:value-of select="config/user-login"/>
 fi
 
-if test -z <xsl:value-of select="config/admin-password"/>; then
+if test -z "<xsl:value-of select="config/admin-password"/>"; then
     passwd -d root # Make root account passwordless
 else
     echo <xsl:value-of select="config/admin-password"/> |passwd --stdin root
 fi
 
 # Set user avatar
-if test -n <xsl:value-of select="config/avatar-location"/>; then
+if test -n "<xsl:value-of select="config/avatar-location"/>"; then
 mkdir /mnt/unattended-media
 mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
 cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /var/lib/AccountsService/icons/<xsl:value-of select="config/user-login"/>
-- 
2.9.3



From fabiano at fidencio.org  Mon Jan 16 18:55:01 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Mon, 16 Jan 2017 19:55:01 +0100
Subject: [Libosinfo] [osinfo-db] rhel: Add support to registering to the
	subscription-manager
In-Reply-To: <20170116165703.GC71679@aloka.lostca.se>
References: <20170111232631.31903-1-fabiano@fidencio.org>
	<20170116162852.GB71679@aloka.lostca.se>
	<20170116165703.GC71679@aloka.lostca.se>
Message-ID: <CAK9pz9KUX982_RHW2jOOrM3_FOULBagdoQcDz04fCsUqoXX_pw@mail.gmail.com>

On Mon, Jan 16, 2017 at 5:57 PM, Debarshi Ray <rishi.is at lostca.se> wrote:
> On Mon, Jan 16, 2017 at 04:28:52PM +0000, Debarshi Ray wrote:
>> On Thu, Jan 12, 2017 at 12:26:31AM +0100, Fabiano Fid??ncio wrote:
>> > +if [ -n <xsl:value-of select="config/reg-login"/> -a -n <xsl:value-of select="config/reg-password"/> ]; then
>>
>> We need to enclose the strings in quotes because [ -n -a -n ] will
>> evaluate to TRUE. Try these:
>>   $ if [ -n ]; then echo foo; fi
>>   foo
>>   $ if [ -n "" ]; then echo foo; fi
>>   $
>
> For reference:
> http://tldp.org/LDP/abs/html/comparison-ops.html

Thanks for the review.
I sent a v2 of this patch and fixed this very same issue in a few
other places (other 2 different patches).

-- 
Fabiano Fid?ncio



From rishi.is at lostca.se  Tue Jan 17 14:29:41 2017
From: rishi.is at lostca.se (Debarshi Ray)
Date: Tue, 17 Jan 2017 15:29:41 +0100
Subject: [Libosinfo] [PATCH] Marginally simplify the code to create and run
	a GMainLoop
Message-ID: <20170117142941.5412-1-rishi.is@lostca.se>

From: Debarshi Ray <debarshir at gnome.org>

Even though g_main_loop_new accepts a is_running parameter, it isn't
very important since g_main_loop_run will set it to TRUE anyway. There
is no requirement that it should be set before calling g_main_loop_run.
The vast majority of GMainLoop users simply ignore the is_running
parameter unless they are doing something out of the ordinary.
---
 osinfo/osinfo_install_script.c | 15 ++++++---------
 osinfo/osinfo_media.c          |  5 ++---
 osinfo/osinfo_tree.c           |  5 ++---
 test/test-install-script.c     | 15 ++++++---------
 4 files changed, 16 insertions(+), 24 deletions(-)

diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
index 92061012ba50..688c14a82e91 100644
--- a/osinfo/osinfo_install_script.c
+++ b/osinfo/osinfo_install_script.c
@@ -1169,7 +1169,7 @@ gchar *osinfo_install_script_generate(OsinfoInstallScript *script,
                                       GError **error)
 {
     GMainLoop *loop = g_main_loop_new(g_main_context_get_thread_default(),
-                                      TRUE);
+                                      FALSE);
     OsinfoInstallScriptGenerateSyncData data = {
         loop, NULL, NULL, NULL
     };
@@ -1181,8 +1181,7 @@ gchar *osinfo_install_script_generate(OsinfoInstallScript *script,
                                          osinfo_install_script_generate_done,
                                          &data);
 
-    if (g_main_loop_is_running(loop))
-        g_main_loop_run(loop);
+    g_main_loop_run(loop);
 
     if (data.error)
         g_propagate_error(error, data.error);
@@ -1265,7 +1264,7 @@ gchar *osinfo_install_script_generate_for_media(OsinfoInstallScript *script,
                                                 GError **error)
 {
     GMainLoop *loop = g_main_loop_new(g_main_context_get_thread_default(),
-                                      TRUE);
+                                      FALSE);
     OsinfoInstallScriptGenerateSyncData data = {
         loop, NULL, NULL, NULL
     };
@@ -1277,8 +1276,7 @@ gchar *osinfo_install_script_generate_for_media(OsinfoInstallScript *script,
                                                    osinfo_install_script_generate_for_media_done,
                                                    &data);
 
-    if (g_main_loop_is_running(loop))
-        g_main_loop_run(loop);
+    g_main_loop_run(loop);
 
     if (data.error)
         g_propagate_error(error, data.error);
@@ -1425,7 +1423,7 @@ static GFile *osinfo_install_script_generate_output_common(OsinfoInstallScript *
                                                            GError **error)
 {
     GMainLoop *loop = g_main_loop_new(g_main_context_get_thread_default(),
-                                      TRUE);
+                                      FALSE);
     OsinfoInstallScriptGenerateSyncData data = {
         loop, NULL, NULL, NULL
     };
@@ -1450,8 +1448,7 @@ static GFile *osinfo_install_script_generate_output_common(OsinfoInstallScript *
              &data);
     }
 
-    if (g_main_loop_is_running(loop))
-        g_main_loop_run(loop);
+    g_main_loop_run(loop);
 
     if (data.error)
         g_propagate_error(error, data.error);
diff --git a/osinfo/osinfo_media.c b/osinfo/osinfo_media.c
index af4bb14e3087..679e4d34ead6 100644
--- a/osinfo/osinfo_media.c
+++ b/osinfo/osinfo_media.c
@@ -632,7 +632,7 @@ OsinfoMedia *osinfo_media_create_from_location(const gchar *location,
 
     data = g_slice_new0(CreateFromLocationData);
     data->main_loop = g_main_loop_new(g_main_context_get_thread_default(),
-                                       TRUE);
+                                      FALSE);
 
     osinfo_media_create_from_location_async(location,
                                             G_PRIORITY_DEFAULT,
@@ -641,8 +641,7 @@ OsinfoMedia *osinfo_media_create_from_location(const gchar *location,
                                             data);
 
     /* Loop till we get a reply (or time out) */
-    if (g_main_loop_is_running(data->main_loop))
-        g_main_loop_run(data->main_loop);
+    g_main_loop_run(data->main_loop);
 
     ret = osinfo_media_create_from_location_finish(data->res, error);
     create_from_location_data_free(data);
diff --git a/osinfo/osinfo_tree.c b/osinfo/osinfo_tree.c
index 565ccfead9a6..da01c8baa444 100644
--- a/osinfo/osinfo_tree.c
+++ b/osinfo/osinfo_tree.c
@@ -437,7 +437,7 @@ OsinfoTree *osinfo_tree_create_from_location(const gchar *location,
 
     data = g_slice_new0(CreateFromLocationData);
     data->main_loop = g_main_loop_new(g_main_context_get_thread_default(),
-                                      TRUE);
+                                      FALSE);
 
     osinfo_tree_create_from_location_async(location,
                                            G_PRIORITY_DEFAULT,
@@ -446,8 +446,7 @@ OsinfoTree *osinfo_tree_create_from_location(const gchar *location,
                                            data);
 
     /* Loop till we get a reply (or time out) */
-    if (g_main_loop_is_running(data->main_loop))
-        g_main_loop_run(data->main_loop);
+    g_main_loop_run(data->main_loop);
 
     ret = osinfo_tree_create_from_location_finish(data->res, error);
     create_from_location_data_free(data);
diff --git a/test/test-install-script.c b/test/test-install-script.c
index 7b16552d0720..e5e05e5f5383 100644
--- a/test/test-install-script.c
+++ b/test/test-install-script.c
@@ -149,7 +149,7 @@ START_TEST(test_script_file)
     g_object_unref(loader);
 
     loop = g_main_loop_new(g_main_context_get_thread_default(),
-                           TRUE);
+                           FALSE);
 
     media = create_media();
     fail_unless(osinfo_db_identify_media(db, media), "Failed to identify media");
@@ -161,8 +161,7 @@ START_TEST(test_script_file)
                                                    test_generate_for_media_finish,
                                                    loop);
 
-    if (g_main_loop_is_running(loop))
-        g_main_loop_run(loop);
+    g_main_loop_run(loop);
 
     unlink(BUILDDIR "/test/install-script-actual.txt");
     fail_unless(error == NULL, error ? error->message : "none");
@@ -209,7 +208,7 @@ START_TEST(test_script_data)
                                             data);
 
     loop = g_main_loop_new(g_main_context_get_thread_default(),
-                           TRUE);
+                           FALSE);
 
     osinfo_install_script_generate_for_media_async(script,
                                                    media,
@@ -218,8 +217,7 @@ START_TEST(test_script_data)
                                                    test_generate_for_media_finish,
                                                    loop);
 
-    if (g_main_loop_is_running(loop))
-        g_main_loop_run(loop);
+    g_main_loop_run(loop);
 
     unlink(BUILDDIR "/test/install-script-actual.txt");
     fail_unless(error == NULL, error ? error->message : "none");
@@ -287,7 +285,7 @@ START_TEST(test_script_datamap)
                             "fedora16");
 
     loop = g_main_loop_new(g_main_context_get_thread_default(),
-                           TRUE);
+                           FALSE);
 
     osinfo_install_script_generate_async(script,
                                          os,
@@ -296,8 +294,7 @@ START_TEST(test_script_datamap)
                                          test_generate_finish,
                                          loop);
 
-    if (g_main_loop_is_running(loop))
-        g_main_loop_run(loop);
+    g_main_loop_run(loop);
 
     unlink(BUILDDIR "/test/install-script-actual.txt");
     fail_unless(error == NULL, error ? error->message : "none");
-- 
2.9.3



From rishi.is at lostca.se  Tue Jan 17 15:24:16 2017
From: rishi.is at lostca.se (Debarshi Ray)
Date: Tue, 17 Jan 2017 15:24:16 +0000
Subject: [Libosinfo] [osinfo-db 1/2] rhel: enclose strings used for
 shell ifs in quotes
In-Reply-To: <20170116182956.15510-1-fabiano@fidencio.org>
References: <20170116182956.15510-1-fabiano@fidencio.org>
Message-ID: <20170117152415.GE71679@aloka.lostca.se>

Hey,

On Mon, Jan 16, 2017 at 07:29:55PM +0100, Fabiano Fid??ncio wrote:
>  useradd -G wheel <xsl:value-of select="config/user-login"/> # Add user
> -if test -z <xsl:value-of select="config/user-password"/>; then
> +if test -z "<xsl:value-of select="config/user-password"/>"; then
>      passwd -d <xsl:value-of select="config/user-login"/> # Make user account passwordless
>  else
>      echo <xsl:value-of select="config/user-password"/> |passwd --stdin <xsl:value-of select="config/user-login"/>
>  fi
>  
> -if test -z <xsl:value-of select="config/admin-password"/>; then
> +if test -z "<xsl:value-of select="config/admin-password"/>"; then
>      passwd -d root # Make root account passwordless
>  else
>      echo <xsl:value-of select="config/admin-password"/> |passwd --stdin root
>  fi
>  
>  # Set user avatar
> -if test -n <xsl:value-of select="config/avatar-location"/>; then
> +if test -n "<xsl:value-of select="config/avatar-location"/>"; then
>  mkdir /mnt/unattended-media
>  mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
>  cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /home/<xsl:value-of select="config/user-login"/>/.face

Nested double quotes! So far it has generated valid Kickstart files, but
I don't know if that is by accident or by design.

Happy hacking,
Rishi



From fabiano at fidencio.org  Tue Jan 17 15:35:03 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 17 Jan 2017 16:35:03 +0100
Subject: [Libosinfo] [osinfo-db 1/2] rhel: enclose strings used for
 shell ifs in quotes
In-Reply-To: <20170117152415.GE71679@aloka.lostca.se>
References: <20170116182956.15510-1-fabiano@fidencio.org>
	<20170117152415.GE71679@aloka.lostca.se>
Message-ID: <CAK9pz9JvD3S4uBW61POJuMqjABNA2WEYERw7eiHpPQPX3K3PSw@mail.gmail.com>

On Tue, Jan 17, 2017 at 4:24 PM, Debarshi Ray <rishi.is at lostca.se> wrote:
> Hey,
>
> On Mon, Jan 16, 2017 at 07:29:55PM +0100, Fabiano Fid??ncio wrote:
>>  useradd -G wheel <xsl:value-of select="config/user-login"/> # Add user
>> -if test -z <xsl:value-of select="config/user-password"/>; then
>> +if test -z "<xsl:value-of select="config/user-password"/>"; then
>>      passwd -d <xsl:value-of select="config/user-login"/> # Make user account passwordless
>>  else
>>      echo <xsl:value-of select="config/user-password"/> |passwd --stdin <xsl:value-of select="config/user-login"/>
>>  fi
>>
>> -if test -z <xsl:value-of select="config/admin-password"/>; then
>> +if test -z "<xsl:value-of select="config/admin-password"/>"; then
>>      passwd -d root # Make root account passwordless
>>  else
>>      echo <xsl:value-of select="config/admin-password"/> |passwd --stdin root
>>  fi
>>
>>  # Set user avatar
>> -if test -n <xsl:value-of select="config/avatar-location"/>; then
>> +if test -n "<xsl:value-of select="config/avatar-location"/>"; then
>>  mkdir /mnt/unattended-media
>>  mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
>>  cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /home/<xsl:value-of select="config/user-login"/>/.face
>
> Nested double quotes! So far it has generated valid Kickstart files, but
> I don't know if that is by accident or by design.

I'll replace one of the " by ' before pushing in case this is the only problem.
Better be safe than sorry here.

Thanks for the catch!
-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Tue Jan 17 15:35:47 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 17 Jan 2017 16:35:47 +0100
Subject: [Libosinfo] [osinfo-db 1/2] rhel: enclose strings used for
 shell ifs in quotes
In-Reply-To: <CAK9pz9JvD3S4uBW61POJuMqjABNA2WEYERw7eiHpPQPX3K3PSw@mail.gmail.com>
References: <20170116182956.15510-1-fabiano@fidencio.org>
	<20170117152415.GE71679@aloka.lostca.se>
	<CAK9pz9JvD3S4uBW61POJuMqjABNA2WEYERw7eiHpPQPX3K3PSw@mail.gmail.com>
Message-ID: <CAK9pz9J_SwtoR1LOrHkT3EKeGULTxjJAyPah5iA7j4bCfpZFVQ@mail.gmail.com>

On Tue, Jan 17, 2017 at 4:35 PM, Fabiano Fid?ncio <fabiano at fidencio.org> wrote:
> On Tue, Jan 17, 2017 at 4:24 PM, Debarshi Ray <rishi.is at lostca.se> wrote:
>> Hey,
>>
>> On Mon, Jan 16, 2017 at 07:29:55PM +0100, Fabiano Fid??ncio wrote:
>>>  useradd -G wheel <xsl:value-of select="config/user-login"/> # Add user
>>> -if test -z <xsl:value-of select="config/user-password"/>; then
>>> +if test -z "<xsl:value-of select="config/user-password"/>"; then
>>>      passwd -d <xsl:value-of select="config/user-login"/> # Make user account passwordless
>>>  else
>>>      echo <xsl:value-of select="config/user-password"/> |passwd --stdin <xsl:value-of select="config/user-login"/>
>>>  fi
>>>
>>> -if test -z <xsl:value-of select="config/admin-password"/>; then
>>> +if test -z "<xsl:value-of select="config/admin-password"/>"; then
>>>      passwd -d root # Make root account passwordless
>>>  else
>>>      echo <xsl:value-of select="config/admin-password"/> |passwd --stdin root
>>>  fi
>>>
>>>  # Set user avatar
>>> -if test -n <xsl:value-of select="config/avatar-location"/>; then
>>> +if test -n "<xsl:value-of select="config/avatar-location"/>"; then
>>>  mkdir /mnt/unattended-media
>>>  mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
>>>  cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /home/<xsl:value-of select="config/user-login"/>/.face
>>
>> Nested double quotes! So far it has generated valid Kickstart files, but
>> I don't know if that is by accident or by design.
>
> I'll replace one of the " by ' before pushing in case this is the only problem.
> Better be safe than sorry here.
>
> Thanks for the catch!

And, of course, the comments apply to the Fedora patch as well :-)
-- 
Fabiano Fid?ncio



From rishi.is at lostca.se  Tue Jan 17 16:28:59 2017
From: rishi.is at lostca.se (Debarshi Ray)
Date: Tue, 17 Jan 2017 16:28:59 +0000
Subject: [Libosinfo] [osinfo-db 1/2] rhel: enclose strings used for
 shell ifs in quotes
In-Reply-To: <CAK9pz9JvD3S4uBW61POJuMqjABNA2WEYERw7eiHpPQPX3K3PSw@mail.gmail.com>
References: <20170116182956.15510-1-fabiano@fidencio.org>
	<20170117152415.GE71679@aloka.lostca.se>
	<CAK9pz9JvD3S4uBW61POJuMqjABNA2WEYERw7eiHpPQPX3K3PSw@mail.gmail.com>
Message-ID: <20170117162859.GF71679@aloka.lostca.se>

On Tue, Jan 17, 2017 at 04:35:03PM +0100, Fabiano Fid??ncio wrote:
> On Tue, Jan 17, 2017 at 4:24 PM, Debarshi Ray <rishi.is at lostca.se> wrote:
>> Nested double quotes! So far it has generated valid Kickstart files, but
>> I don't know if that is by accident or by design.
> 
> I'll replace one of the " by ' before pushing in case this is the only
> problem.

Everything else looks fine to me, but I am not qualified to be a
reviewer.



From rishi.is at lostca.se  Tue Jan 17 17:14:15 2017
From: rishi.is at lostca.se (Debarshi Ray)
Date: Tue, 17 Jan 2017 17:14:15 +0000
Subject: [Libosinfo] [osinfo-db v2] rhel: Add support to registering to
 the subscription-manager
In-Reply-To: <20170116182932.15400-1-fabiano@fidencio.org>
References: <20170116182932.15400-1-fabiano@fidencio.org>
Message-ID: <20170117171415.GG71679@aloka.lostca.se>

Hey,

On Mon, Jan 16, 2017 at 07:29:32PM +0100, Fabiano Fid??ncio wrote:
> +if [ -n "<xsl:value-of select="config/reg-login"/>" -a -n "<xsl:value-of select="config/reg-password"/>" ]; then
> +    subscription-manager register --username <xsl:value-of select="config/reg-login"/> --password <xsl:value-of select="config/reg-password"/> --auto-attach
> +fi
> +

I am not 100% sure that --username and --password are the best choices
for a kickstart file. Especially the password.

subscription-manager(8) has this concept of activation keys
(subscription-manager register --activationkey=<...>), which is more
suitable for this case. However, I don't know if it works with every
subscription management server. I am particularly interested in
developers.redhat.com.

Cheers,
Rishi



From fidencio at redhat.com  Tue Jan 17 18:45:59 2017
From: fidencio at redhat.com (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 17 Jan 2017 19:45:59 +0100
Subject: [Libosinfo] [osinfo-db v2] rhel: Add support to registering to
 the subscription-manager
In-Reply-To: <20170117171415.GG71679@aloka.lostca.se>
References: <20170116182932.15400-1-fabiano@fidencio.org>
	<20170117171415.GG71679@aloka.lostca.se>
Message-ID: <CAAY6Xse7SRBjzqTbV+nN7=PU_UDL99ecJ_CRxgrVSByX9JJj5g@mail.gmail.com>

On Tue, Jan 17, 2017 at 6:14 PM, Debarshi Ray <rishi.is at lostca.se> wrote:
> Hey,
>
> On Mon, Jan 16, 2017 at 07:29:32PM +0100, Fabiano Fid??ncio wrote:
>> +if [ -n "<xsl:value-of select="config/reg-login"/>" -a -n "<xsl:value-of select="config/reg-password"/>" ]; then
>> +    subscription-manager register --username <xsl:value-of select="config/reg-login"/> --password <xsl:value-of select="config/reg-password"/> --auto-attach
>> +fi
>> +
>
> I am not 100% sure that --username and --password are the best choices
> for a kickstart file. Especially the password.
>
> subscription-manager(8) has this concept of activation keys
> (subscription-manager register --activationkey=<...>), which is more
> suitable for this case. However, I don't know if it works with every
> subscription management server. I am particularly interested in
> developers.redhat.com.

Well, --username, --password may not be the ideal for what you're
trying toa achieve with Boxes but it's, IMO, still valid to have
support for it.

Alternatively, we can add support to --activationkey without any issue.

>
> Cheers,
> Rishi
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



From fabiano at fidencio.org  Sat Jan 21 15:10:35 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Sat, 21 Jan 2017 16:10:35 +0100
Subject: [Libosinfo] [PATCH 0/2] Two trivial fixes
In-Reply-To: <20170116100854.GE13096@redhat.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
	<20170116084612.7rxz2jiciohe7ybn@edamame.cdg.redhat.com>
	<CAK9pz9+tLXEzYZQq30iUG5ACg9LRJA1YwOBdQm1odUeWgsCC=Q@mail.gmail.com>
	<20170116100854.GE13096@redhat.com>
Message-ID: <CAK9pz9KnZpbpZyEWFV4RkvwEHXNNEUa8cq5biM3cG+YSC41vkA@mail.gmail.com>

On Mon, Jan 16, 2017 at 11:08 AM, Daniel P. Berrange
<berrange at redhat.com> wrote:
> On Mon, Jan 16, 2017 at 10:52:01AM +0100, Fabiano Fid?ncio wrote:
>> On Mon, Jan 16, 2017 at 9:46 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Mon, Jan 16, 2017 at 09:06:49AM +0100, Michal Privoznik wrote:
>> >> BTW: the test-isodetect test is still failing for me (surprisingly).
>> >
>> > What is the failure? Could it be caused by an outdated osinfo-db?
>>
>> Hmm. Fails here as well and I have the latest osinfo-db installed.
>
> Those errors rather suggest you have old data installed somewhere
> that is being found. Perhaps in $HOME or /etc/ - it definitely
> isn't finding the new osinfo-db data

What I've notice here is libosinfo tries to search for the db in
/usr/local/share/ ... while it is installed in /usr/share/...

>
>
> There *is* a single genuine failure in the test, however, that was caused
> when the patches to add F25 were added last week, caused by incorrect
> volume size data AFAICT
>
> Regards,
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|



-- 
Fabiano Fid?ncio



From berrange at redhat.com  Mon Jan 23 09:26:50 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Mon, 23 Jan 2017 09:26:50 +0000
Subject: [Libosinfo] [PATCH 0/2] Two trivial fixes
In-Reply-To: <CAK9pz9KnZpbpZyEWFV4RkvwEHXNNEUa8cq5biM3cG+YSC41vkA@mail.gmail.com>
References: <cover.1484553870.git.mprivozn@redhat.com>
	<20170116084612.7rxz2jiciohe7ybn@edamame.cdg.redhat.com>
	<CAK9pz9+tLXEzYZQq30iUG5ACg9LRJA1YwOBdQm1odUeWgsCC=Q@mail.gmail.com>
	<20170116100854.GE13096@redhat.com>
	<CAK9pz9KnZpbpZyEWFV4RkvwEHXNNEUa8cq5biM3cG+YSC41vkA@mail.gmail.com>
Message-ID: <20170123092650.GA2853@redhat.com>

On Sat, Jan 21, 2017 at 04:10:35PM +0100, Fabiano Fid?ncio wrote:
> On Mon, Jan 16, 2017 at 11:08 AM, Daniel P. Berrange
> <berrange at redhat.com> wrote:
> > On Mon, Jan 16, 2017 at 10:52:01AM +0100, Fabiano Fid?ncio wrote:
> >> On Mon, Jan 16, 2017 at 9:46 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> >> > On Mon, Jan 16, 2017 at 09:06:49AM +0100, Michal Privoznik wrote:
> >> >> BTW: the test-isodetect test is still failing for me (surprisingly).
> >> >
> >> > What is the failure? Could it be caused by an outdated osinfo-db?
> >>
> >> Hmm. Fails here as well and I have the latest osinfo-db installed.
> >
> > Those errors rather suggest you have old data installed somewhere
> > that is being found. Perhaps in $HOME or /etc/ - it definitely
> > isn't finding the new osinfo-db data
> 
> What I've notice here is libosinfo tries to search for the db in
> /usr/local/share/ ... while it is installed in /usr/share/...

That'll be due to the --prefix arg you passed to configure. You need to
use prefix=usr, or set OSINFO_SYSTEM_DIR env variable

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|



From carnold at suse.com  Wed Jan 25 16:49:58 2017
From: carnold at suse.com (Charles Arnold)
Date: Wed, 25 Jan 2017 09:49:58 -0700
Subject: [Libosinfo] [PATCH 0/3] Add openSUSE 42.2 and SLE-12-SP2 isodata
Message-ID: <1485363001-8908-1-git-send-email-carnold@suse.com>

Add data for openSUSE 42.2
Add data for SLE-12-SP2 Desktop
Add data for SLE-12-SP2 Server

Charles Arnold (3):
  Add openSUSE Leap 42.2 data
  Add SLES-12-SP2 data
  Add SLED-12-SP2 data

 .../openSUSE-Leap-42.2-DVD-x86_64.iso.txt          | 29 ++++++++++++++++++++++
 .../SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt  | 29 ++++++++++++++++++++++
 .../SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt  | 29 ++++++++++++++++++++++
 .../SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt  | 16 ++++++++++++
 .../SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt    | 29 ++++++++++++++++++++++
 .../SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt   | 29 ++++++++++++++++++++++
 6 files changed, 161 insertions(+)
 create mode 100644 test/isodata/opensuse/opensuse42.2/openSUSE-Leap-42.2-DVD-x86_64.iso.txt
 create mode 100644 test/isodata/sled/sled12sp2/SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt

-- 
1.8.5.6



From carnold at suse.com  Wed Jan 25 16:50:01 2017
From: carnold at suse.com (Charles Arnold)
Date: Wed, 25 Jan 2017 09:50:01 -0700
Subject: [Libosinfo] [PATCH 3/3] Add SLED-12-SP2 data
In-Reply-To: <1485363001-8908-1-git-send-email-carnold@suse.com>
References: <1485363001-8908-1-git-send-email-carnold@suse.com>
Message-ID: <1485363001-8908-4-git-send-email-carnold@suse.com>

---
 .../SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt  | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 test/isodata/sled/sled12sp2/SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt

diff --git a/test/isodata/sled/sled12sp2/SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt b/test/isodata/sled/sled12sp2/SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt
new file mode 100644
index 0000000..1c0e912
--- /dev/null
+++ b/test/isodata/sled/sled12sp2/SLE-12-SP2-Desktop-DVD-x86_64-GM-DVD1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: SLE-12-SP2-Desktop-DVD-x86_64091
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: SLE-12-SP2-Desktop-DVD-x86_64-Build0915-Media1
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 2015612
+El Torito VD version 1 found, boot catalog is in sector 20
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID 'SUSE LINUX GmbH'
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 1536 5430
-- 
1.8.5.6



From carnold at suse.com  Wed Jan 25 16:49:59 2017
From: carnold at suse.com (Charles Arnold)
Date: Wed, 25 Jan 2017 09:49:59 -0700
Subject: [Libosinfo] [PATCH 1/3] Add openSUSE Leap 42.2 data
In-Reply-To: <1485363001-8908-1-git-send-email-carnold@suse.com>
References: <1485363001-8908-1-git-send-email-carnold@suse.com>
Message-ID: <1485363001-8908-2-git-send-email-carnold@suse.com>

---
 .../openSUSE-Leap-42.2-DVD-x86_64.iso.txt          | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 test/isodata/opensuse/opensuse42.2/openSUSE-Leap-42.2-DVD-x86_64.iso.txt

diff --git a/test/isodata/opensuse/opensuse42.2/openSUSE-Leap-42.2-DVD-x86_64.iso.txt b/test/isodata/opensuse/opensuse42.2/openSUSE-Leap-42.2-DVD-x86_64.iso.txt
new file mode 100644
index 0000000..a9bed45
--- /dev/null
+++ b/test/isodata/opensuse/opensuse42.2/openSUSE-Leap-42.2-DVD-x86_64.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: openSUSE-Leap-42.2-DVD-x86_64028
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: openSUSE-Leap-42.2-DVD-x86_64-Build0283-Media
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 2140229
+El Torito VD version 1 found, boot catalog is in sector 20
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID 'SUSE LINUX GmbH'
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 16C0 5824
-- 
1.8.5.6



From carnold at suse.com  Wed Jan 25 16:50:00 2017
From: carnold at suse.com (Charles Arnold)
Date: Wed, 25 Jan 2017 09:50:00 -0700
Subject: [Libosinfo] [PATCH 2/3] Add SLES-12-SP2 data
In-Reply-To: <1485363001-8908-1-git-send-email-carnold@suse.com>
References: <1485363001-8908-1-git-send-email-carnold@suse.com>
Message-ID: <1485363001-8908-3-git-send-email-carnold@suse.com>

---
 .../SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt  | 29 ++++++++++++++++++++++
 .../SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt  | 16 ++++++++++++
 .../SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt    | 29 ++++++++++++++++++++++
 .../SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt   | 29 ++++++++++++++++++++++
 4 files changed, 103 insertions(+)
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt
 create mode 100644 test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt

diff --git a/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt
new file mode 100644
index 0000000..cf72b96
--- /dev/null
+++ b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-aarch64-GM-DVD1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: SLE-12-SP2-Server-DVD-aarch64219
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: SLE-12-SP2-Server-DVD-aarch64-Build2192-Media1
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1388741
+El Torito VD version 1 found, boot catalog is in sector 20
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID 'SUSE LINUX GmbH'
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect AD4
+        Bootoff D074 53364
diff --git a/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt
new file mode 100644
index 0000000..1113c53
--- /dev/null
+++ b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-ppc64le-GM-DVD1.iso.txt
@@ -0,0 +1,16 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: SLE-12-SP2-Server-DVD-ppc64le219
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: SLE-12-SP2-Server-DVD-ppc64le-Build2192-Media1
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1570275
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
diff --git a/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt
new file mode 100644
index 0000000..58b20d9
--- /dev/null
+++ b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-s390x-GM-DVD1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: SLE-12-SP2-Server-DVD-s390x21921
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: SLE-12-SP2-Server-DVD-s390x-Build2192-Media1
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1633038
+El Torito VD version 1 found, boot catalog is in sector 20
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID 'SUSE LINUX GmbH'
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 260 608
diff --git a/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt
new file mode 100644
index 0000000..0d19b25
--- /dev/null
+++ b/test/isodata/sles/sles12sp2/SLE-12-SP2-Server-DVD-x86_64-GM-DVD1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: SLE-12-SP2-Server-DVD-x86_642192
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: SLE-12-SP2-Server-DVD-x86_64-Build2192-Media1
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1632145
+El Torito VD version 1 found, boot catalog is in sector 20
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID 'SUSE LINUX GmbH'
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 150C 5388
-- 
1.8.5.6