[Libosinfo] [PATCH libosinfo] test-isodetect: add Debian's arm flavours

[Guido Günther]

Hi,
On Wed, Jul 12, 2017 at 09:35:16AM +0200, Christophe Fergeau wrote:
> On Tue, Jul 11, 2017 at 09:58:26PM +0200, Guido Günther wrote:
> > to avoid "Unknown arch" debug messges
> > ---
> >  tests/test-isodetect.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c
> > index c72b8fc..6a38963 100644
> > --- a/tests/test-isodetect.c
> > +++ b/tests/test-isodetect.c
> > @@ -128,8 +128,12 @@ static struct ISOInfo *load_iso(GFile *file, const gchar *shortid, const gchar *
> >          arch = "ia64";
> >      else if (strstr(name, "s390x"))
> >          arch = "s390x";
> > -    else if (strstr(name, "aarch64"))
> > +    else if (strstr(name, "aarch64") ||
> > +             strstr(name, "arm64"))
> >          arch = "aarch64";
> 
> This change looks good.
> 
> > +    else if (strstr(name, "armhf") ||
> > +             strstr(name, "armv7l"))
> > +        arch = "armhf";
> 
> However for this one I'd expect arch = "armv7l" as this is what is in
> the RNG schema? My understanding of
> https://bugzilla.redhat.com/show_bug.cgi?id=719609#c13 is that armv7l is
> a soft floating point arch, armv7hl would be hard floating point. And



> armhf is hard floating point as well. So I don't think we can consider
> the 2 are the same here. You probably need to add a new ARM arch to the
> schema file, and use that for armhf.

On my A20 Olinuxino I see

$ uname -m
armv7l

$ dpkg --print-architecture
armhf

I assumed that the armv7l refers to an architecture supporting hard
float but your link suggests otherwise. In this case we need to fixup
osinfo-db as well. I couldn't find any other good references on this.

I'll post a v2 for libosinfo and will fix osinfo-db if that looks o.k.

Cheers,
 -- Guido