[Libosinfo] [osinfo-db PATCH] Sort list of sources in POTFILES.in

[Pino Toscano]

On Monday, 20 March 2017 21:13:00 CET Eric Blake wrote:
> On 03/20/2017 08:49 AM, Pino Toscano wrote:
> > This way, the generation of osinfo-db.pot is more deterministic and
> > stable, and it is way easier to diff pot files before and after editing
> > the XML definitions of OSes, devices, etc.
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index a7a5c68..e2db764 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -81,7 +81,7 @@ clean:
> >  	rm -f $(DATA_FILES) $(SCHEMA_FILES) po/POTFILES.in po/osinfo-db.pot
> >  
> >  po/POTFILES.in:
> > -	$(V_GEN) find data -name *.xml.in > $@
> > +	$(V_GEN) find data -name *.xml.in | sort > $@
> 
> Do you want to use 'LC_ALL=C sort' instead of locale-dependent 'sort',
> to ensure that variations in the build environment locale don't affect
> things?

Oh good point indeed, I'll amend it.  That's what you get when testing
patches from a Linux setup with LC_ALL=C already :)

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170321/ba4c9b03/attachment.sig>