From cfergeau at redhat.com  Tue May  2 11:07:51 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Tue, 2 May 2017 13:07:51 +0200
Subject: [Libosinfo] [osinfo-db 2/2] install-script,
 suse: Add install-scripts for SLES 11 SP4
In-Reply-To: <20170422224131.9328-3-fidencio@redhat.com>
References: <20170422224131.9328-1-fidencio@redhat.com>
	<20170422224131.9328-3-fidencio@redhat.com>
Message-ID: <20170502110751.srzsn3w6fg7oqh7k@edamame.cdg.redhat.com>

On Sun, Apr 23, 2017 at 12:41:31AM +0200, Fabiano Fid?ncio wrote:
> Some small changes have been done in the bootloader and in the patterns
> currently used for SLES 12+ in order to also support the "old" SLES 11
> SP4.
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  .../suse.com/suse-autoyast-desktop.xml.in          | 34 ++++++++++++++++++++--
>  .../suse.com/suse-autoyast-jeos.xml.in             |  9 +++++-
>  data/os/suse.com/sles-11.4.xml.in                  |  9 ++++--
>  3 files changed, 47 insertions(+), 5 deletions(-)
> 
> diff --git a/data/install-script/suse.com/suse-autoyast-desktop.xml.in b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> index acb38c1..381d621 100644
> --- a/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> +++ b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> @@ -86,7 +86,14 @@
>                  <timeout config:type="integer">8</timeout>
>                  <vgamode/>
>                </global>
> -              <loader_type>grub2</loader_type>
> +              <xsl:choose>
> +                <xsl:when test="os/version &lt; 12">
> +                  <loader_type>grub</loader_type>
> +                </xsl:when>
> +                <xsl:otherwise>
> +                  <loader_type>grub2</loader_type>
> +                </xsl:otherwise>
> +              </xsl:choose>
>              </bootloader>
>              <firewall>
>                <enable_firewall config:type="boolean">false</enable_firewall>
> @@ -172,13 +179,20 @@ if test -z '<xsl:value-of select="config/user-password"/>'; then
>  pam-config -a --unix-nullok
>  pam-config -a --nullok
>  
> -<xsl:if test="os/version = 12">
> +<xsl:if test="os/version &lt; 12.1">

I'd squash this hunk in the first patch. Does this mean we are not
adding any users with older suse?

>  useradd <xsl:value-of select="config/user-login"/> -m -G users
>  passwd -d <xsl:value-of select="config/user-login"/>
>  </xsl:if>
>  
>  #Enable passwordless login for users that are part of the nopasswdlogin group
> +<xsl:choose>
> +  <xsl:when test="os/version &lt; 12">
> +sed -i '2 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm
> +  </xsl:when>
> +  <xsl:otherwise>
>  sed -i '4 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm-password
> +  </xsl:otherwise>
> +</xsl:choose>

Maybe you could match on the first empty line, and insert this line
before it to avoid the special casing here? (I don't have a suse at hand
to check this file content, tryin to guess after looking at my fedora
install).

>  fi
>  
>  if test -n '<xsl:value-of select="config/avatar-location"/>'; then
> @@ -213,6 +227,15 @@ fi
>                  <pattern>base</pattern>
>                  <pattern>gnome-basic</pattern>
>                  <pattern>printing</pattern>

Shouldn't these 2 lines be removed?


Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170502/7568664a/attachment.sig>

From cfergeau at redhat.com  Tue May  2 11:48:47 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Tue, 2 May 2017 13:48:47 +0200
Subject: [Libosinfo] [osinfo-db 1/2] install-script,
 suse: Add install-scripts for SLES 12+
In-Reply-To: <20170422224131.9328-2-fidencio@redhat.com>
References: <20170422224131.9328-1-fidencio@redhat.com>
	<20170422224131.9328-2-fidencio@redhat.com>
Message-ID: <20170502114847.zk475mig35fc3m4u@edamame.cdg.redhat.com>

On Sun, Apr 23, 2017 at 12:41:30AM +0200, Fabiano Fid?ncio wrote:
> The install-scripts added support SLES 12, SLES 12 SP1 and SLES 12 SP2.
> 
> Those scripts were completely based on the openSUSE ones and tested
> against the "free for download" ISOs provided by SUSE, that you can find
> in: https://www.suse.com/download-linux/
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  .../suse.com/suse-autoyast-desktop.xml.in          | 287 +++++++++++++++++++++
>  .../suse.com/suse-autoyast-jeos.xml.in             | 201 +++++++++++++++
>  data/os/suse.com/sles-12.1.xml.in                  |   7 +-
>  data/os/suse.com/sles-12.2.xml.in                  |  13 +-
>  data/os/suse.com/sles-12.xml.in                    |   7 +-
>  5 files changed, 509 insertions(+), 6 deletions(-)
>  create mode 100644 data/install-script/suse.com/suse-autoyast-desktop.xml.in
>  create mode 100644 data/install-script/suse.com/suse-autoyast-jeos.xml.in
> 
> diff --git a/data/install-script/suse.com/suse-autoyast-desktop.xml.in b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> new file mode 100644
> index 0000000..acb38c1
> --- /dev/null
> +++ b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> @@ -0,0 +1,287 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +
> +  <!-- DESKTOP PROFILE -->
> +  <install-script id='http://suse.com/suse/autoyast/desktop'>
> +    <profile>desktop</profile>
> +    <expected-filename>autoinst.xml</expected-filename>
> +    <config>
> +      <!-- Localization options -->
> +      <param name="l10n-keyboard" policy="optional" value-map="http://x.org/x11-keyboard"/>
> +      <param name="l10n-language" policy="optional"/>
> +      <param name="l10n-timezone" policy="optional"/>
> +
> +      <!-- Network options -->
> +      <param name="hostname" policy="optional"/>
> +      <param name="domain" policy="optional"/>
> +
> +      <!-- Account options -->
> +      <param name="admin-password" policy="optional"/>
> +      <param name="user-fullname" policy="optional"/>
> +      <param name="user-login" policy="required"/>
> +      <param name="user-password" policy="optional"/>
> +      <param name="avatar-location" policy="optional"/>
> +      <param name="avatar-disk" policy="optional"/>
> +    </config>
> +    <injection-method>disk</injection-method>
> +
> +    <template>
> +      <xsl:stylesheet
> +        xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
> +        version="1.0">
> +
> +        <xsl:output method="xml" indent="yes" omit-xml-declaration="yes"/>
> +
> +        <xsl:template name="l10n-language">
> +          <xsl:choose>
> +            <xsl:when test="config/l10n-language != '' and config/l10n-language != 'C'">
> +              <xsl:value-of select="config/l10n-language"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:text>en_US</xsl:text>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
> +        <xsl:template name="l10n-keyboard">
> +          <xsl:choose>
> +            <xsl:when test="config/l10n-keyboard != '' and config/l10n-keyboard != 'C'">
> +              <xsl:value-of select="config/l10n-keyboard"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:text>us</xsl:text>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
> +        <xsl:template match="/command-line">
> +            <xsl:text>autoyast=device://sda/</xsl:text>

I guess vda is not valid there?

> +            <xsl:value-of select="script/expected-filename"/>
> +        </xsl:template>
> +
> +        <xsl:template match="/install-script-config">
> +          <profile xmlns="http://www.suse.com/1.0/yast2ns" xmlns:config="http://www.suse.com/1.0/configns">
> +            <bootloader>
> +              <device_map config:type="list">
> +                <device_map_entry>
> +                  <firmware>hd0</firmware>
> +                  <linux>/dev/vda</linux>
> +                </device_map_entry>
> +              </device_map>
> +              <global>
> +                <activate>true</activate>
> +                <append>resume=/dev/vda1 splash=silent quiet showopts</append>
> +                <boot_boot>false</boot_boot>
> +                <boot_extended>false</boot_extended>
> +                <boot_mbr>false</boot_mbr>
> +                <boot_root>true</boot_root>
> +                <default>0</default>
> +                <distributor/>
> +                <failsafe_disabled>true</failsafe_disabled>
> +                <generic_mbr>true</generic_mbr>
> +                <gfxmode>auto</gfxmode>
> +                <os_prober>true</os_prober>
> +                <terminal>gfxterm</terminal>
> +                <timeout config:type="integer">8</timeout>
> +                <vgamode/>
> +              </global>
> +              <loader_type>grub2</loader_type>
> +            </bootloader>
> +            <firewall>
> +              <enable_firewall config:type="boolean">false</enable_firewall>
> +              <start_firewall config:type="boolean">false</start_firewall>
> +            </firewall>

Any particular reason to disable firewall?

> +            <general>
> +              <ask-list config:type="list"/>
> +              <mode>
> +                <confirm config:type="boolean">false</confirm>
> +                <final_reboot config:type="boolean">true</final_reboot>
> +              </mode>
> +              <proposals config:type="list"/>
> +              <signature-handling>
> +                <accept_file_without_checksum config:type="boolean">true</accept_file_without_checksum>
> +                <accept_non_trusted_gpg_key config:type="boolean">true</accept_non_trusted_gpg_key>
> +                <accept_unknown_gpg_key config:type="boolean">true</accept_unknown_gpg_key>
> +                <accept_unsigned_file config:type="boolean">true</accept_unsigned_file>
> +                <accept_verification_failed config:type="boolean">false</accept_verification_failed>
> +                <import_gpg_key config:type="boolean">true</import_gpg_key>
> +              </signature-handling>

This seems fairly unsecure too, is this required?


> +              <storage>
> +                <partition_alignment config:type="symbol">align_optimal</partition_alignment>
> +                <start_multipath config:type="boolean">false</start_multipath>
> +              </storage>
> +            </general>
> +            <keyboard>
> +              <keyboard_values>
> +                <delay/>
> +                <discaps config:type="boolean">false</discaps>
> +                <numlock>bios</numlock>
> +                <rate/>
> +              </keyboard_values>
> +              <keymap><xsl:call-template name="l10n-keyboard"/></keymap>
> +            </keyboard>
> +            <language><xsl:call-template name="l10n-language"/></language>
> +          <networking>
> +            <managed config:type="boolean">false</managed>
> +            <interfaces  config:type="list">
> +              <interface>
> +                <bootproto>dhcp</bootproto>
> +                  <device>eth0</device>
> +                  <startmode>auto</startmode>
> +                  <usercontrol>no</usercontrol>
> +                </interface>
> +            </interfaces>
> +          </networking>
> +          <partitioning config:type="list">
> +            <drive>
> +              <device>/dev/vda</device>
> +              <type config:type="symbol">CT_DISK</type>
> +              <use>all</use>
> +            </drive>
> +          </partitioning>
> +            <report>
> +              <errors>
> +                <log config:type="boolean">true</log>
> +                <show config:type="boolean">true</show>
> +                <timeout config:type="integer">0</timeout>
> +              </errors>
> +              <messages>
> +                <log config:type="boolean">true</log>
> +                <show config:type="boolean">true</show>
> +                <timeout config:type="integer">10</timeout>
> +              </messages>
> +              <warnings>
> +                <log config:type="boolean">true</log>
> +                <show config:type="boolean">true</show>
> +                <timeout config:type="integer">10</timeout>
> +              </warnings>
> +              <yesno_messages>
> +                <log config:type="boolean">true</log>
> +                <show config:type="boolean">true</show>
> +                <timeout config:type="integer">10</timeout>
> +              </yesno_messages>
> +            </report>
> +            <scripts>
> +              <chroot-scripts config:type="list">
> +                <script>
> +                  <chrooted config:type="boolean">true</chrooted>
> +                  <source>
> +
> +if test -z '<xsl:value-of select="config/user-password"/>'; then
> +pam-config -a --unix-nullok
> +pam-config -a --nullok

Shouldn't this be conditional on the SUSE version as done below?

> +
> +<xsl:if test="os/version = 12">
> +useradd <xsl:value-of select="config/user-login"/> -m -G users
> +passwd -d <xsl:value-of select="config/user-login"/>
> +</xsl:if>

Does this mean we are not setting a password on older suse?

> +
> +#Enable passwordless login for users that are part of the nopasswdlogin group
> +sed -i '4 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm-password
> +fi
> +
> +if test -n '<xsl:value-of select="config/avatar-location"/>'; then
> +# Set user avatar
> +mkdir /mnt/unattended-media
> +mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
> +cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /var/lib/AccountsService/icons/<xsl:value-of select="config/user-login"/>
> +umount /mnt/unattended-media
> +
> +echo "
> +[User]
> +Language=<xsl:value-of select="config/l10n-language"/>.UTF-8
> +XSession=gnome
> +Icon=/var/lib/AccountsService/icons/<xsl:value-of select="config/user-login"/>
> +" >> /var/lib/AccountsService/users/<xsl:value-of select="config/user-login"/>
> +fi
> +                  </source>
> +                </script>
> +              </chroot-scripts>
> +            </scripts>
> +            <services-manager>
> +              <default_target>graphical</default_target>
> +            </services-manager>
> +            <software>
> +              <packages config:type="list">
> +                <package>autoyast2-installation</package>
> +                <package>gdm</package>
> +              </packages>
> +              <patterns config:type="list">
> +                <pattern>Minimal</pattern>
> +                <pattern>apparmor</pattern>
> +                <pattern>base</pattern>
> +                <pattern>gnome-basic</pattern>
> +                <pattern>printing</pattern>
> +                <xsl:if test="os/version &gt; 12">
> +                  <pattern>smt</pattern>
> +                </xsl:if>
> +                <pattern>x11</pattern>
> +              </patterns>
> +            </software>
> +            <sysconfig config:type="list">
> +              <sysconfig_entry>
> +                <sysconfig_key>DISPLAYMANAGER</sysconfig_key>
> +                <sysconfig_path>/etc/sysconfig/displaymanager</sysconfig_path>
> +                <sysconfig_value>gdm</sysconfig_value>
> +              </sysconfig_entry>
> +              <sysconfig_entry>
> +                <sysconfig_key>DEFAULT_WM</sysconfig_key>
> +                <sysconfig_path>/etc/sysconfig/windowmanager</sysconfig_path>
> +                <sysconfig_value>gnome</sysconfig_value>
> +              </sysconfig_entry>
> +            </sysconfig>
> +            <timezone>
> +              <hwclock>UTC</hwclock>
> +              <timezone><xsl:value-of select="config/l10n-timezone"/></timezone>
> +            </timezone>
> +            <user_defaults>
> +              <expire/>
> +              <group>100</group>
> +              <groups/>
> +              <home>/home</home>
> +              <inactive>-1</inactive>
> +              <no_groups config:type="boolean">true</no_groups>
> +              <shell>/bin/bash</shell>
> +              <skel>/etc/skel</skel>
> +              <umask>022</umask>
> +            </user_defaults>

Same question, a bit below you check for suse version before allowing
empty passwords, should the condition be here too?

> +            <xsl:if test="config/user-password = ''">
> +              <groups config:type="list">
> +                <group>
> +                  <group_password>x</group_password>
> +                  <groupname>nopasswdlogin</groupname>
> +                  <userlist><xsl:value-of select="config/user-login"/></userlist>
> +                </group>
> +              </groups>
> +            </xsl:if>
> +            <users config:type="list">
> +              <user>
> +                <encrypted config:type="boolean">false</encrypted>
> +                <fullname>root</fullname>
> +                <gid>0</gid>
> +                <home>/root</home>
> +                <shell>/bin/bash</shell>
> +                <uid>0</uid>
> +                <user_password><xsl:value-of select="config/admin-password"/></user_password>
> +                <username>root</username>
> +              </user>
> +              <!--
> +                While SLES 12 doesn't allow creating a user without a password,
> +                it's okay to do so on the newer versions
> +                -->
> +              <xsl:if test="config/user-password != '' or os/version &gt; 12">
> +                <user>
> +                  <encrypted config:type="boolean">false</encrypted>
> +                  <fullname><xsl:value-of select="config/user-fullname"/></fullname>
> +                  <user_password><xsl:value-of select="config/user-password"/></user_password>
> +                  <username><xsl:value-of select="config/user-login"/></username>
> +                </user>
> +              </xsl:if>

So we don't set a user password on older suse?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170502/7562429b/attachment.sig>

From cfergeau at redhat.com  Tue May  2 13:27:09 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Tue, 2 May 2017 15:27:09 +0200
Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata
In-Reply-To: <20170429062758.9371-1-bogorodskiy@gmail.com>
References: <20170429062758.9371-1-bogorodskiy@gmail.com>
Message-ID: <20170502132709.z2bnk5qhy4xvx6ab@edamame.cdg.redhat.com>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>
and pushed.

On Sat, Apr 29, 2017 at 10:27:58AM +0400, Roman Bogorodskiy wrote:
> Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
> ---
>  .../FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt       | 33 ++++++++++++++++++++++
>  .../FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt        | 33 ++++++++++++++++++++++
>  .../FreeBSD-11.0-RELEASE-i386-disc1.iso.txt        | 33 ++++++++++++++++++++++
>  .../FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt         | 33 ++++++++++++++++++++++
>  4 files changed, 132 insertions(+)
>  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt
>  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt
>  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt
>  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt
> 
> diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt
> new file mode 100644
> index 0000000..b3be918
> --- /dev/null
> +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt
> @@ -0,0 +1,33 @@
> +CD-ROM is in ISO 9660 format
> +System id: FreeBSD
> +Volume id: 11_0_RELEASE_P1_AMD64_CD
> +Volume set id: 
> +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> +Data preparer id: 
> +Application id: 
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 335954
> +El Torito VD version 1 found, boot catalog is in sector 19
> +NO Joliet present
> +
> +SUSP signatures version 1 found
> +Rock Ridge signatures version 1 found
> +Rock Ridge id 'IEEE_P1282'
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Cksum AA 55 OK
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 14 20
> diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt
> new file mode 100644
> index 0000000..994ea44
> --- /dev/null
> +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt
> @@ -0,0 +1,33 @@
> +CD-ROM is in ISO 9660 format
> +System id: FreeBSD
> +Volume id: 11_0_RELEASE_P1_AMD64_DVD
> +Volume set id: 
> +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> +Data preparer id: 
> +Application id: 
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1430708
> +El Torito VD version 1 found, boot catalog is in sector 19
> +NO Joliet present
> +
> +SUSP signatures version 1 found
> +Rock Ridge signatures version 1 found
> +Rock Ridge id 'IEEE_P1282'
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Cksum AA 55 OK
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 14 20
> diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt
> new file mode 100644
> index 0000000..ea93f9b
> --- /dev/null
> +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt
> @@ -0,0 +1,33 @@
> +CD-ROM is in ISO 9660 format
> +System id: FreeBSD
> +Volume id: 11_0_RELEASE_P1_I386_CD
> +Volume set id: 
> +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> +Data preparer id: 
> +Application id: 
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 293706
> +El Torito VD version 1 found, boot catalog is in sector 19
> +NO Joliet present
> +
> +SUSP signatures version 1 found
> +Rock Ridge signatures version 1 found
> +Rock Ridge id 'IEEE_P1282'
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Cksum AA 55 OK
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 14 20
> diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt
> new file mode 100644
> index 0000000..2556ab9
> --- /dev/null
> +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt
> @@ -0,0 +1,33 @@
> +CD-ROM is in ISO 9660 format
> +System id: FreeBSD
> +Volume id: 11_0_RELEASE_P1_I386_DVD
> +Volume set id: 
> +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> +Data preparer id: 
> +Application id: 
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1291396
> +El Torito VD version 1 found, boot catalog is in sector 19
> +NO Joliet present
> +
> +SUSP signatures version 1 found
> +Rock Ridge signatures version 1 found
> +Rock Ridge id 'IEEE_P1282'
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Cksum AA 55 OK
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 14 20
> -- 
> 2.11.0
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170502/e0a80b76/attachment.sig>

From bogorodskiy at gmail.com  Tue May  2 15:22:47 2017
From: bogorodskiy at gmail.com (Roman Bogorodskiy)
Date: Tue, 2 May 2017 19:22:47 +0400
Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata
In-Reply-To: <20170502132709.z2bnk5qhy4xvx6ab@edamame.cdg.redhat.com>
References: <20170429062758.9371-1-bogorodskiy@gmail.com>
	<20170502132709.z2bnk5qhy4xvx6ab@edamame.cdg.redhat.com>
Message-ID: <20170502152245.GA2346@kloomba>

  Christophe Fergeau wrote:

> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> and pushed.

Oops, it looks like it should be moved to 'tests' dir now (I generated
this patch before the rename).

Also, I've noticed that trailing whitespaces were stripped:

https://gitlab.com/libosinfo/libosinfo/commit/093d9cb73e40065d44656c53cff73d780589d686

Is that something some sort of post-processing that needs to be done
after running 'isoinfo -d -i'? Quick glance over isoinfo manpage does
not show how to make it strip whitespaces.

> On Sat, Apr 29, 2017 at 10:27:58AM +0400, Roman Bogorodskiy wrote:
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
> > ---
> >  .../FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt       | 33 ++++++++++++++++++++++
> >  .../FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt        | 33 ++++++++++++++++++++++
> >  .../FreeBSD-11.0-RELEASE-i386-disc1.iso.txt        | 33 ++++++++++++++++++++++
> >  .../FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt         | 33 ++++++++++++++++++++++
> >  4 files changed, 132 insertions(+)
> >  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt
> >  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt
> >  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt
> >  create mode 100644 test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt
> > 
> > diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt
> > new file mode 100644
> > index 0000000..b3be918
> > --- /dev/null
> > +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-disc1.iso.txt
> > @@ -0,0 +1,33 @@
> > +CD-ROM is in ISO 9660 format
> > +System id: FreeBSD
> > +Volume id: 11_0_RELEASE_P1_AMD64_CD
> > +Volume set id: 
> > +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> > +Data preparer id: 
> > +Application id: 
> > +Copyright File id: 
> > +Abstract File id: 
> > +Bibliographic File id: 
> > +Volume set size is: 1
> > +Volume set sequence number is: 1
> > +Logical block size is: 2048
> > +Volume size is: 335954
> > +El Torito VD version 1 found, boot catalog is in sector 19
> > +NO Joliet present
> > +
> > +SUSP signatures version 1 found
> > +Rock Ridge signatures version 1 found
> > +Rock Ridge id 'IEEE_P1282'
> > +Eltorito validation header:
> > +    Hid 1
> > +    Arch 0 (x86)
> > +    ID ''
> > +    Cksum AA 55 OK
> > +    Key 55 AA
> > +    Eltorito defaultboot header:
> > +        Bootid 88 (bootable)
> > +        Boot media 0 (No Emulation Boot)
> > +        Load segment 0
> > +        Sys type 0
> > +        Nsect 4
> > +        Bootoff 14 20
> > diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt
> > new file mode 100644
> > index 0000000..994ea44
> > --- /dev/null
> > +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso.txt
> > @@ -0,0 +1,33 @@
> > +CD-ROM is in ISO 9660 format
> > +System id: FreeBSD
> > +Volume id: 11_0_RELEASE_P1_AMD64_DVD
> > +Volume set id: 
> > +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> > +Data preparer id: 
> > +Application id: 
> > +Copyright File id: 
> > +Abstract File id: 
> > +Bibliographic File id: 
> > +Volume set size is: 1
> > +Volume set sequence number is: 1
> > +Logical block size is: 2048
> > +Volume size is: 1430708
> > +El Torito VD version 1 found, boot catalog is in sector 19
> > +NO Joliet present
> > +
> > +SUSP signatures version 1 found
> > +Rock Ridge signatures version 1 found
> > +Rock Ridge id 'IEEE_P1282'
> > +Eltorito validation header:
> > +    Hid 1
> > +    Arch 0 (x86)
> > +    ID ''
> > +    Cksum AA 55 OK
> > +    Key 55 AA
> > +    Eltorito defaultboot header:
> > +        Bootid 88 (bootable)
> > +        Boot media 0 (No Emulation Boot)
> > +        Load segment 0
> > +        Sys type 0
> > +        Nsect 4
> > +        Bootoff 14 20
> > diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt
> > new file mode 100644
> > index 0000000..ea93f9b
> > --- /dev/null
> > +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-disc1.iso.txt
> > @@ -0,0 +1,33 @@
> > +CD-ROM is in ISO 9660 format
> > +System id: FreeBSD
> > +Volume id: 11_0_RELEASE_P1_I386_CD
> > +Volume set id: 
> > +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> > +Data preparer id: 
> > +Application id: 
> > +Copyright File id: 
> > +Abstract File id: 
> > +Bibliographic File id: 
> > +Volume set size is: 1
> > +Volume set sequence number is: 1
> > +Logical block size is: 2048
> > +Volume size is: 293706
> > +El Torito VD version 1 found, boot catalog is in sector 19
> > +NO Joliet present
> > +
> > +SUSP signatures version 1 found
> > +Rock Ridge signatures version 1 found
> > +Rock Ridge id 'IEEE_P1282'
> > +Eltorito validation header:
> > +    Hid 1
> > +    Arch 0 (x86)
> > +    ID ''
> > +    Cksum AA 55 OK
> > +    Key 55 AA
> > +    Eltorito defaultboot header:
> > +        Bootid 88 (bootable)
> > +        Boot media 0 (No Emulation Boot)
> > +        Load segment 0
> > +        Sys type 0
> > +        Nsect 4
> > +        Bootoff 14 20
> > diff --git a/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt
> > new file mode 100644
> > index 0000000..2556ab9
> > --- /dev/null
> > +++ b/test/isodata/freebsd/freebsd11.0/FreeBSD-11.0-RELEASE-i386-dvd1.iso.txt
> > @@ -0,0 +1,33 @@
> > +CD-ROM is in ISO 9660 format
> > +System id: FreeBSD
> > +Volume id: 11_0_RELEASE_P1_I386_DVD
> > +Volume set id: 
> > +Publisher id: THE FREEBSD PROJECT.  HTTP://WWW.FREEBSD.ORG/
> > +Data preparer id: 
> > +Application id: 
> > +Copyright File id: 
> > +Abstract File id: 
> > +Bibliographic File id: 
> > +Volume set size is: 1
> > +Volume set sequence number is: 1
> > +Logical block size is: 2048
> > +Volume size is: 1291396
> > +El Torito VD version 1 found, boot catalog is in sector 19
> > +NO Joliet present
> > +
> > +SUSP signatures version 1 found
> > +Rock Ridge signatures version 1 found
> > +Rock Ridge id 'IEEE_P1282'
> > +Eltorito validation header:
> > +    Hid 1
> > +    Arch 0 (x86)
> > +    ID ''
> > +    Cksum AA 55 OK
> > +    Key 55 AA
> > +    Eltorito defaultboot header:
> > +        Bootid 88 (bootable)
> > +        Boot media 0 (No Emulation Boot)
> > +        Load segment 0
> > +        Sys type 0
> > +        Nsect 4
> > +        Bootoff 14 20
> > -- 
> > 2.11.0
> > 
> > _______________________________________________
> > Libosinfo mailing list
> > Libosinfo at redhat.com
> > https://www.redhat.com/mailman/listinfo/libosinfo



Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170502/178c20ac/attachment.sig>

From bogorodskiy at gmail.com  Tue May  2 15:24:55 2017
From: bogorodskiy at gmail.com (Roman Bogorodskiy)
Date: Tue, 2 May 2017 19:24:55 +0400
Subject: [Libosinfo] [PATCH] configure: add (usb|pci).ids locations on
 FreeBSD
In-Reply-To: <20170428151602.GI11415@redhat.com>
References: <20170428151147.15187-1-bogorodskiy@gmail.com>
	<20170428151602.GI11415@redhat.com>
Message-ID: <20170502152453.GB2346@kloomba>

  Daniel P. Berrange wrote:

> On Fri, Apr 28, 2017 at 07:11:47PM +0400, Roman Bogorodskiy wrote:
> > Add default locations for usb.ids and pci.ids on FreeBSD,
> > i.e. paths used when installing this from misc/usbids
> > and misc/pciids ports.
> > 
> > This way users on FreeBSD don't need to explicitly set
> > these paths using --with-(usb|pci)-ids-path flag.
> > ---
> >  configure.ac | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> ACK

Thanks; it looks like it wasn't pushed though.

> 
> Regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170502/a742131a/attachment.sig>

From berrange at redhat.com  Tue May  2 15:42:03 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Tue, 2 May 2017 16:42:03 +0100
Subject: [Libosinfo] [PATCH] configure: add (usb|pci).ids locations on
 FreeBSD
In-Reply-To: <20170502152453.GB2346@kloomba>
References: <20170428151147.15187-1-bogorodskiy@gmail.com>
	<20170428151602.GI11415@redhat.com> <20170502152453.GB2346@kloomba>
Message-ID: <20170502154203.GG16624@redhat.com>

On Tue, May 02, 2017 at 07:24:55PM +0400, Roman Bogorodskiy wrote:
>   Daniel P. Berrange wrote:
> 
> > On Fri, Apr 28, 2017 at 07:11:47PM +0400, Roman Bogorodskiy wrote:
> > > Add default locations for usb.ids and pci.ids on FreeBSD,
> > > i.e. paths used when installing this from misc/usbids
> > > and misc/pciids ports.
> > > 
> > > This way users on FreeBSD don't need to explicitly set
> > > these paths using --with-(usb|pci)-ids-path flag.
> > > ---
> > >  configure.ac | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > ACK
> 
> Thanks; it looks like it wasn't pushed though.

Oh, whoops.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From berrange at redhat.com  Tue May  2 15:43:13 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Tue, 2 May 2017 16:43:13 +0100
Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata
In-Reply-To: <20170502152245.GA2346@kloomba>
References: <20170429062758.9371-1-bogorodskiy@gmail.com>
	<20170502132709.z2bnk5qhy4xvx6ab@edamame.cdg.redhat.com>
	<20170502152245.GA2346@kloomba>
Message-ID: <20170502154313.GH16624@redhat.com>

On Tue, May 02, 2017 at 07:22:47PM +0400, Roman Bogorodskiy wrote:
>   Christophe Fergeau wrote:
> 
> > 
> > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > and pushed.
> 
> Oops, it looks like it should be moved to 'tests' dir now (I generated
> this patch before the rename).

I'll sort that.

> Also, I've noticed that trailing whitespaces were stripped:
> 
> https://gitlab.com/libosinfo/libosinfo/commit/093d9cb73e40065d44656c53cff73d780589d686
> 
> Is that something some sort of post-processing that needs to be done
> after running 'isoinfo -d -i'? Quick glance over isoinfo manpage does
> not show how to make it strip whitespaces.

I stripped whitespace, otherwise "syntax-check" fails - I think we've
always just done it manually.

Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From bogorodskiy at gmail.com  Tue May  2 15:48:52 2017
From: bogorodskiy at gmail.com (Roman Bogorodskiy)
Date: Tue, 2 May 2017 19:48:52 +0400
Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata
In-Reply-To: <20170502154313.GH16624@redhat.com>
References: <20170429062758.9371-1-bogorodskiy@gmail.com>
	<20170502132709.z2bnk5qhy4xvx6ab@edamame.cdg.redhat.com>
	<20170502152245.GA2346@kloomba> <20170502154313.GH16624@redhat.com>
Message-ID: <20170502154850.GC2346@kloomba>

  Daniel P. Berrange wrote:

> On Tue, May 02, 2017 at 07:22:47PM +0400, Roman Bogorodskiy wrote:
> >   Christophe Fergeau wrote:
> > 
> > > 
> > > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > > and pushed.
> > 
> > Oops, it looks like it should be moved to 'tests' dir now (I generated
> > this patch before the rename).
> 
> I'll sort that.

Thanks!

> > Also, I've noticed that trailing whitespaces were stripped:
> > 
> > https://gitlab.com/libosinfo/libosinfo/commit/093d9cb73e40065d44656c53cff73d780589d686
> > 
> > Is that something some sort of post-processing that needs to be done
> > after running 'isoinfo -d -i'? Quick glance over isoinfo manpage does
> > not show how to make it strip whitespaces.
> 
> I stripped whitespace, otherwise "syntax-check" fails - I think we've
> always just done it manually.

Oh, weird, syntax-check doesn't fail for me (luckily, I still have a
branch with that commit as I sent it and before test -> tests). Maybe
yet another GNU and BSD grep (or whatever tool is used to find this)
incompatibilities. :-(

> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170502/b127c6f0/attachment.sig>

From berrange at redhat.com  Tue May  2 15:51:01 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Tue, 2 May 2017 16:51:01 +0100
Subject: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata
In-Reply-To: <20170502154850.GC2346@kloomba>
References: <20170429062758.9371-1-bogorodskiy@gmail.com>
	<20170502132709.z2bnk5qhy4xvx6ab@edamame.cdg.redhat.com>
	<20170502152245.GA2346@kloomba> <20170502154313.GH16624@redhat.com>
	<20170502154850.GC2346@kloomba>
Message-ID: <20170502155101.GJ16624@redhat.com>

On Tue, May 02, 2017 at 07:48:52PM +0400, Roman Bogorodskiy wrote:
>   Daniel P. Berrange wrote:
> 
> > On Tue, May 02, 2017 at 07:22:47PM +0400, Roman Bogorodskiy wrote:
> > >   Christophe Fergeau wrote:
> > > 
> > > > 
> > > > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > > > and pushed.
> > > 
> > > Oops, it looks like it should be moved to 'tests' dir now (I generated
> > > this patch before the rename).
> > 
> > I'll sort that.
> 
> Thanks!
> 
> > > Also, I've noticed that trailing whitespaces were stripped:
> > > 
> > > https://gitlab.com/libosinfo/libosinfo/commit/093d9cb73e40065d44656c53cff73d780589d686
> > > 
> > > Is that something some sort of post-processing that needs to be done
> > > after running 'isoinfo -d -i'? Quick glance over isoinfo manpage does
> > > not show how to make it strip whitespaces.
> > 
> > I stripped whitespace, otherwise "syntax-check" fails - I think we've
> > always just done it manually.
> 
> Oh, weird, syntax-check doesn't fail for me (luckily, I still have a
> branch with that commit as I sent it and before test -> tests). Maybe
> yet another GNU and BSD grep (or whatever tool is used to find this)
> incompatibilities. :-(

Oh, actually, I see what happened - cfg.mk tells syntax-check to ignore
all trailing whitespace on tests/isodata. So the only reason we hit the
build failure was because we committed them in the wrong directory first.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From fabiano at fidencio.org  Tue May  2 19:25:00 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 2 May 2017 21:25:00 +0200
Subject: [Libosinfo] [osinfo-db 1/2] install-script,
 suse: Add install-scripts for SLES 12+
In-Reply-To: <20170502114847.zk475mig35fc3m4u@edamame.cdg.redhat.com>
References: <20170422224131.9328-1-fidencio@redhat.com>
	<20170422224131.9328-2-fidencio@redhat.com>
	<20170502114847.zk475mig35fc3m4u@edamame.cdg.redhat.com>
Message-ID: <CAK9pz9Jnx2juf7ndaxc1yb_hvggP7YJqYk3E21trGVPkwBdcsA@mail.gmail.com>

On Tue, May 2, 2017 at 1:48 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Sun, Apr 23, 2017 at 12:41:30AM +0200, Fabiano Fid?ncio wrote:
>> The install-scripts added support SLES 12, SLES 12 SP1 and SLES 12 SP2.
>>
>> Those scripts were completely based on the openSUSE ones and tested
>> against the "free for download" ISOs provided by SUSE, that you can find
>> in: https://www.suse.com/download-linux/
>>
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  .../suse.com/suse-autoyast-desktop.xml.in          | 287 +++++++++++++++++++++
>>  .../suse.com/suse-autoyast-jeos.xml.in             | 201 +++++++++++++++
>>  data/os/suse.com/sles-12.1.xml.in                  |   7 +-
>>  data/os/suse.com/sles-12.2.xml.in                  |  13 +-
>>  data/os/suse.com/sles-12.xml.in                    |   7 +-
>>  5 files changed, 509 insertions(+), 6 deletions(-)
>>  create mode 100644 data/install-script/suse.com/suse-autoyast-desktop.xml.in
>>  create mode 100644 data/install-script/suse.com/suse-autoyast-jeos.xml.in
>>
>> diff --git a/data/install-script/suse.com/suse-autoyast-desktop.xml.in b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
>> new file mode 100644
>> index 0000000..acb38c1
>> --- /dev/null
>> +++ b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
>> @@ -0,0 +1,287 @@
>> +<libosinfo version="0.0.1">
>> +<!-- Licensed under the GNU General Public License version 2 or later.
>> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
>> +
>> +  <!-- DESKTOP PROFILE -->
>> +  <install-script id='http://suse.com/suse/autoyast/desktop'>
>> +    <profile>desktop</profile>
>> +    <expected-filename>autoinst.xml</expected-filename>
>> +    <config>
>> +      <!-- Localization options -->
>> +      <param name="l10n-keyboard" policy="optional" value-map="http://x.org/x11-keyboard"/>
>> +      <param name="l10n-language" policy="optional"/>
>> +      <param name="l10n-timezone" policy="optional"/>
>> +
>> +      <!-- Network options -->
>> +      <param name="hostname" policy="optional"/>
>> +      <param name="domain" policy="optional"/>
>> +
>> +      <!-- Account options -->
>> +      <param name="admin-password" policy="optional"/>
>> +      <param name="user-fullname" policy="optional"/>
>> +      <param name="user-login" policy="required"/>
>> +      <param name="user-password" policy="optional"/>
>> +      <param name="avatar-location" policy="optional"/>
>> +      <param name="avatar-disk" policy="optional"/>
>> +    </config>
>> +    <injection-method>disk</injection-method>
>> +
>> +    <template>
>> +      <xsl:stylesheet
>> +        xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
>> +        version="1.0">
>> +
>> +        <xsl:output method="xml" indent="yes" omit-xml-declaration="yes"/>
>> +
>> +        <xsl:template name="l10n-language">
>> +          <xsl:choose>
>> +            <xsl:when test="config/l10n-language != '' and config/l10n-language != 'C'">
>> +              <xsl:value-of select="config/l10n-language"/>
>> +            </xsl:when>
>> +            <xsl:otherwise>
>> +              <xsl:text>en_US</xsl:text>
>> +            </xsl:otherwise>
>> +          </xsl:choose>
>> +        </xsl:template>
>> +
>> +        <xsl:template name="l10n-keyboard">
>> +          <xsl:choose>
>> +            <xsl:when test="config/l10n-keyboard != '' and config/l10n-keyboard != 'C'">
>> +              <xsl:value-of select="config/l10n-keyboard"/>
>> +            </xsl:when>
>> +            <xsl:otherwise>
>> +              <xsl:text>us</xsl:text>
>> +            </xsl:otherwise>
>> +          </xsl:choose>
>> +        </xsl:template>
>> +
>> +        <xsl:template match="/command-line">
>> +            <xsl:text>autoyast=device://sda/</xsl:text>
>
> I guess vda is not valid there?

Nops. That's the same case for OpenSUSE.

>
>> +            <xsl:value-of select="script/expected-filename"/>
>> +        </xsl:template>
>> +
>> +        <xsl:template match="/install-script-config">
>> +          <profile xmlns="http://www.suse.com/1.0/yast2ns" xmlns:config="http://www.suse.com/1.0/configns">
>> +            <bootloader>
>> +              <device_map config:type="list">
>> +                <device_map_entry>
>> +                  <firmware>hd0</firmware>
>> +                  <linux>/dev/vda</linux>
>> +                </device_map_entry>
>> +              </device_map>
>> +              <global>
>> +                <activate>true</activate>
>> +                <append>resume=/dev/vda1 splash=silent quiet showopts</append>
>> +                <boot_boot>false</boot_boot>
>> +                <boot_extended>false</boot_extended>
>> +                <boot_mbr>false</boot_mbr>
>> +                <boot_root>true</boot_root>
>> +                <default>0</default>
>> +                <distributor/>
>> +                <failsafe_disabled>true</failsafe_disabled>
>> +                <generic_mbr>true</generic_mbr>
>> +                <gfxmode>auto</gfxmode>
>> +                <os_prober>true</os_prober>
>> +                <terminal>gfxterm</terminal>
>> +                <timeout config:type="integer">8</timeout>
>> +                <vgamode/>
>> +              </global>
>> +              <loader_type>grub2</loader_type>
>> +            </bootloader>
>> +            <firewall>
>> +              <enable_firewall config:type="boolean">false</enable_firewall>
>> +              <start_firewall config:type="boolean">false</start_firewall>
>> +            </firewall>
>
> Any particular reason to disable firewall?

No particular reason. I'll remove it in a v2.

>
>> +            <general>
>> +              <ask-list config:type="list"/>
>> +              <mode>
>> +                <confirm config:type="boolean">false</confirm>
>> +                <final_reboot config:type="boolean">true</final_reboot>
>> +              </mode>
>> +              <proposals config:type="list"/>
>> +              <signature-handling>
>> +                <accept_file_without_checksum config:type="boolean">true</accept_file_without_checksum>
>> +                <accept_non_trusted_gpg_key config:type="boolean">true</accept_non_trusted_gpg_key>
>> +                <accept_unknown_gpg_key config:type="boolean">true</accept_unknown_gpg_key>
>> +                <accept_unsigned_file config:type="boolean">true</accept_unsigned_file>
>> +                <accept_verification_failed config:type="boolean">false</accept_verification_failed>
>> +                <import_gpg_key config:type="boolean">true</import_gpg_key>
>> +              </signature-handling>
>
> This seems fairly unsecure too, is this required?

Hmm. I'll double check, but I do believe I can drop those for SLES.

>
>
>> +              <storage>
>> +                <partition_alignment config:type="symbol">align_optimal</partition_alignment>
>> +                <start_multipath config:type="boolean">false</start_multipath>
>> +              </storage>
>> +            </general>
>> +            <keyboard>
>> +              <keyboard_values>
>> +                <delay/>
>> +                <discaps config:type="boolean">false</discaps>
>> +                <numlock>bios</numlock>
>> +                <rate/>
>> +              </keyboard_values>
>> +              <keymap><xsl:call-template name="l10n-keyboard"/></keymap>
>> +            </keyboard>
>> +            <language><xsl:call-template name="l10n-language"/></language>
>> +          <networking>
>> +            <managed config:type="boolean">false</managed>
>> +            <interfaces  config:type="list">
>> +              <interface>
>> +                <bootproto>dhcp</bootproto>
>> +                  <device>eth0</device>
>> +                  <startmode>auto</startmode>
>> +                  <usercontrol>no</usercontrol>
>> +                </interface>
>> +            </interfaces>
>> +          </networking>
>> +          <partitioning config:type="list">
>> +            <drive>
>> +              <device>/dev/vda</device>
>> +              <type config:type="symbol">CT_DISK</type>
>> +              <use>all</use>
>> +            </drive>
>> +          </partitioning>
>> +            <report>
>> +              <errors>
>> +                <log config:type="boolean">true</log>
>> +                <show config:type="boolean">true</show>
>> +                <timeout config:type="integer">0</timeout>
>> +              </errors>
>> +              <messages>
>> +                <log config:type="boolean">true</log>
>> +                <show config:type="boolean">true</show>
>> +                <timeout config:type="integer">10</timeout>
>> +              </messages>
>> +              <warnings>
>> +                <log config:type="boolean">true</log>
>> +                <show config:type="boolean">true</show>
>> +                <timeout config:type="integer">10</timeout>
>> +              </warnings>
>> +              <yesno_messages>
>> +                <log config:type="boolean">true</log>
>> +                <show config:type="boolean">true</show>
>> +                <timeout config:type="integer">10</timeout>
>> +              </yesno_messages>
>> +            </report>
>> +            <scripts>
>> +              <chroot-scripts config:type="list">
>> +                <script>
>> +                  <chrooted config:type="boolean">true</chrooted>
>> +                  <source>
>> +
>> +if test -z '<xsl:value-of select="config/user-password"/>'; then
>> +pam-config -a --unix-nullok
>> +pam-config -a --nullok
>
> Shouldn't this be conditional on the SUSE version as done below?

Nops. It's needed for all versions to allow setting a user with no password.

>
>> +
>> +<xsl:if test="os/version = 12">
>> +useradd <xsl:value-of select="config/user-login"/> -m -G users
>> +passwd -d <xsl:value-of select="config/user-login"/>
>> +</xsl:if>
>
> Does this mean we are not setting a password on older suse?

There's no older SUSE script at this point.

For 12 SP1 and 12 SP2 we can do this using the <users> XML tag, while
for 12 the only way that worked was by actually adding the user as
done above.

>
>> +
>> +#Enable passwordless login for users that are part of the nopasswdlogin group
>> +sed -i '4 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm-password
>> +fi
>> +
>> +if test -n '<xsl:value-of select="config/avatar-location"/>'; then
>> +# Set user avatar
>> +mkdir /mnt/unattended-media
>> +mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
>> +cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /var/lib/AccountsService/icons/<xsl:value-of select="config/user-login"/>
>> +umount /mnt/unattended-media
>> +
>> +echo "
>> +[User]
>> +Language=<xsl:value-of select="config/l10n-language"/>.UTF-8
>> +XSession=gnome
>> +Icon=/var/lib/AccountsService/icons/<xsl:value-of select="config/user-login"/>
>> +" >> /var/lib/AccountsService/users/<xsl:value-of select="config/user-login"/>
>> +fi
>> +                  </source>
>> +                </script>
>> +              </chroot-scripts>
>> +            </scripts>
>> +            <services-manager>
>> +              <default_target>graphical</default_target>
>> +            </services-manager>
>> +            <software>
>> +              <packages config:type="list">
>> +                <package>autoyast2-installation</package>
>> +                <package>gdm</package>
>> +              </packages>
>> +              <patterns config:type="list">
>> +                <pattern>Minimal</pattern>
>> +                <pattern>apparmor</pattern>
>> +                <pattern>base</pattern>
>> +                <pattern>gnome-basic</pattern>
>> +                <pattern>printing</pattern>
>> +                <xsl:if test="os/version &gt; 12">
>> +                  <pattern>smt</pattern>
>> +                </xsl:if>
>> +                <pattern>x11</pattern>
>> +              </patterns>
>> +            </software>
>> +            <sysconfig config:type="list">
>> +              <sysconfig_entry>
>> +                <sysconfig_key>DISPLAYMANAGER</sysconfig_key>
>> +                <sysconfig_path>/etc/sysconfig/displaymanager</sysconfig_path>
>> +                <sysconfig_value>gdm</sysconfig_value>
>> +              </sysconfig_entry>
>> +              <sysconfig_entry>
>> +                <sysconfig_key>DEFAULT_WM</sysconfig_key>
>> +                <sysconfig_path>/etc/sysconfig/windowmanager</sysconfig_path>
>> +                <sysconfig_value>gnome</sysconfig_value>
>> +              </sysconfig_entry>
>> +            </sysconfig>
>> +            <timezone>
>> +              <hwclock>UTC</hwclock>
>> +              <timezone><xsl:value-of select="config/l10n-timezone"/></timezone>
>> +            </timezone>
>> +            <user_defaults>
>> +              <expire/>
>> +              <group>100</group>
>> +              <groups/>
>> +              <home>/home</home>
>> +              <inactive>-1</inactive>
>> +              <no_groups config:type="boolean">true</no_groups>
>> +              <shell>/bin/bash</shell>
>> +              <skel>/etc/skel</skel>
>> +              <umask>022</umask>
>> +            </user_defaults>
>
> Same question, a bit below you check for suse version before allowing
> empty passwords, should the condition be here too?

That's not the case here. The group "nopasswdlogin" must be created in
any SLES version in order to allow passwordless login.

>
>> +            <xsl:if test="config/user-password = ''">
>> +              <groups config:type="list">
>> +                <group>
>> +                  <group_password>x</group_password>
>> +                  <groupname>nopasswdlogin</groupname>
>> +                  <userlist><xsl:value-of select="config/user-login"/></userlist>
>> +                </group>
>> +              </groups>
>> +            </xsl:if>
>> +            <users config:type="list">
>> +              <user>
>> +                <encrypted config:type="boolean">false</encrypted>
>> +                <fullname>root</fullname>
>> +                <gid>0</gid>
>> +                <home>/root</home>
>> +                <shell>/bin/bash</shell>
>> +                <uid>0</uid>
>> +                <user_password><xsl:value-of select="config/admin-password"/></user_password>
>> +                <username>root</username>
>> +              </user>
>> +              <!--
>> +                While SLES 12 doesn't allow creating a user without a password,
>> +                it's okay to do so on the newer versions
>> +                -->
>> +              <xsl:if test="config/user-password != '' or os/version &gt; 12">
>> +                <user>
>> +                  <encrypted config:type="boolean">false</encrypted>
>> +                  <fullname><xsl:value-of select="config/user-fullname"/></fullname>
>> +                  <user_password><xsl:value-of select="config/user-password"/></user_password>
>> +                  <username><xsl:value-of select="config/user-login"/></username>
>> +                </user>
>> +              </xsl:if>
>
> So we don't set a user password on older suse?

We do!

At this point the only supported versions are:
SLES 12:
 - passwordless users must be created by useradd
 - normal user creating can be done through <user> XML tag
SLES 12 SP1 and SLES 12 SP2:
 - both normal and passwordless users can be created through the
<user> XML tag.

>
> Christophe
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>

Best Regards,
-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Tue May  2 19:33:26 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 2 May 2017 21:33:26 +0200
Subject: [Libosinfo] [osinfo-db 2/2] install-script,
 suse: Add install-scripts for SLES 11 SP4
In-Reply-To: <20170502110751.srzsn3w6fg7oqh7k@edamame.cdg.redhat.com>
References: <20170422224131.9328-1-fidencio@redhat.com>
	<20170422224131.9328-3-fidencio@redhat.com>
	<20170502110751.srzsn3w6fg7oqh7k@edamame.cdg.redhat.com>
Message-ID: <CAK9pz9Jm-EX1rVGAvoJG_XSwQsH5kLKg-ms8OFMjHR3W_=1JdA@mail.gmail.com>

On Tue, May 2, 2017 at 1:07 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Sun, Apr 23, 2017 at 12:41:31AM +0200, Fabiano Fid?ncio wrote:
>> Some small changes have been done in the bootloader and in the patterns
>> currently used for SLES 12+ in order to also support the "old" SLES 11
>> SP4.
>>
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  .../suse.com/suse-autoyast-desktop.xml.in          | 34 ++++++++++++++++++++--
>>  .../suse.com/suse-autoyast-jeos.xml.in             |  9 +++++-
>>  data/os/suse.com/sles-11.4.xml.in                  |  9 ++++--
>>  3 files changed, 47 insertions(+), 5 deletions(-)
>>
>> diff --git a/data/install-script/suse.com/suse-autoyast-desktop.xml.in b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
>> index acb38c1..381d621 100644
>> --- a/data/install-script/suse.com/suse-autoyast-desktop.xml.in
>> +++ b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
>> @@ -86,7 +86,14 @@
>>                  <timeout config:type="integer">8</timeout>
>>                  <vgamode/>
>>                </global>
>> -              <loader_type>grub2</loader_type>
>> +              <xsl:choose>
>> +                <xsl:when test="os/version &lt; 12">
>> +                  <loader_type>grub</loader_type>
>> +                </xsl:when>
>> +                <xsl:otherwise>
>> +                  <loader_type>grub2</loader_type>
>> +                </xsl:otherwise>
>> +              </xsl:choose>
>>              </bootloader>
>>              <firewall>
>>                <enable_firewall config:type="boolean">false</enable_firewall>
>> @@ -172,13 +179,20 @@ if test -z '<xsl:value-of select="config/user-password"/>'; then
>>  pam-config -a --unix-nullok
>>  pam-config -a --nullok
>>
>> -<xsl:if test="os/version = 12">
>> +<xsl:if test="os/version &lt; 12.1">
>
> I'd squash this hunk in the first patch. Does this mean we are not
> adding any users with older suse?

Nops. It means that as done for SLES 12, SLES 11 SP4 also has to have
the passwordless user created using useradd.
The reason that I've decided to not squash it into the first patch is
that I didn't know that SLES 11 SP4 would have the same behaviour as
SLES 12. /o\

I can squash if you prefer ...

>
>>  useradd <xsl:value-of select="config/user-login"/> -m -G users
>>  passwd -d <xsl:value-of select="config/user-login"/>
>>  </xsl:if>
>>
>>  #Enable passwordless login for users that are part of the nopasswdlogin group
>> +<xsl:choose>
>> +  <xsl:when test="os/version &lt; 12">
>> +sed -i '2 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm
>> +  </xsl:when>
>> +  <xsl:otherwise>
>>  sed -i '4 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm-password
>> +  </xsl:otherwise>
>> +</xsl:choose>
>
> Maybe you could match on the first empty line, and insert this line
> before it to avoid the special casing here? (I don't have a suse at hand
> to check this file content, tryin to guess after looking at my fedora
> install).

AFAIR I've tried to so, but this line must be exactly before the line
"auth required pam_unix.so". :-\

>
>>  fi
>>
>>  if test -n '<xsl:value-of select="config/avatar-location"/>'; then
>> @@ -213,6 +227,15 @@ fi
>>                  <pattern>base</pattern>
>>                  <pattern>gnome-basic</pattern>
>>                  <pattern>printing</pattern>
>
> Shouldn't these 2 lines be removed?
>
>
> Christophe
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>


Best Regards,
-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Tue May  2 21:25:21 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 2 May 2017 23:25:21 +0200
Subject: [Libosinfo] [libosinfo PATCH] ubuntu: add Ubuntu 17.04 test data
In-Reply-To: <20170418103628.6729-1-ptoscano@redhat.com>
References: <20170418103508.6582-1-ptoscano@redhat.com>
	<20170418103628.6729-1-ptoscano@redhat.com>
Message-ID: <CAK9pz9+R0nvMzbq9PUM1pdk_U4HSd3J=86W0drVYGq_jj0zrLg@mail.gmail.com>

Pino,


On Tue, Apr 18, 2017 at 12:36 PM, Pino Toscano <ptoscano at redhat.com> wrote:
> ---
>  .../ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt | 29 ++++++++++++++++++++++
>  .../ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt  | 29 ++++++++++++++++++++++
>  .../ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt  | 29 ++++++++++++++++++++++
>  .../ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt  | 29 ++++++++++++++++++++++
>  .../ubuntu17.04/ubuntu-17.04-server-i386.iso.txt   | 29 ++++++++++++++++++++++
>  .../ubuntu-17.04-server-ppc64el.iso.txt            | 17 +++++++++++++
>  .../ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt  | 29 ++++++++++++++++++++++
>  7 files changed, 191 insertions(+)
>  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt
>  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt
>  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt
>  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt
>  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt
>  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt
>  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt

I'm facing some make check issues related to
"ubuntu-17.04-desktop-amd64.iso.txt" (would you mind checking whether
you can see the same issue on your system?)

You'll have to move these files under tests dir instead of test due to
the changes done in the commit a409a71b2c5

[snip]



From ptoscano at redhat.com  Wed May  3 08:25:41 2017
From: ptoscano at redhat.com (Pino Toscano)
Date: Wed, 03 May 2017 10:25:41 +0200
Subject: [Libosinfo] [libosinfo PATCH] ubuntu: add Ubuntu 17.04 test data
In-Reply-To: <CAK9pz9+R0nvMzbq9PUM1pdk_U4HSd3J=86W0drVYGq_jj0zrLg@mail.gmail.com>
References: <20170418103508.6582-1-ptoscano@redhat.com>
	<20170418103628.6729-1-ptoscano@redhat.com>
	<CAK9pz9+R0nvMzbq9PUM1pdk_U4HSd3J=86W0drVYGq_jj0zrLg@mail.gmail.com>
Message-ID: <3440324.n2ZzNkyH2u@thyrus.usersys.redhat.com>

On Tuesday, 2 May 2017 23:25:21 CEST Fabiano Fid?ncio wrote:
> Pino,
> 
> 
> On Tue, Apr 18, 2017 at 12:36 PM, Pino Toscano <ptoscano at redhat.com> wrote:
> > ---
> >  .../ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt | 29 ++++++++++++++++++++++
> >  .../ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt  | 29 ++++++++++++++++++++++
> >  .../ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt  | 29 ++++++++++++++++++++++
> >  .../ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt  | 29 ++++++++++++++++++++++
> >  .../ubuntu17.04/ubuntu-17.04-server-i386.iso.txt   | 29 ++++++++++++++++++++++
> >  .../ubuntu-17.04-server-ppc64el.iso.txt            | 17 +++++++++++++
> >  .../ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt  | 29 ++++++++++++++++++++++
> >  7 files changed, 191 insertions(+)
> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt
> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt
> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt
> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt
> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt
> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt
> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt
> 
> I'm facing some make check issues related to
> "ubuntu-17.04-desktop-amd64.iso.txt" (would you mind checking whether
> you can see the same issue on your system?)
> 
> You'll have to move these files under tests dir instead of test due to
> the changes done in the commit a409a71b2c5

If I move the data according to the recent test -> tests renaming, they
seem to be working here.  I'll refresh this patch so it can be tested
cleanly.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170503/a411196a/attachment.sig>

From ptoscano at redhat.com  Wed May  3 08:27:58 2017
From: ptoscano at redhat.com (Pino Toscano)
Date: Wed,  3 May 2017 10:27:58 +0200
Subject: [Libosinfo] [libosinfo PATCH v2] ubuntu: add Ubuntu 17.04 test data
In-Reply-To: <20170418103628.6729-1-ptoscano@redhat.com>
References: <20170418103628.6729-1-ptoscano@redhat.com>
Message-ID: <20170503082758.29668-1-ptoscano@redhat.com>

---
 .../ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt | 29 ++++++++++++++++++++++
 .../ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt  | 29 ++++++++++++++++++++++
 .../ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt  | 29 ++++++++++++++++++++++
 .../ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt  | 29 ++++++++++++++++++++++
 .../ubuntu17.04/ubuntu-17.04-server-i386.iso.txt   | 29 ++++++++++++++++++++++
 .../ubuntu-17.04-server-ppc64el.iso.txt            | 17 +++++++++++++
 .../ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt  | 29 ++++++++++++++++++++++
 7 files changed, 191 insertions(+)
 create mode 100644 tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt
 create mode 100644 tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt
 create mode 100644 tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt
 create mode 100644 tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt
 create mode 100644 tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt
 create mode 100644 tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt
 create mode 100644 tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt

diff --git a/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt
new file mode 100644
index 0000000..80bcf51
--- /dev/null
+++ b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Ubuntu 17.04 amd64
+Volume set id: 
+Publisher id: 
+Data preparer id: XORRISO-1.2.4 2012.07.20.130001, LIBISOBURN-1.2.4, LIBISOFS-1.2.4, LIBBURN-1.2.4
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 785664
+El Torito VD version 1 found, boot catalog is in sector 173
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff BDC0A 777226
diff --git a/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt
new file mode 100644
index 0000000..be25b9e
--- /dev/null
+++ b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Ubuntu 17.04 i386
+Volume set id: 
+Publisher id: 
+Data preparer id: XORRISO-1.1.8 2011.11.20.173001, LIBISOBURN-1.1.8, LIBISOFS-1.1.6, LIBBURN-1.1.8
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 797328
+El Torito VD version 1 found, boot catalog is in sector 256
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff C1A0D 793101
diff --git a/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt
new file mode 100644
index 0000000..191e274
--- /dev/null
+++ b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Ubuntu-Server 17.04 amd64
+Volume set id: 
+Publisher id: 
+Data preparer id: XORRISO-1.2.4 2012.07.20.130001, LIBISOBURN-1.2.4, LIBISOFS-1.2.4, LIBBURN-1.2.4
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 350720
+El Torito VD version 1 found, boot catalog is in sector 2093
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff B1C5 45509
diff --git a/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt
new file mode 100644
index 0000000..9a78ddc
--- /dev/null
+++ b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Ubuntu-Server 17.04 arm64
+Volume set id: 
+Publisher id: 
+Data preparer id: XORRISO-1.2.4 2012.07.20.130001, LIBISOBURN-1.2.4, LIBISOFS-1.2.4, LIBBURN-1.2.4
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 316447
+El Torito VD version 1 found, boot catalog is in sector 2050
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 239 (Unknown Arch)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 380
+        Bootoff 10034 65588
diff --git a/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt
new file mode 100644
index 0000000..d25278d
--- /dev/null
+++ b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Ubuntu-Server 17.04 i386
+Volume set id: 
+Publisher id: 
+Data preparer id: XORRISO-1.1.8 2011.11.20.173001, LIBISOBURN-1.1.8, LIBISOFS-1.1.6, LIBBURN-1.1.8
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 349184
+El Torito VD version 1 found, boot catalog is in sector 4100
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff B851 47185
diff --git a/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt
new file mode 100644
index 0000000..ea661d7
--- /dev/null
+++ b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt
@@ -0,0 +1,17 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Ubuntu-Server 17.04 ppc64
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 362532
+CD-ROM uses ISO 9660:1999 relaxed format
+NO Joliet present
+Rock Ridge signatures version 1 found
diff --git a/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt
new file mode 100644
index 0000000..7c13dab
--- /dev/null
+++ b/tests/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Ubuntu-Server 17.04 s390x
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 288035
+El Torito VD version 1 found, boot catalog is in sector 1988
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect FFFFDAD0
+        Bootoff 7C5 1989
-- 
2.9.3



From fabiano at fidencio.org  Wed May  3 16:34:40 2017
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Wed, 3 May 2017 18:34:40 +0200
Subject: [Libosinfo] [libosinfo PATCH] ubuntu: add Ubuntu 17.04 test data
In-Reply-To: <3440324.n2ZzNkyH2u@thyrus.usersys.redhat.com>
References: <20170418103508.6582-1-ptoscano@redhat.com>
	<20170418103628.6729-1-ptoscano@redhat.com>
	<CAK9pz9+R0nvMzbq9PUM1pdk_U4HSd3J=86W0drVYGq_jj0zrLg@mail.gmail.com>
	<3440324.n2ZzNkyH2u@thyrus.usersys.redhat.com>
Message-ID: <CAK9pz9+ooddyq06Vf1ZAp7VeyOJoOTz8LQnt=Xf2AM3CH0xJuQ@mail.gmail.com>

On Wed, May 3, 2017 at 10:25 AM, Pino Toscano <ptoscano at redhat.com> wrote:
> On Tuesday, 2 May 2017 23:25:21 CEST Fabiano Fid?ncio wrote:
>> Pino,
>>
>>
>> On Tue, Apr 18, 2017 at 12:36 PM, Pino Toscano <ptoscano at redhat.com> wrote:
>> > ---
>> >  .../ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt | 29 ++++++++++++++++++++++
>> >  .../ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt  | 29 ++++++++++++++++++++++
>> >  .../ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt  | 29 ++++++++++++++++++++++
>> >  .../ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt  | 29 ++++++++++++++++++++++
>> >  .../ubuntu17.04/ubuntu-17.04-server-i386.iso.txt   | 29 ++++++++++++++++++++++
>> >  .../ubuntu-17.04-server-ppc64el.iso.txt            | 17 +++++++++++++
>> >  .../ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt  | 29 ++++++++++++++++++++++
>> >  7 files changed, 191 insertions(+)
>> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt
>> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt
>> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt
>> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt
>> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt
>> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt
>> >  create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt
>>
>> I'm facing some make check issues related to
>> "ubuntu-17.04-desktop-amd64.iso.txt" (would you mind checking whether
>> you can see the same issue on your system?)
>>
>> You'll have to move these files under tests dir instead of test due to
>> the changes done in the commit a409a71b2c5
>
> If I move the data according to the recent test -> tests renaming, they
> seem to be working here.  I'll refresh this patch so it can be tested
> cleanly.

Hmm. Testing against a fresh osinfo-db build imported in the system,
for some reason, makes the test-isodetect fail with:

Running suite(s): List
78%: Checks: 14, Failures: 3, Errors: 0
test-isodetect.c:354:F:Core:test_rhel:0: ISO
RHEL-6.9-20170309.0-Server-x86_64-dvd1.iso.txt was not matched by OS
rhel6.9
test-isodetect.c:354:F:Core:test_ubuntu:0: ISO
ubuntu-17.04-desktop-amd64.iso.txt was not matched by OS ubuntu17.04
test-isodetect.c:354:F:Core:test_centos:0: ISO
CentOS-6.8-x86_64-netinstall.iso.txt was not matched by OS centos6.8
FAIL test-isodetect (exit status: 1)

The test passes when setting OSINFO_SYSTEM_DIR to my osinfo-db/data
folder though.

Anyways, I'm acking and pushing these 2 patches.
-- 
Fabiano Fid?ncio



From cfergeau at redhat.com  Thu May  4 14:00:20 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 4 May 2017 16:00:20 +0200
Subject: [Libosinfo] [osinfo-db 1/2] install-script,
 suse: Add install-scripts for SLES 12+
In-Reply-To: <CAK9pz9Jnx2juf7ndaxc1yb_hvggP7YJqYk3E21trGVPkwBdcsA@mail.gmail.com>
References: <20170422224131.9328-1-fidencio@redhat.com>
	<20170422224131.9328-2-fidencio@redhat.com>
	<20170502114847.zk475mig35fc3m4u@edamame.cdg.redhat.com>
	<CAK9pz9Jnx2juf7ndaxc1yb_hvggP7YJqYk3E21trGVPkwBdcsA@mail.gmail.com>
Message-ID: <20170504140020.a2mfjmksw7lkfjgn@edamame.cdg.redhat.com>

On Tue, May 02, 2017 at 09:25:00PM +0200, Fabiano Fid?ncio wrote:
> On Tue, May 2, 2017 at 1:48 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Sun, Apr 23, 2017 at 12:41:30AM +0200, Fabiano Fid?ncio wrote:
> >> The install-scripts added support SLES 12, SLES 12 SP1 and SLES 12 SP2.
> >>
> >> Those scripts were completely based on the openSUSE ones and tested
> >> against the "free for download" ISOs provided by SUSE, that you can find
> >> in: https://www.suse.com/download-linux/
> >>
> >> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> >> ---
> >>  .../suse.com/suse-autoyast-desktop.xml.in          | 287 +++++++++++++++++++++
> >>  .../suse.com/suse-autoyast-jeos.xml.in             | 201 +++++++++++++++
> >>  data/os/suse.com/sles-12.1.xml.in                  |   7 +-
> >>  data/os/suse.com/sles-12.2.xml.in                  |  13 +-
> >>  data/os/suse.com/sles-12.xml.in                    |   7 +-
> >>  5 files changed, 509 insertions(+), 6 deletions(-)
> >>  create mode 100644 data/install-script/suse.com/suse-autoyast-desktop.xml.in
> >>  create mode 100644 data/install-script/suse.com/suse-autoyast-jeos.xml.in
> >>
> >> diff --git a/data/install-script/suse.com/suse-autoyast-desktop.xml.in b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> >> new file mode 100644
> >> index 0000000..acb38c1
> >> --- /dev/null
> >> +++ b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> >> @@ -0,0 +1,287 @@
> >> +<libosinfo version="0.0.1">
> >> +<!-- Licensed under the GNU General Public License version 2 or later.
> >> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> >> +
> >> +  <!-- DESKTOP PROFILE -->
> >> +  <install-script id='http://suse.com/suse/autoyast/desktop'>
> >> +    <profile>desktop</profile>
> >> +    <expected-filename>autoinst.xml</expected-filename>
> >> +    <config>
> >> +      <!-- Localization options -->
> >> +      <param name="l10n-keyboard" policy="optional" value-map="http://x.org/x11-keyboard"/>
> >> +      <param name="l10n-language" policy="optional"/>
> >> +      <param name="l10n-timezone" policy="optional"/>
> >> +
> >> +      <!-- Network options -->
> >> +      <param name="hostname" policy="optional"/>
> >> +      <param name="domain" policy="optional"/>
> >> +
> >> +      <!-- Account options -->
> >> +      <param name="admin-password" policy="optional"/>
> >> +      <param name="user-fullname" policy="optional"/>
> >> +      <param name="user-login" policy="required"/>
> >> +      <param name="user-password" policy="optional"/>
> >> +      <param name="avatar-location" policy="optional"/>
> >> +      <param name="avatar-disk" policy="optional"/>
> >> +    </config>
> >> +    <injection-method>disk</injection-method>
> >> +
> >> +    <template>
> >> +      <xsl:stylesheet
> >> +        xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
> >> +        version="1.0">
> >> +
> >> +        <xsl:output method="xml" indent="yes" omit-xml-declaration="yes"/>
> >> +
> >> +        <xsl:template name="l10n-language">
> >> +          <xsl:choose>
> >> +            <xsl:when test="config/l10n-language != '' and config/l10n-language != 'C'">
> >> +              <xsl:value-of select="config/l10n-language"/>
> >> +            </xsl:when>
> >> +            <xsl:otherwise>
> >> +              <xsl:text>en_US</xsl:text>
> >> +            </xsl:otherwise>
> >> +          </xsl:choose>
> >> +        </xsl:template>
> >> +
> >> +        <xsl:template name="l10n-keyboard">
> >> +          <xsl:choose>
> >> +            <xsl:when test="config/l10n-keyboard != '' and config/l10n-keyboard != 'C'">
> >> +              <xsl:value-of select="config/l10n-keyboard"/>
> >> +            </xsl:when>
> >> +            <xsl:otherwise>
> >> +              <xsl:text>us</xsl:text>
> >> +            </xsl:otherwise>
> >> +          </xsl:choose>
> >> +        </xsl:template>
> >> +
> >> +        <xsl:template match="/command-line">
> >> +            <xsl:text>autoyast=device://sda/</xsl:text>
> >
> > I guess vda is not valid there?
> 
> Nops. That's the same case for OpenSUSE.
> 
> >
> >> +            <xsl:value-of select="script/expected-filename"/>
> >> +        </xsl:template>
> >> +
> >> +        <xsl:template match="/install-script-config">
> >> +          <profile xmlns="http://www.suse.com/1.0/yast2ns" xmlns:config="http://www.suse.com/1.0/configns">
> >> +            <bootloader>
> >> +              <device_map config:type="list">
> >> +                <device_map_entry>
> >> +                  <firmware>hd0</firmware>
> >> +                  <linux>/dev/vda</linux>
> >> +                </device_map_entry>
> >> +              </device_map>
> >> +              <global>
> >> +                <activate>true</activate>
> >> +                <append>resume=/dev/vda1 splash=silent quiet showopts</append>
> >> +                <boot_boot>false</boot_boot>
> >> +                <boot_extended>false</boot_extended>
> >> +                <boot_mbr>false</boot_mbr>
> >> +                <boot_root>true</boot_root>
> >> +                <default>0</default>
> >> +                <distributor/>
> >> +                <failsafe_disabled>true</failsafe_disabled>
> >> +                <generic_mbr>true</generic_mbr>
> >> +                <gfxmode>auto</gfxmode>
> >> +                <os_prober>true</os_prober>
> >> +                <terminal>gfxterm</terminal>
> >> +                <timeout config:type="integer">8</timeout>
> >> +                <vgamode/>
> >> +              </global>
> >> +              <loader_type>grub2</loader_type>
> >> +            </bootloader>
> >> +            <firewall>
> >> +              <enable_firewall config:type="boolean">false</enable_firewall>
> >> +              <start_firewall config:type="boolean">false</start_firewall>
> >> +            </firewall>
> >
> > Any particular reason to disable firewall?
> 
> No particular reason. I'll remove it in a v2.
> 
> >
> >> +            <general>
> >> +              <ask-list config:type="list"/>
> >> +              <mode>
> >> +                <confirm config:type="boolean">false</confirm>
> >> +                <final_reboot config:type="boolean">true</final_reboot>
> >> +              </mode>
> >> +              <proposals config:type="list"/>
> >> +              <signature-handling>
> >> +                <accept_file_without_checksum config:type="boolean">true</accept_file_without_checksum>
> >> +                <accept_non_trusted_gpg_key config:type="boolean">true</accept_non_trusted_gpg_key>
> >> +                <accept_unknown_gpg_key config:type="boolean">true</accept_unknown_gpg_key>
> >> +                <accept_unsigned_file config:type="boolean">true</accept_unsigned_file>
> >> +                <accept_verification_failed config:type="boolean">false</accept_verification_failed>
> >> +                <import_gpg_key config:type="boolean">true</import_gpg_key>
> >> +              </signature-handling>
> >
> > This seems fairly unsecure too, is this required?
> 
> Hmm. I'll double check, but I do believe I can drop those for SLES.
> 
> >
> >
> >> +              <storage>
> >> +                <partition_alignment config:type="symbol">align_optimal</partition_alignment>
> >> +                <start_multipath config:type="boolean">false</start_multipath>
> >> +              </storage>
> >> +            </general>
> >> +            <keyboard>
> >> +              <keyboard_values>
> >> +                <delay/>
> >> +                <discaps config:type="boolean">false</discaps>
> >> +                <numlock>bios</numlock>
> >> +                <rate/>
> >> +              </keyboard_values>
> >> +              <keymap><xsl:call-template name="l10n-keyboard"/></keymap>
> >> +            </keyboard>
> >> +            <language><xsl:call-template name="l10n-language"/></language>
> >> +          <networking>
> >> +            <managed config:type="boolean">false</managed>
> >> +            <interfaces  config:type="list">
> >> +              <interface>
> >> +                <bootproto>dhcp</bootproto>
> >> +                  <device>eth0</device>
> >> +                  <startmode>auto</startmode>
> >> +                  <usercontrol>no</usercontrol>
> >> +                </interface>
> >> +            </interfaces>
> >> +          </networking>
> >> +          <partitioning config:type="list">
> >> +            <drive>
> >> +              <device>/dev/vda</device>
> >> +              <type config:type="symbol">CT_DISK</type>
> >> +              <use>all</use>
> >> +            </drive>
> >> +          </partitioning>
> >> +            <report>
> >> +              <errors>
> >> +                <log config:type="boolean">true</log>
> >> +                <show config:type="boolean">true</show>
> >> +                <timeout config:type="integer">0</timeout>
> >> +              </errors>
> >> +              <messages>
> >> +                <log config:type="boolean">true</log>
> >> +                <show config:type="boolean">true</show>
> >> +                <timeout config:type="integer">10</timeout>
> >> +              </messages>
> >> +              <warnings>
> >> +                <log config:type="boolean">true</log>
> >> +                <show config:type="boolean">true</show>
> >> +                <timeout config:type="integer">10</timeout>
> >> +              </warnings>
> >> +              <yesno_messages>
> >> +                <log config:type="boolean">true</log>
> >> +                <show config:type="boolean">true</show>
> >> +                <timeout config:type="integer">10</timeout>
> >> +              </yesno_messages>
> >> +            </report>
> >> +            <scripts>
> >> +              <chroot-scripts config:type="list">
> >> +                <script>
> >> +                  <chrooted config:type="boolean">true</chrooted>
> >> +                  <source>
> >> +
> >> +if test -z '<xsl:value-of select="config/user-password"/>'; then
> >> +pam-config -a --unix-nullok
> >> +pam-config -a --nullok
> >
> > Shouldn't this be conditional on the SUSE version as done below?
> 
> Nops. It's needed for all versions to allow setting a user with no password.
> 
> >
> >> +
> >> +<xsl:if test="os/version = 12">
> >> +useradd <xsl:value-of select="config/user-login"/> -m -G users
> >> +passwd -d <xsl:value-of select="config/user-login"/>
> >> +</xsl:if>
> >
> > Does this mean we are not setting a password on older suse?
> 
> There's no older SUSE script at this point.
> 
> For 12 SP1 and 12 SP2 we can do this using the <users> XML tag, while
> for 12 the only way that worked was by actually adding the user as
> done above.
> 
> >
> >> +
> >> +#Enable passwordless login for users that are part of the nopasswdlogin group
> >> +sed -i '4 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm-password
> >> +fi
> >> +
> >> +if test -n '<xsl:value-of select="config/avatar-location"/>'; then
> >> +# Set user avatar
> >> +mkdir /mnt/unattended-media
> >> +mount <xsl:value-of select='config/avatar-disk'/> /mnt/unattended-media
> >> +cp /mnt/unattended-media<xsl:value-of select="config/avatar-location"/> /var/lib/AccountsService/icons/<xsl:value-of select="config/user-login"/>
> >> +umount /mnt/unattended-media
> >> +
> >> +echo "
> >> +[User]
> >> +Language=<xsl:value-of select="config/l10n-language"/>.UTF-8
> >> +XSession=gnome
> >> +Icon=/var/lib/AccountsService/icons/<xsl:value-of select="config/user-login"/>
> >> +" >> /var/lib/AccountsService/users/<xsl:value-of select="config/user-login"/>
> >> +fi
> >> +                  </source>
> >> +                </script>
> >> +              </chroot-scripts>
> >> +            </scripts>
> >> +            <services-manager>
> >> +              <default_target>graphical</default_target>
> >> +            </services-manager>
> >> +            <software>
> >> +              <packages config:type="list">
> >> +                <package>autoyast2-installation</package>
> >> +                <package>gdm</package>
> >> +              </packages>
> >> +              <patterns config:type="list">
> >> +                <pattern>Minimal</pattern>
> >> +                <pattern>apparmor</pattern>
> >> +                <pattern>base</pattern>
> >> +                <pattern>gnome-basic</pattern>
> >> +                <pattern>printing</pattern>
> >> +                <xsl:if test="os/version &gt; 12">
> >> +                  <pattern>smt</pattern>
> >> +                </xsl:if>
> >> +                <pattern>x11</pattern>
> >> +              </patterns>
> >> +            </software>
> >> +            <sysconfig config:type="list">
> >> +              <sysconfig_entry>
> >> +                <sysconfig_key>DISPLAYMANAGER</sysconfig_key>
> >> +                <sysconfig_path>/etc/sysconfig/displaymanager</sysconfig_path>
> >> +                <sysconfig_value>gdm</sysconfig_value>
> >> +              </sysconfig_entry>
> >> +              <sysconfig_entry>
> >> +                <sysconfig_key>DEFAULT_WM</sysconfig_key>
> >> +                <sysconfig_path>/etc/sysconfig/windowmanager</sysconfig_path>
> >> +                <sysconfig_value>gnome</sysconfig_value>
> >> +              </sysconfig_entry>
> >> +            </sysconfig>
> >> +            <timezone>
> >> +              <hwclock>UTC</hwclock>
> >> +              <timezone><xsl:value-of select="config/l10n-timezone"/></timezone>
> >> +            </timezone>
> >> +            <user_defaults>
> >> +              <expire/>
> >> +              <group>100</group>
> >> +              <groups/>
> >> +              <home>/home</home>
> >> +              <inactive>-1</inactive>
> >> +              <no_groups config:type="boolean">true</no_groups>
> >> +              <shell>/bin/bash</shell>
> >> +              <skel>/etc/skel</skel>
> >> +              <umask>022</umask>
> >> +            </user_defaults>
> >
> > Same question, a bit below you check for suse version before allowing
> > empty passwords, should the condition be here too?
> 
> That's not the case here. The group "nopasswdlogin" must be created in
> any SLES version in order to allow passwordless login.
> 
> >
> >> +            <xsl:if test="config/user-password = ''">
> >> +              <groups config:type="list">
> >> +                <group>
> >> +                  <group_password>x</group_password>
> >> +                  <groupname>nopasswdlogin</groupname>
> >> +                  <userlist><xsl:value-of select="config/user-login"/></userlist>
> >> +                </group>
> >> +              </groups>
> >> +            </xsl:if>
> >> +            <users config:type="list">
> >> +              <user>
> >> +                <encrypted config:type="boolean">false</encrypted>
> >> +                <fullname>root</fullname>
> >> +                <gid>0</gid>
> >> +                <home>/root</home>
> >> +                <shell>/bin/bash</shell>
> >> +                <uid>0</uid>
> >> +                <user_password><xsl:value-of select="config/admin-password"/></user_password>
> >> +                <username>root</username>
> >> +              </user>
> >> +              <!--
> >> +                While SLES 12 doesn't allow creating a user without a password,
> >> +                it's okay to do so on the newer versions
> >> +                -->
> >> +              <xsl:if test="config/user-password != '' or os/version &gt; 12">
> >> +                <user>
> >> +                  <encrypted config:type="boolean">false</encrypted>
> >> +                  <fullname><xsl:value-of select="config/user-fullname"/></fullname>
> >> +                  <user_password><xsl:value-of select="config/user-password"/></user_password>
> >> +                  <username><xsl:value-of select="config/user-login"/></username>
> >> +                </user>
> >> +              </xsl:if>
> >
> > So we don't set a user password on older suse?
> 
> We do!
> 
> At this point the only supported versions are:
> SLES 12:
>  - passwordless users must be created by useradd
>  - normal user creating can be done through <user> XML tag
> SLES 12 SP1 and SLES 12 SP2:
>  - both normal and passwordless users can be created through the
> <user> XML tag.

Ok, so I think it's the comment which confused me:
+              <!--
+                While SLES 12 doesn't allow creating a user without a password,
+                it's okay to do so on the newer versions
+                -->

It doesn't allow creating a user without a password *in this <user>
section*, this needs to be done with useradd instead (I'd add a similar
comment before the useradd part).

It's more clear to me now, thanks!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170504/03563da9/attachment.sig>

From cfergeau at redhat.com  Thu May  4 14:03:57 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 4 May 2017 16:03:57 +0200
Subject: [Libosinfo] [osinfo-db 2/2] install-script,
 suse: Add install-scripts for SLES 11 SP4
In-Reply-To: <CAK9pz9Jm-EX1rVGAvoJG_XSwQsH5kLKg-ms8OFMjHR3W_=1JdA@mail.gmail.com>
References: <20170422224131.9328-1-fidencio@redhat.com>
	<20170422224131.9328-3-fidencio@redhat.com>
	<20170502110751.srzsn3w6fg7oqh7k@edamame.cdg.redhat.com>
	<CAK9pz9Jm-EX1rVGAvoJG_XSwQsH5kLKg-ms8OFMjHR3W_=1JdA@mail.gmail.com>
Message-ID: <20170504140357.ydlopy2ihnwh4tce@edamame.cdg.redhat.com>

On Tue, May 02, 2017 at 09:33:26PM +0200, Fabiano Fid?ncio wrote:
> On Tue, May 2, 2017 at 1:07 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Sun, Apr 23, 2017 at 12:41:31AM +0200, Fabiano Fid?ncio wrote:
> >> Some small changes have been done in the bootloader and in the patterns
> >> currently used for SLES 12+ in order to also support the "old" SLES 11
> >> SP4.
> >>
> >> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> >> ---
> >>  .../suse.com/suse-autoyast-desktop.xml.in          | 34 ++++++++++++++++++++--
> >>  .../suse.com/suse-autoyast-jeos.xml.in             |  9 +++++-
> >>  data/os/suse.com/sles-11.4.xml.in                  |  9 ++++--
> >>  3 files changed, 47 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/data/install-script/suse.com/suse-autoyast-desktop.xml.in b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> >> index acb38c1..381d621 100644
> >> --- a/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> >> +++ b/data/install-script/suse.com/suse-autoyast-desktop.xml.in
> >> @@ -86,7 +86,14 @@
> >>                  <timeout config:type="integer">8</timeout>
> >>                  <vgamode/>
> >>                </global>
> >> -              <loader_type>grub2</loader_type>
> >> +              <xsl:choose>
> >> +                <xsl:when test="os/version &lt; 12">
> >> +                  <loader_type>grub</loader_type>
> >> +                </xsl:when>
> >> +                <xsl:otherwise>
> >> +                  <loader_type>grub2</loader_type>
> >> +                </xsl:otherwise>
> >> +              </xsl:choose>
> >>              </bootloader>
> >>              <firewall>
> >>                <enable_firewall config:type="boolean">false</enable_firewall>
> >> @@ -172,13 +179,20 @@ if test -z '<xsl:value-of select="config/user-password"/>'; then
> >>  pam-config -a --unix-nullok
> >>  pam-config -a --nullok
> >>
> >> -<xsl:if test="os/version = 12">
> >> +<xsl:if test="os/version &lt; 12.1">
> >
> > I'd squash this hunk in the first patch. Does this mean we are not
> > adding any users with older suse?
> 
> Nops. It means that as done for SLES 12, SLES 11 SP4 also has to have
> the passwordless user created using useradd.
> The reason that I've decided to not squash it into the first patch is
> that I didn't know that SLES 11 SP4 would have the same behaviour as
> SLES 12. /o\

Ah yeah, confused again, < 12.1 indeed means that you added 11.4 into
the mix.

> 
> I can squash if you prefer ...
> 
> >
> >>  useradd <xsl:value-of select="config/user-login"/> -m -G users
> >>  passwd -d <xsl:value-of select="config/user-login"/>
> >>  </xsl:if>
> >>
> >>  #Enable passwordless login for users that are part of the nopasswdlogin group
> >> +<xsl:choose>
> >> +  <xsl:when test="os/version &lt; 12">
> >> +sed -i '2 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm
> >> +  </xsl:when>
> >> +  <xsl:otherwise>
> >>  sed -i '4 i auth sufficient pam_succeed_if.so user ingroup nopasswdlogin' /etc/pam.d/gdm-password
> >> +  </xsl:otherwise>
> >> +</xsl:choose>
> >
> > Maybe you could match on the first empty line, and insert this line
> > before it to avoid the special casing here? (I don't have a suse at hand
> > to check this file content, tryin to guess after looking at my fedora
> > install).
> 
> AFAIR I've tried to so, but this line must be exactly before the line
> "auth required pam_unix.so". :-\

What about this then?

sed -i '/auth required pam_unix.so/ i auth sufficient pam_succeed_if.so
user ingroup nopasswdlogin' /etc/pam.d/gdm

Or are gdm/gdm-password sufficiently different that this would not work?

> 
> >
> >>  fi
> >>
> >>  if test -n '<xsl:value-of select="config/avatar-location"/>'; then
> >> @@ -213,6 +227,15 @@ fi
> >>                  <pattern>base</pattern>
> >>                  <pattern>gnome-basic</pattern>
> >>                  <pattern>printing</pattern>
> >
> > Shouldn't these 2 lines be removed?

Just making sure you did not miss this comment ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170504/967c833e/attachment.sig>

From cfergeau at redhat.com  Tue May 30 09:20:58 2017
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Tue, 30 May 2017 11:20:58 +0200
Subject: [Libosinfo] [libosinfo] build: Don't use private header for
	gir/vapi generation
Message-ID: <20170530092058.11803-1-cfergeau@redhat.com>

Using private headers when generating the gir/vapi files mean that they
are listing private methods which are not exported by the shared
library, as well as types which are not present in public headers, and
not meant to be used by external users.

This was noticed with recent vala.git as it started erroring out on the
ProductForeachFlag which is only  defined in osinfo_product_private.h

https://bugzilla.redhat.com/show_bug.cgi?id=1456709
---
 osinfo/Makefile.am | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/osinfo/Makefile.am b/osinfo/Makefile.am
index c915b577..5d952a13 100644
--- a/osinfo/Makefile.am
+++ b/osinfo/Makefile.am
@@ -105,7 +105,7 @@ nodist_libosinfo_1_0_include_HEADERS =	\
   osinfo_enum_types.h			\
   $(NULL)
 
-libosinfo_1_0_la_SOURCES =		\
+libosinfo_c_files =		\
   osinfo_avatar_format.c		\
   osinfo_datamap.c			\
   osinfo_datamaplist.c			\
@@ -118,16 +118,13 @@ libosinfo_1_0_la_SOURCES =		\
   osinfo_devicelinklist.c		\
   osinfo_devicelinkfilter.c		\
   osinfo_device_driver.c		\
-  osinfo_device_driver_private.h	\
   osinfo_device_driverlist.c		\
   osinfo_install_config.c		\
   osinfo_install_config_param.c		\
   osinfo_install_config_paramlist.c	\
   osinfo_install_script.c		\
-  osinfo_install_script_private.h	\
   osinfo_install_scriptlist.c		\
   osinfo_product.c			\
-  osinfo_product_private.h		\
   osinfo_productfilter.c		\
   osinfo_productlist.c			\
   osinfo_platform.c			\
@@ -139,7 +136,6 @@ libosinfo_1_0_la_SOURCES =		\
   osinfo_deployment.c			\
   osinfo_deploymentlist.c		\
   osinfo_media.c			\
-  osinfo_media_private.h		\
   osinfo_medialist.c			\
   osinfo_resources.c			\
   osinfo_resourceslist.c		\
@@ -147,9 +143,21 @@ libosinfo_1_0_la_SOURCES =		\
   osinfo_treelist.c			\
   osinfo_db.c				\
   osinfo_loader.c			\
+  $(NULL)
+
+libosinfo_private_header_files =	\
+  osinfo_device_driver_private.h	\
+  osinfo_install_script_private.h	\
+  osinfo_product_private.h		\
+  osinfo_media_private.h		\
   ignore-value.h			\
   $(NULL)
 
+libosinfo_1_0_la_SOURCES =		\
+  $(libosinfo_c_files)			\
+  $(libosinfo_private_header_files)	\
+  $(NULL)
+
 nodist_libosinfo_1_0_la_SOURCES =	\
   osinfo_enum_types.c			\
   $(NULL)
@@ -187,12 +195,13 @@ INTROSPECTION_GIRS =
 CLEANFILES =
 
 if HAVE_INTROSPECTION
+
 Libosinfo-1.0.gir: libosinfo-1.0.la
 Libosinfo_1_0_gir_INCLUDES = GObject-2.0 Gio-2.0 libxml2-2.0
 Libosinfo_1_0_gir_PACKAGES = gobject-2.0 gio-2.0 libxml-2.0 libxslt
 Libosinfo_1_0_gir_EXPORT_PACKAGES = libosinfo-1.0
 Libosinfo_1_0_gir_LIBS = libosinfo-1.0.la
-Libosinfo_1_0_gir_FILES = $(libosinfo_1_0_include_HEADERS) $(nodist_libosinfo_1_0_include_HEADERS) $(libosinfo_1_0_la_SOURCES) $(nodist_libosinfo_1_0_la_SOURCES)
+Libosinfo_1_0_gir_FILES = $(libosinfo_1_0_include_HEADERS) $(nodist_libosinfo_1_0_include_HEADERS) $(libosinfo_c_files) $(nodist_libosinfo_1_0_la_SOURCES)
 Libosinfo_1_0_gir_CFLAGS = $(libosinfo_1_0_la_CFLAGS)
 Libosinfo_1_0_gir_SCANNERFLAGS = --identifier-prefix=Osinfo --symbol-prefix=osinfo --c-include="osinfo/osinfo.h"
 INTROSPECTION_GIRS += Libosinfo-1.0.gir
-- 
2.13.0



From berrange at redhat.com  Tue May 30 09:22:07 2017
From: berrange at redhat.com (Daniel P. Berrange)
Date: Tue, 30 May 2017 10:22:07 +0100
Subject: [Libosinfo] [libosinfo] build: Don't use private header for
 gir/vapi generation
In-Reply-To: <20170530092058.11803-1-cfergeau@redhat.com>
References: <20170530092058.11803-1-cfergeau@redhat.com>
Message-ID: <20170530092207.GE21566@redhat.com>

On Tue, May 30, 2017 at 11:20:58AM +0200, Christophe Fergeau wrote:
> Using private headers when generating the gir/vapi files mean that they
> are listing private methods which are not exported by the shared
> library, as well as types which are not present in public headers, and
> not meant to be used by external users.
> 
> This was noticed with recent vala.git as it started erroring out on the
> ProductForeachFlag which is only  defined in osinfo_product_private.h
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1456709
> ---
>  osinfo/Makefile.am | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)

ACK


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|