[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [libosinfo PATCH 2/3] build: make curl optional, and only for tests



Hey,

On Tue, Oct 17, 2017 at 04:39:38PM +0100, Daniel P. Berrange wrote:
> On Tue, Oct 17, 2017 at 05:23:32PM +0200, Pino Toscano wrote:
> > Look for curl only when the tests are enabled, and as optional build
> > dependency.  If curl is missing, then the two network tests are not
> > built.  Also, limit the use of curl CFLAGS/LIBS only for the tests that
> > really need it.
> > 
> > As side result, it is possible to drop the curl BuildRequires from the
> > mingw spec, as it builds with --enable-tests=no.
> > 
> > Signed-off-by: Pino Toscano <ptoscano redhat com>
> 
> Reviewed-by: Daniel P. Berrange <berrange redhat com>
> 
> 
> If someone feels motivated it would be nice to try and convert our
> tests to use GIO for networking, if possible, so we don't need extra
> libraries.

The tests used to be using libsoup (which also counts as an extra
library), this was switched to curl in b61be04 because the former does
not support ftp. I was able to get a FTP FreeBSD ISO with
gio mount ftp://ftp.freebsd.org/
gio copy ftp://ftp.freebsd.org/pub/FreeBSD/releases/ISO-IMAGES/11.0/FreeBSD-11.0-RELEASE-amd64-dvd1.iso .
gio mount -u ftp://ftp.freebsd.org/
so it should indeed be possible to cook up something with GIO (provided
the needed GVFS backends are installed).

> Also I wonder we want an explicit --disable-network-tests to disable
> just the tests which involve networking, for sake of build envs which
> don't allow networking.

By default, the tests which need networking are only run if
LIBOSINFO_NETWORK_TESTS is in the environment, --disable-network-tests
could be useful in making this more visible indeed, though the network
tests are so long that they'd be disabled most of the time.

Christophe

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]