[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [libosinfo PATCH 3/3] README: document "check" for tests



On Tuesday, 17 October 2017 17:40:19 CEST Daniel P. Berrange wrote:
> On Tue, Oct 17, 2017 at 05:23:33PM +0200, Pino Toscano wrote:
> > "check" is required when building the tests (which are enabled by
> > default), so document it.
> > 
> > Signed-off-by: Pino Toscano <ptoscano redhat com>
> > ---
> >  README | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/README b/README
> > index 1a0fa2e..11063ca 100644
> > --- a/README
> > +++ b/README
> > @@ -19,6 +19,7 @@ Dependencies
> >  ============
> >  
> >  - Required:
> > +  - check (for tests only)
> >    - gobject-2.0
> >    - gio-2.0
> >    - libxml-2.0
> 
> Reviewed-by: Daniel P. Berrange <berrange redhat com>
> 
> 
> Another future thing we should do is rewrite tests to use glib's native
> unit test infrastructure and ditch 'check' entirely.

Actually I withdraw this patch, since I'm going to send a conversion of
the tests to the GLib test framework.

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]