[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework



On Thu, Oct 19, 2017 at 03:33:33PM +0200, Pino Toscano wrote:
> On Thursday, 19 October 2017 15:14:24 CEST Pino Toscano wrote:
> > GLib has shipped a testing framework for many years already, so we can
> > make use of it, replacing the external "check".
> > 
> > The conversion only switches framework without changing the structure of
> > the tests, making use of the more appropriate assertion in the various
> > places.
> > 
> > Signed-off-by: Pino Toscano <ptoscano redhat com>
> > ---
> 
> Meh, I suck, I accentally pushed it (see why I did not wanted powers!).
> Apologies.
> 
> I can revert it right now, if needed.  Otherwise, if there are just
> small edges to smooth, I can post cleanup patches.  Let me know.

Its not a problem - it all looks fine to me - I just had one RFE
suggestion

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]