[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH] Marginally simplify the code to create and run a GMainLoop



Hey,

On Mon, Oct 16, 2017 at 02:20:59PM +0200, Christophe Fergeau wrote:
> Just took another look at it, and we don't have this situation currently
> in libosinfo codebase, so your patch should be fine.
> 
> Acked-by: Christophe Fergeau <cfergeau redhat com>

My point was that this situation should never arise in any
asynchronous API in the first place. :)

GTask makes it pretty hard to get into this situation. Otherwise we
could have even asserted against this eventuality.

The documentation around how a GAsyncReadyCallback should be invoked
has been clarified now:
  https://bugzilla.gnome.org/show_bug.cgi?id=783825

> Have you sent the follow-up that you mention to use a non-default
> GMainContext for these operations? I have memories of seeing such a
> patch, but could not find it on the mailing list.

I never sent it to the mailing list because I was going to base it on
this initial simplification. I'll do it as soon as I have some time. I
guess I should also rebase this one against current master.

By the way, I don't have commit access, so somebody has to push the
patches for me.

Cheers,
Rishi


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]