[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH osinfo-db 0/9] Add q35 devices



On Wed, Aug 29, 2018 at 05:54:38PM -0400, Cole Robinson wrote:
> The main goal of this series is to advertise q35 chipset and device
> support for suitable OS. Some details about the individual decisions
> 
> * We group q35+ich9+e1000e together. This likely isn't completely
>   accurate but in the virt case I think it only makes sense to
>   specify the latter two devices when pcie (q35) is present, so
>   I went with it.

It is good enough to start off with. Better to not report it where
it can be supported, than to mistakenly report it when it cannot
be supported, as the latter leads to install failures.

> * We only advertise q35 when virtio1.0 devices are available, on linux.
>   This definitely isn't accurate, q35 predates virtio1.0 by 8 years or
>   so, but there's issues combining q35 with legacy virtio, and that's
>   the only combo I'll be exploring for virt-manager so other scenarios
>   my go untested.

IMHO the issue combining q35 with virtio 0.9 should be handled by
looking at the supported devices.

ie if the OS reports q35 support, but does *not* support virtio-1.0-xxxx
device support, then the app should not use q35.

This allows the app to decide to use q35 if they know they are going
to use non-virtio devices.


What I think is missing here though is the explicit reporting of
i440fx support.

By not including i440fx info here we are forcing apps to use
the lack of info as meaning i440fx. This means that when new
OS are released, until we add info on that new OS, the app
is going to fallback to i440fx. This is undesirable - we want
mgmt apps to fallback to q35 on the basis that new OS should
get the new chipset if nothing is known.

> * The actual OS+q35 combos are largely untested by me
> 
> Patch 1-2 are some prep cleanups
> Patch 3-4 add more virtio1.0 annotations
> Patch 5-7 add the new device files
> Patch 8-9 add the new devices to os files
> 
> 
> Cole Robinson (9):
>   os: Add a name comment with every <device> block
>   suse: Remove redundant virtio1.0 <device>
>   ubuntu: Add virtio1.0 devices for 17.04+
>   redhat: Add virtio1.0 devices for rhel7.2+
>   device: Add chipset q35
>   device: Add network e1000e
>   device: Add sound ich9
>   os: Add q35/e1000e/ich9 for win2k8r2+ and win7+
>   os: linux: Add q35/ich9/e1000e alongside virtio1.0 <device>
> 
>  .../pcisig.com/pci-8086-10d3.d/class.xml.in   |  8 +++
>  .../pcisig.com/pci-8086-293e.d/class.xml.in   |  8 +++
>  .../pcisig.com/pci-8086-29c0.d/class.xml.in   |  8 +++
>  data/os/altlinux.org/altlinux-5.0.xml.in      |  4 +-
>  data/os/altlinux.org/altlinux-6.0.xml.in      |  2 +-
>  data/os/debian.org/debian-5.xml.in            |  4 +-
>  data/os/debian.org/debian-6.xml.in            |  2 +-
>  data/os/debian.org/debian-7.xml.in            |  4 +-
>  data/os/debian.org/debian-9.xml.in            | 19 +++---
>  data/os/fedoraproject.org/fedora-1.xml.in     |  4 +-
>  data/os/fedoraproject.org/fedora-11.xml.in    |  2 +-
>  data/os/fedoraproject.org/fedora-23.xml.in    |  5 +-
>  data/os/fedoraproject.org/fedora-24.xml.in    |  2 +-
>  data/os/fedoraproject.org/fedora-9.xml.in     |  1 -
>  data/os/freebsd.org/freebsd-6.0.xml.in        |  2 +-
>  data/os/freebsd.org/freebsd-8.0.xml.in        |  2 +-
>  .../os/gnome.org/gnome-continuous-3.10.xml.in |  6 +-
>  data/os/mageia.org/mageia-1.xml.in            |  6 +-
>  data/os/mandriva.com/mandriva-2010.0.xml.in   |  4 +-
>  data/os/mandriva.com/mes-5.1.xml.in           |  4 +-
>  data/os/microsoft.com/win-10.xml.in           |  2 +-
>  data/os/microsoft.com/win-2k.xml.in           |  8 +--
>  data/os/microsoft.com/win-7.xml.in            | 29 +++++----
>  data/os/microsoft.com/win-8.1.xml.in          |  2 +-
>  data/os/microsoft.com/win-8.xml.in            |  2 +-
>  data/os/microsoft.com/win-95.xml.in           |  8 +--
>  data/os/microsoft.com/win-xp.xml.in           | 24 +++----
>  data/os/openbsd.org/openbsd-4.9.xml.in        |  2 +-
>  data/os/opensuse.org/opensuse-10.2.xml.in     |  2 +-
>  data/os/opensuse.org/opensuse-11.1.xml.in     |  2 +-
>  data/os/opensuse.org/opensuse-12.3.xml.in     | 12 ++--
>  data/os/opensuse.org/opensuse-15.0.xml.in     | 21 +++---
>  data/os/opensuse.org/opensuse-42.2.xml.in     | 21 +++---
>  data/os/opensuse.org/opensuse-42.3.xml.in     | 12 ----
>  .../opensuse.org/opensuse-tumbleweed.xml.in   | 37 ++++++-----
>  data/os/redhat.com/rhel-5.6.xml.in            |  4 +-
>  data/os/redhat.com/rhel-6.0.xml.in            |  6 +-
>  data/os/redhat.com/rhel-7.0.xml.in            |  6 +-
>  data/os/redhat.com/rhel-7.2.xml.in            | 14 ++++
>  data/os/redhat.com/rhel-atomic-7.0.xml.in     |  6 +-
>  data/os/sun.com/opensolaris-2009.06.xml.in    |  2 +-
>  data/os/sun.com/solaris-10.xml.in             |  2 +-
>  data/os/suse.com/sled-10.2.xml.in             |  2 +-
>  data/os/suse.com/sled-11.3.xml.in             | 16 ++---
>  data/os/suse.com/sled-11.xml.in               |  2 +-
>  data/os/suse.com/sled-12.2.xml.in             | 21 +++---
>  data/os/suse.com/sled-12.3.xml.in             | 12 ----
>  data/os/suse.com/sles-10.2.xml.in             |  2 +-
>  data/os/suse.com/sles-11.3.xml.in             | 16 ++---
>  data/os/suse.com/sles-11.xml.in               |  2 +-
>  data/os/suse.com/sles-12.2.xml.in             | 21 +++---
>  data/os/suse.com/sles-12.3.xml.in             | 12 ----
>  data/os/ubuntu.com/ubuntu-17.04.xml.in        | 14 ++++
>  data/os/ubuntu.com/ubuntu-5.04.xml.in         |  2 +-
>  data/os/ubuntu.com/ubuntu-8.04.xml.in         |  2 +-
>  data/os/ubuntu.com/ubuntu-9.04.xml.in         |  2 +-
>  data/platform/qemu.org/qemu-1.0.xml.in        | 65 +++++++------------
>  .../redhat.com/xen-rhel-3.0.3.5.0.xml.in      |  2 +-
>  data/platform/xen.org/xen-3.0.2.xml.in        |  6 +-
>  data/platform/xen.org/xen-3.0.4.xml.in        |  2 +-
>  data/schema/osinfo.rng.in                     |  1 +
>  61 files changed, 271 insertions(+), 252 deletions(-)
>  create mode 100644 data/device/pcisig.com/pci-8086-10d3.d/class.xml.in
>  create mode 100644 data/device/pcisig.com/pci-8086-293e.d/class.xml.in
>  create mode 100644 data/device/pcisig.com/pci-8086-29c0.d/class.xml.in
> 
> -- 
> 2.17.1
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo redhat com
> https://www.redhat.com/mailman/listinfo/libosinfo

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]