[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH osinfo-db 5/9] device: Add chipset q35



On Wed, Aug 29, 2018 at 05:54:43PM -0400, Cole Robinson wrote:
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
> Is class 'chipset' fine for q35? The actual PCI ID is for
>     ' 82G33/G31/P35/P31 Express DRAM Controller'

Awesome, it appears that QEMU has screwed up and actually implemented
a P35 chipset, but called it Q35 :-)

They are mostly the same but Q35 has integrated graphics and VT-D,
neither of which QEMU implemented, so....

>  data/device/pcisig.com/pci-8086-29c0.d/class.xml.in | 8 ++++++++
>  data/schema/osinfo.rng.in                           | 1 +
>  2 files changed, 9 insertions(+)
>  create mode 100644 data/device/pcisig.com/pci-8086-29c0.d/class.xml.in
> 
> diff --git a/data/device/pcisig.com/pci-8086-29c0.d/class.xml.in b/data/device/pcisig.com/pci-8086-29c0.d/class.xml.in
> new file mode 100644
> index 0000000..2ac4515
> --- /dev/null
> +++ b/data/device/pcisig.com/pci-8086-29c0.d/class.xml.in
> @@ -0,0 +1,8 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <device id="http://pcisig.com/pci/8086/29c0";>
> +    <name>q35</name>

... now we have the question of whether libosinfo should tell the
truth here <name>p35</name>, or should lie to match QEMU "q35".

I'm inclined to have libosinfo tell the truth, because we are
filling out the rest of the device information by pulling in
the pci.ids file data, and this will be saying P35 for the
description.

> +    <class>chipset</class>
> +  </device>
> +</libosinfo>
> diff --git a/data/schema/osinfo.rng.in b/data/schema/osinfo.rng.in
> index 843519d..1bb822e 100644
> --- a/data/schema/osinfo.rng.in
> +++ b/data/schema/osinfo.rng.in
> @@ -76,6 +76,7 @@
>              <choice>
>                <value>audio</value>
>                <value>block</value>
> +              <value>chipset</value>
>                <value>console</value>
>                <value>filesystem</value>
>                <value>input</value>
> -- 
> 2.17.1
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo redhat com
> https://www.redhat.com/mailman/listinfo/libosinfo

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]