[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [PATCH osinfo-db 7/9] device: Add sound ich9



On Wed, Aug 29, 2018 at 05:54:45PM -0400, Cole Robinson wrote:
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  data/device/pcisig.com/pci-8086-293e.d/class.xml.in | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 data/device/pcisig.com/pci-8086-293e.d/class.xml.in
> 
> diff --git a/data/device/pcisig.com/pci-8086-293e.d/class.xml.in b/data/device/pcisig.com/pci-8086-293e.d/class.xml.in
> new file mode 100644
> index 0000000..6326a4d
> --- /dev/null
> +++ b/data/device/pcisig.com/pci-8086-293e.d/class.xml.in
> @@ -0,0 +1,8 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <device id="http://pcisig.com/pci/8086/293e";>
> +    <name>ich9</name>

ich9 is a general chipset name, so is ambiguous. In particular it is also
the name of the USB controllers

So we should likely give it the name 'ich9-hda' to distinguish it from
USB

> +    <class>audio</class>
> +  </device>
> +</libosinfo>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]