[Libosinfo] [libosinfo PATCH 0/4] Properly detect whether PPC ISOs are bootable (plus a minor leak fix)

Fabiano Fidêncio fidencio at redhat.com
Fri Dec 14 09:27:54 UTC 2018


On Fri, Dec 14, 2018 at 10:21 AM Fabiano Fidêncio <fidencio at redhat.com> wrote:
>
> Please, refer to the commit message + comments in the "media: Check
> whether PPC ISOs are bootable" patch for further details about the
> checks done to verify whether a PPC ISO is bootable or not.

Ah, two things that I forgot to mention:
- How to test this series?
  - You can simply download the Debian PPC images here:
https://cdimage.debian.org/cdimage/archive/8.10.0/powerpc/iso-cd/
  - Run osinfo-detect to those images;
    - debian-8.10.0-powerpc-CD-2.iso and
debian-8.10.0-powerpc-CD-3.iso should not be bootable;
    - all other ISOs should be bootable;

- How to add tests for it upstream?
  - I'll try to create two really small ISOs with the PPC format and
add some tests for it.
  - While it's not done, I'm looking for feedback in the patches;
  - Once its done, would be okay to have two really small ISOs as part
of our tests in our git? Or would be better to place those somewhere
else (libosinfo website?) and download them as part of the test, in
case case we explicitly set to enable the tests that depend on
network?

Best Regards,
-- 
Fabiano Fidêncio




More information about the Libosinfo mailing list