[Libosinfo] [libosinfo PATCH v2 0/5] install-script: Changes needed in order to add support for unattended-installation in virt-install

Fabiano Fidêncio fidencio at redhat.com
Mon Dec 17 19:10:56 UTC 2018


This patch set has been written while playing with virt-install in order
to add support there to unattended installations.

In the way things are nowdays we have a few issues that I'm addressing
with this series:
- preferred-injection-method: We have no way to let the apps decide
  what's the preferred injection method for the scripts. We list the
  methods we support and that's it. Now I've introduced a new API which
  actually let the apps chose what they want to use (GNOME Boxes, for
  instance, prefers "disk" injection-method while virt-install prefers
  "initrd" injection-method and the command-line generated for each of
  those methods *is* different);

- installation-source: Once the app has decided what's the method to be
  used for unattended installations, they should be able to set the
  installation source as in "network" or "media" because there are a few
  differences in the scripts that would depend on that. One example is
  here is the kickstart files for Fedora which would only set the repos
  when playing with network installation, or only set the cdrom (as
  source) when playing with media installation.

These ideas where brought up in the following thread:
https://www.redhat.com/archives/libosinfo/2018-November/msg00312.html

osinfo-db patches will be sent later. If you're curious/need to take a
look on the changes done in the scripts, please, take a look at:
https://gitlab.com/fidencio/osinfo-db/commits/wip/unattended_virt_install

- Changes since v1:
  https://www.redhat.com/archives/libosinfo/2018-December/msg00005.html
  - Dropped the first two patches as there's no need to add GFlags
    related methods to OsinfoEntity

Fabiano Fidêncio (5):
  install-script: Add _(get|set)_preferred_injection_method()
  test-install-script: Cover _(get|set)_preferred_injection_method()
  install-script: Add _(get|set)_installation_source()
  test-install-script: Cover _(get|set)_installation_source()
  tools,install-script: Add "installation-source" parameter

 osinfo/libosinfo.syms                         |   6 +
 osinfo/osinfo_install_script.c                | 151 ++++++++++++++++++
 osinfo/osinfo_install_script.h                |  15 ++
 .../libosinfo-test-install-script.xml         |   5 +
 tests/test-install-script.c                   |  47 ++++++
 tools/osinfo-install-script.c                 |  15 ++
 6 files changed, 239 insertions(+)

-- 
2.19.1




More information about the Libosinfo mailing list