[Libosinfo] [libosinfo PATCH] Use g_list_free_full where easily possible

Fabiano Fidêncio fidencio at redhat.com
Thu Dec 20 10:50:59 UTC 2018


On Thu, 2018-12-20 at 10:56 +0100, Pino Toscano wrote:
> Use g_list_free_full instead of g_list_foreach + g_list_free, so the
> lists are cleared with a single call.
> 
> test-isodetect gets a void* wrapper, so there is no need to add casts
> everywhere.
> 
[snip]

Pino, your patch looks fine although it could also do this cleanup in a
few other places, altogether.

Please, take a look at: 
https://gitlab.com/fidencio/libosinfo/commit/527e51cfc6bdcc3412b574e825f4060781fef537

If you agree with my proposed fixup, I'd squash my changes into your
patch and have your patch merged.

Best Regards,
-- 
Fabiano Fidêncio




More information about the Libosinfo mailing list