From cfergeau at redhat.com  Wed May  2 07:47:38 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Wed, 2 May 2018 09:47:38 +0200
Subject: [Libosinfo] [PATCH] rhel: Add RHEL 7.5 isodata
In-Reply-To: <20180430105402.8514-1-feborges@redhat.com>
References: <20180430105402.8514-1-feborges@redhat.com>
Message-ID: <20180502074738.GB21636@natto.ory.fergeau.eu>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Mon, Apr 30, 2018 at 12:54:02PM +0200, Felipe Borges wrote:
> Signed-off-by: Felipe Borges <feborges at redhat.com>
> ---
>  ...L-7.5-20180322.0-Server-ppc64-dvd1.iso.txt | 16 ++++++++++
>  ...7.5-20180322.0-Server-ppc64le-dvd1.iso.txt | 17 +++++++++++
>  ...L-7.5-20180322.0-Server-s390x-dvd1.iso.txt | 29 +++++++++++++++++++
>  ...-7.5-20180322.0-Server-x86_64-dvd1.iso.txt | 29 +++++++++++++++++++
>  4 files changed, 91 insertions(+)
>  create mode 100644 tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt
>  create mode 100644 tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
>  create mode 100644 tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-s390x-dvd1.iso.txt
>  create mode 100644 tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-x86_64-dvd1.iso.txt
> 
> diff --git a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt
> new file mode 100644
> index 0000000..a522afb
> --- /dev/null
> +++ b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt
> @@ -0,0 +1,16 @@
> +CD-ROM is in ISO 9660 format
> +System id: PPC
> +Volume id: RHEL-7.5 Server.ppc64
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1813066
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> diff --git a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
> new file mode 100644
> index 0000000..d555458
> --- /dev/null
> +++ b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
> @@ -0,0 +1,17 @@
> +CD-ROM is in ISO 9660 format
> +System id: PPC
> +Volume id: RHEL-7.5 Server.ppc64le
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1694649
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +
> diff --git a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-s390x-dvd1.iso.txt b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-s390x-dvd1.iso.txt
> new file mode 100644
> index 0000000..0cb7cee
> --- /dev/null
> +++ b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-s390x-dvd1.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: RHEL-7.5 Server.s390x
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1591340
> +El Torito VD version 1 found, boot catalog is in sector 675
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4450
> +        Bootoff 2C0 704
> diff --git a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-x86_64-dvd1.iso.txt b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-x86_64-dvd1.iso.txt
> new file mode 100644
> index 0000000..511e30b
> --- /dev/null
> +++ b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-x86_64-dvd1.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: RHEL-7.5 Server.x86_64
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 2254848
> +El Torito VD version 1 found, boot catalog is in sector 806
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 42AA7 273063
> -- 
> 2.17.0
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180502/91d1c168/attachment.sig>

From cfergeau at redhat.com  Wed May  2 07:47:44 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Wed, 2 May 2018 09:47:44 +0200
Subject: [Libosinfo] [PATCH] rhel: add RHEL 7.5 info
In-Reply-To: <20180430105313.8320-1-feborges@redhat.com>
References: <20180430105313.8320-1-feborges@redhat.com>
Message-ID: <20180502074744.GC21636@natto.ory.fergeau.eu>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Mon, Apr 30, 2018 at 12:53:13PM +0200, Felipe Borges wrote:
> https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/7.5_release_notes/
> 
> Signed-off-by: Felipe Borges <feborges at redhat.com>
> ---
>  data/os/redhat.com/rhel-7.5.xml.in | 89 ++++++++++++++++++++++++++++++
>  1 file changed, 89 insertions(+)
>  create mode 100644 data/os/redhat.com/rhel-7.5.xml.in
> 
> diff --git a/data/os/redhat.com/rhel-7.5.xml.in b/data/os/redhat.com/rhel-7.5.xml.in
> new file mode 100644
> index 0000000..36b6f61
> --- /dev/null
> +++ b/data/os/redhat.com/rhel-7.5.xml.in
> @@ -0,0 +1,89 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <os id="http://redhat.com/rhel/7.5">
> +    <short-id>rhel7.5</short-id>
> +    <_name>Red Hat Enterprise Linux 7.5</_name>
> +    <version>7.5</version>
> +    <_vendor>Red Hat, Inc</_vendor>
> +    <family>linux</family>
> +    <distro>rhel</distro>
> +    <codename>Maipo</codename>
> +    <upgrades id="http://redhat.com/rhel/7.4"/>
> +    <derives-from id="http://redhat.com/rhel/7.4"/>
> +
> +    <release-date>2018-04-10</release-date>
> +
> +    <media arch="x86_64">
> +      <iso>
> +        <system-id>LINUX</system-id>
> +        <volume-id>.*RHEL-7.5.*x86_64.*</volume-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <media arch="aarch64">
> +       <iso>
> +         <system-id>LINUX</system-id>
> +         <volume-id>RHEL-7.5.*aarch64$</volume-id>
> +       </iso>
> +     </media>
> +
> +    <media arch="ppc64">
> +       <iso>
> +         <system-id>PPC</system-id>
> +         <volume-id>RHEL-7.5.*ppc64$</volume-id>
> +       </iso>
> +     </media>
> +
> +    <media arch="ppc64le">
> +       <iso>
> +         <system-id>PPC</system-id>
> +         <volume-id>RHEL-7.5.*ppc64le$</volume-id>
> +       </iso>
> +     </media>
> +
> +    <media arch="s390x">
> +       <iso>
> +         <system-id>LINUX</system-id>
> +         <volume-id>RHEL-7.5.*s390x$</volume-id>
> +       </iso>
> +     </media>
> +
> +    <resources arch="ppc64">
> +      <minimum>
> +        <n-cpus>1</n-cpus>
> +        <cpu>1000000000</cpu>
> +        <ram>2147483648</ram>
> +        <storage>10737418240</storage>
> +      </minimum>
> +
> +      <recommended>
> +        <cpu>400000000</cpu>
> +        <ram>2147483648</ram>
> +        <storage>21474836480</storage>
> +      </recommended>
> +    </resources>
> +
> +    <resources arch="all">
> +      <minimum>
> +        <n-cpus>1</n-cpus>
> +        <cpu>1000000000</cpu>
> +        <ram>1073741824</ram>
> +        <storage>10737418240</storage>
> +      </minimum>
> +
> +      <recommended>
> +        <cpu>400000000</cpu>
> +        <ram>1073741824</ram>
> +        <storage>9663676416</storage>
> +      </recommended>
> +    </resources>
> +
> +    <installer>
> +      <script id='http://redhat.com/rhel/kickstart/jeos'/>
> +      <script id='http://redhat.com/rhel/kickstart/desktop'/>
> +    </installer>
> +  </os>
> +</libosinfo>
> -- 
> 2.17.0
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180502/6ebb5620/attachment.sig>

From fabiano at fidencio.org  Wed May  2 18:15:02 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Wed, 2 May 2018 20:15:02 +0200
Subject: [Libosinfo] [PATCH] rhel: add RHEL 7.5 info
In-Reply-To: <20180502074744.GC21636@natto.ory.fergeau.eu>
References: <20180430105313.8320-1-feborges@redhat.com>
	<20180502074744.GC21636@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9JpZwQWze+ghNn-SS6Rt-8tRGkQa5mT3Na_2nKd52vKjQ@mail.gmail.com>

On Wed, May 2, 2018 at 9:47 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
>
> On Mon, Apr 30, 2018 at 12:53:13PM +0200, Felipe Borges wrote:
>> https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/7.5_release_notes/
>>
>> Signed-off-by: Felipe Borges <feborges at redhat.com>
>> ---
>>  data/os/redhat.com/rhel-7.5.xml.in | 89 ++++++++++++++++++++++++++++++
>>  1 file changed, 89 insertions(+)
>>  create mode 100644 data/os/redhat.com/rhel-7.5.xml.in
>>
>> diff --git a/data/os/redhat.com/rhel-7.5.xml.in b/data/os/redhat.com/rhel-7.5.xml.in
>> new file mode 100644
>> index 0000000..36b6f61
>> --- /dev/null
>> +++ b/data/os/redhat.com/rhel-7.5.xml.in
>> @@ -0,0 +1,89 @@
>> +<libosinfo version="0.0.1">
>> +<!-- Licensed under the GNU General Public License version 2 or later.
>> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
>> +  <os id="http://redhat.com/rhel/7.5">
>> +    <short-id>rhel7.5</short-id>
>> +    <_name>Red Hat Enterprise Linux 7.5</_name>
>> +    <version>7.5</version>
>> +    <_vendor>Red Hat, Inc</_vendor>
>> +    <family>linux</family>
>> +    <distro>rhel</distro>
>> +    <codename>Maipo</codename>
>> +    <upgrades id="http://redhat.com/rhel/7.4"/>
>> +    <derives-from id="http://redhat.com/rhel/7.4"/>
>> +
>> +    <release-date>2018-04-10</release-date>
>> +
>> +    <media arch="x86_64">
>> +      <iso>
>> +        <system-id>LINUX</system-id>
>> +        <volume-id>.*RHEL-7.5.*x86_64.*</volume-id>
>> +      </iso>
>> +      <kernel>isolinux/vmlinuz</kernel>
>> +      <initrd>isolinux/initrd.img</initrd>
>> +    </media>
>> +
>> +    <media arch="aarch64">
>> +       <iso>
>> +         <system-id>LINUX</system-id>
>> +         <volume-id>RHEL-7.5.*aarch64$</volume-id>
>> +       </iso>
>> +     </media>
>> +
>> +    <media arch="ppc64">
>> +       <iso>
>> +         <system-id>PPC</system-id>
>> +         <volume-id>RHEL-7.5.*ppc64$</volume-id>
>> +       </iso>
>> +     </media>
>> +
>> +    <media arch="ppc64le">
>> +       <iso>
>> +         <system-id>PPC</system-id>
>> +         <volume-id>RHEL-7.5.*ppc64le$</volume-id>
>> +       </iso>
>> +     </media>
>> +
>> +    <media arch="s390x">
>> +       <iso>
>> +         <system-id>LINUX</system-id>
>> +         <volume-id>RHEL-7.5.*s390x$</volume-id>
>> +       </iso>
>> +     </media>
>> +
>> +    <resources arch="ppc64">
>> +      <minimum>
>> +        <n-cpus>1</n-cpus>
>> +        <cpu>1000000000</cpu>
>> +        <ram>2147483648</ram>
>> +        <storage>10737418240</storage>
>> +      </minimum>
>> +
>> +      <recommended>
>> +        <cpu>400000000</cpu>
>> +        <ram>2147483648</ram>
>> +        <storage>21474836480</storage>
>> +      </recommended>
>> +    </resources>
>> +
>> +    <resources arch="all">
>> +      <minimum>
>> +        <n-cpus>1</n-cpus>
>> +        <cpu>1000000000</cpu>
>> +        <ram>1073741824</ram>
>> +        <storage>10737418240</storage>
>> +      </minimum>
>> +
>> +      <recommended>
>> +        <cpu>400000000</cpu>
>> +        <ram>1073741824</ram>
>> +        <storage>9663676416</storage>
>> +      </recommended>
>> +    </resources>
>> +
>> +    <installer>
>> +      <script id='http://redhat.com/rhel/kickstart/jeos'/>
>> +      <script id='http://redhat.com/rhel/kickstart/desktop'/>
>> +    </installer>
>> +  </os>
>> +</libosinfo>
>> --
>> 2.17.0
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>

I have pushed both patches, but changed the recommended resources of this one.

-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Wed May  2 18:15:34 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Wed, 2 May 2018 20:15:34 +0200
Subject: [Libosinfo] [osinfo-db] rhel,centos: Fix recommended resources
In-Reply-To: <20180410100610.GG24364@natto.ory.fergeau.eu>
References: <20171117145327.32611-1-fabiano@fidencio.org>
	<20171117145327.32611-2-fabiano@fidencio.org>
	<20180410094607.GF24364@natto.ory.fergeau.eu>
	<20180410100610.GG24364@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9LojXAJRSJ+VGxbjV6DcR=WcJz5D1K2se1Mjko-WFKfQA@mail.gmail.com>

On Tue, Apr 10, 2018 at 12:06 PM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Tue, Apr 10, 2018 at 11:46:07AM +0200, Christophe Fergeau wrote:
>>
>> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
>
> Actually, would you mind squashing the attached patch? I was a bit too
> hasty pushing the asianux stuff, and it should be consistent with the
> RHEL7 values I think.

I have pushed mine and yours, thanks!

>
> Christophe
>
>>
>> On Fri, Nov 17, 2017 at 03:53:26PM +0100, Fabiano Fid?ncio wrote:
>> > Both RHEL and CentOS have some wrong values set for minimum and
>> > recommended ram and storage size.
>> >
>> > I've adjusted the recommended resources values according to:
>> > https://access.redhat.com/articles/rhel-limits
>> >
>> > Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> > ---
>> >  data/os/centos.org/centos-7.0.xml.in      | 4 ++--
>> >  data/os/redhat.com/rhel-7.0.xml.in        | 6 +++---
>> >  data/os/redhat.com/rhel-7.1.xml.in        | 6 +++---
>> >  data/os/redhat.com/rhel-7.2.xml.in        | 6 +++---
>> >  data/os/redhat.com/rhel-7.3.xml.in        | 6 +++---
>> >  data/os/redhat.com/rhel-7.4.xml.in        | 6 +++---
>> >  data/os/redhat.com/rhel-atomic-7.0.xml.in | 4 ++--
>> >  data/os/redhat.com/rhel-atomic-7.1.xml.in | 4 ++--
>> >  data/os/redhat.com/rhel-atomic-7.2.xml.in | 4 ++--
>> >  9 files changed, 23 insertions(+), 23 deletions(-)
>> >
>> > diff --git a/data/os/centos.org/centos-7.0.xml.in b/data/os/centos.org/centos-7.0.xml.in
>> > index a58c642..cdeb28a 100644
>> > --- a/data/os/centos.org/centos-7.0.xml.in
>> > +++ b/data/os/centos.org/centos-7.0.xml.in
>> > @@ -31,9 +31,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >
>> > diff --git a/data/os/redhat.com/rhel-7.0.xml.in b/data/os/redhat.com/rhel-7.0.xml.in
>> > index bdf6231..e841ab3 100644
>> > --- a/data/os/redhat.com/rhel-7.0.xml.in
>> > +++ b/data/os/redhat.com/rhel-7.0.xml.in
>> > @@ -48,7 +48,7 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>2147483648</ram>
>> >          <storage>21474836480</storage>
>> >        </recommended>
>> > @@ -63,9 +63,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >
>> > diff --git a/data/os/redhat.com/rhel-7.1.xml.in b/data/os/redhat.com/rhel-7.1.xml.in
>> > index 984e82a..8a43acf 100644
>> > --- a/data/os/redhat.com/rhel-7.1.xml.in
>> > +++ b/data/os/redhat.com/rhel-7.1.xml.in
>> > @@ -41,7 +41,7 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>2147483648</ram>
>> >          <storage>21474836480</storage>
>> >        </recommended>
>> > @@ -56,9 +56,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >
>> > diff --git a/data/os/redhat.com/rhel-7.2.xml.in b/data/os/redhat.com/rhel-7.2.xml.in
>> > index 7344341..6763445 100644
>> > --- a/data/os/redhat.com/rhel-7.2.xml.in
>> > +++ b/data/os/redhat.com/rhel-7.2.xml.in
>> > @@ -60,7 +60,7 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>2147483648</ram>
>> >          <storage>21474836480</storage>
>> >        </recommended>
>> > @@ -75,9 +75,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >
>> > diff --git a/data/os/redhat.com/rhel-7.3.xml.in b/data/os/redhat.com/rhel-7.3.xml.in
>> > index 894f511..4418af7 100644
>> > --- a/data/os/redhat.com/rhel-7.3.xml.in
>> > +++ b/data/os/redhat.com/rhel-7.3.xml.in
>> > @@ -60,7 +60,7 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>2147483648</ram>
>> >          <storage>21474836480</storage>
>> >        </recommended>
>> > @@ -75,9 +75,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >
>> > diff --git a/data/os/redhat.com/rhel-7.4.xml.in b/data/os/redhat.com/rhel-7.4.xml.in
>> > index a230d68..72bb357 100644
>> > --- a/data/os/redhat.com/rhel-7.4.xml.in
>> > +++ b/data/os/redhat.com/rhel-7.4.xml.in
>> > @@ -60,7 +60,7 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>2147483648</ram>
>> >          <storage>21474836480</storage>
>> >        </recommended>
>> > @@ -75,9 +75,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >
>> > diff --git a/data/os/redhat.com/rhel-atomic-7.0.xml.in b/data/os/redhat.com/rhel-atomic-7.0.xml.in
>> > index cb9434e..31f5d7f 100644
>> > --- a/data/os/redhat.com/rhel-atomic-7.0.xml.in
>> > +++ b/data/os/redhat.com/rhel-atomic-7.0.xml.in
>> > @@ -36,9 +36,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >    </os>
>> > diff --git a/data/os/redhat.com/rhel-atomic-7.1.xml.in b/data/os/redhat.com/rhel-atomic-7.1.xml.in
>> > index d01a70e..a5302b6 100644
>> > --- a/data/os/redhat.com/rhel-atomic-7.1.xml.in
>> > +++ b/data/os/redhat.com/rhel-atomic-7.1.xml.in
>> > @@ -42,9 +42,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >    </os>
>> > diff --git a/data/os/redhat.com/rhel-atomic-7.2.xml.in b/data/os/redhat.com/rhel-atomic-7.2.xml.in
>> > index 4734ed5..c4ff6e3 100644
>> > --- a/data/os/redhat.com/rhel-atomic-7.2.xml.in
>> > +++ b/data/os/redhat.com/rhel-atomic-7.2.xml.in
>> > @@ -31,9 +31,9 @@
>> >        </minimum>
>> >
>> >        <recommended>
>> > -        <cpu>400000000</cpu>
>> > +        <cpu>1000000000</cpu>
>> >          <ram>1073741824</ram>
>> > -        <storage>9663676416</storage>
>> > +        <storage>10737418240</storage>
>> >        </recommended>
>> >      </resources>
>> >    </os>
>> > --
>> > 2.13.6
>> >
>> > _______________________________________________
>> > Libosinfo mailing list
>> > Libosinfo at redhat.com
>> > https://www.redhat.com/mailman/listinfo/libosinfo
>
>
>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo
>



-- 
Fabiano Fid?ncio



From abologna at redhat.com  Thu May  3 15:09:19 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Thu,  3 May 2018 17:09:19 +0200
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
Message-ID: <20180503150919.10425-1-abologna@redhat.com>

There is a spurious empty line at the end of the file that
causes 'make syntax-check' to fail with:

  [...]
  tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
  maint.mk: empty line(s) or no newline at EOF
  make: *** [maint.mk:927: sc_prohibit_empty_lines_at_EOF] Error 1

Get rid of it to solve the issue.

See also

  https://ci.centos.org/view/libvirt/job/libosinfo-master-syntax-check/123/

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
test-isodetect still fails for me with

  [...]
    /isodetect/rhel:
  ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:23747): ERROR **: ISO RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt was not matched by OS rhel7.5
  Trace/breakpoint trap (core dumped)

but I think that's because the relevant information has not been
merged into osinfo-db yet?

 .../isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
index d555458..1aa5db0 100644
--- a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
+++ b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
@@ -14,4 +14,3 @@ Logical block size is: 2048
 Volume size is: 1694649
 Joliet with UCS level 3 found
 Rock Ridge signatures version 1 found
-
-- 
2.14.3



From berrange at redhat.com  Thu May  3 15:12:19 2018
From: berrange at redhat.com (Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?=)
Date: Thu, 3 May 2018 16:12:19 +0100
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
In-Reply-To: <20180503150919.10425-1-abologna@redhat.com>
References: <20180503150919.10425-1-abologna@redhat.com>
Message-ID: <20180503151219.GF11382@redhat.com>

On Thu, May 03, 2018 at 05:09:19PM +0200, Andrea Bolognani wrote:
> There is a spurious empty line at the end of the file that
> causes 'make syntax-check' to fail with:
> 
>   [...]
>   tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
>   maint.mk: empty line(s) or no newline at EOF
>   make: *** [maint.mk:927: sc_prohibit_empty_lines_at_EOF] Error 1
> 
> Get rid of it to solve the issue.
> 
> See also
> 
>   https://ci.centos.org/view/libvirt/job/libosinfo-master-syntax-check/123/
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
> test-isodetect still fails for me with
> 
>   [...]
>     /isodetect/rhel:
>   ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:23747): ERROR **: ISO RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt was not matched by OS rhel7.5
>   Trace/breakpoint trap (core dumped)
> 
> but I think that's because the relevant information has not been
> merged into osinfo-db yet?

It is in osinfo-db - you will just need to update your local database
eg do to osinfo-db git checkout and run 'make', and it'll generate you
a tar.gz file. Just import that 

  osinfo-db-import osinfo-db-20180503.tar.xz

and then tests will pass

> 
>  .../isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
> index d555458..1aa5db0 100644
> --- a/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
> +++ b/tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
> @@ -14,4 +14,3 @@ Logical block size is: 2048
>  Volume size is: 1694649
>  Joliet with UCS level 3 found
>  Rock Ridge signatures version 1 found
> -
> -- 
> 2.14.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From abologna at redhat.com  Thu May  3 15:25:44 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Thu, 03 May 2018 17:25:44 +0200
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
In-Reply-To: <20180503151219.GF11382@redhat.com>
References: <20180503150919.10425-1-abologna@redhat.com>
	<20180503151219.GF11382@redhat.com>
Message-ID: <1525361144.16525.9.camel@redhat.com>

On Thu, 2018-05-03 at 16:12 +0100, Daniel P. Berrang? wrote:
> On Thu, May 03, 2018 at 05:09:19PM +0200, Andrea Bolognani wrote:
> > test-isodetect still fails for me with
> > 
> >   [...]
> >     /isodetect/rhel:
> >   ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:23747): ERROR **: ISO RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt was not matched by OS rhel7.5
> >   Trace/breakpoint trap (core dumped)
> > 
> > but I think that's because the relevant information has not been
> > merged into osinfo-db yet?
> 
> It is in osinfo-db - you will just need to update your local database
> eg do to osinfo-db git checkout and run 'make', and it'll generate you
> a tar.gz file. Just import that 
> 
>   osinfo-db-import osinfo-db-20180503.tar.xz
> 
> and then tests will pass

I follow the CI setup closely, which means I have $VIRT_PREFIX
set up and I call

  $MAKE install OSINFO_DB_TARGET="--system"

after compiling. IIUC, it should lead to the same result.

Anyway, the RHEL 7.5 data is indeed in osinfo-db already; it's
just that I thought I pulled but apparently I didn't :/

Now /isodetect/rhel passes, and I get

  /isodetect/opensuse: 
  ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:24007): ERROR **: ISO openSUSE-Leap-42.3-NET-x86_64.iso.txt was not matched by OS opensuse42.3
  Trace/breakpoint trap (core dumped)

instead. Progress? :)

-- 
Andrea Bolognani / Red Hat / Virtualization



From abologna at redhat.com  Thu May  3 15:29:25 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Thu,  3 May 2018 17:29:25 +0200
Subject: [Libosinfo] [PATCH] maint: Drop autobuild.sh
Message-ID: <20180503152925.11835-1-abologna@redhat.com>

The Test-AutoBuild project, that this script is supposed to
be used with, hasn't seen any activity in ~7 years; these
days, libosinfo CI builds are happening on the Jenkins-based
CentOS CI environment under the libvirt umbrella[1], and in
that context the script is not used at all.

[1] https://ci.centos.org/view/libvirt/

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 autobuild.sh | 105 -----------------------------------------------------------
 1 file changed, 105 deletions(-)
 delete mode 100755 autobuild.sh

diff --git a/autobuild.sh b/autobuild.sh
deleted file mode 100755
index 1db1fce..0000000
--- a/autobuild.sh
+++ /dev/null
@@ -1,105 +0,0 @@
-#!/bin/sh
-
-set -e
-set -v
-
-test -n "$1" && RESULTS=$1 || RESULTS=results.log
-: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder}
-
-# Make things clean.
-test -f Makefile && make -k distclean || :
-
-rm -rf build
-mkdir build
-cd build
-
-../autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \
-    --enable-werror --enable-gtk-doc
-
-# If the MAKEFLAGS envvar does not yet include a -j option,
-# add -jN where N depends on the number of processors.
-case $MAKEFLAGS in
-  *-j*) ;;
-  *) n=$(getconf _NPROCESSORS_ONLN 2> /dev/null)
-    test "$n" -gt 0 || n=1
-    n=$(expr $n + 1)
-    MAKEFLAGS="$MAKEFLAGS -j$n"
-    export MAKEFLAGS
-    ;;
-esac
-
-make
-make install
-
-# set -o pipefail is a bashism; this use of exec is the POSIX alternative
-exec 3>&1
-st=$(
-  exec 4>&1 >&3
-  { make check syntax-check 2>&1 3>&- 4>&-; echo $? >&4; } | tee "$RESULTS"
-)
-exec 3>&-
-test "$st" = 0
-
-rm -f *.tar.gz
-make dist
-
-if [ -n "$AUTOBUILD_COUNTER" ]; then
-  EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
-else
-  NOW=`date +"%s"`
-  EXTRA_RELEASE=".$USER$NOW"
-fi
-
-if [ -f /usr/bin/rpmbuild ]; then
-  rpmbuild --nodeps \
-     --define "extra_release $EXTRA_RELEASE" \
-     --define "_sourcedir `pwd`" \
-     -ba --clean libosinfo.spec
-fi
-
-# Test mingw32 cross-compile
-if test -x /usr/bin/i686-w64-mingw32-gcc ; then
-  make distclean
-
-  PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
-  CC="i686-w64-mingw32-gcc" \
-  ../configure \
-    --build=$(uname -m)-pc-linux \
-    --host=i686-w64-mingw32 \
-    --prefix="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \
-    --enable-werror \
-    --enable-introspection=no \
-    --enable-tests=no
-
-  make
-  make install
-
-fi
-
-# Test mingw64 cross-compile
-if test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
-  make distclean
-
-  PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
-  CC="x86_64-w64-mingw32-gcc" \
-  ../configure \
-    --build=$(uname -m)-pc-linux \
-    --host=x86_64-w64-mingw32 \
-    --prefix="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \
-    --enable-werror \
-    --enable-introspection=no \
-    --enable-tests=no
-
-  make
-  make install
-
-fi
-
-if test -x /usr/bin/i686-w64-mingw32-gcc && test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
-  if test -f /usr/bin/rpmbuild ; then
-    rpmbuild --nodeps \
-       --define "extra_release $EXTRA_RELEASE" \
-       --define "_sourcedir `pwd`" \
-       -ba --clean mingw-libosinfo.spec
-  fi
-fi
-- 
2.14.3



From abologna at redhat.com  Thu May  3 15:32:44 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Thu,  3 May 2018 17:32:44 +0200
Subject: [Libosinfo] [osinfo-db PATCH] maint: Drop autobuild.sh
Message-ID: <20180503153244.12400-1-abologna@redhat.com>

The Test-AutoBuild project, that this script is supposed to
be used with, hasn't seen any activity in ~7 years; these
days, osinfo-db CI builds are happening on the Jenkins-based
CentOS CI environment under the libvirt umbrella[1], and in
that context the script is not used at all.

[1] https://ci.centos.org/view/libvirt/

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 autobuild.sh | 48 ------------------------------------------------
 1 file changed, 48 deletions(-)
 delete mode 100755 autobuild.sh

diff --git a/autobuild.sh b/autobuild.sh
deleted file mode 100755
index d82b0ef..0000000
--- a/autobuild.sh
+++ /dev/null
@@ -1,48 +0,0 @@
-#!/bin/sh
-
-set -e
-set -v
-
-test -n "$1" && RESULTS=$1 || RESULTS=results.log
-: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder}
-
-# Make things clean.
-make -k clean
-
-# If the MAKEFLAGS envvar does not yet include a -j option,
-# add -jN where N depends on the number of processors.
-case $MAKEFLAGS in
-  *-j*) ;;
-  *) n=$(getconf _NPROCESSORS_ONLN 2> /dev/null)
-    test "$n" -gt 0 || n=1
-    n=$(expr $n + 1)
-    MAKEFLAGS="$MAKEFLAGS -j$n"
-    export MAKEFLAGS
-    ;;
-esac
-
-make
-make install DESTDIR="$AUTOBUILD_INSTALL_ROOT" OSINFO_DB_TARGET="--system"
-
-if [ -n "$AUTOBUILD_COUNTER" ]; then
-  EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
-else
-  NOW=`date +"%s"`
-  EXTRA_RELEASE=".$USER$NOW"
-fi
-
-if [ -f /usr/bin/rpmbuild ]; then
-  rpmbuild --nodeps \
-     --define "extra_release $EXTRA_RELEASE" \
-     --define "_sourcedir `pwd`" \
-     -ba --clean osinfo-db.spec
-fi
-
-if test -x /usr/bin/i686-w64-mingw32-gcc && test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
-  if test -f /usr/bin/rpmbuild ; then
-    rpmbuild --nodeps \
-       --define "extra_release $EXTRA_RELEASE" \
-       --define "_sourcedir `pwd`" \
-       -ba --clean mingw-osinfo-db.spec
-  fi
-fi
-- 
2.14.3



From berrange at redhat.com  Thu May  3 15:49:38 2018
From: berrange at redhat.com (Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?=)
Date: Thu, 3 May 2018 16:49:38 +0100
Subject: [Libosinfo] [PATCH] maint: Drop autobuild.sh
In-Reply-To: <20180503152925.11835-1-abologna@redhat.com>
References: <20180503152925.11835-1-abologna@redhat.com>
Message-ID: <20180503154938.GY11382@redhat.com>

On Thu, May 03, 2018 at 05:29:25PM +0200, Andrea Bolognani wrote:
> The Test-AutoBuild project, that this script is supposed to
> be used with, hasn't seen any activity in ~7 years; these
> days, libosinfo CI builds are happening on the Jenkins-based
> CentOS CI environment under the libvirt umbrella[1], and in
> that context the script is not used at all.
> 
> [1] https://ci.centos.org/view/libvirt/
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  autobuild.sh | 105 -----------------------------------------------------------
>  1 file changed, 105 deletions(-)
>  delete mode 100755 autobuild.sh

I use this when cutting releases

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From abologna at redhat.com  Fri May  4 07:38:45 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Fri, 04 May 2018 09:38:45 +0200
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
In-Reply-To: <20180503151233.GG11382@redhat.com>
References: <20180503150919.10425-1-abologna@redhat.com>
	<20180503151233.GG11382@redhat.com>
Message-ID: <1525419525.16525.14.camel@redhat.com>

[re-adding libosinfo]

On Thu, 2018-05-03 at 16:12 +0100, Daniel P. Berrang? wrote:
> On Thu, May 03, 2018 at 05:09:19PM +0200, Andrea Bolognani wrote:
> > There is a spurious empty line at the end of the file that
> > causes 'make syntax-check' to fail with:
> > 
> >   [...]
> >   tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
> >   maint.mk: empty line(s) or no newline at EOF
> >   make: *** [maint.mk:927: sc_prohibit_empty_lines_at_EOF] Error 1
> > 
> > Get rid of it to solve the issue.
> > 
> > See also
> > 
> >   https://ci.centos.org/view/libvirt/job/libosinfo-master-syntax-check/123/
> > 
> > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> 
> Reviewed-by: Daniel P. Berrang? <berrange at redhat.com>

This was probably supposed to go to the list ;)

Also, I don't have commit access to libosinfo projects, so someone
else will have to push it.

Thanks.

-- 
Andrea Bolognani / Red Hat / Virtualization



From fidencio at redhat.com  Fri May  4 07:42:39 2018
From: fidencio at redhat.com (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Fri, 4 May 2018 09:42:39 +0200
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
In-Reply-To: <1525361144.16525.9.camel@redhat.com>
References: <20180503150919.10425-1-abologna@redhat.com>
	<20180503151219.GF11382@redhat.com>
	<1525361144.16525.9.camel@redhat.com>
Message-ID: <CAAY6Xsf6g8pcEyw7jM8yr8g-yENqM4qKFGiTtrhfojZEOX1Q4g@mail.gmail.com>

Andrea,

On Thu, May 3, 2018 at 5:25 PM, Andrea Bolognani <abologna at redhat.com> wrote:
> On Thu, 2018-05-03 at 16:12 +0100, Daniel P. Berrang? wrote:
>> On Thu, May 03, 2018 at 05:09:19PM +0200, Andrea Bolognani wrote:
>> > test-isodetect still fails for me with
>> >
>> >   [...]
>> >     /isodetect/rhel:
>> >   ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:23747): ERROR **: ISO RHEL-7.5-20180322.0-Server-ppc64-dvd1.iso.txt was not matched by OS rhel7.5
>> >   Trace/breakpoint trap (core dumped)
>> >
>> > but I think that's because the relevant information has not been
>> > merged into osinfo-db yet?
>>
>> It is in osinfo-db - you will just need to update your local database
>> eg do to osinfo-db git checkout and run 'make', and it'll generate you
>> a tar.gz file. Just import that
>>
>>   osinfo-db-import osinfo-db-20180503.tar.xz
>>
>> and then tests will pass
>
> I follow the CI setup closely, which means I have $VIRT_PREFIX
> set up and I call
>
>   $MAKE install OSINFO_DB_TARGET="--system"
>
> after compiling. IIUC, it should lead to the same result.
>
> Anyway, the RHEL 7.5 data is indeed in osinfo-db already; it's
> just that I thought I pulled but apparently I didn't :/
>
> Now /isodetect/rhel passes, and I get
>
>   /isodetect/opensuse:
>   ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:24007): ERROR **: ISO openSUSE-Leap-42.3-NET-x86_64.iso.txt was not matched by OS opensuse42.3
>   Trace/breakpoint trap (core dumped)
>
> instead. Progress? :)

Sorry for the long email.

Here's the output of how I check that our tests are passing:

[fidencio at machado osinfo-db]$ make
  I18N      data/datamap/microsoft.com/win-7-l10n-language.xml
  I18N      data/datamap/microsoft.com/win-8-l10n-language-reverse.xml
  I18N      data/datamap/microsoft.com/win-8-l10n-language.xml
  I18N      data/datamap/x.org/x11-keyboard.xml
  I18N      data/install-script/opensuse.org/opensuse-autoyast-jeos.xml
  I18N      data/install-script/opensuse.org/opensuse-autoyast-desktop.xml
  I18N      data/install-script/ubuntu.com/ubuntu-preseed-jeos.xml
  I18N      data/install-script/redhat.com/rhel-kickstart-desktop.xml
  I18N      data/install-script/redhat.com/rhel-kickstart-jeos.xml
  I18N      data/install-script/microsoft.com/windows-unattend-jeos.xml
  I18N      data/install-script/microsoft.com/windows-sif-jeos.xml
  I18N      data/install-script/microsoft.com/windows-cmd-desktop.xml
  I18N      data/install-script/microsoft.com/windows-unattend-desktop.xml
  I18N      data/install-script/microsoft.com/windows-sif-desktop.xml
  I18N      data/install-script/microsoft.com/windows-reg-desktop.xml
  I18N      data/install-script/fedoraproject.org/fedora-kickstart-jeos.xml
  I18N      data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml
  I18N      data/install-script/debian.org/debian-preseed-jeos.xml
  I18N      data/install-script/debian.org/debian-preseed-desktop.xml
  I18N      data/os/asianux.com/asianux-4.6.xml
  I18N      data/os/asianux.com/asianux-7.1.xml
  I18N      data/os/asianux.com/asianux-4.7.xml
  I18N      data/os/asianux.com/asianux-7.2.xml
  I18N      data/os/asianux.com/asianux-7.0.xml
  I18N      data/os/asianux.com/asianux-unknown.xml
  I18N      data/os/endlessos.com/eos-3.3.xml
  I18N      data/os/freebsd.org/freebsd-10.2.xml
  I18N      data/os/freebsd.org/freebsd-4.3.xml
  I18N      data/os/freebsd.org/freebsd-4.10.xml
  I18N      data/os/freebsd.org/freebsd-10.0.xml
  I18N      data/os/freebsd.org/freebsd-8.2.xml
  I18N      data/os/freebsd.org/freebsd-7.3.xml
  I18N      data/os/freebsd.org/freebsd-5.2.1.xml
  I18N      data/os/freebsd.org/freebsd-4.4.xml
  I18N      data/os/freebsd.org/freebsd-9.0.xml
  I18N      data/os/freebsd.org/freebsd-4.1.xml
  I18N      data/os/freebsd.org/freebsd-1.0.xml
  I18N      data/os/freebsd.org/freebsd-2.0.5.xml
  I18N      data/os/freebsd.org/freebsd-3.2.xml
  I18N      data/os/freebsd.org/freebsd-6.1.xml
  I18N      data/os/freebsd.org/freebsd-4.7.xml
  I18N      data/os/freebsd.org/freebsd-11.1.xml
  I18N      data/os/freebsd.org/freebsd-3.0.xml
  I18N      data/os/freebsd.org/freebsd-5.5.xml
  I18N      data/os/freebsd.org/freebsd-4.9.xml
  I18N      data/os/freebsd.org/freebsd-4.5.xml
  I18N      data/os/freebsd.org/freebsd-9.3.xml
  I18N      data/os/freebsd.org/freebsd-4.11.xml
  I18N      data/os/freebsd.org/freebsd-6.4.xml
  I18N      data/os/freebsd.org/freebsd-4.2.xml
  I18N      data/os/freebsd.org/freebsd-7.2.xml
  I18N      data/os/freebsd.org/freebsd-5.4.xml
  I18N      data/os/freebsd.org/freebsd-4.0.xml
  I18N      data/os/freebsd.org/freebsd-5.1.xml
  I18N      data/os/freebsd.org/freebsd-10.3.xml
  I18N      data/os/freebsd.org/freebsd-8.1.xml
  I18N      data/os/freebsd.org/freebsd-6.2.xml
  I18N      data/os/freebsd.org/freebsd-4.8.xml
  I18N      data/os/freebsd.org/freebsd-6.3.xml
  I18N      data/os/freebsd.org/freebsd-9.1.xml
  I18N      data/os/freebsd.org/freebsd-7.0.xml
  I18N      data/os/freebsd.org/freebsd-8.3.xml
  I18N      data/os/freebsd.org/freebsd-6.0.xml
  I18N      data/os/freebsd.org/freebsd-2.2.8.xml
  I18N      data/os/freebsd.org/freebsd-10.4.xml
  I18N      data/os/freebsd.org/freebsd-11.0.xml
  I18N      data/os/freebsd.org/freebsd-10.1.xml
  I18N      data/os/freebsd.org/freebsd-2.0.xml
  I18N      data/os/freebsd.org/freebsd-8.4.xml
  I18N      data/os/freebsd.org/freebsd-9.2.xml
  I18N      data/os/freebsd.org/freebsd-8.0.xml
  I18N      data/os/freebsd.org/freebsd-7.1.xml
  I18N      data/os/freebsd.org/freebsd-5.3.xml
  I18N      data/os/freebsd.org/freebsd-5.2.xml
  I18N      data/os/freebsd.org/freebsd-7.4.xml
  I18N      data/os/freebsd.org/freebsd-4.6.xml
  I18N      data/os/freebsd.org/freebsd-5.0.xml
  I18N      data/os/freebsd.org/freebsd-2.2.9.xml
  I18N      data/os/opensuse.org/opensuse-10.2.xml
  I18N      data/os/opensuse.org/opensuse-13.1.xml
  I18N      data/os/opensuse.org/opensuse-11.3.xml
  I18N      data/os/opensuse.org/opensuse-unknown.xml
  I18N      data/os/opensuse.org/opensuse-11.4.xml
  I18N      data/os/opensuse.org/opensuse-13.2.xml
  I18N      data/os/opensuse.org/opensuse-11.1.xml
  I18N      data/os/opensuse.org/opensuse-42.3.xml
  I18N      data/os/opensuse.org/opensuse-12.3.xml
  I18N      data/os/opensuse.org/opensuse-factory.xml
  I18N      data/os/opensuse.org/opensuse-42.1.xml
  I18N      data/os/opensuse.org/opensuse-10.3.xml
  I18N      data/os/opensuse.org/opensuse-12.1.xml
  I18N      data/os/opensuse.org/opensuse-11.2.xml
  I18N      data/os/opensuse.org/opensuse-11.0.xml
  I18N      data/os/opensuse.org/opensuse-42.2.xml
  I18N      data/os/opensuse.org/opensuse-12.2.xml
  I18N      data/os/opensuse.org/opensuse-tumbleweed.xml
  I18N      data/os/freedos.org/freedos-1.2.xml
  I18N      data/os/centos.org/centos-6.7.xml
  I18N      data/os/centos.org/centos-6.3.xml
  I18N      data/os/centos.org/centos-7.0.xml
  I18N      data/os/centos.org/centos-6.4.xml
  I18N      data/os/centos.org/centos-6.1.xml
  I18N      data/os/centos.org/centos-6.8.xml
  I18N      data/os/centos.org/centos-6.5.xml
  I18N      data/os/centos.org/centos-6.9.xml
  I18N      data/os/centos.org/centos-6.2.xml
  I18N      data/os/centos.org/centos-6.0.xml
  I18N      data/os/centos.org/centos-6.6.xml
  I18N      data/os/fedoraproject.org/fedora-19.xml
  I18N      data/os/fedoraproject.org/fedora-5.xml
  I18N      data/os/fedoraproject.org/fedora-24.xml
  I18N      data/os/fedoraproject.org/fedora-4.xml
  I18N      data/os/fedoraproject.org/fedora-26.xml
  I18N      data/os/fedoraproject.org/fedora-1.xml
  I18N      data/os/fedoraproject.org/fedora-23.xml
  I18N      data/os/fedoraproject.org/fedora-2.xml
  I18N      data/os/fedoraproject.org/fedora-17.xml
  I18N      data/os/fedoraproject.org/fedora-18.xml
  I18N      data/os/fedoraproject.org/fedora-11.xml
  I18N      data/os/fedoraproject.org/fedora-27.xml
  I18N      data/os/fedoraproject.org/fedora-unknown.xml
  I18N      data/os/fedoraproject.org/fedora-12.xml
  I18N      data/os/fedoraproject.org/fedora-16.xml
  I18N      data/os/fedoraproject.org/fedora-7.xml
  I18N      data/os/fedoraproject.org/fedora-21.xml
  I18N      data/os/fedoraproject.org/fedora-10.xml
  I18N      data/os/fedoraproject.org/fedora-8.xml
  I18N      data/os/fedoraproject.org/fedora-22.xml
  I18N      data/os/fedoraproject.org/fedora-15.xml
  I18N      data/os/fedoraproject.org/fedora-25.xml
  I18N      data/os/fedoraproject.org/fedora-9.xml
  I18N      data/os/fedoraproject.org/fedora-6.xml
  I18N      data/os/fedoraproject.org/fedora-14.xml
  I18N      data/os/fedoraproject.org/fedora-3.xml
  I18N      data/os/fedoraproject.org/fedora-20.xml
  I18N      data/os/fedoraproject.org/fedora-13.xml
  I18N      data/os/mandriva.com/mandriva-2007.xml
  I18N      data/os/mandriva.com/mandrake-5.1.xml
  I18N      data/os/mandriva.com/mandrake-9.0.xml
  I18N      data/os/mandriva.com/mandriva-2009.1.xml
  I18N      data/os/mandriva.com/mandrake-6.0.xml
  I18N      data/os/mandriva.com/mandrake-10.1.xml
  I18N      data/os/mandriva.com/mandriva-2010.1.xml
  I18N      data/os/mandriva.com/mandrake-9.1.xml
  I18N      data/os/mandriva.com/mandriva-2008.1.xml
  I18N      data/os/mandriva.com/mandrake-5.2.xml
  I18N      data/os/mandriva.com/mandriva-2009.0.xml
  I18N      data/os/mandriva.com/mes-5.0.xml
  I18N      data/os/mandriva.com/mandrake-10.2.xml
  I18N      data/os/mandriva.com/mbs-1.0.xml
  I18N      data/os/mandriva.com/mandriva-2011.xml
  I18N      data/os/mandriva.com/mandrake-10.0.xml
  I18N      data/os/mandriva.com/mandrake-7.2.xml
  I18N      data/os/mandriva.com/mandrake-7.1.xml
  I18N      data/os/mandriva.com/mes-5.1.xml
  I18N      data/os/mandriva.com/mandriva-2006.0.xml
  I18N      data/os/mandriva.com/mandrake-8.0.xml
  I18N      data/os/mandriva.com/mandriva-2008.0.xml
  I18N      data/os/mandriva.com/mandrake-8.1.xml
  I18N      data/os/mandriva.com/mandrake-6.1.xml
  I18N      data/os/mandriva.com/mandrake-8.2.xml
  I18N      data/os/mandriva.com/mandriva-2010.2.xml
  I18N      data/os/mandriva.com/mandrake-5.3.xml
  I18N      data/os/mandriva.com/mandriva-2007.1.xml
  I18N      data/os/mandriva.com/mandriva-2010.0.xml
  I18N      data/os/mandriva.com/mandrake-9.2.xml
  I18N      data/os/mandriva.com/mandrake-7.0.xml
  I18N      data/os/ubuntu.com/ubuntu-14.04.xml
  I18N      data/os/ubuntu.com/ubuntu-9.10.xml
  I18N      data/os/ubuntu.com/ubuntu-7.10.xml
  I18N      data/os/ubuntu.com/ubuntu-17.04.xml
  I18N      data/os/ubuntu.com/ubuntu-15.10.xml
  I18N      data/os/ubuntu.com/ubuntu-10.10.xml
  I18N      data/os/ubuntu.com/ubuntu-14.10.xml
  I18N      data/os/ubuntu.com/ubuntu-12.04.xml
  I18N      data/os/ubuntu.com/ubuntu-13.10.xml
  I18N      data/os/ubuntu.com/ubuntu-6.06.xml
  I18N      data/os/ubuntu.com/ubuntu-11.04.xml
  I18N      data/os/ubuntu.com/ubuntu-17.10.xml
  I18N      data/os/ubuntu.com/ubuntu-8.04.xml
  I18N      data/os/ubuntu.com/ubuntu-4.10.xml
  I18N      data/os/ubuntu.com/ubuntu-9.04.xml
  I18N      data/os/ubuntu.com/ubuntu-5.04.xml
  I18N      data/os/ubuntu.com/ubuntu-6.10.xml
  I18N      data/os/ubuntu.com/ubuntu-11.10.xml
  I18N      data/os/ubuntu.com/ubuntu-16.04.xml
  I18N      data/os/ubuntu.com/ubuntu-13.04.xml
  I18N      data/os/ubuntu.com/ubuntu-10.04.xml
  I18N      data/os/ubuntu.com/ubuntu-7.04.xml
  I18N      data/os/ubuntu.com/ubuntu-5.10.xml
  I18N      data/os/ubuntu.com/ubuntu-12.10.xml
  I18N      data/os/ubuntu.com/ubuntu-15.04.xml
  I18N      data/os/ubuntu.com/ubuntu-16.10.xml
  I18N      data/os/ubuntu.com/ubuntu-8.10.xml
  I18N      data/os/redhat.com/rhl-6.2.xml
  I18N      data/os/redhat.com/rhel-3.9.xml
  I18N      data/os/redhat.com/rhl-7.xml
  I18N      data/os/redhat.com/rhl-5.1.xml
  I18N      data/os/redhat.com/rhel-2.1.4.xml
  I18N      data/os/redhat.com/rhl-6.0.xml
  I18N      data/os/redhat.com/rhel-7.5.xml
  I18N      data/os/redhat.com/rhel-2.1.7.xml
  I18N      data/os/redhat.com/rhel-atomic-7.2.xml
  I18N      data/os/redhat.com/rhl-5.0.xml
  I18N      data/os/redhat.com/rhel-3.7.xml
  I18N      data/os/redhat.com/rhel-5.9.xml
  I18N      data/os/redhat.com/rhel-7.3.xml
  I18N      data/os/redhat.com/rhel-atomic-7.0.xml
  I18N      data/os/redhat.com/rhl-2.0.xml
  I18N      data/os/redhat.com/rhel-4.5.xml
  I18N      data/os/redhat.com/rhel-5.5.xml
  I18N      data/os/redhat.com/rhel-5.11.xml
  I18N      data/os/redhat.com/rhel-7.1.xml
  I18N      data/os/redhat.com/rhel-3.6.xml
  I18N      data/os/redhat.com/rhel-5.0.xml
  I18N      data/os/redhat.com/rhel-3.3.xml
  I18N      data/os/redhat.com/rhel-5.3.xml
  I18N      data/os/redhat.com/rhel-6.7.xml
  I18N      data/os/redhat.com/rhel-4.2.xml
  I18N      data/os/redhat.com/rhel-4.9.xml
  I18N      data/os/redhat.com/rhel-3.xml
  I18N      data/os/redhat.com/rhel-3.2.xml
  I18N      data/os/redhat.com/rhel-6.6.xml
  I18N      data/os/redhat.com/rhl-6.1.xml
  I18N      data/os/redhat.com/rhel-3.4.xml
  I18N      data/os/redhat.com/rhel-4.0.xml
  I18N      data/os/redhat.com/rhel-2.1.6.xml
  I18N      data/os/redhat.com/rhel-3.1.xml
  I18N      data/os/redhat.com/rhel-2.1.3.xml
  I18N      data/os/redhat.com/rhel-6.9.xml
  I18N      data/os/redhat.com/rhel-4.6.xml
  I18N      data/os/redhat.com/rhel-6.2.xml
  I18N      data/os/redhat.com/rhel-7.2.xml
  I18N      data/os/redhat.com/rhel-5.7.xml
  I18N      data/os/redhat.com/rhl-1.1.xml
  I18N      data/os/redhat.com/rhl-7.1.xml
  I18N      data/os/redhat.com/rhel-6.8.xml
  I18N      data/os/redhat.com/rhl-7.3.xml
  I18N      data/os/redhat.com/rhel-4.4.xml
  I18N      data/os/redhat.com/rhl-8.0.xml
  I18N      data/os/redhat.com/rhel-5.10.xml
  I18N      data/os/redhat.com/rhel-4.1.xml
  I18N      data/os/redhat.com/rhel-4.7.xml
  I18N      data/os/redhat.com/rhel-3.5.xml
  I18N      data/os/redhat.com/rhel-6.0.xml
  I18N      data/os/redhat.com/rhel-6.3.xml
  I18N      data/os/redhat.com/rhl-5.2.xml
  I18N      data/os/redhat.com/rhel-2.1.1.xml
  I18N      data/os/redhat.com/rhel-4.3.xml
  I18N      data/os/redhat.com/rhel-5.6.xml
  I18N      data/os/redhat.com/rhel-6.1.xml
  I18N      data/os/redhat.com/rhel-2.1.2.xml
  I18N      data/os/redhat.com/rhel-4.8.xml
  I18N      data/os/redhat.com/rhel-2.1.xml
  I18N      data/os/redhat.com/rhel-6.5.xml
  I18N      data/os/redhat.com/rhl-9.xml
  I18N      data/os/redhat.com/rhl-4.1.xml
  I18N      data/os/redhat.com/rhel-7.0.xml
  I18N      data/os/redhat.com/rhl-4.2.xml
  I18N      data/os/redhat.com/rhl-2.1.xml
  I18N      data/os/redhat.com/rhel-atomic-7.1.xml
  I18N      data/os/redhat.com/rhel-7.4.xml
  I18N      data/os/redhat.com/rhel-6.4.xml
  I18N      data/os/redhat.com/rhel-3.8.xml
  I18N      data/os/redhat.com/rhl-1.0.xml
  I18N      data/os/redhat.com/rhl-3.0.3.xml
  I18N      data/os/redhat.com/rhel-2.1.5.xml
  I18N      data/os/redhat.com/rhl-7.2.xml
  I18N      data/os/redhat.com/rhel-5.2.xml
  I18N      data/os/redhat.com/rhel-5.4.xml
  I18N      data/os/redhat.com/rhl-4.0.xml
  I18N      data/os/redhat.com/rhel-5.1.xml
  I18N      data/os/redhat.com/rhel-5.8.xml
  I18N      data/os/microsoft.com/win-2.1.xml
  I18N      data/os/microsoft.com/win-2k3.xml
  I18N      data/os/microsoft.com/win-10.xml
  I18N      data/os/microsoft.com/win-1.0.xml
  I18N      data/os/microsoft.com/win-98.xml
  I18N      data/os/microsoft.com/win-xp.xml
  I18N      data/os/microsoft.com/winnt-3.51.xml
  I18N      data/os/microsoft.com/win-2k3r2.xml
  I18N      data/os/microsoft.com/win-vista.xml
  I18N      data/os/microsoft.com/win-2.0.xml
  I18N      data/os/microsoft.com/winnt-4.0.xml
  I18N      data/os/microsoft.com/win-8.1.xml
  I18N      data/os/microsoft.com/win-2k8.xml
  I18N      data/os/microsoft.com/win-95.xml
  I18N      data/os/microsoft.com/msdos-6.22.xml
  I18N      data/os/microsoft.com/win-2k12.xml
  I18N      data/os/microsoft.com/win-2k16.xml
  I18N      data/os/microsoft.com/winnt-3.5.xml
  I18N      data/os/microsoft.com/win-3.1.xml
  I18N      data/os/microsoft.com/win-2k12r2.xml
  I18N      data/os/microsoft.com/win-7.xml
  I18N      data/os/microsoft.com/win-2k.xml
  I18N      data/os/microsoft.com/win-2k8r2.xml
  I18N      data/os/microsoft.com/winnt-3.1.xml
  I18N      data/os/microsoft.com/win-8.xml
  I18N      data/os/microsoft.com/win-me.xml
  I18N      data/os/suse.com/sles-10.1.xml
  I18N      data/os/suse.com/sled-11.xml
  I18N      data/os/suse.com/sles-12.2.xml
  I18N      data/os/suse.com/sled-11.3.xml
  I18N      data/os/suse.com/sled-12.xml
  I18N      data/os/suse.com/sled-11.4.xml
  I18N      data/os/suse.com/sles-10.2.xml
  I18N      data/os/suse.com/sled-11.1.xml
  I18N      data/os/suse.com/sles-11.xml
  I18N      data/os/suse.com/sles-11.4.xml
  I18N      data/os/suse.com/sled-12.3.xml
  I18N      data/os/suse.com/sled-10.xml
  I18N      data/os/suse.com/sles-11.3.xml
  I18N      data/os/suse.com/sled-9.xml
  I18N      data/os/suse.com/sled-10.3.xml
  I18N      data/os/suse.com/sled-12.1.xml
  I18N      data/os/suse.com/sles-12.xml
  I18N      data/os/suse.com/sled-11.2.xml
  I18N      data/os/suse.com/sled-10.4.xml
  I18N      data/os/suse.com/sled-10.1.xml
  I18N      data/os/suse.com/sles-12.3.xml
  I18N      data/os/suse.com/sles-10.xml
  I18N      data/os/suse.com/sled-10.2.xml
  I18N      data/os/suse.com/sles-9.xml
  I18N      data/os/suse.com/sled-12.2.xml
  I18N      data/os/suse.com/sles-10.3.xml
  I18N      data/os/suse.com/sles-12.1.xml
  I18N      data/os/suse.com/sles-11.2.xml
  I18N      data/os/suse.com/sles-11.1.xml
  I18N      data/os/suse.com/sles-10.4.xml
  I18N      data/os/gnome.org/gnome-3.8.xml
  I18N      data/os/gnome.org/gnome-continuous-3.14.xml
  I18N      data/os/gnome.org/gnome-continuous-3.12.xml
  I18N      data/os/gnome.org/gnome-continuous-3.10.xml
  I18N      data/os/gnome.org/gnome-3.6.xml
  I18N      data/os/sun.com/opensolaris-2009.06.xml
  I18N      data/os/sun.com/solaris-10.xml
  I18N      data/os/sun.com/solaris-9.xml
  I18N      data/os/mageia.org/mageia-3.xml
  I18N      data/os/mageia.org/mageia-2.xml
  I18N      data/os/mageia.org/mageia-1.xml
  I18N      data/os/mageia.org/mageia-4.xml
  I18N      data/os/mageia.org/mageia-6.xml
  I18N      data/os/mageia.org/mageia-5.xml
  I18N      data/os/apple.com/macosx-10.7.xml
  I18N      data/os/apple.com/macosx-10.3.xml
  I18N      data/os/apple.com/macosx-10.6.xml
  I18N      data/os/apple.com/macosx-10.4.xml
  I18N      data/os/apple.com/macosx-10.1.xml
  I18N      data/os/apple.com/macosx-10.5.xml
  I18N      data/os/apple.com/macosx-10.2.xml
  I18N      data/os/apple.com/macosx-10.0.xml
  I18N      data/os/novell.com/netware-6.xml
  I18N      data/os/novell.com/netware-5.xml
  I18N      data/os/novell.com/netware-4.xml
  I18N      data/os/altlinux.org/altlinux-1.0.xml
  I18N      data/os/altlinux.org/altlinux-4.0.xml
  I18N      data/os/altlinux.org/altlinux-6.0.xml
  I18N      data/os/altlinux.org/altlinux-2.2.xml
  I18N      data/os/altlinux.org/altlinux-2.0.xml
  I18N      data/os/altlinux.org/altlinux-5.0.xml
  I18N      data/os/altlinux.org/altlinux-7.0.xml
  I18N      data/os/altlinux.org/altlinux-4.1.xml
  I18N      data/os/altlinux.org/altlinux-3.0.xml
  I18N      data/os/altlinux.org/altlinux-2.4.xml
  I18N      data/os/system76.com/popos-17.10.xml
  I18N      data/os/alpinelinux.org/alpinelinux-3.6.xml
  I18N      data/os/alpinelinux.org/alpinelinux-3.7.xml
  I18N      data/os/alpinelinux.org/alpinelinux-3.5.xml
  I18N      data/os/openbsd.org/openbsd-5.6.xml
  I18N      data/os/openbsd.org/openbsd-6.1.xml
  I18N      data/os/openbsd.org/openbsd-5.3.xml
  I18N      data/os/openbsd.org/openbsd-4.5.xml
  I18N      data/os/openbsd.org/openbsd-4.2.xml
  I18N      data/os/openbsd.org/openbsd-5.4.xml
  I18N      data/os/openbsd.org/openbsd-5.1.xml
  I18N      data/os/openbsd.org/openbsd-6.2.xml
  I18N      data/os/openbsd.org/openbsd-5.7.xml
  I18N      data/os/openbsd.org/openbsd-6.0.xml
  I18N      data/os/openbsd.org/openbsd-4.9.xml
  I18N      data/os/openbsd.org/openbsd-5.5.xml
  I18N      data/os/openbsd.org/openbsd-5.8.xml
  I18N      data/os/openbsd.org/openbsd-5.2.xml
  I18N      data/os/openbsd.org/openbsd-4.8.xml
  I18N      data/os/openbsd.org/openbsd-6.3.xml
  I18N      data/os/openbsd.org/openbsd-5.0.xml
  I18N      data/os/openbsd.org/openbsd-5.9.xml
  I18N      data/os/openbsd.org/openbsd-4.3.xml
  I18N      data/os/openbsd.org/openbsd-4.4.xml
  I18N      data/os/debian.org/debian-testing.xml
  I18N      data/os/debian.org/debian-5.xml
  I18N      data/os/debian.org/debian-1.2.xml
  I18N      data/os/debian.org/debian-2.1.xml
  I18N      data/os/debian.org/debian-9.xml
  I18N      data/os/debian.org/debian-7.xml
  I18N      data/os/debian.org/debian-2.2.xml
  I18N      data/os/debian.org/debian-3.xml
  I18N      data/os/debian.org/debian-2.0.xml
  I18N      data/os/debian.org/debian-8.xml
  I18N      data/os/debian.org/debian-4.xml
  I18N      data/os/debian.org/debian-1.3.xml
  I18N      data/os/debian.org/debian-3.1.xml
  I18N      data/os/debian.org/debian-6.xml
  I18N      data/os/debian.org/debian-1.1.xml
  I18N      data/os/netbsd.org/netbsd-6.0.xml
  I18N      data/os/netbsd.org/netbsd-2.0.xml
  I18N      data/os/netbsd.org/netbsd-7.1.xml
  I18N      data/os/netbsd.org/netbsd-1.6.xml
  I18N      data/os/netbsd.org/netbsd-5.0.xml
  I18N      data/os/netbsd.org/netbsd-1.3.xml
  I18N      data/os/netbsd.org/netbsd-1.4.xml
  I18N      data/os/netbsd.org/netbsd-7.1.1.xml
  I18N      data/os/netbsd.org/netbsd-1.1.xml
  I18N      data/os/netbsd.org/netbsd-0.8.xml
  I18N      data/os/netbsd.org/netbsd-7.0.xml
  I18N      data/os/netbsd.org/netbsd-0.9.xml
  I18N      data/os/netbsd.org/netbsd-6.1.xml
  I18N      data/os/netbsd.org/netbsd-1.5.xml
  I18N      data/os/netbsd.org/netbsd-3.0.xml
  I18N      data/os/netbsd.org/netbsd-1.2.xml
  I18N      data/os/netbsd.org/netbsd-1.0.xml
  I18N      data/os/netbsd.org/netbsd-4.0.xml
  I18N      data/os/netbsd.org/netbsd-5.1.xml
  I18N      data/os/oracle.com/solaris-11.xml
  I18N      data/device/pcisig.com/pci-1234-1111.xml
  I18N      data/device/xen.org/xen-vkbd.xml
  I18N      data/device/xen.org/xen-vif.xml
  I18N      data/device/xen.org/xen-vfb.xml
  I18N      data/device/xen.org/xen-vbd.xml
  I18N      data/device/xen.org/xen-pci.xml
  I18N      data/device/xen.org/xen-console.xml
  I18N      data/device/xen.org/xen-vscsi.xml
  I18N      data/device/xen.org/xen-vtpm.xml
  I18N      data/device/ibasetechnologies.net/isa-ib700.xml
  I18N      data/device/ibm.com/ps2-mouse.xml
  I18N      data/device/ibm.com/ps2-keyboard.xml
  I18N      data/platform/qemu.org/qemu-1.2.2.xml
  I18N      data/platform/qemu.org/qemu-2.1.2.xml
  I18N      data/platform/qemu.org/qemu-2.1.0.xml
  I18N      data/platform/qemu.org/qemu-1.1.1-1.xml
  I18N      data/platform/qemu.org/qemu-1.2.0.xml
  I18N      data/platform/qemu.org/qemu-2.0.1.xml
  I18N      data/platform/qemu.org/qemu-2.0.2.xml
  I18N      data/platform/qemu.org/qemu-1.1.xml
  I18N      data/platform/qemu.org/qemu-1.7.1.xml
  I18N      data/platform/qemu.org/qemu-1.5.2.xml
  I18N      data/platform/qemu.org/qemu-1.6.0.xml
  I18N      data/platform/qemu.org/qemu-1.3.1.xml
  I18N      data/platform/qemu.org/qemu-1.1.1.xml
  I18N      data/platform/qemu.org/qemu-2.2.0.xml
  I18N      data/platform/qemu.org/qemu-1.7.0.xml
  I18N      data/platform/qemu.org/qemu-1.4.1.xml
  I18N      data/platform/qemu.org/qemu-1.7.2.xml
  I18N      data/platform/qemu.org/qemu-2.0.0.xml
  I18N      data/platform/qemu.org/qemu-1.5.3.xml
  I18N      data/platform/qemu.org/qemu-2.1.3.xml
  I18N      data/platform/qemu.org/qemu-1.0.xml
  I18N      data/platform/qemu.org/qemu-1.3.0.xml
  I18N      data/platform/qemu.org/qemu-1.5.1.xml
  I18N      data/platform/qemu.org/qemu-1.6.1.xml
  I18N      data/platform/qemu.org/qemu-1.4.2.xml
  I18N      data/platform/qemu.org/qemu-1.2.1.xml
  I18N      data/platform/qemu.org/qemu-1.6.2.xml
  I18N      data/platform/qemu.org/qemu-2.1.1.xml
  I18N      data/platform/qemu.org/qemu-1.5.0.xml
  I18N      data/platform/qemu.org/qemu-1.4.0.xml
  I18N      data/platform/qemu.org/qemu-1.1.2.xml
  I18N      data/platform/qemu.org/qemu-1.0.1.xml
  I18N      data/platform/qemu.org/qemu-2.2.1.xml
  I18N      data/platform/qemu.org/qemu-2.3.0.xml
  I18N      data/platform/redhat.com/xen-rhel-3.1.0.5.6.xml
  I18N      data/platform/redhat.com/xen-rhel-3.1.0.5.3.xml
  I18N      data/platform/redhat.com/xen-rhel-3.1.0.5.4.xml
  I18N      data/platform/redhat.com/xen-rhel-3.1.0.5.1.xml
  I18N      data/platform/redhat.com/xen-rhel-3.0.3.5.0.xml
  I18N      data/platform/redhat.com/xen-rhel-3.1.0.5.5.xml
  I18N      data/platform/redhat.com/xen-rhel-3.1.0.5.2.xml
  I18N      data/platform/redhat.com/xen-rhel-3.1.0.5.7.xml
  I18N      data/platform/linux-kvm.org/qemu-kvm-1.0.xml
  I18N      data/platform/linux-kvm.org/qemu-kvm-1.1.2.xml
  I18N      data/platform/linux-kvm.org/qemu-kvm-1.1.0.xml
  I18N      data/platform/linux-kvm.org/qemu-kvm-1.0.1.xml
  I18N      data/platform/linux-kvm.org/qemu-kvm-1.2.0.xml
  I18N      data/platform/linux-kvm.org/qemu-kvm-1.1.1.xml
  I18N      data/platform/xen.org/xen-3.2.3.xml
  I18N      data/platform/xen.org/xen-3.0.3.xml
  I18N      data/platform/xen.org/xen-3.4.2.xml
  I18N      data/platform/xen.org/xen-4.0.1.xml
  I18N      data/platform/xen.org/xen-3.2.1.xml
  I18N      data/platform/xen.org/xen-3.0.4.xml
  I18N      data/platform/xen.org/xen-3.1.0.xml
  I18N      data/platform/xen.org/xen-3.2.0.xml
  I18N      data/platform/xen.org/xen-4.1.0.xml
  I18N      data/platform/xen.org/xen-3.2.2.xml
  I18N      data/platform/xen.org/xen-3.1.4.xml
  I18N      data/platform/xen.org/xen-3.0.2.xml
  I18N      data/platform/xen.org/xen-3.4.3.xml
  I18N      data/platform/xen.org/xen-3.4.0.xml
  I18N      data/platform/xen.org/xen-3.1.3.xml
  I18N      data/platform/xen.org/xen-3.3.1.xml
  I18N      data/platform/xen.org/xen-4.0.0.xml
  I18N      data/platform/xen.org/xen-3.3.2.xml
  I18N      data/platform/xen.org/xen-3.4.1.xml
  I18N      data/platform/xen.org/xen-3.3.0.xml
  I18N      data/device/pcisig.com/pci-1af4-1052.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1042.d/class.xml
  I18N      data/device/pcisig.com/pci-10ec-8029.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1048.d/class.xml
  I18N      data/device/pcisig.com/pci-10ec-8139.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1044.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1049.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1050.d/class.xml
  I18N      data/device/pcisig.com/pci-8086-25ab.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1003.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1005.d/class.xml
  I18N      data/device/pcisig.com/pci-8086-2415.d/class.xml
  I18N      data/device/pcisig.com/pci-1013-00b8.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1043.d/class.xml
  I18N      data/device/pcisig.com/pci-1000-0012.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1009.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1001.d/class.xml
  I18N      data/device/pcisig.com/pci-8086-100e.d/class.xml
  I18N      data/device/pcisig.com/pci-8086-2668.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1045.d/class.xml
  I18N      data/device/pcisig.com/pci-1b36-0100.d/class.xml
  I18N      data/device/pcisig.com/pci-1022-2000.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1004.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1002.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1041.d/class.xml
  I18N      data/device/pcisig.com/pci-1af4-1000.d/class.xml
  I18N      data/device/pcisig.com/pci-1274-5000.d/class.xml
  I18N      data/device/pcisig.com/pci-15ad-0710.d/class.xml
  I18N      data/device/usb.org/usb-80ee-0021.d/class.xml
  GEN       data/schema/osinfo.rng
  EXP       osinfo-db-20180504.tar.xz
  GEN       osinfo-db.spec
  GEN       mingw-osinfo-db.spec
[fidencio at machado osinfo-db]$ export OSINFO_SYSTEM_DIR=$PWD/data
[fidencio at machado osinfo-db]$ cd ../libosinfo/
[fidencio at machado libosinfo]$ make check
Making check in osinfo
make[1]: Entering directory '/home/fidencio/src/upstream/libosinfo/osinfo'
make  check-am
make[2]: Entering directory '/home/fidencio/src/upstream/libosinfo/osinfo'
  GEN      libosinfo-1.0.vapi
Generation succeeded - 0 warning(s)
make  check-local
make[3]: Entering directory '/home/fidencio/src/upstream/libosinfo/osinfo'
  GEN      check-symfile
  GEN      check-symsorting
make[3]: Leaving directory '/home/fidencio/src/upstream/libosinfo/osinfo'
make[2]: Leaving directory '/home/fidencio/src/upstream/libosinfo/osinfo'
make[1]: Leaving directory '/home/fidencio/src/upstream/libosinfo/osinfo'
Making check in tools
make[1]: Entering directory '/home/fidencio/src/upstream/libosinfo/tools'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/fidencio/src/upstream/libosinfo/tools'
Making check in docs
make[1]: Entering directory '/home/fidencio/src/upstream/libosinfo/docs'
Making check in reference
make[2]: Entering directory
'/home/fidencio/src/upstream/libosinfo/docs/reference'
make[2]: Leaving directory
'/home/fidencio/src/upstream/libosinfo/docs/reference'
make[2]: Entering directory '/home/fidencio/src/upstream/libosinfo/docs'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/home/fidencio/src/upstream/libosinfo/docs'
make[1]: Leaving directory '/home/fidencio/src/upstream/libosinfo/docs'
Making check in po
make[1]: Entering directory '/home/fidencio/src/upstream/libosinfo/po'
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
if [ -r missing -o -r notexist ]; then \
  exit 1; \
fi
make[1]: Leaving directory '/home/fidencio/src/upstream/libosinfo/po'
Making check in examples
make[1]: Entering directory '/home/fidencio/src/upstream/libosinfo/examples'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/fidencio/src/upstream/libosinfo/examples'
Making check in tests
make[1]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
make  test-entity test-device test-list test-devicelist test-filter
test-product test-os test-oslist test-productfilter test-platform
test-platformlist test-db test-loader test-isodetect
test-install-script
make[2]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
make[2]: 'test-entity' is up to date.
make[2]: 'test-device' is up to date.
make[2]: 'test-list' is up to date.
make[2]: 'test-devicelist' is up to date.
make[2]: 'test-filter' is up to date.
make[2]: 'test-product' is up to date.
make[2]: 'test-os' is up to date.
make[2]: 'test-oslist' is up to date.
make[2]: 'test-productfilter' is up to date.
make[2]: 'test-platform' is up to date.
make[2]: 'test-platformlist' is up to date.
make[2]: 'test-db' is up to date.
make[2]: 'test-loader' is up to date.
make[2]: 'test-isodetect' is up to date.
make[2]: 'test-install-script' is up to date.
make[2]: Leaving directory '/home/fidencio/src/upstream/libosinfo/tests'
make  check-TESTS
make[2]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
make[3]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
PASS: test-entity
PASS: test-device
PASS: test-list
PASS: test-devicelist
PASS: test-filter
PASS: test-product
PASS: test-os
PASS: test-oslist
PASS: test-productfilter
PASS: test-platform
PASS: test-platformlist
PASS: test-db
PASS: test-loader
PASS: test-isodetect
PASS: test-install-script
============================================================================
Testsuite summary for libosinfo 1.2.0
============================================================================
# TOTAL: 15
# PASS:  15
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/home/fidencio/src/upstream/libosinfo/tests'
make[2]: Leaving directory '/home/fidencio/src/upstream/libosinfo/tests'
make[1]: Leaving directory '/home/fidencio/src/upstream/libosinfo/tests'
make[1]: Entering directory '/home/fidencio/src/upstream/libosinfo'
make[1]: Leaving directory '/home/fidencio/src/upstream/libosinfo'
  GEN      public-submodule-commit
[fidencio at machado libosinfo]$


>
> --
> Andrea Bolognani / Red Hat / Virtualization
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



From abologna at redhat.com  Fri May  4 14:00:25 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Fri, 04 May 2018 16:00:25 +0200
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
In-Reply-To: <CAAY6Xsf6g8pcEyw7jM8yr8g-yENqM4qKFGiTtrhfojZEOX1Q4g@mail.gmail.com>
References: <20180503150919.10425-1-abologna@redhat.com>
	<20180503151219.GF11382@redhat.com>
	<1525361144.16525.9.camel@redhat.com>
	<CAAY6Xsf6g8pcEyw7jM8yr8g-yENqM4qKFGiTtrhfojZEOX1Q4g@mail.gmail.com>
Message-ID: <38f2001e04e296ec1f686e239572d3461ff4047c.camel@redhat.com>

On Fri, 2018-05-04 at 09:42 +0200, Fabiano Fid?ncio wrote:
> > Now /isodetect/rhel passes, and I get
> > 
> >   /isodetect/opensuse:
> >   ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:24007): ERROR **: ISO openSUSE-Leap-42.3-NET-x86_64.iso.txt was not matched by OS opensuse42.3
> >   Trace/breakpoint trap (core dumped)
> > 
> > instead. Progress? :)
> 
> Sorry for the long email.
> 
> Here's the output of how I check that our tests are passing:
> 
> [fidencio at machado osinfo-db]$ make
>   I18N      data/datamap/microsoft.com/win-7-l10n-language.xml
[...]
>   GEN       data/schema/osinfo.rng
>   EXP       osinfo-db-20180504.tar.xz
>   GEN       osinfo-db.spec
>   GEN       mingw-osinfo-db.spec
> [fidencio at machado osinfo-db]$ export OSINFO_SYSTEM_DIR=$PWD/data
> [fidencio at machado osinfo-db]$ cd ../libosinfo/
> [fidencio at machado libosinfo]$ make check
[...]
> make  check-TESTS
> make[2]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
> make[3]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
> PASS: test-entity
[...]
> PASS: test-isodetect
> PASS: test-install-script
> ============================================================================
> Testsuite summary for libosinfo 1.2.0
> ============================================================================
> # TOTAL: 15
> # PASS:  15
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  0
> # XPASS: 0
> # ERROR: 0
> ============================================================================

Your step are not identical, but equivalent, to the ones I use.
Following your instructions to the letter didn't help.

Weirdly, I'm only seeing this failure on Fedora 27: I tried with
Debian 9 and Fedora 28 and it worked fine both times, so there's
probably something wrong with my guest rather than with libosinfo :)

Either way, as soon as someone'll be kind enough to push my patch
we'll see the results popping up on the CI environment ;)

-- 
Andrea Bolognani / Red Hat / Virtualization



From berrange at redhat.com  Fri May  4 14:21:04 2018
From: berrange at redhat.com (Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?=)
Date: Fri, 4 May 2018 15:21:04 +0100
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
In-Reply-To: <38f2001e04e296ec1f686e239572d3461ff4047c.camel@redhat.com>
References: <20180503150919.10425-1-abologna@redhat.com>
	<20180503151219.GF11382@redhat.com>
	<1525361144.16525.9.camel@redhat.com>
	<CAAY6Xsf6g8pcEyw7jM8yr8g-yENqM4qKFGiTtrhfojZEOX1Q4g@mail.gmail.com>
	<38f2001e04e296ec1f686e239572d3461ff4047c.camel@redhat.com>
Message-ID: <20180504142104.GQ29999@redhat.com>

On Fri, May 04, 2018 at 04:00:25PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-05-04 at 09:42 +0200, Fabiano Fid?ncio wrote:
> > > Now /isodetect/rhel passes, and I get
> > > 
> > >   /isodetect/opensuse:
> > >   ** (/home/test/libosinfo/tests/.libs/lt-test-isodetect:24007): ERROR **: ISO openSUSE-Leap-42.3-NET-x86_64.iso.txt was not matched by OS opensuse42.3
> > >   Trace/breakpoint trap (core dumped)
> > > 
> > > instead. Progress? :)
> > 
> > Sorry for the long email.
> > 
> > Here's the output of how I check that our tests are passing:
> > 
> > [fidencio at machado osinfo-db]$ make
> >   I18N      data/datamap/microsoft.com/win-7-l10n-language.xml
> [...]
> >   GEN       data/schema/osinfo.rng
> >   EXP       osinfo-db-20180504.tar.xz
> >   GEN       osinfo-db.spec
> >   GEN       mingw-osinfo-db.spec
> > [fidencio at machado osinfo-db]$ export OSINFO_SYSTEM_DIR=$PWD/data
> > [fidencio at machado osinfo-db]$ cd ../libosinfo/
> > [fidencio at machado libosinfo]$ make check
> [...]
> > make  check-TESTS
> > make[2]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
> > make[3]: Entering directory '/home/fidencio/src/upstream/libosinfo/tests'
> > PASS: test-entity
> [...]
> > PASS: test-isodetect
> > PASS: test-install-script
> > ============================================================================
> > Testsuite summary for libosinfo 1.2.0
> > ============================================================================
> > # TOTAL: 15
> > # PASS:  15
> > # SKIP:  0
> > # XFAIL: 0
> > # FAIL:  0
> > # XPASS: 0
> > # ERROR: 0
> > ============================================================================
> 
> Your step are not identical, but equivalent, to the ones I use.
> Following your instructions to the letter didn't help.
> 
> Weirdly, I'm only seeing this failure on Fedora 27: I tried with
> Debian 9 and Fedora 28 and it worked fine both times, so there's
> probably something wrong with my guest rather than with libosinfo :)

Last time I investigated this kind of wierd problem, I found that it was
caused by non-deterministic file ordering from readdir(), combined with
multiple matches by different osinfo files. That should have been fixed
by:

commit aa06a8b2905f7ee488b1215e35e486cd36c2df26
Author: Daniel P. Berrang? <berrange at redhat.com>
Date:   Fri Mar 16 13:18:22 2018 +0000

    loader: process files in alphabetical order
    
    Currently when loading DB files we process them in whatever order
    readdir() returns them in, which is often inode order. This makes the
    order of loading files non-deterministic across installs, and if there
    are ambiguities in the data, we can in turn get different results.
    eg ISO images match different OS entries depending on load order.
    
    Alphabetically sorting the files doesn't remove any ambiguity that
    may exist, but at least gives us consistent results on every host.
    
    Signed-off-by: Daniel P. Berrang? <berrange at redhat.com>
    Reviewed-by: Fabiano Fid?ncio <fabiano at fidencio.org>



Is it possible that your $HOME/.config/osinfo directory has some
stale content perhaps.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From berrange at redhat.com  Fri May  4 14:22:41 2018
From: berrange at redhat.com (Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?=)
Date: Fri, 4 May 2018 15:22:41 +0100
Subject: [Libosinfo] [PATCH] rhel: Fix isodata for RHEL 7.5 on ppc64le
In-Reply-To: <1525419525.16525.14.camel@redhat.com>
References: <20180503150919.10425-1-abologna@redhat.com>
	<20180503151233.GG11382@redhat.com>
	<1525419525.16525.14.camel@redhat.com>
Message-ID: <20180504142241.GR29999@redhat.com>

On Fri, May 04, 2018 at 09:38:45AM +0200, Andrea Bolognani wrote:
> [re-adding libosinfo]
> 
> On Thu, 2018-05-03 at 16:12 +0100, Daniel P. Berrang? wrote:
> > On Thu, May 03, 2018 at 05:09:19PM +0200, Andrea Bolognani wrote:
> > > There is a spurious empty line at the end of the file that
> > > causes 'make syntax-check' to fail with:
> > > 
> > >   [...]
> > >   tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt
> > >   maint.mk: empty line(s) or no newline at EOF
> > >   make: *** [maint.mk:927: sc_prohibit_empty_lines_at_EOF] Error 1
> > > 
> > > Get rid of it to solve the issue.
> > > 
> > > See also
> > > 
> > >   https://ci.centos.org/view/libvirt/job/libosinfo-master-syntax-check/123/
> > > 
> > > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> > 
> > Reviewed-by: Daniel P. Berrang? <berrange at redhat.com>
> 
> This was probably supposed to go to the list ;)
> 
> Also, I don't have commit access to libosinfo projects, so someone
> else will have to push it.

Opps, I have pushed it now.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From fabiano at fidencio.org  Fri May  4 20:25:48 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Fri, 4 May 2018 22:25:48 +0200
Subject: [Libosinfo] [libosinfo] tests: Add test-os-resources
In-Reply-To: <20180410102944.GH24364@natto.ory.fergeau.eu>
References: <20171117145327.32611-1-fabiano@fidencio.org>
	<20171117145327.32611-3-fabiano@fidencio.org>
	<20180410102944.GH24364@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9JXnVFTS8=WVV-nqMu3+EqMWaK4=vKZ4zH+0OSKaDD5Ug@mail.gmail.com>

On Tue, Apr 10, 2018 at 12:29 PM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Fri, Nov 17, 2017 at 03:53:27PM +0100, Fabiano Fid?ncio wrote:
>> test-os-resources has been written to avoid bug as having minimum
>> resources greater than the recommended resources in osinfo-db.
>>
>> It has been hitting (without any harm no far) by RHEL/CentOS data files,
>> which caused so really bad UI effect on clients using those two
>> attributes (as in GNOME Boxes).
>>
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  tests/Makefile.am         |   5 ++
>>  tests/test-os-resources.c | 184 ++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 189 insertions(+)
>>  create mode 100644 tests/test-os-resources.c
>>
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> index 7566d3c..06f81bf 100644
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -17,6 +17,7 @@ check_PROGRAMS = \
>>       test-loader \
>>       test-isodetect \
>>       test-install-script \
>> +     test-os-resources \
>>          $(NULL)
>>
>>  if HAVE_CURL
>> @@ -111,6 +112,10 @@ test_install_script_LDADD = $(COMMON_LDADD)
>>  test_install_script_CFLAGS = $(COMMON_CFLAGS)
>>  test_install_script_SOURCES = test-install-script.c
>>
>> +test_os_resources_LDADD = $(COMMON_LDADD)
>> +test_os_resources_CFLAGS = $(COMMON_CFLAGS)
>> +test_os_resources_SOURCES = test-os-resources.c
>> +
>>  TESTS = $(check_PROGRAMS) \
>>       $(NULL)
>>
>> diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c
>> new file mode 100644
>> index 0000000..9942d9c
>> --- /dev/null
>> +++ b/tests/test-os-resources.c
>> @@ -0,0 +1,184 @@
>> +/*
>> + * Copyright (C) 2017 Fabiano Fid?ncio
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License along
>> + * with this program; if not, write to the Free Software Foundation,
>> + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
>> + *
>> + * Authors:
>> + *   Fabiano Fid?ncio <fabiano at fidencio.org>
>> + */
>> +
>> +#include <config.h>
>> +
>> +#include <stdlib.h>
>> +#include <osinfo/osinfo.h>
>> +
>> +
>> +static void test_n_cpus(OsinfoResources *minimum, OsinfoResources *recommended)
>> +{
>> +    gint minimum_cpus, recommended_cpus;
>> +
>> +    minimum_cpus = osinfo_resources_get_n_cpus(minimum);
>> +    recommended_cpus = osinfo_resources_get_n_cpus(recommended);
>> +
>> +    if (recommended_cpus >= 0 && minimum_cpus >= 0)
>> +        g_assert_true(recommended_cpus >= minimum_cpus);
>
> Is it 0 if unspecified in the XML? Aren't we going to miss the case when
> a minimum CPU value is specified, but not a recommended CPU value? or is
> it fine in this case? Same question for the other tests.

If it's unspecified in the XML we get -1.
The apps using libosinfo should be aware of this (it's documented) and
use the minimum in case the recommended is not found.

Does this answer your question?

>
>> +static void
>> +test_minimum_recommended_resources(void)
>> +{
>> +    OsinfoLoader *loader = osinfo_loader_new();
>> +    OsinfoDb *db = osinfo_loader_get_db(loader);
>> +    OsinfoOsList *oslist;
>> +    GList *oses;
>> +    GError *error = NULL;
>> +
>> +    g_assert_true(OSINFO_IS_LOADER(loader));
>> +    g_assert_true(OSINFO_IS_DB(db));
>> +
>> +    osinfo_loader_process_default_path(loader, &error);
>> +    g_assert_no_error(error);
>> +
>> +    oslist = osinfo_db_get_os_list(db);
>> +    oses = osinfo_list_get_elements(OSINFO_LIST(oslist));
>> +
>> +    for (; oses != NULL; oses = oses->next) {
>> +        OsinfoOs *os = oses->data;
>> +        OsinfoResourcesList *minimum_list, *recommended_list;
>> +        GList *minimum_resources, *recommended_resources;
>> +        const gchar *minimum_arch, * recommended_arch;
>> +
>> +        minimum_list = osinfo_os_get_minimum_resources(os);
>> +        minimum_resources = osinfo_list_get_elements(OSINFO_LIST(minimum_list));
>> +
>> +        recommended_list = osinfo_os_get_recommended_resources(os);
>> +        recommended_resources = osinfo_list_get_elements(OSINFO_LIST(recommended_list));
>> +
>> +        /* That's fine as not all OSes have those fields filled */
>> +        if (minimum_resources == NULL || recommended_resources == NULL)
>> +            continue;
>> +
>> +        for (; minimum_resources != NULL;
>> +                minimum_resources = minimum_resources->next) {
>> +            OsinfoResources *minimum = minimum_resources->data;
>> +            GList *tmp = recommended_resources;
>> +
>> +            minimum_arch = osinfo_resources_get_architecture(minimum);
>> +
>> +
>
> Maybe get rid of one of the extra spaces here

Done!

>
>> +            for (; tmp != NULL; tmp = tmp->next) {
>> +                OsinfoResources *recommended = tmp->data;
>> +
>> +                recommended_arch = osinfo_resources_get_architecture(recommended);
>> +
>> +                 if (g_str_equal(minimum_arch, recommended_arch)) {
>> +                    const gchar *name;
>> +
>> +                    name = osinfo_product_get_name(OSINFO_PRODUCT(os));
>> +
>> +                    g_test_message("checking %s (architecture: %s)",
>> +                                   name, minimum_arch);
>
> Is there a way to get this message to be displayed? I only could get it
> through --debug-log, but this seems a bit too low-level. I could not
> find it in the test logs.

One thing that could be done (and not only for this test) would be to
use g_debug() instead of g_test_message().
For now, I'd stick with the pattern seen/used in the other tests (just
using g_test_message()).

>
>> +
>> +                    test_n_cpus(minimum, recommended);
>> +                    test_cpu(minimum, recommended);
>> +                    test_ram(minimum, recommended);
>> +                    test_storage(minimum, recommended);
>> +                    break;
>> +                }
>> +            }
>> +        }
>> +
>> +        g_object_unref(minimum_list);
>> +        g_object_unref(recommended_list);
>> +    }
>> +
>> +    if (oslist)
>> +        g_object_unref(oslist);
>
> Higher up in the function, you did:
>
> +    oslist = osinfo_db_get_os_list(db);
> +    oses = osinfo_list_get_elements(OSINFO_LIST(oslist));
>
> I would expect the test to have failed at this point if 'oslist' is
> NULL. In other word, I think you can just remove the if (oslist) check.

True, done!

>
> I fixed a few leaks in that function, see attached patch.

I've squashed your patch into mine.

>
>> +
>> +    g_object_unref(loader);
>> +}
>> +
>> +
>> +int
>> +main(int argc, char *argv[])
>> +{
>> +    int ret;
>> +
>> +    g_test_init(&argc, &argv, NULL);
>> +
>> +    g_test_add_func("/os/resources/minimum_recommended", test_minimum_recommended_resources);
>> +
>> +    /* Make sure we catch unexpected g_warning() */
>> +    g_log_set_always_fatal(G_LOG_LEVEL_ERROR | G_LOG_LEVEL_CRITICAL | G_LOG_LEVEL_WARNING);
>
> Nope, this is not needed when using GTest, actually I have a patch on
> the mailing list removing it from all the tests which is waiting for a
> review ;)

I've merged your patch a month or so ago. :-)
Unfortunately my patch was sent before yours was merged. Anyways, fixed.

>
> Apart from these comments, looks good to me.
>
> Christophe

I'll submit a v2 soon. Thanks for the review.

-- 
Fabiano Fid?ncio



From fidencio at redhat.com  Fri May  4 20:34:09 2018
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Fri,  4 May 2018 22:34:09 +0200
Subject: [Libosinfo] [libosinfo][PATCH v2] tests: Add test-os-resources
Message-ID: <20180504203409.20560-1-fidencio@redhat.com>

From: Fabiano Fid?ncio <fabiano at fidencio.org>

test-os-resources has been written to avoid bug as having minimum
resources greater than the recommended resources in osinfo-db.

This problem was exposed by RHEL/CentOS data files, which caused some
really bad UI effect in clientes using those two attributes (as GNOME
Boxes).

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 tests/Makefile.am         |   5 ++
 tests/test-os-resources.c | 184 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 189 insertions(+)
 create mode 100644 tests/test-os-resources.c

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7566d3c..06f81bf 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -17,6 +17,7 @@ check_PROGRAMS = \
 	test-loader \
 	test-isodetect \
 	test-install-script \
+	test-os-resources \
         $(NULL)
 
 if HAVE_CURL
@@ -111,6 +112,10 @@ test_install_script_LDADD = $(COMMON_LDADD)
 test_install_script_CFLAGS = $(COMMON_CFLAGS)
 test_install_script_SOURCES = test-install-script.c
 
+test_os_resources_LDADD = $(COMMON_LDADD)
+test_os_resources_CFLAGS = $(COMMON_CFLAGS)
+test_os_resources_SOURCES = test-os-resources.c
+
 TESTS = $(check_PROGRAMS) \
 	$(NULL)
 
diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c
new file mode 100644
index 0000000..f7a8039
--- /dev/null
+++ b/tests/test-os-resources.c
@@ -0,0 +1,184 @@
+/*
+ * Copyright (C) 2017 Fabiano Fid?ncio
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ *
+ * Authors:
+ *   Fabiano Fid?ncio <fabiano at fidencio.org>
+ */
+
+#include <config.h>
+
+#include <stdlib.h>
+#include <osinfo/osinfo.h>
+
+
+static void test_n_cpus(OsinfoResources *minimum, OsinfoResources *recommended)
+{
+    gint minimum_cpus, recommended_cpus;
+
+    minimum_cpus = osinfo_resources_get_n_cpus(minimum);
+    recommended_cpus = osinfo_resources_get_n_cpus(recommended);
+
+    if (recommended_cpus >= 0 && minimum_cpus >= 0)
+        g_assert_true(recommended_cpus >= minimum_cpus);
+}
+
+
+static void test_cpu(OsinfoResources *minimum, OsinfoResources *recommended)
+{
+    gint64 minimum_cpu, recommended_cpu;
+
+    minimum_cpu = osinfo_resources_get_cpu(minimum);
+    recommended_cpu = osinfo_resources_get_cpu(recommended);
+
+    if (recommended_cpu >= 0 && minimum_cpu >= 0)
+        g_assert_true(recommended_cpu >= minimum_cpu);
+}
+
+
+static void test_ram(OsinfoResources *minimum, OsinfoResources *recommended)
+{
+    gint64 minimum_ram, recommended_ram;
+
+    minimum_ram = osinfo_resources_get_ram(minimum);
+    recommended_ram = osinfo_resources_get_ram(recommended);
+
+    if (recommended_ram >= 0 && minimum_ram >= 0)
+        g_assert_true(recommended_ram >= minimum_ram);
+}
+
+
+static void test_storage(OsinfoResources *minimum, OsinfoResources *recommended)
+{
+    gint64 minimum_storage, recommended_storage;
+
+    minimum_storage = osinfo_resources_get_storage(minimum);
+    recommended_storage = osinfo_resources_get_storage(recommended);
+
+    if (recommended_storage >= 0 && minimum_storage >= 0)
+        g_assert_true(recommended_storage >= minimum_storage);
+}
+
+static void
+test_minimum_recommended_resources(void)
+{
+    OsinfoLoader *loader = osinfo_loader_new();
+    OsinfoDb *db = osinfo_loader_get_db(loader);
+    OsinfoOsList *oslist;
+    GList *oses;
+    GList *oses_it;
+    GError *error = NULL;
+
+    g_assert_true(OSINFO_IS_LOADER(loader));
+    g_assert_true(OSINFO_IS_DB(db));
+
+    osinfo_loader_process_default_path(loader, &error);
+    g_assert_no_error(error);
+
+    oslist = osinfo_db_get_os_list(db);
+    oses = osinfo_list_get_elements(OSINFO_LIST(oslist));
+
+    for (oses_it = oses; oses_it != NULL; oses_it = oses_it->next) {
+        OsinfoOs *os = oses->data;
+        OsinfoResourcesList *minimum_list, *recommended_list;
+        GList *minimum_resources, *recommended_resources;
+        GList *resources_it;
+        const gchar *minimum_arch, *recommended_arch;
+
+        minimum_list = osinfo_os_get_minimum_resources(os);
+        minimum_resources = osinfo_list_get_elements(OSINFO_LIST(minimum_list));
+
+        recommended_list = osinfo_os_get_recommended_resources(os);
+        recommended_resources = osinfo_list_get_elements(OSINFO_LIST(recommended_list));
+
+        /* That's fine as not all OSes have those fields filled */
+        if (minimum_resources == NULL || recommended_resources == NULL)
+            goto next;
+
+        for (resources_it = minimum_resources; resources_it != NULL; resources_it = resources_it->next) {
+            OsinfoResources *minimum = resources_it->data;
+            GList *tmp = recommended_resources;
+
+            minimum_arch = osinfo_resources_get_architecture(minimum);
+
+            for (; tmp != NULL; tmp = tmp->next) {
+                OsinfoResources *recommended = tmp->data;
+
+                recommended_arch = osinfo_resources_get_architecture(recommended);
+
+                 if (g_str_equal(minimum_arch, recommended_arch)) {
+                    const gchar *name;
+
+                    name = osinfo_product_get_name(OSINFO_PRODUCT(os));
+
+                    g_test_message("checking %s (architecture: %s)",
+                                   name, minimum_arch);
+
+                    test_n_cpus(minimum, recommended);
+                    test_cpu(minimum, recommended);
+                    test_ram(minimum, recommended);
+                    test_storage(minimum, recommended);
+                    break;
+                }
+            }
+        }
+
+next:
+        g_list_free(minimum_resources);
+        g_list_free(recommended_resources);
+        g_object_unref(minimum_list);
+        g_object_unref(recommended_list);
+    }
+
+    g_object_unref(oslist);
+    g_list_free(oses);
+
+    g_object_unref(loader);
+}
+
+
+int
+main(int argc, char *argv[])
+{
+    int ret;
+
+    g_test_init(&argc, &argv, NULL);
+
+    g_test_add_func("/os/resources/minimum_recommended", test_minimum_recommended_resources);
+
+    /* Upfront so we don't confuse valgrind */
+    osinfo_entity_get_type();
+    osinfo_db_get_type();
+    osinfo_device_get_type();
+    osinfo_platform_get_type();
+    osinfo_os_get_type();
+    osinfo_list_get_type();
+    osinfo_devicelist_get_type();
+    osinfo_platformlist_get_type();
+    osinfo_oslist_get_type();
+    osinfo_filter_get_type();
+
+    ret = g_test_run();
+
+    return ret;
+}
+/*
+ * Local variables:
+ *  indent-tabs-mode: nil
+ *  c-indent-level: 4
+ *  c-basic-offset: 4
+ * End:
+ */
-- 
2.14.3



From abologna at redhat.com  Mon May  7 14:51:23 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:51:23 +0200
Subject: [Libosinfo] [PATCH v2 0/3] Remove Test::AutoBuild leftovers
Message-ID: <20180507145126.25778-1-abologna@redhat.com>

Changes from [v1]:

* rename the script instead of dropping it;

* perform some further clean ups.


[v1] https://www.redhat.com/archives/libosinfo/2018-May/msg00007.html

Andrea Bolognani (3):
  maint: Rename autobuild.sh to prepare-release.sh
  prepare-release: Drop references to Test::AutoBuild
  spec: Drop %{extra_release}

 libosinfo.spec.in                  |  2 +-
 mingw-libosinfo.spec.in            |  2 +-
 autobuild.sh => prepare-release.sh | 21 ++++++---------------
 3 files changed, 8 insertions(+), 17 deletions(-)
 rename autobuild.sh => prepare-release.sh (73%)

-- 
2.17.0



From abologna at redhat.com  Mon May  7 14:51:24 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:51:24 +0200
Subject: [Libosinfo] [PATCH v2 1/3] maint: Rename autobuild.sh to
	prepare-release.sh
In-Reply-To: <20180507145126.25778-1-abologna@redhat.com>
References: <20180507145126.25778-1-abologna@redhat.com>
Message-ID: <20180507145126.25778-2-abologna@redhat.com>

The script was originally used by the Test::AutoBuild
project to perform periodic automatic builds; however, that
effort has been abandoned a long time ago, and these days
libosinfo CI builds are happening on the Jenkins-based
CentOS CI environment under the libvirt umbrella[1], where
build recipes are maintained separately from the projects
themselves.

The script is still used to prepare releases, so it can't
be dropped from the repository: rename it so that its
purpose is more clearly communicated instead.

[1] https://ci.centos.org/view/libvirt/

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 autobuild.sh => prepare-release.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename autobuild.sh => prepare-release.sh (100%)

diff --git a/autobuild.sh b/prepare-release.sh
similarity index 100%
rename from autobuild.sh
rename to prepare-release.sh
-- 
2.17.0



From abologna at redhat.com  Mon May  7 14:51:25 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:51:25 +0200
Subject: [Libosinfo] [PATCH v2 2/3] prepare-release: Drop references to
	Test::AutoBuild
In-Reply-To: <20180507145126.25778-1-abologna@redhat.com>
References: <20180507145126.25778-1-abologna@redhat.com>
Message-ID: <20180507145126.25778-3-abologna@redhat.com>

They are misleading, and no longer relevant anyway.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 prepare-release.sh | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/prepare-release.sh b/prepare-release.sh
index 1db1fce..30aac2a 100755
--- a/prepare-release.sh
+++ b/prepare-release.sh
@@ -4,7 +4,7 @@ set -e
 set -v
 
 test -n "$1" && RESULTS=$1 || RESULTS=results.log
-: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder}
+INSTALL_ROOT=$HOME/builder
 
 # Make things clean.
 test -f Makefile && make -k distclean || :
@@ -13,7 +13,7 @@ rm -rf build
 mkdir build
 cd build
 
-../autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \
+../autogen.sh --prefix=$INSTALL_ROOT \
     --enable-werror --enable-gtk-doc
 
 # If the MAKEFLAGS envvar does not yet include a -j option,
@@ -43,12 +43,8 @@ test "$st" = 0
 rm -f *.tar.gz
 make dist
 
-if [ -n "$AUTOBUILD_COUNTER" ]; then
-  EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
-else
-  NOW=`date +"%s"`
-  EXTRA_RELEASE=".$USER$NOW"
-fi
+NOW=`date +"%s"`
+EXTRA_RELEASE=".$USER$NOW"
 
 if [ -f /usr/bin/rpmbuild ]; then
   rpmbuild --nodeps \
@@ -61,12 +57,12 @@ fi
 if test -x /usr/bin/i686-w64-mingw32-gcc ; then
   make distclean
 
-  PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
+  PKG_CONFIG_PATH="$INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
   CC="i686-w64-mingw32-gcc" \
   ../configure \
     --build=$(uname -m)-pc-linux \
     --host=i686-w64-mingw32 \
-    --prefix="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \
+    --prefix="$INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \
     --enable-werror \
     --enable-introspection=no \
     --enable-tests=no
@@ -80,12 +76,12 @@ fi
 if test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
   make distclean
 
-  PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
+  PKG_CONFIG_PATH="$INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
   CC="x86_64-w64-mingw32-gcc" \
   ../configure \
     --build=$(uname -m)-pc-linux \
     --host=x86_64-w64-mingw32 \
-    --prefix="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \
+    --prefix="$INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \
     --enable-werror \
     --enable-introspection=no \
     --enable-tests=no
-- 
2.17.0



From abologna at redhat.com  Mon May  7 14:51:26 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:51:26 +0200
Subject: [Libosinfo] [PATCH v2 3/3] spec: Drop %{extra_release}
In-Reply-To: <20180507145126.25778-1-abologna@redhat.com>
References: <20180507145126.25778-1-abologna@redhat.com>
Message-ID: <20180507145126.25778-4-abologna@redhat.com>

It was mainly meant to be used for automatic builds through
Test::AutoBuild, so it can be removed now.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 libosinfo.spec.in       | 2 +-
 mingw-libosinfo.spec.in | 2 +-
 prepare-release.sh      | 5 -----
 3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/libosinfo.spec.in b/libosinfo.spec.in
index f3e3690..0acc3a7 100644
--- a/libosinfo.spec.in
+++ b/libosinfo.spec.in
@@ -3,7 +3,7 @@
 Summary: A library for managing OS information for virtualization
 Name: libosinfo
 Version: @VERSION@
-Release: 1%{?dist}%{?extra_release}
+Release: 1%{?dist}
 License: LGPLv2+
 Group: Development/Libraries
 Source: https://releases.pagure.io/%{name}/%{name}-%{version}.tar.gz
diff --git a/mingw-libosinfo.spec.in b/mingw-libosinfo.spec.in
index 526d65a..dbde214 100644
--- a/mingw-libosinfo.spec.in
+++ b/mingw-libosinfo.spec.in
@@ -2,7 +2,7 @@
 
 Name: mingw-libosinfo
 Version: @VERSION@
-Release: 1%{?dist}%{?extra_release}
+Release: 1%{?dist}
 Summary: MinGW Windows port of a library for managing OS information for virtualization
 License: LGPLv2+
 Group: Development/Libraries
diff --git a/prepare-release.sh b/prepare-release.sh
index 30aac2a..f1fe696 100755
--- a/prepare-release.sh
+++ b/prepare-release.sh
@@ -43,12 +43,8 @@ test "$st" = 0
 rm -f *.tar.gz
 make dist
 
-NOW=`date +"%s"`
-EXTRA_RELEASE=".$USER$NOW"
-
 if [ -f /usr/bin/rpmbuild ]; then
   rpmbuild --nodeps \
-     --define "extra_release $EXTRA_RELEASE" \
      --define "_sourcedir `pwd`" \
      -ba --clean libosinfo.spec
 fi
@@ -94,7 +90,6 @@ fi
 if test -x /usr/bin/i686-w64-mingw32-gcc && test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
   if test -f /usr/bin/rpmbuild ; then
     rpmbuild --nodeps \
-       --define "extra_release $EXTRA_RELEASE" \
        --define "_sourcedir `pwd`" \
        -ba --clean mingw-libosinfo.spec
   fi
-- 
2.17.0



From abologna at redhat.com  Mon May  7 14:57:59 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:57:59 +0200
Subject: [Libosinfo] [osinfo-db PATCH v2 0/3] Remove Test::AutoBuild
	leftovers
Message-ID: <20180507145802.27139-1-abologna@redhat.com>

Changes from [v1]:

* rename the script instead of dropping it;

* perform some further clean ups.


[v1] https://www.redhat.com/archives/libosinfo/2018-May/msg00008.html

Andrea Bolognani (3):
  maint: Rename autobuild.sh to prepare-release.sh
  prepare-release: Drop references to Test::AutoBuild
  spec: Drop %{extra_release}

 mingw-osinfo-db.spec.in            |  2 +-
 osinfo-db.spec.in                  |  2 +-
 autobuild.sh => prepare-release.sh | 13 ++-----------
 3 files changed, 4 insertions(+), 13 deletions(-)
 rename autobuild.sh => prepare-release.sh (69%)

-- 
2.17.0



From abologna at redhat.com  Mon May  7 14:58:00 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:58:00 +0200
Subject: [Libosinfo] [osinfo-db PATCH v2 1/3] maint: Rename autobuild.sh to
	prepare-release.sh
In-Reply-To: <20180507145802.27139-1-abologna@redhat.com>
References: <20180507145802.27139-1-abologna@redhat.com>
Message-ID: <20180507145802.27139-2-abologna@redhat.com>

The script was originally used by the Test::AutoBuild
project to perform periodic automatic builds; however, that
effort has been abandoned a long time ago, and these days
osinfo-db CI builds are happening on the Jenkins-based
CentOS CI environment under the libvirt umbrella[1], where
build recipes are maintained separately from the projects
themselves.

The script is still used to prepare releases, so it can't
be dropped from the repository: rename it so that its
purpose is more clearly communicated instead.

[1] https://ci.centos.org/view/libvirt/

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 autobuild.sh => prepare-release.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename autobuild.sh => prepare-release.sh (100%)

diff --git a/autobuild.sh b/prepare-release.sh
similarity index 100%
rename from autobuild.sh
rename to prepare-release.sh
-- 
2.17.0



From abologna at redhat.com  Mon May  7 14:58:01 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:58:01 +0200
Subject: [Libosinfo] [osinfo-db PATCH v2 2/3] prepare-release: Drop
	references to Test::AutoBuild
In-Reply-To: <20180507145802.27139-1-abologna@redhat.com>
References: <20180507145802.27139-1-abologna@redhat.com>
Message-ID: <20180507145802.27139-3-abologna@redhat.com>

They are misleading, and no longer relevant anyway.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 prepare-release.sh | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/prepare-release.sh b/prepare-release.sh
index d82b0ef..1873b7d 100755
--- a/prepare-release.sh
+++ b/prepare-release.sh
@@ -4,7 +4,7 @@ set -e
 set -v
 
 test -n "$1" && RESULTS=$1 || RESULTS=results.log
-: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder}
+INSTALL_ROOT=$HOME/builder
 
 # Make things clean.
 make -k clean
@@ -22,14 +22,10 @@ case $MAKEFLAGS in
 esac
 
 make
-make install DESTDIR="$AUTOBUILD_INSTALL_ROOT" OSINFO_DB_TARGET="--system"
+make install DESTDIR="$INSTALL_ROOT" OSINFO_DB_TARGET="--system"
 
-if [ -n "$AUTOBUILD_COUNTER" ]; then
-  EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
-else
-  NOW=`date +"%s"`
-  EXTRA_RELEASE=".$USER$NOW"
-fi
+NOW=`date +"%s"`
+EXTRA_RELEASE=".$USER$NOW"
 
 if [ -f /usr/bin/rpmbuild ]; then
   rpmbuild --nodeps \
-- 
2.17.0



From abologna at redhat.com  Mon May  7 14:58:02 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Mon,  7 May 2018 16:58:02 +0200
Subject: [Libosinfo] [osinfo-db PATCH v2 3/3] spec: Drop %{extra_release}
In-Reply-To: <20180507145802.27139-1-abologna@redhat.com>
References: <20180507145802.27139-1-abologna@redhat.com>
Message-ID: <20180507145802.27139-4-abologna@redhat.com>

It was mainly meant to be used for automatic builds through
Test::AutoBuild, so it can be removed now.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 mingw-osinfo-db.spec.in | 2 +-
 osinfo-db.spec.in       | 2 +-
 prepare-release.sh      | 5 -----
 3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/mingw-osinfo-db.spec.in b/mingw-osinfo-db.spec.in
index e9c84b4..95b4389 100644
--- a/mingw-osinfo-db.spec.in
+++ b/mingw-osinfo-db.spec.in
@@ -2,7 +2,7 @@
 
 Name: mingw-osinfo-db
 Version: @VERSION@
-Release: 1%{?dist}%{?extra_release}
+Release: 1%{?dist}
 Summary: Database for libosinfo API
 License: GPLv2+
 Group: Development/Libraries
diff --git a/osinfo-db.spec.in b/osinfo-db.spec.in
index 334ee8a..375b2f9 100644
--- a/osinfo-db.spec.in
+++ b/osinfo-db.spec.in
@@ -3,7 +3,7 @@
 Summary: osinfo database files
 Name: osinfo-db
 Version: @VERSION@
-Release: 1%{?dist}%{?extra_release}
+Release: 1%{?dist}
 License: GPLv2+
 Group: Development/Libraries
 Source: https://releases.pagure.io/libosinfo/%{name}-%{version}.tar.xz
diff --git a/prepare-release.sh b/prepare-release.sh
index 1873b7d..39f1ad2 100755
--- a/prepare-release.sh
+++ b/prepare-release.sh
@@ -24,12 +24,8 @@ esac
 make
 make install DESTDIR="$INSTALL_ROOT" OSINFO_DB_TARGET="--system"
 
-NOW=`date +"%s"`
-EXTRA_RELEASE=".$USER$NOW"
-
 if [ -f /usr/bin/rpmbuild ]; then
   rpmbuild --nodeps \
-     --define "extra_release $EXTRA_RELEASE" \
      --define "_sourcedir `pwd`" \
      -ba --clean osinfo-db.spec
 fi
@@ -37,7 +33,6 @@ fi
 if test -x /usr/bin/i686-w64-mingw32-gcc && test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
   if test -f /usr/bin/rpmbuild ; then
     rpmbuild --nodeps \
-       --define "extra_release $EXTRA_RELEASE" \
        --define "_sourcedir `pwd`" \
        -ba --clean mingw-osinfo-db.spec
   fi
-- 
2.17.0



From berrange at redhat.com  Tue May  8 12:35:57 2018
From: berrange at redhat.com (=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?=)
Date: Tue,  8 May 2018 13:35:57 +0100
Subject: [Libosinfo] [PATCH osinfodb] os: fix version for windows 2016
Message-ID: <20180508123557.10470-1-berrange@redhat.com>

The win2k16 version is mistakely set to 1709 which looks like a build
patch level version. For windows distros we are using the NT kernel
version as the version field, since it is the only thing that increments
in a sensible manner across Windows releases.

Signed-off-by: Daniel P. Berrang? <berrange at redhat.com>
---
 data/os/microsoft.com/win-2k16.xml.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/os/microsoft.com/win-2k16.xml.in b/data/os/microsoft.com/win-2k16.xml.in
index 1f1bfc7..523733d 100644
--- a/data/os/microsoft.com/win-2k16.xml.in
+++ b/data/os/microsoft.com/win-2k16.xml.in
@@ -4,7 +4,7 @@
   <os id="http://microsoft.com/win/2k16">
     <short-id>win2k16</short-id>
     <_name>Microsoft Windows Server 2016</_name>
-    <version>1709</version>
+    <version>10.0</version>
     <_vendor>Microsoft Corporation</_vendor>
     <family>winnt</family>
     <distro>win</distro>
-- 
2.17.0



From berrange at redhat.com  Tue May  8 13:38:44 2018
From: berrange at redhat.com (=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?=)
Date: Tue,  8 May 2018 14:38:44 +0100
Subject: [Libosinfo] [PATCH] configure: fix HAVE_CURL conditional on Win32
Message-ID: <20180508133844.30199-1-berrange@redhat.com>

AM_CONDITIONAL lines must always be executed, but HAVE_CURL was inside
an "if ...", which caused configure to fail when run on Win32.

Signed-off-by: Daniel P. Berrang? <berrange at redhat.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index d834c89..f7f1c72 100644
--- a/configure.ac
+++ b/configure.ac
@@ -60,8 +60,8 @@ if test "x$enable_tests" != "xno" ; then
   PKG_CHECK_MODULES([CURL], [libcurl], [have_curl=yes], [:])
   AC_SUBST(CURL_CFLAGS)
   AC_SUBST(CURL_LIBS)
-  AM_CONDITIONAL([HAVE_CURL],[test "x$have_curl" = "xyes"])
 fi
+AM_CONDITIONAL([HAVE_CURL],[test "x$have_curl" = "xyes"])
 
 AM_CONDITIONAL([ENABLE_TESTS],[test "x$enable_tests" = "xyes"])
 
-- 
2.17.0



From berrange at redhat.com  Tue May  8 13:41:43 2018
From: berrange at redhat.com (Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?=)
Date: Tue, 8 May 2018 14:41:43 +0100
Subject: [Libosinfo] [PATCH v2 0/3] Remove Test::AutoBuild leftovers
In-Reply-To: <20180507145126.25778-1-abologna@redhat.com>
References: <20180507145126.25778-1-abologna@redhat.com>
Message-ID: <20180508134143.GU5967@redhat.com>

On Mon, May 07, 2018 at 04:51:23PM +0200, Andrea Bolognani wrote:
> Changes from [v1]:
> 
> * rename the script instead of dropping it;
> 
> * perform some further clean ups.
> 
> 
> [v1] https://www.redhat.com/archives/libosinfo/2018-May/msg00007.html
> 
> Andrea Bolognani (3):
>   maint: Rename autobuild.sh to prepare-release.sh
>   prepare-release: Drop references to Test::AutoBuild
>   spec: Drop %{extra_release}
> 
>  libosinfo.spec.in                  |  2 +-
>  mingw-libosinfo.spec.in            |  2 +-
>  autobuild.sh => prepare-release.sh | 21 ++++++---------------
>  3 files changed, 8 insertions(+), 17 deletions(-)
>  rename autobuild.sh => prepare-release.sh (73%)

For all three patches

Reviewed-by: Daniel P. Berrang? <berrange at redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From berrange at redhat.com  Tue May  8 13:54:45 2018
From: berrange at redhat.com (Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?=)
Date: Tue, 8 May 2018 14:54:45 +0100
Subject: [Libosinfo] [osinfo-db PATCH v2 0/3] Remove Test::AutoBuild
 leftovers
In-Reply-To: <20180507145802.27139-1-abologna@redhat.com>
References: <20180507145802.27139-1-abologna@redhat.com>
Message-ID: <20180508135445.GW5967@redhat.com>

On Mon, May 07, 2018 at 04:57:59PM +0200, Andrea Bolognani wrote:
> Changes from [v1]:
> 
> * rename the script instead of dropping it;
> 
> * perform some further clean ups.
> 
> 
> [v1] https://www.redhat.com/archives/libosinfo/2018-May/msg00008.html
> 
> Andrea Bolognani (3):
>   maint: Rename autobuild.sh to prepare-release.sh
>   prepare-release: Drop references to Test::AutoBuild
>   spec: Drop %{extra_release}
> 
>  mingw-osinfo-db.spec.in            |  2 +-
>  osinfo-db.spec.in                  |  2 +-
>  autobuild.sh => prepare-release.sh | 13 ++-----------
>  3 files changed, 4 insertions(+), 13 deletions(-)
>  rename autobuild.sh => prepare-release.sh (69%)

For all three

Reviewed-by: Daniel P. Berrang? <berrange at redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From fabiano at fidencio.org  Tue May  8 15:18:36 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 8 May 2018 17:18:36 +0200
Subject: [Libosinfo] [PATCH osinfodb] os: fix version for windows 2016
In-Reply-To: <20180508123557.10470-1-berrange@redhat.com>
References: <20180508123557.10470-1-berrange@redhat.com>
Message-ID: <CAK9pz9+3XA61eOEbXae1e6W+XLiUm6Y6NTy=yAO8n3tfsh=X-g@mail.gmail.com>

On Tue, May 8, 2018 at 2:35 PM, Daniel P. Berrang? <berrange at redhat.com> wrote:
> The win2k16 version is mistakely set to 1709 which looks like a build
> patch level version. For windows distros we are using the NT kernel
> version as the version field, since it is the only thing that increments
> in a sensible manner across Windows releases.
>
> Signed-off-by: Daniel P. Berrang? <berrange at redhat.com>
> ---
>  data/os/microsoft.com/win-2k16.xml.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/os/microsoft.com/win-2k16.xml.in b/data/os/microsoft.com/win-2k16.xml.in
> index 1f1bfc7..523733d 100644
> --- a/data/os/microsoft.com/win-2k16.xml.in
> +++ b/data/os/microsoft.com/win-2k16.xml.in
> @@ -4,7 +4,7 @@
>    <os id="http://microsoft.com/win/2k16">
>      <short-id>win2k16</short-id>
>      <_name>Microsoft Windows Server 2016</_name>
> -    <version>1709</version>
> +    <version>10.0</version>
>      <_vendor>Microsoft Corporation</_vendor>
>      <family>winnt</family>
>      <distro>win</distro>
> --
> 2.17.0
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo

Ack!

-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Tue May  8 15:18:51 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Tue, 8 May 2018 17:18:51 +0200
Subject: [Libosinfo] [PATCH] configure: fix HAVE_CURL conditional on
	Win32
In-Reply-To: <20180508133844.30199-1-berrange@redhat.com>
References: <20180508133844.30199-1-berrange@redhat.com>
Message-ID: <CAK9pz9K+0+QdaLtGoJ7JJ9d8PjsW26hxew2cpHggv0oKSQ9nwA@mail.gmail.com>

On Tue, May 8, 2018 at 3:38 PM, Daniel P. Berrang? <berrange at redhat.com> wrote:
> AM_CONDITIONAL lines must always be executed, but HAVE_CURL was inside
> an "if ...", which caused configure to fail when run on Win32.
>
> Signed-off-by: Daniel P. Berrang? <berrange at redhat.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index d834c89..f7f1c72 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -60,8 +60,8 @@ if test "x$enable_tests" != "xno" ; then
>    PKG_CHECK_MODULES([CURL], [libcurl], [have_curl=yes], [:])
>    AC_SUBST(CURL_CFLAGS)
>    AC_SUBST(CURL_LIBS)
> -  AM_CONDITIONAL([HAVE_CURL],[test "x$have_curl" = "xyes"])
>  fi
> +AM_CONDITIONAL([HAVE_CURL],[test "x$have_curl" = "xyes"])
>
>  AM_CONDITIONAL([ENABLE_TESTS],[test "x$enable_tests" = "xyes"])
>
> --
> 2.17.0
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo


Ack!
-- 
Fabiano Fid?ncio



From pierre-alain.toret at protonmail.com  Tue May  8 19:47:59 2018
From: pierre-alain.toret at protonmail.com (Pierre-Alain TORET)
Date: Tue, 08 May 2018 15:47:59 -0400
Subject: [Libosinfo]  [PATCH osinfo-db] netbsd : Add NetBSD 7.1.2 info
Message-ID: <CJsXoZ--Uh9LhGYuYmyfm47f1KHvmeCFOI1vDOWH4Q0Y9I2_kfM5HP5soFrpa2ijcp0AsmtHWmormLbeNZ_IUmsXRgufIACiO3PraOidDuQ=@protonmail.com>

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
---
  data/os/netbsd.org/netbsd-7.1.2.xml.in | 64 ++++++++++++++++++++++++++
  1 file changed, 64 insertions(+)
  create mode 100644 data/os/netbsd.org/netbsd-7.1.2.xml.in

diff --git a/data/os/netbsd.org/netbsd-7.1.2.xml.in 
b/data/os/netbsd.org/netbsd-7.1.2.xml.in
new file mode 100644
index 0000000..e045e88
--- /dev/null
+++ b/data/os/netbsd.org/netbsd-7.1.2.xml.in
@@ -0,0 +1,64 @@
+<libosinfo version="0.0.1">
+
+  <os id="http://netbsd.org/netbsd/7.1.2">
+    <short-id>netbsd7.1.2</short-id>
+    <_name>NetBSD 7.1.2</_name>
+    <version>7.1.2</version>
+    <_vendor>NetBSD Project</_vendor>
+    <family>netbsd</family>
+    <distro>netbsd</distro>
+    <upgrades id="http://netbsd.org/netbsd/7.1"/>
+    <derives-from id="http://netbsd.org/netbsd/7.1"/>
+
+    <release-date>2018-03-15</release-date>
+
+    <media arch="x86_64">
+ 
<url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-amd64.iso</url>
+      <iso>
+        <system-id>NetBSD</system-id>
+        <volume-id>NETBSD_712</volume-id>
+        <volume-size>393832448</volume-size>
+      </iso>
+    </media>
+    <media arch="x86_64">
+ 
<url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot.iso</url>
+      <iso>
+        <system-id>NetBSD</system-id>
+        <volume-id>NETBSD_712</volume-id>
+        <volume-size>86235136</volume-size>
+      </iso>
+    </media>
+    <media arch="x86_64">
+ 
<url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot-com.iso</url>
+      <iso>
+        <system-id>NetBSD</system-id>
+        <volume-id>NETBSD_712</volume-id>
+        <volume-size>86235136</volume-size>
+      </iso>
+    </media>
+    <media arch="i686">
+ 
<url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-i386.iso</url>
+      <iso>
+        <system-id>NetBSD</system-id>
+        <volume-id>NETBSD_712</volume-id>
+        <volume-size>427264000</volume-size>
+      </iso>
+    </media>
+    <media arch="i686">
+ 
<url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot.iso</url>
+      <iso>
+        <system-id>NetBSD</system-id>
+        <volume-id>NETBSD_712</volume-id>
+        <volume-size>91035648</volume-size>
+      </iso>
+    </media>
+    <media arch="i686">
+ 
<url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot-com.iso</url>
+      <iso>
+        <system-id>NetBSD</system-id>
+        <volume-id>NETBSD_712</volume-id>
+        <volume-size>91035648</volume-size>
+      </iso>
+    </media>
+  </os>
+</libosinfo>
-- 
2.17.0




From pierre-alain.toret at protonmail.com  Tue May  8 19:55:23 2018
From: pierre-alain.toret at protonmail.com (Pierre-Alain TORET)
Date: Tue, 08 May 2018 15:55:23 -0400
Subject: [Libosinfo]  [PATCH libosinfo] netbsd : Add NetBSD 7.1.2 isodata
Message-ID: <b67y8PvsW3SFo4g6ds4gDe99f2NQ0PW4pLwQf-ZV74uuhqJlno5p5llxdV72ZINXWeTkXItnjjb-9xJ9nILqFe2Ea-MdJRvtdZKuizqikf8=@protonmail.com>

Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
---
  .../NetBSD-7.1.2-amd64-boot-com.iso.txt       | 33 +++++++++++++++++++
  .../NetBSD-7.1.2-amd64-boot.iso.txt           | 33 +++++++++++++++++++
  .../netbsd7.1.2/NetBSD-7.1.2-amd64.iso.txt    | 32 ++++++++++++++++++ 
.../NetBSD-7.1.2-i386-boot-com.iso.txt        | 33 +++++++++++++++++++
  .../NetBSD-7.1.2-i386-boot.iso.txt            | 33 +++++++++++++++++++
  .../netbsd7.1.2/NetBSD-7.1.2-i386.iso.txt     | 33 +++++++++++++++++++
  6 files changed, 197 insertions(+)
  create mode 100644 
tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot-com.iso.txt
  create mode 100644 
tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot.iso.txt
  create mode 100644 
tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64.iso.txt
  create mode 100644 
tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot-com.iso.txt
  create mode 100644 
tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot.iso.txt
  create mode 100644 
tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386.iso.txt

diff --git 
a/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot-com.iso.txt 
b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot-com.iso.txt
new file mode 100644
index 0000000..9013585
--- /dev/null+++ 
b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot-com.iso.txt
@@ -0,0 +1,33 @@
+CD-ROM is in ISO 9660 format
+System id: NetBSD
+Volume id: NETBSD_712
+Volume set id:
+Publisher id: THE_NETBSD_PROJECT
+Data preparer id:
+Application id:
+Copyright File id:
+Abstract File id:
+Bibliographic File id:
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 41957
+El Torito VD version 1 found, boot catalog is in sector 19
+NO Joliet present
+
+SUSP signatures version 1 found
+Rock Ridge signatures version 1 found
+Rock Ridge id 'IEEE_P1282'
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Cksum AA 55 OK
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 14 20
diff --git 
a/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot.iso.txt 
b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot.iso.txt
new file mode 100644
index 0000000..9013585
--- /dev/null
+++ b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64-boot.iso.txt
@@ -0,0 +1,33 @@
+CD-ROM is in ISO 9660 format
+System id: NetBSD
+Volume id: NETBSD_712
+Volume set id:
+Publisher id: THE_NETBSD_PROJECT
+Data preparer id:
+Application id:
+Copyright File id:
+Abstract File id:
+Bibliographic File id:
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 41957
+El Torito VD version 1 found, boot catalog is in sector 19
+NO Joliet present
+
+SUSP signatures version 1 found
+Rock Ridge signatures version 1 found
+Rock Ridge id 'IEEE_P1282'
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Cksum AA 55 OK
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 14 20
diff --git a/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64.iso.txt 
b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64.iso.txt
new file mode 100644
index 0000000..84862fe
--- /dev/null
+++ b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-amd64.iso.txt
@@ -0,0 +1,32 @@
+CD-ROM is in ISO 9660 formatSystem id: NetBSD
+Volume id: NETBSD_712
+Volume set id:
+Publisher id: THE_NETBSD_PROJECT
+Data preparer id:
+Application id:
+Copyright File id:
+Abstract File id:
+Bibliographic File id:
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 192151
+El Torito VD version 1 found, boot catalog is in sector 19
+NO Joliet present
+
+SUSP signatures version 1 found
+Rock Ridge signatures version 1 found
+Rock Ridge id 'IEEE_P1282'
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Cksum AA 55 OK
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 14 20
diff --git 
a/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot-com.iso.txt 
b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot-com.iso.txt
new file mode 100644
index 0000000..0feeac8
--- /dev/null
+++ b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot-com.iso.txt
@@ -0,0 +1,33 @@
+CD-ROM is in ISO 9660 format
+System id: NetBSD
+Volume id: NETBSD_712
+Volume set id:
+Publisher id: THE_NETBSD_PROJECT
+Data preparer id:
+Application id:
+Copyright File id:
+Abstract File id:
+Bibliographic File id:
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 44301
+El Torito VD version 1 found, boot catalog is in sector 19
+NO Joliet present
+
+SUSP signatures version 1 found
+Rock Ridge signatures version 1 found
+Rock Ridge id 'IEEE_P1282'
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Cksum AA 55 OK
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 14 20
diff --git 
a/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot.iso.txt 
b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot.iso.txt
new file mode 100644
index 0000000..0feeac8
--- /dev/null
+++ b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386-boot.iso.txt
@@ -0,0 +1,33 @@
+CD-ROM is in ISO 9660 format
+System id: NetBSD
+Volume id: NETBSD_712
+Volume set id:
+Publisher id: THE_NETBSD_PROJECT
+Data preparer id:
+Application id:
+Copyright File id:
+Abstract File id:
+Bibliographic File id:
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 44301
+El Torito VD version 1 found, boot catalog is in sector 19
+NO Joliet present
+
+SUSP signatures version 1 found
+Rock Ridge signatures version 1 found
+Rock Ridge id 'IEEE_P1282'
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Cksum AA 55 OK
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 14 20
diff --git a/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386.iso.txt 
b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386.iso.txt
new file mode 100644
index 0000000..a3de59e
--- /dev/null
+++ b/tests/isodata/netbsd/netbsd7.1.2/NetBSD-7.1.2-i386.iso.txt
@@ -0,0 +1,33 @@
+CD-ROM is in ISO 9660 format
+System id: NetBSD
+Volume id: NETBSD_712
+Volume set id:
+Publisher id: THE_NETBSD_PROJECT
+Data preparer id:
+Application id:
+Copyright File id:
+Abstract File id:
+Bibliographic File id:
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 208475
+El Torito VD version 1 found, boot catalog is in sector 19
+NO Joliet present
+
+SUSP signatures version 1 found
+Rock Ridge signatures version 1 found
+Rock Ridge id 'IEEE_P1282'
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Cksum AA 55 OK
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 14 20
-- 
2.17.0




From abologna at redhat.com  Wed May  9 12:12:16 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Wed,  9 May 2018 14:12:16 +0200
Subject: [Libosinfo] [PATCH] autogen: Don't hardcode --enable-gtk-doc
Message-ID: <20180509121216.10493-1-abologna@redhat.com>

The usual behavior is for configure to detect the availability
of gtk-doc, along with other optional features, and only enable
it if found.

Hardcoding it this way is causing issues for MinGW builds,
where pkg-config is looking in the MinGW-specific paths and
can't locate the native gtk-doc.pc file, thus concluding
gtk-doc must not be present and aborting the build altogether
instead of simply skipping API reference generation.

Both 'make distcheck' (through the DISTCHECK_CONFIGURE_FLAGS
variable) and the prepare-release.sh script are already
enforcing the availability of gtk-doc when preparing releases,
so it's safe to use the default behavior for regular builds.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 autogen.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index eea755b..275f7b2 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -20,4 +20,4 @@ which gnome-autogen.sh || {
 # exists at all times :-(
 touch ChangeLog AUTHORS
 
-ACLOCAL_FLAGS="$ACLOCAL_FLAGS" . gnome-autogen.sh --enable-gtk-doc "$@"
+ACLOCAL_FLAGS="$ACLOCAL_FLAGS" . gnome-autogen.sh "$@"
-- 
2.17.0



From berrange at redhat.com  Thu May 10 08:57:23 2018
From: berrange at redhat.com (Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?=)
Date: Thu, 10 May 2018 09:57:23 +0100
Subject: [Libosinfo] [PATCH] autogen: Don't hardcode --enable-gtk-doc
In-Reply-To: <20180509121216.10493-1-abologna@redhat.com>
References: <20180509121216.10493-1-abologna@redhat.com>
Message-ID: <20180510085723.GD23581@redhat.com>

On Wed, May 09, 2018 at 02:12:16PM +0200, Andrea Bolognani wrote:
> The usual behavior is for configure to detect the availability
> of gtk-doc, along with other optional features, and only enable
> it if found.
> 
> Hardcoding it this way is causing issues for MinGW builds,
> where pkg-config is looking in the MinGW-specific paths and
> can't locate the native gtk-doc.pc file, thus concluding
> gtk-doc must not be present and aborting the build altogether
> instead of simply skipping API reference generation.
> 
> Both 'make distcheck' (through the DISTCHECK_CONFIGURE_FLAGS
> variable) and the prepare-release.sh script are already
> enforcing the availability of gtk-doc when preparing releases,
> so it's safe to use the default behavior for regular builds.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  autogen.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrang? <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From mclasen at redhat.com  Thu May 10 22:57:17 2018
From: mclasen at redhat.com (Matthias Clasen)
Date: Thu, 10 May 2018 18:57:17 -0400
Subject: [Libosinfo] Fedora 28
Message-ID: <CAEXRhXmb1+0BmuWbR9xDFy+MCNn72U1obv7MhHMDXH7A5dx6Ww@mail.gmail.com>

>From 060fb63cceb4dab2dfaa8ebfaa7b826529c6cdee Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen at redhat.com>
Date: Thu, 10 May 2018 17:54:34 -0400
Subject: [PATCH] Add Fedora 28

This adds all the variants of Fedora 28.
---
 data/os/fedoraproject.org/fedora-28.xml.in | 129 +++++++++++++++++++++
 1 file changed, 129 insertions(+)
 create mode 100644 data/os/fedoraproject.org/fedora-28.xml.in

diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/
fedoraproject.org/fedora-28.xml.in
new file mode 100644
index 0000000..761f3df
--- /dev/null
+++ b/data/os/fedoraproject.org/fedora-28.xml.in
@@ -0,0 +1,129 @@
+<libosinfo version="0.0.1">
+<!-- Licensed under the GNU General Public License version 2 or later.
+     See http://www.gnu.org/licenses/ for a copy of the license text -->
+  <os id="http://fedoraproject.org/fedora/28">
+    <short-id>fedora28</short-id>
+    <_name>Fedora 28</_name>
+    <version>28</version>
+    <_vendor>Fedora Project</_vendor>
+    <family>linux</family>
+    <distro>fedora</distro>
+    <upgrades id="http://fedoraproject.org/fedora/27"/>
+    <derives-from id="http://fedoraproject.org/fedora/27"/>
+
+    <release-date>2018-05-01</release-date>
+
+    <variant id="workstation">
+      <_name>Fedora 28 Workstation</_name>
+    </variant>
+    <variant id="workstation-netinst">
+      <_name>Fedora 28 Workstation</_name>
+    </variant>
+    <variant id="workstation-atomic">
+      <_name>Fedora 28 Workstation</_name>
+    </variant>
+    <variant id="server">
+      <_name>Fedora 28 Server</_name>
+    </variant>
+    <variant id="server-netinst">
+      <_name>Fedora 28 Server</_name>
+    </variant>
+
+    <!-- Workstation -->
+
+    <!-- Live -->
+    <media arch="x86_64" live="true">
+      <variant id="workstation"/>
+      <url>
https://download.fedoraproject.org/pub/fedora/linux/releases/28/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-28-1.1.iso
</url>
+      <iso>
+        <volume-id>Fedora-WS-Live-28.*</volume-id>
+        <system-id>LINUX</system-id>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <!-- Atomic -->
+    <media arch="x86_64">
+      <variant id="workstation-atomic"/>
+      <url>
https://download.fedoraproject.org/pub/fedora/linux/releases/28/AtomicWorkstation/x86_64/iso/Fedora-WorkstationOstree-ostree-x86_64-28-1.1.iso
</url>
+      <iso>
+        <volume-id>Fedora-WSOstree-ostree-x86_64-28</volume-id>
+        <system-id>LINUX</system-id>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <!-- Network Installer !-->
+    <media arch="x86_64">
+      <variant id="workstation-netinst"/>
+      <url>
https://download.fedoraproject.org/pub/fedora/linux/releases/28/Workstation/x86_64/iso/Fedora-Workstation-netinst-x86_64-28-1.1.iso
</url>
+      <iso>
+        <volume-id>Fedora-WS-dvd-x86_64-28</volume-id>
+        <system-id>LINUX</system-id>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <!-- Server -->
+
+    <!-- DVD -->
+    <media arch="x86_64">
+      <variant id="server"/>
+      <url>
https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/iso/Fedora-Server-dvd-x86_64-28-1.1.iso
</url>
+      <iso>
+        <volume-id>Fedora-S-dvd-x86_64-28</volume-id>
+        <system-id>LINUX</system-id>
+        <volume-size>2490122240</volume-size>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <!-- Network Installer !-->
+    <media arch="x86_64">
+      <variant id="server-netinst"/>
+      <url>
https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/iso/Fedora-Server-netinst-x86_64-28-1.1.iso
</url>
+      <iso>
+        <volume-id>Fedora-S-dvd-x86_64-28</volume-id>
+        <system-id>LINUX</system-id>
+        <volume-size>535017472</volume-size>
+      </iso>
+      <kernel>isolinux/vmlinuz</kernel>
+      <initrd>isolinux/initrd.img</initrd>
+    </media>
+
+    <tree arch="x86_64">
+      <url>
https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/os/
</url>
+      <variant id="server"/>
+      <treeinfo>
+        <family>Fedora</family>
+        <version>28</version>
+        <arch>x86_64</arch>
+      </treeinfo>
+    </tree>
+
+    <!-- No install media or tree is provided for Fedora 28 Cloud variant
-->
+
+    <resources arch="all">
+      <minimum>
+        <n-cpus>1</n-cpus>
+        <cpu>1000000000</cpu>
+        <ram>1073741824</ram>
+        <storage>10737418240</storage>
+      </minimum>
+
+      <recommended>
+        <ram>2147483648</ram>
+        <storage>21474836480</storage>
+      </recommended>
+    </resources>
+
+    <installer>
+      <script id='http://fedoraproject.org/fedora/kickstart/jeos'/>
+      <script id='http://fedoraproject.org/fedora/kickstart/desktop'/>
+    </installer>
+  </os>
+</libosinfo>
-- 
2.17.0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180510/f11ab4c5/attachment.htm>

From fabiano at fidencio.org  Fri May 11 09:28:20 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Fri, 11 May 2018 11:28:20 +0200
Subject: [Libosinfo] Fedora 28
In-Reply-To: <CAEXRhXmb1+0BmuWbR9xDFy+MCNn72U1obv7MhHMDXH7A5dx6Ww@mail.gmail.com>
References: <CAEXRhXmb1+0BmuWbR9xDFy+MCNn72U1obv7MhHMDXH7A5dx6Ww@mail.gmail.com>
Message-ID: <CAK9pz9Lmu32Fdc82ZrT4uDTeHnk2h7FK16bMPVxW1JCyLaXhyA@mail.gmail.com>

Matthias,

On Fri, May 11, 2018 at 12:57 AM, Matthias Clasen <mclasen at redhat.com> wrote:
> From 060fb63cceb4dab2dfaa8ebfaa7b826529c6cdee Mon Sep 17 00:00:00 2001
> From: Matthias Clasen <mclasen at redhat.com>
> Date: Thu, 10 May 2018 17:54:34 -0400
> Subject: [PATCH] Add Fedora 28
>
> This adds all the variants of Fedora 28.
> ---
>  data/os/fedoraproject.org/fedora-28.xml.in | 129 +++++++++++++++++++++
>  1 file changed, 129 insertions(+)
>  create mode 100644 data/os/fedoraproject.org/fedora-28.xml.in
>
> diff --git a/data/os/fedoraproject.org/fedora-28.xml.in
> b/data/os/fedoraproject.org/fedora-28.xml.in
> new file mode 100644
> index 0000000..761f3df
> --- /dev/null
> +++ b/data/os/fedoraproject.org/fedora-28.xml.in
> @@ -0,0 +1,129 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <os id="http://fedoraproject.org/fedora/28">
> +    <short-id>fedora28</short-id>
> +    <_name>Fedora 28</_name>
> +    <version>28</version>
> +    <_vendor>Fedora Project</_vendor>
> +    <family>linux</family>
> +    <distro>fedora</distro>
> +    <upgrades id="http://fedoraproject.org/fedora/27"/>
> +    <derives-from id="http://fedoraproject.org/fedora/27"/>
> +
> +    <release-date>2018-05-01</release-date>
> +
> +    <variant id="workstation">
> +      <_name>Fedora 28 Workstation</_name>
> +    </variant>
> +    <variant id="workstation-netinst">
> +      <_name>Fedora 28 Workstation</_name>
> +    </variant>
> +    <variant id="workstation-atomic">
> +      <_name>Fedora 28 Workstation</_name>
> +    </variant>
> +    <variant id="server">
> +      <_name>Fedora 28 Server</_name>
> +    </variant>
> +    <variant id="server-netinst">
> +      <_name>Fedora 28 Server</_name>
> +    </variant>
> +
> +    <!-- Workstation -->
> +
> +    <!-- Live -->
> +    <media arch="x86_64" live="true">
> +      <variant id="workstation"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-WS-Live-28.*</volume-id>
> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Atomic -->
> +    <media arch="x86_64">
> +      <variant id="workstation-atomic"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/AtomicWorkstation/x86_64/iso/Fedora-WorkstationOstree-ostree-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-WSOstree-ostree-x86_64-28</volume-id>
> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Network Installer !-->
> +    <media arch="x86_64">
> +      <variant id="workstation-netinst"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Workstation/x86_64/iso/Fedora-Workstation-netinst-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-WS-dvd-x86_64-28</volume-id>
> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Server -->
> +
> +    <!-- DVD -->
> +    <media arch="x86_64">
> +      <variant id="server"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/iso/Fedora-Server-dvd-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-S-dvd-x86_64-28</volume-id>
> +        <system-id>LINUX</system-id>
> +        <volume-size>2490122240</volume-size>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Network Installer !-->
> +    <media arch="x86_64">
> +      <variant id="server-netinst"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/iso/Fedora-Server-netinst-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-S-dvd-x86_64-28</volume-id>
> +        <system-id>LINUX</system-id>
> +        <volume-size>535017472</volume-size>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <tree arch="x86_64">
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/os/</url>
> +      <variant id="server"/>
> +      <treeinfo>
> +        <family>Fedora</family>
> +        <version>28</version>
> +        <arch>x86_64</arch>
> +      </treeinfo>
> +    </tree>
> +
> +    <!-- No install media or tree is provided for Fedora 28 Cloud variant
> -->
> +
> +    <resources arch="all">
> +      <minimum>
> +        <n-cpus>1</n-cpus>
> +        <cpu>1000000000</cpu>
> +        <ram>1073741824</ram>
> +        <storage>10737418240</storage>
> +      </minimum>
> +
> +      <recommended>
> +        <ram>2147483648</ram>
> +        <storage>21474836480</storage>
> +      </recommended>
> +    </resources>
> +
> +    <installer>
> +      <script id='http://fedoraproject.org/fedora/kickstart/jeos'/>
> +      <script id='http://fedoraproject.org/fedora/kickstart/desktop'/>
> +    </installer>
> +  </os>
> +</libosinfo>
> --
> 2.17.0
>
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>

Patch looks good.

Do you happen to have the ISOs around? If so, please, do:
isoinfo -d -i /path/to/the/iso >
/path/to/libosinfo/tests/isodata/fedora/fedora28/iso_name.txt
Otherwise, let me know and I'll do it by myself.

We always add the isodata info together with the osinfo-db info.

Best Regards,
-- 
Fabiano Fid?ncio



From mclasen at redhat.com  Fri May 11 14:20:04 2018
From: mclasen at redhat.com (Matthias Clasen)
Date: Fri, 11 May 2018 10:20:04 -0400
Subject: [Libosinfo] Fedora 28
In-Reply-To: <CAK9pz9Lmu32Fdc82ZrT4uDTeHnk2h7FK16bMPVxW1JCyLaXhyA@mail.gmail.com>
References: <CAEXRhXmb1+0BmuWbR9xDFy+MCNn72U1obv7MhHMDXH7A5dx6Ww@mail.gmail.com>
	<CAK9pz9Lmu32Fdc82ZrT4uDTeHnk2h7FK16bMPVxW1JCyLaXhyA@mail.gmail.com>
Message-ID: <CAEXRhXmGUQ6DWCR+6fSq3FDk=sMBQQO9x4ST_rYvDX0WRWaXUQ@mail.gmail.com>

>
> Do you happen to have the ISOs around? If so, please, do:
> isoinfo -d -i /path/to/the/iso >
> /path/to/libosinfo/tests/isodata/fedora/fedora28/iso_name.txt
> Otherwise, let me know and I'll do it by myself.
>
> We always add the isodata info together with the osinfo-db info.
>
>
No, sorry. No isos here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180511/f05e6e21/attachment.htm>

From abologna at redhat.com  Fri May 11 15:01:53 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Fri, 11 May 2018 17:01:53 +0200
Subject: [Libosinfo] [PATCH] tools: Fix compilation with Clang 6
Message-ID: <20180511150153.5982-1-abologna@redhat.com>

Clang 6 doesn't like the way the last item in a GOptionEntry
array is initialized:

  ../../tools/osinfo-install-script.c:87:12: error: missing field
  'short_name' initializer [-Werror,-Wmissing-field-initializers]
      { NULL }
             ^
  1 error generated.
  gmake[2]: *** [Makefile:540: osinfo-install-script.o] Error 1
  gmake[2]: *** Waiting for unfinished jobs....
  ../../tools/osinfo-detect.c:104:12: error: missing field
  'short_name' initializer [-Werror,-Wmissing-field-initializers]
      { NULL }
             ^
  1 error generated.
  gmake[2]: *** [Makefile:540: osinfo-detect.o] Error 1

Fix the issue by initializing all fields explicitly.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 tools/osinfo-detect.c         | 2 +-
 tools/osinfo-install-script.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c
index 2e5af97..460c6e1 100644
--- a/tools/osinfo-detect.c
+++ b/tools/osinfo-detect.c
@@ -101,7 +101,7 @@ static GOptionEntry entries[] =
       G_OPTION_ARG_CALLBACK, parse_type_str,
       N_("URL type. Default: media"),
       N_("media|tree.") },
-    { NULL }
+    { NULL, 0, 0, 0, NULL, NULL, NULL }
 };
 
 static void print_bootable(gboolean bootable)
diff --git a/tools/osinfo-install-script.c b/tools/osinfo-install-script.c
index 75bfda1..1230806 100644
--- a/tools/osinfo-install-script.c
+++ b/tools/osinfo-install-script.c
@@ -84,7 +84,7 @@ static GOptionEntry entries[] =
       (void*)&list_inj_method, N_("List supported injection methods"), NULL },
     { "quiet", 'q', 0, G_OPTION_ARG_NONE, (void*)&quiet,
       N_("Do not display output filenames"), NULL },
-    { NULL }
+    { NULL, 0, 0, 0, NULL, NULL, NULL }
 };
 
 
-- 
2.17.0



From eblake at redhat.com  Fri May 11 15:10:49 2018
From: eblake at redhat.com (Eric Blake)
Date: Fri, 11 May 2018 10:10:49 -0500
Subject: [Libosinfo] [PATCH] tools: Fix compilation with Clang 6
In-Reply-To: <20180511150153.5982-1-abologna@redhat.com>
References: <20180511150153.5982-1-abologna@redhat.com>
Message-ID: <ebb25bb7-fc9b-ad39-1e97-0554f8bc237c@redhat.com>

On 05/11/2018 10:01 AM, Andrea Bolognani wrote:
> Clang 6 doesn't like the way the last item in a GOptionEntry
> array is initialized:
> 
>    ../../tools/osinfo-install-script.c:87:12: error: missing field
>    'short_name' initializer [-Werror,-Wmissing-field-initializers]
>        { NULL }
>               ^

Does it work without warning with the simpler:

{ 0 }

which is supposed to be the universal 0-initializer?

Does it work with the gcc/clang extension of:

{}

(even though the C standard does not describe that form)?

Does it work if you used a named initializer, as in:

{ .foo = NULL }

Otherwise, the fact that you have to spell out multiple fields feels 
like a bug in clang giving pointless warnings.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



From abologna at redhat.com  Fri May 11 15:39:41 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Fri, 11 May 2018 17:39:41 +0200
Subject: [Libosinfo] [PATCH] tools: Fix compilation with Clang 6
In-Reply-To: <ebb25bb7-fc9b-ad39-1e97-0554f8bc237c@redhat.com>
References: <20180511150153.5982-1-abologna@redhat.com>
	<ebb25bb7-fc9b-ad39-1e97-0554f8bc237c@redhat.com>
Message-ID: <6b4f11d2623143708b5ca740b068909dca46ee4b.camel@redhat.com>

On Fri, 2018-05-11 at 10:10 -0500, Eric Blake wrote:
> On 05/11/2018 10:01 AM, Andrea Bolognani wrote:
> > Clang 6 doesn't like the way the last item in a GOptionEntry
> > array is initialized:
> > 
> >    ../../tools/osinfo-install-script.c:87:12: error: missing field
> >    'short_name' initializer [-Werror,-Wmissing-field-initializers]
> >        { NULL }
> >               ^
> 
> Does it work without warning with the simpler:
> 
> { 0 }

Yeah, this version works too. I'll respin in a minute.

-- 
Andrea Bolognani / Red Hat / Virtualization



From abologna at redhat.com  Fri May 11 15:41:13 2018
From: abologna at redhat.com (Andrea Bolognani)
Date: Fri, 11 May 2018 17:41:13 +0200
Subject: [Libosinfo] [PATCH v2] tools: Fix compilation with Clang 6
Message-ID: <20180511154113.10139-1-abologna@redhat.com>

Clang 6 doesn't like the way the last item in a GOptionEntry
array is initialized:

  ../../tools/osinfo-install-script.c:87:12: error: missing field
  'short_name' initializer [-Werror,-Wmissing-field-initializers]
      { NULL }
             ^
  1 error generated.
  gmake[2]: *** [Makefile:540: osinfo-install-script.o] Error 1
  gmake[2]: *** Waiting for unfinished jobs....
  ../../tools/osinfo-detect.c:104:12: error: missing field
  'short_name' initializer [-Werror,-Wmissing-field-initializers]
      { NULL }
             ^
  1 error generated.
  gmake[2]: *** [Makefile:540: osinfo-detect.o] Error 1

Fix the issue by using the { 0 } initializer instead.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 tools/osinfo-detect.c         | 2 +-
 tools/osinfo-install-script.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c
index 2e5af97..c6fb36f 100644
--- a/tools/osinfo-detect.c
+++ b/tools/osinfo-detect.c
@@ -101,7 +101,7 @@ static GOptionEntry entries[] =
       G_OPTION_ARG_CALLBACK, parse_type_str,
       N_("URL type. Default: media"),
       N_("media|tree.") },
-    { NULL }
+    { 0 }
 };
 
 static void print_bootable(gboolean bootable)
diff --git a/tools/osinfo-install-script.c b/tools/osinfo-install-script.c
index 75bfda1..3535022 100644
--- a/tools/osinfo-install-script.c
+++ b/tools/osinfo-install-script.c
@@ -84,7 +84,7 @@ static GOptionEntry entries[] =
       (void*)&list_inj_method, N_("List supported injection methods"), NULL },
     { "quiet", 'q', 0, G_OPTION_ARG_NONE, (void*)&quiet,
       N_("Do not display output filenames"), NULL },
-    { NULL }
+    { 0 }
 };
 
 
-- 
2.17.0



From fabiano at fidencio.org  Sat May 12 10:21:09 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Sat, 12 May 2018 12:21:09 +0200
Subject: [Libosinfo] [PATCH v2] tools: Fix compilation with Clang 6
In-Reply-To: <20180511154113.10139-1-abologna@redhat.com>
References: <20180511154113.10139-1-abologna@redhat.com>
Message-ID: <CAK9pz9JWia+ta5dR-xF_zh3K1f08qfrXLC=jyP_npdthSqowxA@mail.gmail.com>

On Fri, May 11, 2018 at 5:41 PM, Andrea Bolognani <abologna at redhat.com> wrote:
> Clang 6 doesn't like the way the last item in a GOptionEntry
> array is initialized:
>
>   ../../tools/osinfo-install-script.c:87:12: error: missing field
>   'short_name' initializer [-Werror,-Wmissing-field-initializers]
>       { NULL }
>              ^
>   1 error generated.
>   gmake[2]: *** [Makefile:540: osinfo-install-script.o] Error 1
>   gmake[2]: *** Waiting for unfinished jobs....
>   ../../tools/osinfo-detect.c:104:12: error: missing field
>   'short_name' initializer [-Werror,-Wmissing-field-initializers]
>       { NULL }
>              ^
>   1 error generated.
>   gmake[2]: *** [Makefile:540: osinfo-detect.o] Error 1
>
> Fix the issue by using the { 0 } initializer instead.
>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  tools/osinfo-detect.c         | 2 +-
>  tools/osinfo-install-script.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c
> index 2e5af97..c6fb36f 100644
> --- a/tools/osinfo-detect.c
> +++ b/tools/osinfo-detect.c
> @@ -101,7 +101,7 @@ static GOptionEntry entries[] =
>        G_OPTION_ARG_CALLBACK, parse_type_str,
>        N_("URL type. Default: media"),
>        N_("media|tree.") },
> -    { NULL }
> +    { 0 }
>  };
>
>  static void print_bootable(gboolean bootable)
> diff --git a/tools/osinfo-install-script.c b/tools/osinfo-install-script.c
> index 75bfda1..3535022 100644
> --- a/tools/osinfo-install-script.c
> +++ b/tools/osinfo-install-script.c
> @@ -84,7 +84,7 @@ static GOptionEntry entries[] =
>        (void*)&list_inj_method, N_("List supported injection methods"), NULL },
>      { "quiet", 'q', 0, G_OPTION_ARG_NONE, (void*)&quiet,
>        N_("Do not display output filenames"), NULL },
> -    { NULL }
> +    { 0 }
>  };
>
>
> --
> 2.17.0
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo


Ack!
-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Sat May 12 10:30:32 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Sat, 12 May 2018 12:30:32 +0200
Subject: [Libosinfo] [PATCH osinfo-db] netbsd : Add NetBSD 7.1.2 info
In-Reply-To: <CJsXoZ--Uh9LhGYuYmyfm47f1KHvmeCFOI1vDOWH4Q0Y9I2_kfM5HP5soFrpa2ijcp0AsmtHWmormLbeNZ_IUmsXRgufIACiO3PraOidDuQ=@protonmail.com>
References: <CJsXoZ--Uh9LhGYuYmyfm47f1KHvmeCFOI1vDOWH4Q0Y9I2_kfM5HP5soFrpa2ijcp0AsmtHWmormLbeNZ_IUmsXRgufIACiO3PraOidDuQ=@protonmail.com>
Message-ID: <CAK9pz9LVsJyoxP6ZYa_NfFsHSP+1ejdCeV4JmvnLrr_N=JTLVA@mail.gmail.com>

On Tue, May 8, 2018 at 9:47 PM, Pierre-Alain TORET
<pierre-alain.toret at protonmail.com> wrote:
> Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
> ---
>   data/os/netbsd.org/netbsd-7.1.2.xml.in | 64 ++++++++++++++++++++++++++
>   1 file changed, 64 insertions(+)
>   create mode 100644 data/os/netbsd.org/netbsd-7.1.2.xml.in
>
> diff --git a/data/os/netbsd.org/netbsd-7.1.2.xml.in
> b/data/os/netbsd.org/netbsd-7.1.2.xml.in
> new file mode 100644
> index 0000000..e045e88
> --- /dev/null
> +++ b/data/os/netbsd.org/netbsd-7.1.2.xml.in
> @@ -0,0 +1,64 @@
> +<libosinfo version="0.0.1">
> +
> +  <os id="http://netbsd.org/netbsd/7.1.2">
> +    <short-id>netbsd7.1.2</short-id>
> +    <_name>NetBSD 7.1.2</_name>
> +    <version>7.1.2</version>
> +    <_vendor>NetBSD Project</_vendor>
> +    <family>netbsd</family>
> +    <distro>netbsd</distro>
> +    <upgrades id="http://netbsd.org/netbsd/7.1"/>
> +    <derives-from id="http://netbsd.org/netbsd/7.1"/>

It derives-from and upgrades 7.1.1 (not 7.1)
I've fixed this locally before pushing.

> +
> +    <release-date>2018-03-15</release-date>
> +
> +    <media arch="x86_64">
> +
> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-amd64.iso</url>

I'm not sure why there's the new line for the URL, but it causes
errors applying the patch.
I've fixed this locally before pushing.

> +      <iso>
> +        <system-id>NetBSD</system-id>
> +        <volume-id>NETBSD_712</volume-id>
> +        <volume-size>393832448</volume-size>
> +      </iso>
> +    </media>
> +    <media arch="x86_64">
> +
> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot.iso</url>

Same here.

> +      <iso>
> +        <system-id>NetBSD</system-id>
> +        <volume-id>NETBSD_712</volume-id>
> +        <volume-size>86235136</volume-size>
> +      </iso>
> +    </media>
> +    <media arch="x86_64">
> +
> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot-com.iso</url>

Same here.

> +      <iso>
> +        <system-id>NetBSD</system-id>
> +        <volume-id>NETBSD_712</volume-id>
> +        <volume-size>86235136</volume-size>
> +      </iso>
> +    </media>
> +    <media arch="i686">
> +
> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-i386.iso</url>

Same here.

> +      <iso>
> +        <system-id>NetBSD</system-id>
> +        <volume-id>NETBSD_712</volume-id>
> +        <volume-size>427264000</volume-size>
> +      </iso>
> +    </media>
> +    <media arch="i686">
> +
> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot.iso</url>

Same here.

> +      <iso>
> +        <system-id>NetBSD</system-id>
> +        <volume-id>NETBSD_712</volume-id>
> +        <volume-size>91035648</volume-size>
> +      </iso>
> +    </media>
> +    <media arch="i686">
> +
> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot-com.iso</url>

Same here.

> +      <iso>
> +        <system-id>NetBSD</system-id>
> +        <volume-id>NETBSD_712</volume-id>
> +        <volume-size>91035648</volume-size>
> +      </iso>
> +    </media>
> +  </os>
> +</libosinfo>
> --
> 2.17.0
>
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo


I'll push your patches, with the modifications, later Today.
Thanks for your contribution!

-- 
Fabiano Fid?ncio



From pierre-alain.toret at protonmail.com  Sat May 12 11:34:58 2018
From: pierre-alain.toret at protonmail.com (Pierre-Alain TORET)
Date: Sat, 12 May 2018 07:34:58 -0400
Subject: [Libosinfo] [PATCH osinfo-db] netbsd : Add NetBSD 7.1.2 info
In-Reply-To: <CAK9pz9LVsJyoxP6ZYa_NfFsHSP+1ejdCeV4JmvnLrr_N=JTLVA@mail.gmail.com>
References: <CJsXoZ--Uh9LhGYuYmyfm47f1KHvmeCFOI1vDOWH4Q0Y9I2_kfM5HP5soFrpa2ijcp0AsmtHWmormLbeNZ_IUmsXRgufIACiO3PraOidDuQ=@protonmail.com>
	<CAK9pz9LVsJyoxP6ZYa_NfFsHSP+1ejdCeV4JmvnLrr_N=JTLVA@mail.gmail.com>
Message-ID: <tJgtEjzuOV6qM84-fi2aYspdV5qCM2WzU1_-3nM0gGXfl31zMc3DvPQx4pu-zGKcmtoYih-Zk0haQrUPPLgLefS5Vqzg3S0Hvqv3irGUalo=@protonmail.com>

Le 12/05/2018 ? 12:30, Fabiano Fid?ncio a ?crit?:
> On Tue, May 8, 2018 at 9:47 PM, Pierre-Alain TORET
> <pierre-alain.toret at protonmail.com> wrote:
>> Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
>> ---
>>    data/os/netbsd.org/netbsd-7.1.2.xml.in | 64 ++++++++++++++++++++++++++
>>    1 file changed, 64 insertions(+)
>>    create mode 100644 data/os/netbsd.org/netbsd-7.1.2.xml.in
>>
>> diff --git a/data/os/netbsd.org/netbsd-7.1.2.xml.in
>> b/data/os/netbsd.org/netbsd-7.1.2.xml.in
>> new file mode 100644
>> index 0000000..e045e88
>> --- /dev/null
>> +++ b/data/os/netbsd.org/netbsd-7.1.2.xml.in
>> @@ -0,0 +1,64 @@
>> +<libosinfo version="0.0.1">
>> +
>> +  <os id="http://netbsd.org/netbsd/7.1.2">
>> +    <short-id>netbsd7.1.2</short-id>
>> +    <_name>NetBSD 7.1.2</_name>
>> +    <version>7.1.2</version>
>> +    <_vendor>NetBSD Project</_vendor>
>> +    <family>netbsd</family>
>> +    <distro>netbsd</distro>
>> +    <upgrades id="http://netbsd.org/netbsd/7.1"/>
>> +    <derives-from id="http://netbsd.org/netbsd/7.1"/>
> 
> It derives-from and upgrades 7.1.1 (not 7.1)
> I've fixed this locally before pushing.
> 
>> +
>> +    <release-date>2018-03-15</release-date>
>> +
>> +    <media arch="x86_64">
>> +
>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-amd64.iso</url>
> 
> I'm not sure why there's the new line for the URL, but it causes
> errors applying the patch.
> I've fixed this locally before pushing.
> 
>> +      <iso>
>> +        <system-id>NetBSD</system-id>
>> +        <volume-id>NETBSD_712</volume-id>
>> +        <volume-size>393832448</volume-size>
>> +      </iso>
>> +    </media>
>> +    <media arch="x86_64">
>> +
>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot.iso</url>
> 
> Same here.
> 
>> +      <iso>
>> +        <system-id>NetBSD</system-id>
>> +        <volume-id>NETBSD_712</volume-id>
>> +        <volume-size>86235136</volume-size>
>> +      </iso>
>> +    </media>
>> +    <media arch="x86_64">
>> +
>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot-com.iso</url>
> 
> Same here.
> 
>> +      <iso>
>> +        <system-id>NetBSD</system-id>
>> +        <volume-id>NETBSD_712</volume-id>
>> +        <volume-size>86235136</volume-size>
>> +      </iso>
>> +    </media>
>> +    <media arch="i686">
>> +
>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-i386.iso</url>
> 
> Same here.
> 
>> +      <iso>
>> +        <system-id>NetBSD</system-id>
>> +        <volume-id>NETBSD_712</volume-id>
>> +        <volume-size>427264000</volume-size>
>> +      </iso>
>> +    </media>
>> +    <media arch="i686">
>> +
>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot.iso</url>
> 
> Same here.
> 
>> +      <iso>
>> +        <system-id>NetBSD</system-id>
>> +        <volume-id>NETBSD_712</volume-id>
>> +        <volume-size>91035648</volume-size>
>> +      </iso>
>> +    </media>
>> +    <media arch="i686">
>> +
>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot-com.iso</url>
> 
> Same here.
> 
>> +      <iso>
>> +        <system-id>NetBSD</system-id>
>> +        <volume-id>NETBSD_712</volume-id>
>> +        <volume-size>91035648</volume-size>
>> +      </iso>
>> +    </media>
>> +  </os>
>> +</libosinfo>
>> --
>> 2.17.0
>>
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo
> 
> 
> I'll push your patches, with the modifications, later Today.
> Thanks for your contribution!
> 

Hello Fabiano,

thank you for taking the time to fix my patch.

Regards,




From fabiano at fidencio.org  Sat May 12 15:33:19 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Sat, 12 May 2018 17:33:19 +0200
Subject: [Libosinfo] [PATCH osinfo-db] netbsd : Add NetBSD 7.1.2 info
In-Reply-To: <tJgtEjzuOV6qM84-fi2aYspdV5qCM2WzU1_-3nM0gGXfl31zMc3DvPQx4pu-zGKcmtoYih-Zk0haQrUPPLgLefS5Vqzg3S0Hvqv3irGUalo=@protonmail.com>
References: <CJsXoZ--Uh9LhGYuYmyfm47f1KHvmeCFOI1vDOWH4Q0Y9I2_kfM5HP5soFrpa2ijcp0AsmtHWmormLbeNZ_IUmsXRgufIACiO3PraOidDuQ=@protonmail.com>
	<CAK9pz9LVsJyoxP6ZYa_NfFsHSP+1ejdCeV4JmvnLrr_N=JTLVA@mail.gmail.com>
	<tJgtEjzuOV6qM84-fi2aYspdV5qCM2WzU1_-3nM0gGXfl31zMc3DvPQx4pu-zGKcmtoYih-Zk0haQrUPPLgLefS5Vqzg3S0Hvqv3irGUalo=@protonmail.com>
Message-ID: <CAK9pz9J=8xOGiYHqqwTtWyOk_Q51nKdfM+j1PZ6WVgWizX3TVQ@mail.gmail.com>

On Sat, May 12, 2018 at 1:34 PM, Pierre-Alain TORET
<pierre-alain.toret at protonmail.com> wrote:
> Le 12/05/2018 ? 12:30, Fabiano Fid?ncio a ?crit :
>> On Tue, May 8, 2018 at 9:47 PM, Pierre-Alain TORET
>> <pierre-alain.toret at protonmail.com> wrote:
>>> Signed-off-by: Pierre-Alain TORET <pierre-alain.toret at protonmail.com>
>>> ---
>>>    data/os/netbsd.org/netbsd-7.1.2.xml.in | 64 ++++++++++++++++++++++++++
>>>    1 file changed, 64 insertions(+)
>>>    create mode 100644 data/os/netbsd.org/netbsd-7.1.2.xml.in
>>>
>>> diff --git a/data/os/netbsd.org/netbsd-7.1.2.xml.in
>>> b/data/os/netbsd.org/netbsd-7.1.2.xml.in
>>> new file mode 100644
>>> index 0000000..e045e88
>>> --- /dev/null
>>> +++ b/data/os/netbsd.org/netbsd-7.1.2.xml.in
>>> @@ -0,0 +1,64 @@
>>> +<libosinfo version="0.0.1">
>>> +
>>> +  <os id="http://netbsd.org/netbsd/7.1.2">
>>> +    <short-id>netbsd7.1.2</short-id>
>>> +    <_name>NetBSD 7.1.2</_name>
>>> +    <version>7.1.2</version>
>>> +    <_vendor>NetBSD Project</_vendor>
>>> +    <family>netbsd</family>
>>> +    <distro>netbsd</distro>
>>> +    <upgrades id="http://netbsd.org/netbsd/7.1"/>
>>> +    <derives-from id="http://netbsd.org/netbsd/7.1"/>
>>
>> It derives-from and upgrades 7.1.1 (not 7.1)
>> I've fixed this locally before pushing.
>>
>>> +
>>> +    <release-date>2018-03-15</release-date>
>>> +
>>> +    <media arch="x86_64">
>>> +
>>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-amd64.iso</url>
>>
>> I'm not sure why there's the new line for the URL, but it causes
>> errors applying the patch.
>> I've fixed this locally before pushing.
>>
>>> +      <iso>
>>> +        <system-id>NetBSD</system-id>
>>> +        <volume-id>NETBSD_712</volume-id>
>>> +        <volume-size>393832448</volume-size>
>>> +      </iso>
>>> +    </media>
>>> +    <media arch="x86_64">
>>> +
>>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot.iso</url>
>>
>> Same here.
>>
>>> +      <iso>
>>> +        <system-id>NetBSD</system-id>
>>> +        <volume-id>NETBSD_712</volume-id>
>>> +        <volume-size>86235136</volume-size>
>>> +      </iso>
>>> +    </media>
>>> +    <media arch="x86_64">
>>> +
>>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot-com.iso</url>
>>
>> Same here.
>>
>>> +      <iso>
>>> +        <system-id>NetBSD</system-id>
>>> +        <volume-id>NETBSD_712</volume-id>
>>> +        <volume-size>86235136</volume-size>
>>> +      </iso>
>>> +    </media>
>>> +    <media arch="i686">
>>> +
>>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-i386.iso</url>
>>
>> Same here.
>>
>>> +      <iso>
>>> +        <system-id>NetBSD</system-id>
>>> +        <volume-id>NETBSD_712</volume-id>
>>> +        <volume-size>427264000</volume-size>
>>> +      </iso>
>>> +    </media>
>>> +    <media arch="i686">
>>> +
>>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot.iso</url>
>>
>> Same here.
>>
>>> +      <iso>
>>> +        <system-id>NetBSD</system-id>
>>> +        <volume-id>NETBSD_712</volume-id>
>>> +        <volume-size>91035648</volume-size>
>>> +      </iso>
>>> +    </media>
>>> +    <media arch="i686">
>>> +
>>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot-com.iso</url>
>>
>> Same here.
>>
>>> +      <iso>
>>> +        <system-id>NetBSD</system-id>
>>> +        <volume-id>NETBSD_712</volume-id>
>>> +        <volume-size>91035648</volume-size>
>>> +      </iso>
>>> +    </media>
>>> +  </os>
>>> +</libosinfo>
>>> --
>>> 2.17.0
>>>
>>>
>>> _______________________________________________
>>> Libosinfo mailing list
>>> Libosinfo at redhat.com
>>> https://www.redhat.com/mailman/listinfo/libosinfo
>>
>>
>> I'll push your patches, with the modifications, later Today.
>> Thanks for your contribution!
>>
>
> Hello Fabiano,
>
> thank you for taking the time to fix my patch.

No problem. :-)

I've also noticed (and fixed locally):
- Volume size didn't match with the ones provided in the libosinfo patch;
- There was no isodata for the NetBSD-7.1.2-amd64.iso

I've fixed both, squashed my fixes into yours and Tomorrow I'll do a
release including the patches!

Again, thanks a lot for the contribution!

>
> Regards,
>
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Sun May 13 08:46:58 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Sun, 13 May 2018 10:46:58 +0200
Subject: [Libosinfo] Fedora 28
In-Reply-To: <CAEXRhXmb1+0BmuWbR9xDFy+MCNn72U1obv7MhHMDXH7A5dx6Ww@mail.gmail.com>
References: <CAEXRhXmb1+0BmuWbR9xDFy+MCNn72U1obv7MhHMDXH7A5dx6Ww@mail.gmail.com>
Message-ID: <CAK9pz9LgTcW2wGAZjZh+3XrTNCF+5U8_woQMtohdOSf_kVuP3A@mail.gmail.com>

On Fri, May 11, 2018 at 12:57 AM, Matthias Clasen <mclasen at redhat.com> wrote:
> From 060fb63cceb4dab2dfaa8ebfaa7b826529c6cdee Mon Sep 17 00:00:00 2001
> From: Matthias Clasen <mclasen at redhat.com>
> Date: Thu, 10 May 2018 17:54:34 -0400
> Subject: [PATCH] Add Fedora 28
>
> This adds all the variants of Fedora 28.
> ---
>  data/os/fedoraproject.org/fedora-28.xml.in | 129 +++++++++++++++++++++
>  1 file changed, 129 insertions(+)
>  create mode 100644 data/os/fedoraproject.org/fedora-28.xml.in
>
> diff --git a/data/os/fedoraproject.org/fedora-28.xml.in
> b/data/os/fedoraproject.org/fedora-28.xml.in
> new file mode 100644
> index 0000000..761f3df
> --- /dev/null
> +++ b/data/os/fedoraproject.org/fedora-28.xml.in
> @@ -0,0 +1,129 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <os id="http://fedoraproject.org/fedora/28">
> +    <short-id>fedora28</short-id>
> +    <_name>Fedora 28</_name>
> +    <version>28</version>
> +    <_vendor>Fedora Project</_vendor>
> +    <family>linux</family>
> +    <distro>fedora</distro>
> +    <upgrades id="http://fedoraproject.org/fedora/27"/>
> +    <derives-from id="http://fedoraproject.org/fedora/27"/>
> +
> +    <release-date>2018-05-01</release-date>
> +
> +    <variant id="workstation">
> +      <_name>Fedora 28 Workstation</_name>
> +    </variant>
> +    <variant id="workstation-netinst">
> +      <_name>Fedora 28 Workstation</_name>
> +    </variant>
> +    <variant id="workstation-atomic">
> +      <_name>Fedora 28 Workstation</_name>
> +    </variant>
> +    <variant id="server">
> +      <_name>Fedora 28 Server</_name>
> +    </variant>
> +    <variant id="server-netinst">
> +      <_name>Fedora 28 Server</_name>
> +    </variant>
> +
> +    <!-- Workstation -->
> +
> +    <!-- Live -->
> +    <media arch="x86_64" live="true">
> +      <variant id="workstation"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-WS-Live-28.*</volume-id>
> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Atomic -->
> +    <media arch="x86_64">
> +      <variant id="workstation-atomic"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/AtomicWorkstation/x86_64/iso/Fedora-WorkstationOstree-ostree-x86_64-28-1.1.iso</url>

While trying to download the ISOs, I've noticed that this URL is wrong.
https://download.fedoraproject.org/pub/fedora/linux/releases/28/AtomicWorkstation/x86_64/iso/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso
is the correct one.

> +      <iso>
> +        <volume-id>Fedora-WSOstree-ostree-x86_64-28</volume-id>

After having access to the isodata I've noticed that the volume-id is wrong.
Fedora-AW-ostree-x86_64-28 is the correct one

> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Network Installer !-->
> +    <media arch="x86_64">
> +      <variant id="workstation-netinst"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Workstation/x86_64/iso/Fedora-Workstation-netinst-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-WS-dvd-x86_64-28</volume-id>
> +        <system-id>LINUX</system-id>
> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Server -->
> +
> +    <!-- DVD -->
> +    <media arch="x86_64">
> +      <variant id="server"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/iso/Fedora-Server-dvd-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-S-dvd-x86_64-28</volume-id>
> +        <system-id>LINUX</system-id>
> +        <volume-size>2490122240</volume-size>

After having access to the isodata, I've noticed that the volume-size is wrong.
2903031808 is the correct one.

> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <!-- Network Installer !-->
> +    <media arch="x86_64">
> +      <variant id="server-netinst"/>
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/iso/Fedora-Server-netinst-x86_64-28-1.1.iso</url>
> +      <iso>
> +        <volume-id>Fedora-S-dvd-x86_64-28</volume-id>
> +        <system-id>LINUX</system-id>
> +        <volume-size>535017472</volume-size>

After having access to the isodata, I've noticed that the volume-size is wrong.
610408448 is the correct one.

> +      </iso>
> +      <kernel>isolinux/vmlinuz</kernel>
> +      <initrd>isolinux/initrd.img</initrd>
> +    </media>
> +
> +    <tree arch="x86_64">
> +
> <url>https://download.fedoraproject.org/pub/fedora/linux/releases/28/Server/x86_64/os/</url>
> +      <variant id="server"/>
> +      <treeinfo>
> +        <family>Fedora</family>
> +        <version>28</version>
> +        <arch>x86_64</arch>
> +      </treeinfo>
> +    </tree>
> +
> +    <!-- No install media or tree is provided for Fedora 28 Cloud variant
> -->
> +
> +    <resources arch="all">
> +      <minimum>
> +        <n-cpus>1</n-cpus>
> +        <cpu>1000000000</cpu>
> +        <ram>1073741824</ram>
> +        <storage>10737418240</storage>
> +      </minimum>
> +
> +      <recommended>
> +        <ram>2147483648</ram>
> +        <storage>21474836480</storage>
> +      </recommended>
> +    </resources>
> +
> +    <installer>
> +      <script id='http://fedoraproject.org/fedora/kickstart/jeos'/>
> +      <script id='http://fedoraproject.org/fedora/kickstart/desktop'/>
> +    </installer>
> +  </os>
> +</libosinfo>
> --
> 2.17.0
>
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>

Also, when updating Fedora data would be really nice to also bump the
fedora-unknown.xml.in.

I've fixed all of issues before pushing the patch and I'll submit the
fedora-unknown.xml.in change + fedora isoinfo.

Thanks for the contribution!
-- 
Fabiano Fid?ncio



From fidencio at redhat.com  Sun May 13 09:05:34 2018
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sun, 13 May 2018 11:05:34 +0200
Subject: [Libosinfo] [[libosinfo][PATCH]] fedora: Add f28 isodata
Message-ID: <20180513090536.13138-1-fidencio@redhat.com>

From: Fabiano Fid?ncio <fabiano at fidencio.org>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 ...-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt | 29 ++++++++++++++++++++++
 .../Fedora-Server-dvd-x86_64-28-1.1.iso.txt        | 29 ++++++++++++++++++++++
 .../Fedora-Server-netinst-x86_64-28-1.1.iso.txt    | 29 ++++++++++++++++++++++
 .../Fedora-Workstation-Live-x86_64-28-1.1.iso.txt  | 29 ++++++++++++++++++++++
 4 files changed, 116 insertions(+)
 create mode 100644 tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt
 create mode 100644 tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt
 create mode 100644 tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt
 create mode 100644 tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt

diff --git a/tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt
new file mode 100644
index 0000000..6380eee
--- /dev/null
+++ b/tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-AW-ostree-x86_64-28
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1020825
+El Torito VD version 1 found, boot catalog is in sector 44
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff F80AD 1015981
diff --git a/tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt
new file mode 100644
index 0000000..5fc55ac
--- /dev/null
+++ b/tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-S-dvd-x86_64-28
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1417496
+El Torito VD version 1 found, boot catalog is in sector 499
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 48C5B 298075
diff --git a/tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt
new file mode 100644
index 0000000..bbfbe82
--- /dev/null
+++ b/tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-S-dvd-x86_64-28
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 298051
+El Torito VD version 1 found, boot catalog is in sector 44
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 47957 293207
diff --git a/tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt
new file mode 100644
index 0000000..aed5d0b
--- /dev/null
+++ b/tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: Fedora-WS-Live-28-1-1
+Volume set id: 
+Publisher id: 
+Data preparer id: 
+Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 872512
+El Torito VD version 1 found, boot catalog is in sector 46
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 6434 25652
-- 
2.14.3



From fidencio at redhat.com  Sun May 13 09:05:35 2018
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sun, 13 May 2018 11:05:35 +0200
Subject: [Libosinfo] [[osinfo-db][PATCH]] fedora-unknown: Adjust the regular
	expression
In-Reply-To: <20180513090536.13138-1-fidencio@redhat.com>
References: <20180513090536.13138-1-fidencio@redhat.com>
Message-ID: <20180513090536.13138-2-fidencio@redhat.com>

From: Fabiano Fid?ncio <fabiano at fidencio.org>

f28 data has been added, so let's adjust the regular expression to match
f29+.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/fedoraproject.org/fedora-unknown.xml.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/os/fedoraproject.org/fedora-unknown.xml.in b/data/os/fedoraproject.org/fedora-unknown.xml.in
index 704829b..694a30b 100644
--- a/data/os/fedoraproject.org/fedora-unknown.xml.in
+++ b/data/os/fedoraproject.org/fedora-unknown.xml.in
@@ -14,7 +14,7 @@
 
     <media arch="x86_64">
       <iso>
-        <volume-id>Fedora-.*-dvd-x86_64-(2[8-9]|[3-9][0-9]|rawh)</volume-id>
+        <volume-id>Fedora-.*-dvd-x86_64-(29|[3-9][0-9]|rawh)</volume-id>
         <system-id>LINUX</system-id>
       </iso>
       <kernel>isolinux/vmlinuz</kernel>
@@ -23,7 +23,7 @@
 
     <media arch="x86_64" live="true">
       <iso>
-        <volume-id>Fedora-.*-Live-(2[8-9]|[3-9][0-9]|Rawhide).*</volume-id>
+        <volume-id>Fedora-.*-Live-(29|[3-9][0-9]|Rawhide).*</volume-id>
         <system-id>LINUX</system-id>
       </iso>
     </media>
-- 
2.14.3



From fidencio at redhat.com  Sun May 13 09:05:36 2018
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sun, 13 May 2018 11:05:36 +0200
Subject: [Libosinfo] [[osinfo-db][PATCH]] fedora: Use more descriptive name
	for variant ids
In-Reply-To: <20180513090536.13138-1-fidencio@redhat.com>
References: <20180513090536.13138-1-fidencio@redhat.com>
Message-ID: <20180513090536.13138-3-fidencio@redhat.com>

From: Fabiano Fid?ncio <fabiano at fidencio.org>

For the user installing the system it does matter whether they will use
the Live, Network Installer or Atomic version of Fedora Workstation
(taking this as an example). So, let's expose this info instead of just
showing "Fedora Workstation" for all of those.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/fedoraproject.org/fedora-27.xml.in | 10 +++++-----
 data/os/fedoraproject.org/fedora-28.xml.in | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in
index ba657d0..a48728d 100644
--- a/data/os/fedoraproject.org/fedora-27.xml.in
+++ b/data/os/fedoraproject.org/fedora-27.xml.in
@@ -14,19 +14,19 @@
     <release-date>2017-11-14</release-date>
 
     <variant id="workstation">
-      <_name>Fedora 27 Workstation</_name>
+      <_name>Fedora 27 Workstation (Live)</_name>
     </variant>
     <variant id="workstation-netinst">
-      <_name>Fedora 27 Workstation</_name>
+      <_name>Fedora 27 Workstation (Network Installer)</_name>
     </variant>
     <variant id="workstation-atomic">
-      <_name>Fedora 27 Workstation</_name>
+      <_name>Fedora 27 Workstation (Atomic)</_name>
     </variant>
     <variant id="server">
-      <_name>Fedora 27 Server</_name>
+      <_name>Fedora 27 Server (DVD)</_name>
     </variant>
     <variant id="server-netinst">
-      <_name>Fedora 27 Server</_name>
+      <_name>Fedora 27 Server (Network Installer)</_name>
     </variant>
 
     <!-- Workstation -->
diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/fedoraproject.org/fedora-28.xml.in
index cda279c..4e75d63 100644
--- a/data/os/fedoraproject.org/fedora-28.xml.in
+++ b/data/os/fedoraproject.org/fedora-28.xml.in
@@ -14,19 +14,19 @@
     <release-date>2018-05-01</release-date>
 
     <variant id="workstation">
-      <_name>Fedora 28 Workstation</_name>
+      <_name>Fedora 28 Workstation (Live)</_name>
     </variant>
     <variant id="workstation-netinst">
-      <_name>Fedora 28 Workstation</_name>
+      <_name>Fedora 28 Workstation (Network Installer)</_name>
     </variant>
     <variant id="workstation-atomic">
-      <_name>Fedora 28 Workstation</_name>
+      <_name>Fedora 28 Workstation (Atomic)</_name>
     </variant>
     <variant id="server">
-      <_name>Fedora 28 Server</_name>
+      <_name>Fedora 28 Server (DVD)</_name>
     </variant>
     <variant id="server-netinst">
-      <_name>Fedora 28 Server</_name>
+      <_name>Fedora 28 Server (Network Installer)</_name>
     </variant>
 
     <!-- Workstation -->
-- 
2.14.3



From cfergeau at redhat.com  Mon May 14 11:04:38 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 14 May 2018 13:04:38 +0200
Subject: [Libosinfo] [[osinfo-db][PATCH]] fedora: Use more descriptive
 name for variant ids
In-Reply-To: <20180513090536.13138-3-fidencio@redhat.com>
References: <20180513090536.13138-1-fidencio@redhat.com>
	<20180513090536.13138-3-fidencio@redhat.com>
Message-ID: <20180514110438.GF29739@natto.ory.fergeau.eu>

On Sun, May 13, 2018 at 11:05:36AM +0200, Fabiano Fid?ncio wrote:
> From: Fabiano Fid?ncio <fabiano at fidencio.org>
> 
> For the user installing the system it does matter whether they will use
> the Live, Network Installer or Atomic version of Fedora Workstation
> (taking this as an example). So, let's expose this info instead of just
> showing "Fedora Workstation" for all of those.
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/os/fedoraproject.org/fedora-27.xml.in | 10 +++++-----
>  data/os/fedoraproject.org/fedora-28.xml.in | 10 +++++-----
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in
> index ba657d0..a48728d 100644
> --- a/data/os/fedoraproject.org/fedora-27.xml.in
> +++ b/data/os/fedoraproject.org/fedora-27.xml.in
> @@ -14,19 +14,19 @@
>      <release-date>2017-11-14</release-date>
>  
>      <variant id="workstation">
> -      <_name>Fedora 27 Workstation</_name>
> +      <_name>Fedora 27 Workstation (Live)</_name>

This is redundant with live="true" on the <media> nodes, and actually
gnome-boxes is already appending "(Live)" on its own when this attribute
is set, so I'm not sure this is the right way to go.

Christophe

>      </variant>
>      <variant id="workstation-netinst">
> -      <_name>Fedora 27 Workstation</_name>
> +      <_name>Fedora 27 Workstation (Network Installer)</_name>
>      </variant>
>      <variant id="workstation-atomic">
> -      <_name>Fedora 27 Workstation</_name>
> +      <_name>Fedora 27 Workstation (Atomic)</_name>
>      </variant>
>      <variant id="server">
> -      <_name>Fedora 27 Server</_name>
> +      <_name>Fedora 27 Server (DVD)</_name>
>      </variant>
>      <variant id="server-netinst">
> -      <_name>Fedora 27 Server</_name>
> +      <_name>Fedora 27 Server (Network Installer)</_name>
>      </variant>
>  
>      <!-- Workstation -->
> diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/fedoraproject.org/fedora-28.xml.in
> index cda279c..4e75d63 100644
> --- a/data/os/fedoraproject.org/fedora-28.xml.in
> +++ b/data/os/fedoraproject.org/fedora-28.xml.in
> @@ -14,19 +14,19 @@
>      <release-date>2018-05-01</release-date>
>  
>      <variant id="workstation">
> -      <_name>Fedora 28 Workstation</_name>
> +      <_name>Fedora 28 Workstation (Live)</_name>
>      </variant>
>      <variant id="workstation-netinst">
> -      <_name>Fedora 28 Workstation</_name>
> +      <_name>Fedora 28 Workstation (Network Installer)</_name>
>      </variant>
>      <variant id="workstation-atomic">
> -      <_name>Fedora 28 Workstation</_name>
> +      <_name>Fedora 28 Workstation (Atomic)</_name>
>      </variant>
>      <variant id="server">
> -      <_name>Fedora 28 Server</_name>
> +      <_name>Fedora 28 Server (DVD)</_name>
>      </variant>
>      <variant id="server-netinst">
> -      <_name>Fedora 28 Server</_name>
> +      <_name>Fedora 28 Server (Network Installer)</_name>
>      </variant>
>  
>      <!-- Workstation -->
> -- 
> 2.14.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180514/f616b8db/attachment.sig>

From cfergeau at redhat.com  Mon May 14 11:10:44 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 14 May 2018 13:10:44 +0200
Subject: [Libosinfo] [[osinfo-db][PATCH]] fedora-unknown: Adjust the
 regular expression
In-Reply-To: <20180513090536.13138-2-fidencio@redhat.com>
References: <20180513090536.13138-1-fidencio@redhat.com>
	<20180513090536.13138-2-fidencio@redhat.com>
Message-ID: <20180514111044.GG29739@natto.ory.fergeau.eu>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Sun, May 13, 2018 at 11:05:35AM +0200, Fabiano Fid?ncio wrote:
> From: Fabiano Fid?ncio <fabiano at fidencio.org>
> 
> f28 data has been added, so let's adjust the regular expression to match
> f29+.
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/os/fedoraproject.org/fedora-unknown.xml.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/data/os/fedoraproject.org/fedora-unknown.xml.in b/data/os/fedoraproject.org/fedora-unknown.xml.in
> index 704829b..694a30b 100644
> --- a/data/os/fedoraproject.org/fedora-unknown.xml.in
> +++ b/data/os/fedoraproject.org/fedora-unknown.xml.in
> @@ -14,7 +14,7 @@
>  
>      <media arch="x86_64">
>        <iso>
> -        <volume-id>Fedora-.*-dvd-x86_64-(2[8-9]|[3-9][0-9]|rawh)</volume-id>
> +        <volume-id>Fedora-.*-dvd-x86_64-(29|[3-9][0-9]|rawh)</volume-id>
>          <system-id>LINUX</system-id>
>        </iso>
>        <kernel>isolinux/vmlinuz</kernel>
> @@ -23,7 +23,7 @@
>  
>      <media arch="x86_64" live="true">
>        <iso>
> -        <volume-id>Fedora-.*-Live-(2[8-9]|[3-9][0-9]|Rawhide).*</volume-id>
> +        <volume-id>Fedora-.*-Live-(29|[3-9][0-9]|Rawhide).*</volume-id>
>          <system-id>LINUX</system-id>
>        </iso>
>      </media>
> -- 
> 2.14.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180514/34e3fece/attachment.sig>

From cfergeau at redhat.com  Mon May 14 11:19:38 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 14 May 2018 13:19:38 +0200
Subject: [Libosinfo] [[libosinfo][PATCH]] fedora: Add f28 isodata
In-Reply-To: <20180513090536.13138-1-fidencio@redhat.com>
References: <20180513090536.13138-1-fidencio@redhat.com>
Message-ID: <20180514111938.GH29739@natto.ory.fergeau.eu>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Sun, May 13, 2018 at 11:05:34AM +0200, Fabiano Fid?ncio wrote:
> From: Fabiano Fid?ncio <fabiano at fidencio.org>
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  ...-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt | 29 ++++++++++++++++++++++
>  .../Fedora-Server-dvd-x86_64-28-1.1.iso.txt        | 29 ++++++++++++++++++++++
>  .../Fedora-Server-netinst-x86_64-28-1.1.iso.txt    | 29 ++++++++++++++++++++++
>  .../Fedora-Workstation-Live-x86_64-28-1.1.iso.txt  | 29 ++++++++++++++++++++++
>  4 files changed, 116 insertions(+)
>  create mode 100644 tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt
>  create mode 100644 tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt
>  create mode 100644 tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt
>  create mode 100644 tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt
> 
> diff --git a/tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt
> new file mode 100644
> index 0000000..6380eee
> --- /dev/null
> +++ b/tests/isodata/fedora/fedora28/Fedora-AtomicWorkstation-ostree-x86_64-28-1.1.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-AW-ostree-x86_64-28
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1020825
> +El Torito VD version 1 found, boot catalog is in sector 44
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff F80AD 1015981
> diff --git a/tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt
> new file mode 100644
> index 0000000..5fc55ac
> --- /dev/null
> +++ b/tests/isodata/fedora/fedora28/Fedora-Server-dvd-x86_64-28-1.1.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-S-dvd-x86_64-28
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1417496
> +El Torito VD version 1 found, boot catalog is in sector 499
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 48C5B 298075
> diff --git a/tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt
> new file mode 100644
> index 0000000..bbfbe82
> --- /dev/null
> +++ b/tests/isodata/fedora/fedora28/Fedora-Server-netinst-x86_64-28-1.1.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-S-dvd-x86_64-28
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 298051
> +El Torito VD version 1 found, boot catalog is in sector 44
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 47957 293207
> diff --git a/tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt b/tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt
> new file mode 100644
> index 0000000..aed5d0b
> --- /dev/null
> +++ b/tests/isodata/fedora/fedora28/Fedora-Workstation-Live-x86_64-28-1.1.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: Fedora-WS-Live-28-1-1
> +Volume set id: 
> +Publisher id: 
> +Data preparer id: 
> +Application id: GENISOIMAGE ISO 9660/HFS FILESYSTEM CREATOR (C) 1993 E.YOUNGDALE (C) 1997-2006 J.PEARSON/J.SCHILLING (C) 2006-2007 CDRKIT TEAM
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 872512
> +El Torito VD version 1 found, boot catalog is in sector 46
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID ''
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 6434 25652
> -- 
> 2.14.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180514/3b9019c4/attachment.sig>

From fabiano at fidencio.org  Mon May 14 11:20:43 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Mon, 14 May 2018 13:20:43 +0200
Subject: [Libosinfo] [[osinfo-db][PATCH]] fedora: Use more descriptive
 name for variant ids
In-Reply-To: <20180514110438.GF29739@natto.ory.fergeau.eu>
References: <20180513090536.13138-1-fidencio@redhat.com>
	<20180513090536.13138-3-fidencio@redhat.com>
	<20180514110438.GF29739@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9LnUafCY8uLPuuLQ07Mv4gvW1iQ5knaSoBr+9Hfzi5NOw@mail.gmail.com>

On Mon, May 14, 2018 at 1:04 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Sun, May 13, 2018 at 11:05:36AM +0200, Fabiano Fid?ncio wrote:
>> From: Fabiano Fid?ncio <fabiano at fidencio.org>
>>
>> For the user installing the system it does matter whether they will use
>> the Live, Network Installer or Atomic version of Fedora Workstation
>> (taking this as an example). So, let's expose this info instead of just
>> showing "Fedora Workstation" for all of those.
>>
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  data/os/fedoraproject.org/fedora-27.xml.in | 10 +++++-----
>>  data/os/fedoraproject.org/fedora-28.xml.in | 10 +++++-----
>>  2 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in
>> index ba657d0..a48728d 100644
>> --- a/data/os/fedoraproject.org/fedora-27.xml.in
>> +++ b/data/os/fedoraproject.org/fedora-27.xml.in
>> @@ -14,19 +14,19 @@
>>      <release-date>2017-11-14</release-date>
>>
>>      <variant id="workstation">
>> -      <_name>Fedora 27 Workstation</_name>
>> +      <_name>Fedora 27 Workstation (Live)</_name>
>
> This is redundant with live="true" on the <media> nodes, and actually
> gnome-boxes is already appending "(Live)" on its own when this attribute
> is set, so I'm not sure this is the right way to go.

Makes sense.
Does the patch still make sense with this part dropped?

>
> Christophe
>
>>      </variant>
>>      <variant id="workstation-netinst">
>> -      <_name>Fedora 27 Workstation</_name>
>> +      <_name>Fedora 27 Workstation (Network Installer)</_name>
>>      </variant>
>>      <variant id="workstation-atomic">
>> -      <_name>Fedora 27 Workstation</_name>
>> +      <_name>Fedora 27 Workstation (Atomic)</_name>
>>      </variant>
>>      <variant id="server">
>> -      <_name>Fedora 27 Server</_name>
>> +      <_name>Fedora 27 Server (DVD)</_name>
>>      </variant>
>>      <variant id="server-netinst">
>> -      <_name>Fedora 27 Server</_name>
>> +      <_name>Fedora 27 Server (Network Installer)</_name>
>>      </variant>
>>
>>      <!-- Workstation -->
>> diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/fedoraproject.org/fedora-28.xml.in
>> index cda279c..4e75d63 100644
>> --- a/data/os/fedoraproject.org/fedora-28.xml.in
>> +++ b/data/os/fedoraproject.org/fedora-28.xml.in
>> @@ -14,19 +14,19 @@
>>      <release-date>2018-05-01</release-date>
>>
>>      <variant id="workstation">
>> -      <_name>Fedora 28 Workstation</_name>
>> +      <_name>Fedora 28 Workstation (Live)</_name>
>>      </variant>
>>      <variant id="workstation-netinst">
>> -      <_name>Fedora 28 Workstation</_name>
>> +      <_name>Fedora 28 Workstation (Network Installer)</_name>
>>      </variant>
>>      <variant id="workstation-atomic">
>> -      <_name>Fedora 28 Workstation</_name>
>> +      <_name>Fedora 28 Workstation (Atomic)</_name>
>>      </variant>
>>      <variant id="server">
>> -      <_name>Fedora 28 Server</_name>
>> +      <_name>Fedora 28 Server (DVD)</_name>
>>      </variant>
>>      <variant id="server-netinst">
>> -      <_name>Fedora 28 Server</_name>
>> +      <_name>Fedora 28 Server (Network Installer)</_name>
>>      </variant>
>>
>>      <!-- Workstation -->
>> --
>> 2.14.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>



-- 
Fabiano Fid?ncio



From fidencio at redhat.com  Mon May 14 11:45:18 2018
From: fidencio at redhat.com (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Mon, 14 May 2018 13:45:18 +0200
Subject: [Libosinfo] [osinfo-db][PATCHv2] fedora: Use more descriptive name
	for variant ids
Message-ID: <20180514114518.20555-1-fidencio@redhat.com>

From: Fabiano Fid?ncio <fabiano at fidencio.org>

For the user installing the system it does matter whether they will use
the Live, Network Installer or Atomic version of Fedora Workstation
(taking this as an example). So, let's expose this info instead of just
showing "Fedora Workstation" for all of those.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/fedoraproject.org/fedora-27.xml.in | 8 ++++----
 data/os/fedoraproject.org/fedora-28.xml.in | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in
index ba657d0..9087922 100644
--- a/data/os/fedoraproject.org/fedora-27.xml.in
+++ b/data/os/fedoraproject.org/fedora-27.xml.in
@@ -17,16 +17,16 @@
       <_name>Fedora 27 Workstation</_name>
     </variant>
     <variant id="workstation-netinst">
-      <_name>Fedora 27 Workstation</_name>
+      <_name>Fedora 27 Workstation (Network Installer)</_name>
     </variant>
     <variant id="workstation-atomic">
-      <_name>Fedora 27 Workstation</_name>
+      <_name>Fedora 27 Workstation (Atomic)</_name>
     </variant>
     <variant id="server">
-      <_name>Fedora 27 Server</_name>
+      <_name>Fedora 27 Server (DVD)</_name>
     </variant>
     <variant id="server-netinst">
-      <_name>Fedora 27 Server</_name>
+      <_name>Fedora 27 Server (Network Installer)</_name>
     </variant>
 
     <!-- Workstation -->
diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/fedoraproject.org/fedora-28.xml.in
index cda279c..8d2db31 100644
--- a/data/os/fedoraproject.org/fedora-28.xml.in
+++ b/data/os/fedoraproject.org/fedora-28.xml.in
@@ -17,16 +17,16 @@
       <_name>Fedora 28 Workstation</_name>
     </variant>
     <variant id="workstation-netinst">
-      <_name>Fedora 28 Workstation</_name>
+      <_name>Fedora 28 Workstation (Network Installer)</_name>
     </variant>
     <variant id="workstation-atomic">
-      <_name>Fedora 28 Workstation</_name>
+      <_name>Fedora 28 Workstation (Atomic)</_name>
     </variant>
     <variant id="server">
-      <_name>Fedora 28 Server</_name>
+      <_name>Fedora 28 Server (DVD)</_name>
     </variant>
     <variant id="server-netinst">
-      <_name>Fedora 28 Server</_name>
+      <_name>Fedora 28 Server (Network Installer)</_name>
     </variant>
 
     <!-- Workstation -->
-- 
2.14.3



From cfergeau at redhat.com  Mon May 14 11:47:26 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 14 May 2018 13:47:26 +0200
Subject: [Libosinfo] [[osinfo-db][PATCH]] fedora: Use more descriptive
 name for variant ids
In-Reply-To: <CAK9pz9LnUafCY8uLPuuLQ07Mv4gvW1iQ5knaSoBr+9Hfzi5NOw@mail.gmail.com>
References: <20180513090536.13138-1-fidencio@redhat.com>
	<20180513090536.13138-3-fidencio@redhat.com>
	<20180514110438.GF29739@natto.ory.fergeau.eu>
	<CAK9pz9LnUafCY8uLPuuLQ07Mv4gvW1iQ5knaSoBr+9Hfzi5NOw@mail.gmail.com>
Message-ID: <20180514114726.GI29739@natto.ory.fergeau.eu>

On Mon, May 14, 2018 at 01:20:43PM +0200, Fabiano Fid?ncio wrote:
> On Mon, May 14, 2018 at 1:04 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Sun, May 13, 2018 at 11:05:36AM +0200, Fabiano Fid?ncio wrote:
> >> From: Fabiano Fid?ncio <fabiano at fidencio.org>
> >>
> >> For the user installing the system it does matter whether they will use
> >> the Live, Network Installer or Atomic version of Fedora Workstation
> >> (taking this as an example). So, let's expose this info instead of just
> >> showing "Fedora Workstation" for all of those.
> >>
> >> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> >> ---
> >>  data/os/fedoraproject.org/fedora-27.xml.in | 10 +++++-----
> >>  data/os/fedoraproject.org/fedora-28.xml.in | 10 +++++-----
> >>  2 files changed, 10 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in
> >> index ba657d0..a48728d 100644
> >> --- a/data/os/fedoraproject.org/fedora-27.xml.in
> >> +++ b/data/os/fedoraproject.org/fedora-27.xml.in
> >> @@ -14,19 +14,19 @@
> >>      <release-date>2017-11-14</release-date>
> >>
> >>      <variant id="workstation">
> >> -      <_name>Fedora 27 Workstation</_name>
> >> +      <_name>Fedora 27 Workstation (Live)</_name>
> >
> > This is redundant with live="true" on the <media> nodes, and actually
> > gnome-boxes is already appending "(Live)" on its own when this attribute
> > is set, so I'm not sure this is the right way to go.
> 
> Makes sense.
> Does the patch still make sense with this part dropped?

While (Atomic) is harder to express in a generic way, I feel that the
"Network Installer" bit might be useful as some kind of XML attribute
rather than being in the string?

Christophe

> 
> >
> > Christophe
> >
> >>      </variant>
> >>      <variant id="workstation-netinst">
> >> -      <_name>Fedora 27 Workstation</_name>
> >> +      <_name>Fedora 27 Workstation (Network Installer)</_name>
> >>      </variant>
> >>      <variant id="workstation-atomic">
> >> -      <_name>Fedora 27 Workstation</_name>
> >> +      <_name>Fedora 27 Workstation (Atomic)</_name>
> >>      </variant>
> >>      <variant id="server">
> >> -      <_name>Fedora 27 Server</_name>
> >> +      <_name>Fedora 27 Server (DVD)</_name>
> >>      </variant>
> >>      <variant id="server-netinst">
> >> -      <_name>Fedora 27 Server</_name>
> >> +      <_name>Fedora 27 Server (Network Installer)</_name>
> >>      </variant>
> >>
> >>      <!-- Workstation -->
> >> diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/fedoraproject.org/fedora-28.xml.in
> >> index cda279c..4e75d63 100644
> >> --- a/data/os/fedoraproject.org/fedora-28.xml.in
> >> +++ b/data/os/fedoraproject.org/fedora-28.xml.in
> >> @@ -14,19 +14,19 @@
> >>      <release-date>2018-05-01</release-date>
> >>
> >>      <variant id="workstation">
> >> -      <_name>Fedora 28 Workstation</_name>
> >> +      <_name>Fedora 28 Workstation (Live)</_name>
> >>      </variant>
> >>      <variant id="workstation-netinst">
> >> -      <_name>Fedora 28 Workstation</_name>
> >> +      <_name>Fedora 28 Workstation (Network Installer)</_name>
> >>      </variant>
> >>      <variant id="workstation-atomic">
> >> -      <_name>Fedora 28 Workstation</_name>
> >> +      <_name>Fedora 28 Workstation (Atomic)</_name>
> >>      </variant>
> >>      <variant id="server">
> >> -      <_name>Fedora 28 Server</_name>
> >> +      <_name>Fedora 28 Server (DVD)</_name>
> >>      </variant>
> >>      <variant id="server-netinst">
> >> -      <_name>Fedora 28 Server</_name>
> >> +      <_name>Fedora 28 Server (Network Installer)</_name>
> >>      </variant>
> >>
> >>      <!-- Workstation -->
> >> --
> >> 2.14.3
> >>
> >> _______________________________________________
> >> Libosinfo mailing list
> >> Libosinfo at redhat.com
> >> https://www.redhat.com/mailman/listinfo/libosinfo
> >
> > _______________________________________________
> > Libosinfo mailing list
> > Libosinfo at redhat.com
> > https://www.redhat.com/mailman/listinfo/libosinfo
> >
> 
> 
> 
> -- 
> Fabiano Fid?ncio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180514/b83deaeb/attachment.sig>

From fabiano at fidencio.org  Mon May 14 11:59:51 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Mon, 14 May 2018 13:59:51 +0200
Subject: [Libosinfo] [[osinfo-db][PATCH]] fedora: Use more descriptive
 name for variant ids
In-Reply-To: <20180514114726.GI29739@natto.ory.fergeau.eu>
References: <20180513090536.13138-1-fidencio@redhat.com>
	<20180513090536.13138-3-fidencio@redhat.com>
	<20180514110438.GF29739@natto.ory.fergeau.eu>
	<CAK9pz9LnUafCY8uLPuuLQ07Mv4gvW1iQ5knaSoBr+9Hfzi5NOw@mail.gmail.com>
	<20180514114726.GI29739@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9LqyG+YiNwhccS+MhtVgNQH3qEPdUVBaEaZ2DiFWf9KDg@mail.gmail.com>

On Mon, May 14, 2018 at 1:47 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, May 14, 2018 at 01:20:43PM +0200, Fabiano Fid?ncio wrote:
>> On Mon, May 14, 2018 at 1:04 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Sun, May 13, 2018 at 11:05:36AM +0200, Fabiano Fid?ncio wrote:
>> >> From: Fabiano Fid?ncio <fabiano at fidencio.org>
>> >>
>> >> For the user installing the system it does matter whether they will use
>> >> the Live, Network Installer or Atomic version of Fedora Workstation
>> >> (taking this as an example). So, let's expose this info instead of just
>> >> showing "Fedora Workstation" for all of those.
>> >>
>> >> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> >> ---
>> >>  data/os/fedoraproject.org/fedora-27.xml.in | 10 +++++-----
>> >>  data/os/fedoraproject.org/fedora-28.xml.in | 10 +++++-----
>> >>  2 files changed, 10 insertions(+), 10 deletions(-)
>> >>
>> >> diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in
>> >> index ba657d0..a48728d 100644
>> >> --- a/data/os/fedoraproject.org/fedora-27.xml.in
>> >> +++ b/data/os/fedoraproject.org/fedora-27.xml.in
>> >> @@ -14,19 +14,19 @@
>> >>      <release-date>2017-11-14</release-date>
>> >>
>> >>      <variant id="workstation">
>> >> -      <_name>Fedora 27 Workstation</_name>
>> >> +      <_name>Fedora 27 Workstation (Live)</_name>
>> >
>> > This is redundant with live="true" on the <media> nodes, and actually
>> > gnome-boxes is already appending "(Live)" on its own when this attribute
>> > is set, so I'm not sure this is the right way to go.
>>
>> Makes sense.
>> Does the patch still make sense with this part dropped?
>
> While (Atomic) is harder to express in a generic way, I feel that the
> "Network Installer" bit might be useful as some kind of XML attribute
> rather than being in the string?

Okay, so I'll re-work this patch with your suggestion in mind and keep
it out of the release I'm preparing for Today.

Thanks for the review, Christophe!

>
> Christophe
>
>>
>> >
>> > Christophe
>> >
>> >>      </variant>
>> >>      <variant id="workstation-netinst">
>> >> -      <_name>Fedora 27 Workstation</_name>
>> >> +      <_name>Fedora 27 Workstation (Network Installer)</_name>
>> >>      </variant>
>> >>      <variant id="workstation-atomic">
>> >> -      <_name>Fedora 27 Workstation</_name>
>> >> +      <_name>Fedora 27 Workstation (Atomic)</_name>
>> >>      </variant>
>> >>      <variant id="server">
>> >> -      <_name>Fedora 27 Server</_name>
>> >> +      <_name>Fedora 27 Server (DVD)</_name>
>> >>      </variant>
>> >>      <variant id="server-netinst">
>> >> -      <_name>Fedora 27 Server</_name>
>> >> +      <_name>Fedora 27 Server (Network Installer)</_name>
>> >>      </variant>
>> >>
>> >>      <!-- Workstation -->
>> >> diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/fedoraproject.org/fedora-28.xml.in
>> >> index cda279c..4e75d63 100644
>> >> --- a/data/os/fedoraproject.org/fedora-28.xml.in
>> >> +++ b/data/os/fedoraproject.org/fedora-28.xml.in
>> >> @@ -14,19 +14,19 @@
>> >>      <release-date>2018-05-01</release-date>
>> >>
>> >>      <variant id="workstation">
>> >> -      <_name>Fedora 28 Workstation</_name>
>> >> +      <_name>Fedora 28 Workstation (Live)</_name>
>> >>      </variant>
>> >>      <variant id="workstation-netinst">
>> >> -      <_name>Fedora 28 Workstation</_name>
>> >> +      <_name>Fedora 28 Workstation (Network Installer)</_name>
>> >>      </variant>
>> >>      <variant id="workstation-atomic">
>> >> -      <_name>Fedora 28 Workstation</_name>
>> >> +      <_name>Fedora 28 Workstation (Atomic)</_name>
>> >>      </variant>
>> >>      <variant id="server">
>> >> -      <_name>Fedora 28 Server</_name>
>> >> +      <_name>Fedora 28 Server (DVD)</_name>
>> >>      </variant>
>> >>      <variant id="server-netinst">
>> >> -      <_name>Fedora 28 Server</_name>
>> >> +      <_name>Fedora 28 Server (Network Installer)</_name>
>> >>      </variant>
>> >>
>> >>      <!-- Workstation -->
>> >> --
>> >> 2.14.3
>> >>
>> >> _______________________________________________
>> >> Libosinfo mailing list
>> >> Libosinfo at redhat.com
>> >> https://www.redhat.com/mailman/listinfo/libosinfo
>> >
>> > _______________________________________________
>> > Libosinfo mailing list
>> > Libosinfo at redhat.com
>> > https://www.redhat.com/mailman/listinfo/libosinfo
>> >
>>
>>
>>
>> --
>> Fabiano Fid?ncio



-- 
Fabiano Fid?ncio



From felipe10borges at gmail.com  Tue May 22 15:14:27 2018
From: felipe10borges at gmail.com (Felipe Borges)
Date: Tue, 22 May 2018 17:14:27 +0200
Subject: [Libosinfo] [PATCH] endlessos: Add Endless OS 3.4
Message-ID: <20180522151427.26547-1-feborges@redhat.com>

Signed-off-by: Felipe Borges <feborges at redhat.com>
---
 data/os/endlessos.com/eos-3.4.xml.in | 199 +++++++++++++++++++++++++++
 1 file changed, 199 insertions(+)
 create mode 100644 data/os/endlessos.com/eos-3.4.xml.in

diff --git a/data/os/endlessos.com/eos-3.4.xml.in b/data/os/endlessos.com/eos-3.4.xml.in
new file mode 100644
index 0000000..d06b328
--- /dev/null
+++ b/data/os/endlessos.com/eos-3.4.xml.in
@@ -0,0 +1,199 @@
+<libosinfo version="0.0.1">
+<!-- Licensed under the GNU General Public License version 2 or later.
+     See http://www.gnu.org/licenses/ for a copy of the license text -->
+  <os id="http://endlessos.com/eos/3.4">
+    <short-id>eos3.4</short-id>
+    <_name>Endless OS 3.4</_name>
+    <version>3.4</version>
+    <_vendor>Endless Mobile, Inc</_vendor>
+    <family>linux</family>
+    <distro>eos</distro>
+
+    <release-date>2018-05-15</release-date>
+
+    <variant id="basic">
+      <_name>Endless OS Basic</_name>
+    </variant>
+    <variant id="ar">
+      <_name>Endless OS Arabic</_name>
+    </variant>
+    <variant id="bn">
+      <_name>Endless OS Bengali</_name>
+    </variant>
+    <variant id="en">
+      <_name>Endless OS English</_name>
+    </variant>
+    <variant id="es">
+      <_name>Endless OS Spanish</_name>
+    </variant>
+    <variant id="es_GT">
+      <_name>Endless OS Spanish (Guatemala)</_name>
+    </variant>
+    <variant id="es_MX">
+      <_name>Endless OS Spanish (Mexico)</_name>
+    </variant>
+    <variant id="fr">
+      <_name>Endless OS French</_name>
+    </variant>
+    <variant id="id">
+      <_name>Endless OS Indonesian</_name>
+    </variant>
+    <variant id="pt_BR">
+      <_name>Endless OS Portuguese (Brazil)</_name>
+    </variant>
+    <variant id="th">
+      <_name>Endless OS Thai</_name>
+    </variant>
+    <variant id="vi">
+      <_name>Endless OS Vietnamese</_name>
+    </variant>
+    <variant id="zh_CN">
+      <_name>Endless OS Chinese (China)</_name>
+    </variant>
+
+    <!-- Basic -->
+    <media arch="x86_64" live="true">
+      <variant id="basic"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/base/eos-eos3.4-amd64-amd64.180515-041823.base.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-base</volume-id>
+        <volume-size>1867401216</volume-size>
+      </iso>
+    </media>
+
+    <!-- Arabic -->
+    <media arch="x86_64" live="true">
+      <variant id="ar"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/ar/eos-eos3.4-amd64-amd64.180515-054338.ar.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-ar</volume-id>
+        <volume-size>9225773056</volume-size>
+      </iso>
+    </media>
+
+    <!-- Bengali -->
+    <media arch="x86_64" live="true">
+      <variant id="bn"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/bn/eos-eos3.4-amd64-amd64.180515-044248.bn.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-bn</volume-id>
+        <volume-size>12961771520</volume-size>
+      </iso>
+    </media>
+
+    <!-- English -->
+    <media arch="x86_64" live="true">
+      <variant id="en"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/en/eos-eos3.4-amd64-amd64.180515-050141.en.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-en</volume-id>
+        <volume-size>16022677504</volume-size>
+      </iso>
+    </media>
+
+    <!-- Spanish -->
+    <media arch="x86_64" live="true">
+      <variant id="es"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/es/eos-eos3.4-amd64-amd64.180515-044004.es.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-es</volume-id>
+        <volume-size>14674853888</volume-size>
+      </iso>
+    </media>
+
+    <!-- Spanish (Guatemala) -->
+    <media arch="x86_64" live="true">
+      <variant id="es_GT"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/es_GT/eos-eos3.4-amd64-amd64.180515-044927.es_GT.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-es_GT</volume-id>
+        <volume-size>15636629504</volume-size>
+      </iso>
+    </media>
+
+    <!-- Spanish (Mexico) -->
+    <media arch="x86_64" live="true">
+      <variant id="es_MX"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/es_MX/eos-eos3.4-amd64-amd64.180515-061343.es_MX.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-es_MX</volume-id>
+        <volume-size>14698831872</volume-size>
+      </iso>
+    </media>
+
+    <!-- French -->
+    <media arch="x86_64" live="true">
+      <variant id="fr"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/fr/eos-eos3.4-amd64-amd64.180515-055726.fr.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-fr</volume-id>
+        <volume-size>9824772096</volume-size>
+      </iso>
+    </media>
+
+    <!-- Indonesian -->
+    <media arch="x86_64" live="true">
+      <variant id="id"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/id/eos-eos3.4-amd64-amd64.180515-062519.id.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-id</volume-id>
+        <volume-size>16871383040</volume-size>
+      </iso>
+    </media>
+
+    <!-- Portuguese (Brazil) -->
+    <media arch="x86_64" live="true">
+      <variant id="pt_BR"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/pt_BR/eos-eos3.4-amd64-amd64.180515-063108.pt_BR.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-pt_BR</volume-id>
+        <volume-size>11167918080</volume-size>
+      </iso>
+    </media>
+
+    <!-- Thai -->
+    <media arch="x86_64" live="true">
+      <variant id="th"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/th/eos-eos3.4-amd64-amd64.180515-064146.th.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-th</volume-id>
+        <volume-size>7867103232</volume-size>
+      </iso>
+    </media>
+
+    <!-- Vietnamese -->
+    <media arch="x86_64" live="true">
+      <variant id="vi"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/vi/eos-eos3.4-amd64-amd64.180515-070619.vi.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-vi</volume-id>
+        <volume-size>8324974592</volume-size>
+      </iso>
+    </media>
+
+    <!-- Chinese (China) -->
+    <media arch="x86_64" live="true">
+      <variant id="zh_CN"/>
+      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/zh_CN/eos-eos3.4-amd64-amd64.180515-071821.zh_CN.iso</url>
+      <iso>
+        <volume-id>Endless-OS-3-4-0-zh_CN</volume-id>
+        <volume-size>6780473344</volume-size>
+      </iso>
+    </media>
+
+    <resources arch="all">
+      <minimum>
+        <n-cpus>1</n-cpus>
+        <cpu>1000000000</cpu>
+        <ram>2147483648</ram>
+        <storage>21474836480</storage>
+      </minimum>
+
+      <recommended>
+        <ram>2147483648</ram>
+        <storage>42949672960</storage>
+      </recommended>
+    </resources>
+
+  </os>
+</libosinfo>
-- 
2.17.0



From felipe10borges at gmail.com  Tue May 22 15:21:05 2018
From: felipe10borges at gmail.com (Felipe Borges)
Date: Tue, 22 May 2018 17:21:05 +0200
Subject: [Libosinfo] [PATCH] endlessos: Add Endless OS 3.4 isodata
Message-ID: <20180522152105.27678-1-feborges@redhat.com>

Signed-off-by: Felipe Borges <feborges at redhat.com>
---
 ...3.4-amd64-amd64.180515-041823.base.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-044004.es.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-044248.bn.iso.txt | 29 +++++++++++++++++++
 ....4-amd64-amd64.180515-044927.es_GT.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-050141.en.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-054338.ar.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-055726.fr.iso.txt | 29 +++++++++++++++++++
 ....4-amd64-amd64.180515-061343.es_MX.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-062519.id.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-064146.th.iso.txt | 29 +++++++++++++++++++
 ...os3.4-amd64-amd64.180515-070619.vi.iso.txt | 29 +++++++++++++++++++
 ....4-amd64-amd64.180515-071821.zh_CN.iso.txt | 29 +++++++++++++++++++
 12 files changed, 348 insertions(+)
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-041823.base.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044004.es.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044248.bn.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044927.es_GT.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-050141.en.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-054338.ar.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-055726.fr.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-061343.es_MX.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-062519.id.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-064146.th.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-070619.vi.iso.txt
 create mode 100644 tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-071821.zh_CN.iso.txt

diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-041823.base.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-041823.base.iso.txt
new file mode 100644
index 0000000..3429c89
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-041823.base.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-base
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 911817
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff DE0E3 909539
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044004.es.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044004.es.iso.txt
new file mode 100644
index 0000000..8e20b03
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044004.es.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-es
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 7165456
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 6D4D29 7163177
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044248.bn.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044248.bn.iso.txt
new file mode 100644
index 0000000..71da571
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044248.bn.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-bn
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 6328990
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 6089B7 6326711
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044927.es_GT.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044927.es_GT.iso.txt
new file mode 100644
index 0000000..1e8fd7e
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-044927.es_GT.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-es_GT
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 7635073
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 74779B 7632795
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-050141.en.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-050141.en.iso.txt
new file mode 100644
index 0000000..42e6575
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-050141.en.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-en
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 7823573
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 7757EF 7821295
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-054338.ar.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-054338.ar.iso.txt
new file mode 100644
index 0000000..33858c7
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-054338.ar.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-ar
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 4504772
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 44B3DD 4502493
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-055726.fr.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-055726.fr.iso.txt
new file mode 100644
index 0000000..7dd72f8
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-055726.fr.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-fr
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 4797252
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 492A5D 4794973
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-061343.es_MX.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-061343.es_MX.iso.txt
new file mode 100644
index 0000000..6ec4745
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-061343.es_MX.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-es_MX
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 7177164
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 6D7AE5 7174885
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-062519.id.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-062519.id.iso.txt
new file mode 100644
index 0000000..b95f166
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-062519.id.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-id
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 8237980
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 7DAAB5 8235701
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-064146.th.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-064146.th.iso.txt
new file mode 100644
index 0000000..0da96ec
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-064146.th.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-th
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 3841359
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 3A9468 3839080
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-070619.vi.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-070619.vi.iso.txt
new file mode 100644
index 0000000..a593573
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-070619.vi.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-vi
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 4064929
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 3DFDBB 4062651
diff --git a/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-071821.zh_CN.iso.txt b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-071821.zh_CN.iso.txt
new file mode 100644
index 0000000..ac7914f
--- /dev/null
+++ b/tests/isodata/eos/eos-3-4/eos-eos3.4-amd64-amd64.180515-071821.zh_CN.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: 
+Volume id: Endless-OS-3-4-0-zh_CN
+Volume set id: 
+Publisher id: ENDLESS COMPUTERS
+Data preparer id: XORRISO-1.4.6 2016.09.16.133001, LIBISOBURN-1.4.6, LIBISOFS-1.4.6, LIBBURN-1.4.6
+Application id: 
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 3310778
+El Torito VD version 1 found, boot catalog is in sector 64
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID ''
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 327BD4 3308500
-- 
2.17.0



From cfergeau at redhat.com  Wed May 23 09:02:56 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Wed, 23 May 2018 11:02:56 +0200
Subject: [Libosinfo] [PATCH] endlessos: Add Endless OS 3.4
In-Reply-To: <20180522151427.26547-1-feborges@redhat.com>
References: <20180522151427.26547-1-feborges@redhat.com>
Message-ID: <20180523090256.GI28727@natto.ory.fergeau.eu>

Hey,

On Tue, May 22, 2018 at 05:14:27PM +0200, Felipe Borges wrote:
> Signed-off-by: Felipe Borges <feborges at redhat.com>
> ---
>  data/os/endlessos.com/eos-3.4.xml.in | 199 +++++++++++++++++++++++++++
>  1 file changed, 199 insertions(+)
>  create mode 100644 data/os/endlessos.com/eos-3.4.xml.in
> 
> diff --git a/data/os/endlessos.com/eos-3.4.xml.in b/data/os/endlessos.com/eos-3.4.xml.in
> new file mode 100644
> index 0000000..d06b328
> --- /dev/null
> +++ b/data/os/endlessos.com/eos-3.4.xml.in
> @@ -0,0 +1,199 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <os id="http://endlessos.com/eos/3.4">
> +    <short-id>eos3.4</short-id>
> +    <_name>Endless OS 3.4</_name>
> +    <version>3.4</version>
> +    <_vendor>Endless Mobile, Inc</_vendor>
> +    <family>linux</family>
> +    <distro>eos</distro>
> +
> +    <release-date>2018-05-15</release-date>
> +
> +    <variant id="basic">
> +      <_name>Endless OS Basic</_name>
> +    </variant>
> +    <variant id="ar">
> +      <_name>Endless OS Arabic</_name>
> +    </variant>
> +    <variant id="bn">
> +      <_name>Endless OS Bengali</_name>
> +    </variant>
> +    <variant id="en">
> +      <_name>Endless OS English</_name>
> +    </variant>
> +    <variant id="es">
> +      <_name>Endless OS Spanish</_name>
> +    </variant>
> +    <variant id="es_GT">
> +      <_name>Endless OS Spanish (Guatemala)</_name>
> +    </variant>
> +    <variant id="es_MX">
> +      <_name>Endless OS Spanish (Mexico)</_name>
> +    </variant>
> +    <variant id="fr">
> +      <_name>Endless OS French</_name>
> +    </variant>
> +    <variant id="id">
> +      <_name>Endless OS Indonesian</_name>
> +    </variant>
> +    <variant id="pt_BR">
> +      <_name>Endless OS Portuguese (Brazil)</_name>
> +    </variant>
> +    <variant id="th">
> +      <_name>Endless OS Thai</_name>
> +    </variant>
> +    <variant id="vi">
> +      <_name>Endless OS Vietnamese</_name>
> +    </variant>
> +    <variant id="zh_CN">
> +      <_name>Endless OS Chinese (China)</_name>
> +    </variant>
> +
> +    <!-- Basic -->
> +    <media arch="x86_64" live="true">
> +      <variant id="basic"/>
> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/base/eos-eos3.4-amd64-amd64.180515-041823.base.iso</url>
> +      <iso>
> +        <volume-id>Endless-OS-3-4-0-base</volume-id>
> +        <volume-size>1867401216</volume-size>
> +      </iso>
> +    </media>
> +
> +    <!-- Arabic -->
> +    <media arch="x86_64" live="true">
> +      <variant id="ar"/>
> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/ar/eos-eos3.4-amd64-amd64.180515-054338.ar.iso</url>
> +      <iso>
> +        <volume-id>Endless-OS-3-4-0-ar</volume-id>
> +        <volume-size>9225773056</volume-size>

libosinfo has the concept of "language-map" in order to map some
language code in the volume id to some locale identifier, see the
data/os/microsoft.com/win-7.xml.in and
data/datamap/microsoft.com/win-7-l10n-language.xml.in for example,
imo it would be more appropriate to use that here rather than multiple
variants. I'm not sure there is a test case for this feature though, nor
that it has been tested recently, so if this does not work as expected,
this might be a preexisting bug in libosinfo code.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180523/6ae49e29/attachment.sig>

From felipe10borges at gmail.com  Wed May 23 09:26:31 2018
From: felipe10borges at gmail.com (Felipe Borges)
Date: Wed, 23 May 2018 11:26:31 +0200
Subject: [Libosinfo] [PATCH] endlessos: Add Endless OS 3.4
In-Reply-To: <20180523090256.GI28727@natto.ory.fergeau.eu>
References: <20180522151427.26547-1-feborges@redhat.com>
	<20180523090256.GI28727@natto.ory.fergeau.eu>
Message-ID: <CAM8h4FNww=CyGpAH8w6YOFS50z3Ehu_cQr3tFiAiWyDF=bLDrw@mail.gmail.com>

Hi!

On Wed, May 23, 2018 at 11:02 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> Hey,
>
> On Tue, May 22, 2018 at 05:14:27PM +0200, Felipe Borges wrote:
>> Signed-off-by: Felipe Borges <feborges at redhat.com>
>> ---
>>  data/os/endlessos.com/eos-3.4.xml.in | 199 +++++++++++++++++++++++++++
>>  1 file changed, 199 insertions(+)
>>  create mode 100644 data/os/endlessos.com/eos-3.4.xml.in
>>
>> diff --git a/data/os/endlessos.com/eos-3.4.xml.in b/data/os/endlessos.com/eos-3.4.xml.in
>> new file mode 100644
>> index 0000000..d06b328
>> --- /dev/null
>> +++ b/data/os/endlessos.com/eos-3.4.xml.in
>> @@ -0,0 +1,199 @@
>> +<libosinfo version="0.0.1">
>> +<!-- Licensed under the GNU General Public License version 2 or later.
>> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
>> +  <os id="http://endlessos.com/eos/3.4">
>> +    <short-id>eos3.4</short-id>
>> +    <_name>Endless OS 3.4</_name>
>> +    <version>3.4</version>
>> +    <_vendor>Endless Mobile, Inc</_vendor>
>> +    <family>linux</family>
>> +    <distro>eos</distro>
>> +
>> +    <release-date>2018-05-15</release-date>
>> +
>> +    <variant id="basic">
>> +      <_name>Endless OS Basic</_name>
>> +    </variant>
>> +    <variant id="ar">
>> +      <_name>Endless OS Arabic</_name>
>> +    </variant>
>> +    <variant id="bn">
>> +      <_name>Endless OS Bengali</_name>
>> +    </variant>
>> +    <variant id="en">
>> +      <_name>Endless OS English</_name>
>> +    </variant>
>> +    <variant id="es">
>> +      <_name>Endless OS Spanish</_name>
>> +    </variant>
>> +    <variant id="es_GT">
>> +      <_name>Endless OS Spanish (Guatemala)</_name>
>> +    </variant>
>> +    <variant id="es_MX">
>> +      <_name>Endless OS Spanish (Mexico)</_name>
>> +    </variant>
>> +    <variant id="fr">
>> +      <_name>Endless OS French</_name>
>> +    </variant>
>> +    <variant id="id">
>> +      <_name>Endless OS Indonesian</_name>
>> +    </variant>
>> +    <variant id="pt_BR">
>> +      <_name>Endless OS Portuguese (Brazil)</_name>
>> +    </variant>
>> +    <variant id="th">
>> +      <_name>Endless OS Thai</_name>
>> +    </variant>
>> +    <variant id="vi">
>> +      <_name>Endless OS Vietnamese</_name>
>> +    </variant>
>> +    <variant id="zh_CN">
>> +      <_name>Endless OS Chinese (China)</_name>
>> +    </variant>
>> +
>> +    <!-- Basic -->
>> +    <media arch="x86_64" live="true">
>> +      <variant id="basic"/>
>> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/base/eos-eos3.4-amd64-amd64.180515-041823.base.iso</url>
>> +      <iso>
>> +        <volume-id>Endless-OS-3-4-0-base</volume-id>
>> +        <volume-size>1867401216</volume-size>
>> +      </iso>
>> +    </media>
>> +
>> +    <!-- Arabic -->
>> +    <media arch="x86_64" live="true">
>> +      <variant id="ar"/>
>> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/ar/eos-eos3.4-amd64-amd64.180515-054338.ar.iso</url>
>> +      <iso>
>> +        <volume-id>Endless-OS-3-4-0-ar</volume-id>
>> +        <volume-size>9225773056</volume-size>
>
> libosinfo has the concept of "language-map" in order to map some
> language code in the volume id to some locale identifier, see the
> data/os/microsoft.com/win-7.xml.in and
> data/datamap/microsoft.com/win-7-l10n-language.xml.in for example,
> imo it would be more appropriate to use that here rather than multiple
> variants.

The reasoning behind the use of multiple variants is that Endless
ships different content in each image. The Spanish, Mexican,
Guatemalan "variants" have different content in it.

What do you think?

> I'm not sure there is a test case for this feature though, nor
> that it has been tested recently, so if this does not work as expected,
> this might be a preexisting bug in libosinfo code.
>
> Christophe



From cfergeau at redhat.com  Wed May 23 12:35:13 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Wed, 23 May 2018 14:35:13 +0200
Subject: [Libosinfo] [PATCH] endlessos: Add Endless OS 3.4
In-Reply-To: <CAM8h4FNww=CyGpAH8w6YOFS50z3Ehu_cQr3tFiAiWyDF=bLDrw@mail.gmail.com>
References: <20180522151427.26547-1-feborges@redhat.com>
	<20180523090256.GI28727@natto.ory.fergeau.eu>
	<CAM8h4FNww=CyGpAH8w6YOFS50z3Ehu_cQr3tFiAiWyDF=bLDrw@mail.gmail.com>
Message-ID: <20180523123513.GK28727@natto.ory.fergeau.eu>

On Wed, May 23, 2018 at 11:26:31AM +0200, Felipe Borges wrote:
> Hi!
> 
> On Wed, May 23, 2018 at 11:02 AM, Christophe Fergeau
> <cfergeau at redhat.com> wrote:
> > Hey,
> >
> > On Tue, May 22, 2018 at 05:14:27PM +0200, Felipe Borges wrote:
> >> Signed-off-by: Felipe Borges <feborges at redhat.com>
> >> ---
> >>  data/os/endlessos.com/eos-3.4.xml.in | 199 +++++++++++++++++++++++++++
> >>  1 file changed, 199 insertions(+)
> >>  create mode 100644 data/os/endlessos.com/eos-3.4.xml.in
> >>
> >> diff --git a/data/os/endlessos.com/eos-3.4.xml.in b/data/os/endlessos.com/eos-3.4.xml.in
> >> new file mode 100644
> >> index 0000000..d06b328
> >> --- /dev/null
> >> +++ b/data/os/endlessos.com/eos-3.4.xml.in
> >> @@ -0,0 +1,199 @@
> >> +<libosinfo version="0.0.1">
> >> +<!-- Licensed under the GNU General Public License version 2 or later.
> >> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> >> +  <os id="http://endlessos.com/eos/3.4">
> >> +    <short-id>eos3.4</short-id>
> >> +    <_name>Endless OS 3.4</_name>
> >> +    <version>3.4</version>
> >> +    <_vendor>Endless Mobile, Inc</_vendor>
> >> +    <family>linux</family>
> >> +    <distro>eos</distro>
> >> +
> >> +    <release-date>2018-05-15</release-date>
> >> +
> >> +    <variant id="basic">
> >> +      <_name>Endless OS Basic</_name>
> >> +    </variant>
> >> +    <variant id="ar">
> >> +      <_name>Endless OS Arabic</_name>
> >> +    </variant>
> >> +    <variant id="bn">
> >> +      <_name>Endless OS Bengali</_name>
> >> +    </variant>
> >> +    <variant id="en">
> >> +      <_name>Endless OS English</_name>
> >> +    </variant>
> >> +    <variant id="es">
> >> +      <_name>Endless OS Spanish</_name>
> >> +    </variant>
> >> +    <variant id="es_GT">
> >> +      <_name>Endless OS Spanish (Guatemala)</_name>
> >> +    </variant>
> >> +    <variant id="es_MX">
> >> +      <_name>Endless OS Spanish (Mexico)</_name>
> >> +    </variant>
> >> +    <variant id="fr">
> >> +      <_name>Endless OS French</_name>
> >> +    </variant>
> >> +    <variant id="id">
> >> +      <_name>Endless OS Indonesian</_name>
> >> +    </variant>
> >> +    <variant id="pt_BR">
> >> +      <_name>Endless OS Portuguese (Brazil)</_name>
> >> +    </variant>
> >> +    <variant id="th">
> >> +      <_name>Endless OS Thai</_name>
> >> +    </variant>
> >> +    <variant id="vi">
> >> +      <_name>Endless OS Vietnamese</_name>
> >> +    </variant>
> >> +    <variant id="zh_CN">
> >> +      <_name>Endless OS Chinese (China)</_name>
> >> +    </variant>
> >> +
> >> +    <!-- Basic -->
> >> +    <media arch="x86_64" live="true">
> >> +      <variant id="basic"/>
> >> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/base/eos-eos3.4-amd64-amd64.180515-041823.base.iso</url>
> >> +      <iso>
> >> +        <volume-id>Endless-OS-3-4-0-base</volume-id>
> >> +        <volume-size>1867401216</volume-size>
> >> +      </iso>
> >> +    </media>
> >> +
> >> +    <!-- Arabic -->
> >> +    <media arch="x86_64" live="true">
> >> +      <variant id="ar"/>
> >> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/ar/eos-eos3.4-amd64-amd64.180515-054338.ar.iso</url>
> >> +      <iso>
> >> +        <volume-id>Endless-OS-3-4-0-ar</volume-id>
> >> +        <volume-size>9225773056</volume-size>
> >
> > libosinfo has the concept of "language-map" in order to map some
> > language code in the volume id to some locale identifier, see the
> > data/os/microsoft.com/win-7.xml.in and
> > data/datamap/microsoft.com/win-7-l10n-language.xml.in for example,
> > imo it would be more appropriate to use that here rather than multiple
> > variants.
> 
> The reasoning behind the use of multiple variants is that Endless
> ships different content in each image. The Spanish, Mexican,
> Guatemalan "variants" have different content in it.
> 
> What do you think?

Are there ISOs with the same content, and whose only difference is their
language? Or is each language also getting some variations in the
available applications/...? This reasoning belongs in the commit log btw
;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180523/33fb229a/attachment.sig>

From fabiano at fidencio.org  Sat May 26 20:29:37 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:37 +0200
Subject: [Libosinfo] [libosinfo][PATCH] opensuse: Add Leap 15.0 isodata
Message-ID: <20180526202946.7606-1-fabiano@fidencio.org>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 .../openSUSE-Leap-15.0-DVD-x86_64.iso.txt          | 29 ++++++++++++++++++++++
 .../openSUSE-Leap-15.0-NET-x86_64.iso.txt          | 29 ++++++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
 create mode 100644 tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt

diff --git a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
new file mode 100644
index 0000000..e89a0de
--- /dev/null
+++ b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: openSUSE-Leap-15.0-DVD-x86_64267
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: openSUSE-Leap-15.0-DVD-x86_64-Build267.2-Media
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 1912564
+El Torito VD version 1 found, boot catalog is in sector 20
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID 'SUSE LINUX GmbH'
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff 145C 5212
diff --git a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
new file mode 100644
index 0000000..d6e6619
--- /dev/null
+++ b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
@@ -0,0 +1,29 @@
+CD-ROM is in ISO 9660 format
+System id: LINUX
+Volume id: openSUSE-Leap-15.0-NET-x86_64267
+Volume set id: 
+Publisher id: SUSE LINUX GmbH
+Data preparer id: KIWI - http://opensuse.github.com/kiwi
+Application id: openSUSE-Leap-15.0-NET-x86_64-Build267.2-Media
+Copyright File id: 
+Abstract File id: 
+Bibliographic File id: 
+Volume set size is: 1
+Volume set sequence number is: 1
+Logical block size is: 2048
+Volume size is: 60205
+El Torito VD version 1 found, boot catalog is in sector 20
+Joliet with UCS level 3 found
+Rock Ridge signatures version 1 found
+Eltorito validation header:
+    Hid 1
+    Arch 0 (x86)
+    ID 'SUSE LINUX GmbH'
+    Key 55 AA
+    Eltorito defaultboot header:
+        Bootid 88 (bootable)
+        Boot media 0 (No Emulation Boot)
+        Load segment 0
+        Sys type 0
+        Nsect 4
+        Bootoff FC8 4040
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:38 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:38 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
	install-script: Skip second stage
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-2-fabiano@fidencio.org>

As we don't do anything in the second stage, we can just skip it
entirely without any issues.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
index 6554eb6..537c266 100644
--- a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
+++ b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
@@ -144,6 +144,7 @@
               <ask-list config:type="list"/>
               <mode>
                 <confirm config:type="boolean">false</confirm>
+                <second_stage config:type="boolean">false</second_stage>
                 <final_reboot config:type="boolean">true</final_reboot>
               </mode>
               <proposals config:type="list"/>
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:40 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:40 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse: Add support for Leap 15.0
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-4-fabiano@fidencio.org>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/opensuse.org/opensuse-15.0.xml.in | 80 +++++++++++++++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644 data/os/opensuse.org/opensuse-15.0.xml.in

diff --git a/data/os/opensuse.org/opensuse-15.0.xml.in b/data/os/opensuse.org/opensuse-15.0.xml.in
new file mode 100644
index 0000000..1ab497e
--- /dev/null
+++ b/data/os/opensuse.org/opensuse-15.0.xml.in
@@ -0,0 +1,80 @@
+<libosinfo version="0.0.1">
+<!-- Licensed under the GNU General Public License version 2 or later.
+     See http://www.gnu.org/licenses/ for a copy of the license text -->
+  <os id="http://opensuse.org/opensuse/15.0">
+    <short-id>opensuse15.0</short-id>
+    <_name>openSUSE Leap 15.0</_name>
+    <version>15.0</version>
+    <_vendor>openSUSE</_vendor>
+    <family>linux</family>
+    <distro>opensuse</distro>
+    <upgrades id="http://opensuse.org/opensuse/42.3"/>
+    <derives-from id="http://opensuse.org/opensuse/42.3"/>
+
+    <release-date>2018-05-25</release-date>
+
+    <variant id="dvd">
+      <_name>openSUSE Leap 15.0 (DVD Image)</_name>
+    </variant>
+    <variant id="network">
+      <_name>openSUSE Leap 15.0 (Network Image)</_name>
+    </variant>
+
+    <devices>
+      <device id="http://pcisig.com/pci/1af4/1041"/>
+      <device id="http://pcisig.com/pci/1af4/1042"/>
+      <device id="http://pcisig.com/pci/1af4/1043"/>
+      <device id="http://pcisig.com/pci/1af4/1044"/>
+      <device id="http://pcisig.com/pci/1af4/1045"/>
+      <device id="http://pcisig.com/pci/1af4/1048"/>
+      <device id="http://pcisig.com/pci/1af4/1049"/>
+      <device id="http://pcisig.com/pci/1af4/1052"/>
+      <device id="http://pcisig.com/pci/1af4/1050"/>
+    </devices>
+
+    <!-- DVD -->
+    <media arch="x86_64">
+      <variant id="dvd"/>
+      <url>http://download.opensuse.org/distribution/leap/15.0/iso/openSUSE-Leap-15.0-DVD-x86_64.iso</url>
+      <iso>
+        <volume-id>openSUSE-Leap-15.0-DVD-x86_64*</volume-id>
+        <system-id>LINUX</system-id>
+        <publisher-id>SUSE LINUX GmbH</publisher-id>
+      </iso>
+      <kernel>boot/x86_64/loader/linux</kernel>
+      <initrd>boot/x86_64/loader/initrd</initrd>
+    </media>
+
+    <!-- Network -->
+    <media arch="x86_64">
+      <variant id="network"/>
+      <url>http://download.opensuse.org/distribution/leap/15.0/iso/openSUSE-Leap-15.0-NET-x86_64.iso</url>
+      <iso>
+        <volume-id>openSUSE-Leap-15.0-NET-x86_64*</volume-id>
+        <system-id>LINUX</system-id>
+        <publisher-id>SUSE LINUX GmbH</publisher-id>
+      </iso>
+      <kernel>boot/x86_64/loader/linux</kernel>
+      <initrd>boot/x86_64/loader/initrd</initrd>
+    </media>
+
+    <installer>
+      <script id='http://opensuse.org/opensuse/autoyast/jeos'/>
+      <script id='http://opensuse.org/opensuse/autoyast/desktop'/>
+    </installer>
+
+    <resources arch="all">
+      <minimum>
+        <cpu>1600000000</cpu>
+        <n-cpus>1</n-cpus>
+        <ram>1073741824</ram>
+        <storage>3221225472</storage>
+      </minimum>
+      <recommended>
+        <cpu>2400000000</cpu>
+        <ram>2147483648</ram>
+        <storage>17179869184</storage>
+      </recommended>
+    </resources>
+  </os>
+</libosinfo>
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:43 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:43 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the
	volume-id regex
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-7-fabiano@fidencio.org>

The regex to match unknown openSUSE prereleases is becoming
bigger and harder to read.

Basically, what it's doing is:

(15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])
---------   -----  ----------------   ---- -------------
    |         |         |                |       |
    v         v         v                |       v
  15.1+      16     20, 30, 50 - 90      v     43.0+
                                  .0, .1, ..., .9

I'm desconsidering both the 13.x series or older and 42.x series as
those are not going to have new releases anymore.

Also, (DVD|NET|Kubic) was introduced as this is the naming chosen for
DVD or NET installation or whether it's a Kubic  DVD installation.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/opensuse.org/opensuse-unknown.xml.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
index 06ae67a..6a8a3b2 100644
--- a/data/os/opensuse.org/opensuse-unknown.xml.in
+++ b/data/os/opensuse.org/opensuse-unknown.xml.in
@@ -14,7 +14,7 @@
 
     <media arch="x86_64">
       <iso>
-        <volume-id>openSUSE-Leap-([1-9][4-9]\.[0-9]+|13\.[3-9])-DVD-x86_64</volume-id>
+        <volume-id>openSUSE-Leap-(15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])-(DVD|NET|Kubic)-x86_64*</volume-id>
         <system-id>LINUX</system-id>
         <publisher-id>SUSE LINUX GmbH</publisher-id>
       </iso>
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:39 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:39 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
	install-script: Adjust the patterns to Leap 15.0
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-3-fabiano@fidencio.org>

Two patterns, devel_basis and yast2_install_wf, have been removed from
autoyast for the Leap 15.0.

Let's just install them for Leap 42.2 and 42.3

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
index 537c266..b0227c9 100644
--- a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
+++ b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
@@ -263,7 +263,6 @@ zypper ar -f <xsl:call-template name="repo-update-oss"/> repo-update-oss
                 <pattern>apparmor</pattern>
                 <pattern>apparmor_opt</pattern>
                 <pattern>console</pattern>
-                <pattern>devel_basis</pattern>
                 <pattern>enhanced_base</pattern>
                 <pattern>enhanced_base_opt</pattern>
                 <pattern>fonts</pattern>
@@ -272,7 +271,11 @@ zypper ar -f <xsl:call-template name="repo-update-oss"/> repo-update-oss
                 <pattern>print_server</pattern>
                 <pattern>sw_management</pattern>
                 <pattern>yast2_basis</pattern>
-                <pattern>yast2_install_wf</pattern>
+                <!-- Those patterns are only present in Leap 42.2 and 42.3 -->
+                <xsl:if test="contains(os/version, '42')">
+                  <pattern>devel_basis</pattern>
+                  <pattern>yast2_install_wf</pattern>
+                </xsl:if>
               </patterns>
             </software>
             <sysconfig config:type="list">
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:41 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:41 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust
	upgrades/derives-from for leap 15.0
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-5-fabiano@fidencio.org>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/opensuse.org/opensuse-unknown.xml.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
index 195ea4a..1292372 100644
--- a/data/os/opensuse.org/opensuse-unknown.xml.in
+++ b/data/os/opensuse.org/opensuse-unknown.xml.in
@@ -8,8 +8,8 @@
     <_vendor>openSUSE</_vendor>
     <family>linux</family>
     <distro>opensuse</distro>
-    <upgrades id="http://opensuse.org/opensuse/42.2"/>
-    <derives-from id="http://opensuse.org/opensuse/42.2"/>
+    <upgrades id="http://opensuse.org/opensuse/15.0"/>
+    <derives-from id="http://opensuse.org/opensuse/15.0"/>
     <release-status>prerelease</release-status>
 
     <media arch="i686">
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:44 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:44 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Increase
	recommended disk size
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-8-fabiano@fidencio.org>

Let's keep Unknown's recommended disk size the same amount we use for
Tumbleweed.
By doing this we ensure that users will be able to have a smooth
experience even with alpha and beta versions of the ISO.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/opensuse.org/opensuse-unknown.xml.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
index 6a8a3b2..cf0ff32 100644
--- a/data/os/opensuse.org/opensuse-unknown.xml.in
+++ b/data/os/opensuse.org/opensuse-unknown.xml.in
@@ -33,7 +33,7 @@
       <recommended>
         <cpu>2400000000</cpu>
         <ram>2147483648</ram>
-        <storage>5368709120</storage>
+        <storage>21474836480</storage>
       </recommended>
     </resources>
   </os>
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:42 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:42 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Drop i686 medias
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-6-fabiano@fidencio.org>

Leap is only releasing x86_64 images

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/opensuse.org/opensuse-unknown.xml.in | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
index 1292372..06ae67a 100644
--- a/data/os/opensuse.org/opensuse-unknown.xml.in
+++ b/data/os/opensuse.org/opensuse-unknown.xml.in
@@ -12,15 +12,6 @@
     <derives-from id="http://opensuse.org/opensuse/15.0"/>
     <release-status>prerelease</release-status>
 
-    <media arch="i686">
-      <iso>
-        <volume-id>openSUSE-Leap-([1-9][4-9]\.[0-9]+|13\.[3-9])-DVD</volume-id>
-        <system-id>LINUX</system-id>
-        <publisher-id>SUSE LINUX GmbH</publisher-id>
-      </iso>
-      <kernel>boot/i386/loader/linux</kernel>
-      <initrd>boot/i386/loader/initrd</initrd>
-    </media>
     <media arch="x86_64">
       <iso>
         <volume-id>openSUSE-Leap-([1-9][4-9]\.[0-9]+|13\.[3-9])-DVD-x86_64</volume-id>
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:45 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:45 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Enable express
	installation
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-9-fabiano@fidencio.org>

By doing this we give the users of alpha and beta a chance to try
express installation on their yet to be released distro.

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/opensuse.org/opensuse-unknown.xml.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
index cf0ff32..bdb1d20 100644
--- a/data/os/opensuse.org/opensuse-unknown.xml.in
+++ b/data/os/opensuse.org/opensuse-unknown.xml.in
@@ -22,6 +22,11 @@
       <initrd>boot/x86_64/loader/initrd</initrd>
     </media>
 
+    <installer>
+      <script id='http://opensuse.org/opensuse/autoyast/jeos'/>
+      <script id='http://opensuse.org/opensuse/autoyast/desktop'/>
+    </installer>
+
     <resources arch="all">
     <!-- http://en.opensuse.org/Hardware_requirements -->
       <minimum>
-- 
2.14.3



From fabiano at fidencio.org  Sat May 26 20:29:46 2018
From: fabiano at fidencio.org (=?UTF-8?q?Fabiano=20Fid=C3=AAncio?=)
Date: Sat, 26 May 2018 22:29:46 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] fedora-unknown: Fix
	derives-from/upgrades info
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180526202946.7606-10-fabiano@fidencio.org>

Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
---
 data/os/fedoraproject.org/fedora-unknown.xml.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/os/fedoraproject.org/fedora-unknown.xml.in b/data/os/fedoraproject.org/fedora-unknown.xml.in
index 694a30b..c2863d3 100644
--- a/data/os/fedoraproject.org/fedora-unknown.xml.in
+++ b/data/os/fedoraproject.org/fedora-unknown.xml.in
@@ -8,8 +8,8 @@
     <_vendor>Fedora Project</_vendor>
     <family>linux</family>
     <distro>fedora</distro>
-    <upgrades id="http://fedoraproject.org/fedora/27"/>
-    <derives-from id="http://fedoraproject.org/fedora/27"/>
+    <upgrades id="http://fedoraproject.org/fedora/28"/>
+    <derives-from id="http://fedoraproject.org/fedora/28"/>
     <release-status>prerelease</release-status>
 
     <media arch="x86_64">
-- 
2.14.3



From cfergeau at redhat.com  Thu May 31 08:54:34 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 10:54:34 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the
 volume-id regex
In-Reply-To: <20180526202946.7606-7-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-7-fabiano@fidencio.org>
Message-ID: <20180531085434.GA4148@natto.ory.fergeau.eu>

On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fid?ncio wrote:
> The regex to match unknown openSUSE prereleases is becoming
> bigger and harder to read.
> 
> Basically, what it's doing is:
> 
> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])
> ---------   -----  ----------------   ---- -------------
>     |         |         |                |       |
>     v         v         v                |       v
>   15.1+      16     20, 30, 50 - 90      v     43.0+
>                                   .0, .1, ..., .9
> 
> I'm desconsidering both the 13.x series or older and 42.x series as
> those are not going to have new releases anymore.

"desconsidering"? Dropping? Note that
https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the
door on another 42.x release "There are currently no plans to release an
openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but
that's close enough.
Are they really going to release 43.x in parallel to/after 15.x?

Christophe

> 
> Also, (DVD|NET|Kubic) was introduced as this is the naming chosen for
> DVD or NET installation or whether it's a Kubic  DVD installation.
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/os/opensuse.org/opensuse-unknown.xml.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
> index 06ae67a..6a8a3b2 100644
> --- a/data/os/opensuse.org/opensuse-unknown.xml.in
> +++ b/data/os/opensuse.org/opensuse-unknown.xml.in
> @@ -14,7 +14,7 @@
>  
>      <media arch="x86_64">
>        <iso>
> -        <volume-id>openSUSE-Leap-([1-9][4-9]\.[0-9]+|13\.[3-9])-DVD-x86_64</volume-id>
> +        <volume-id>openSUSE-Leap-(15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])-(DVD|NET|Kubic)-x86_64*</volume-id>
>          <system-id>LINUX</system-id>
>          <publisher-id>SUSE LINUX GmbH</publisher-id>
>        </iso>
> -- 
> 2.14.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/147ed776/attachment.sig>

From cfergeau at redhat.com  Thu May 31 09:11:14 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 11:11:14 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
 install-script: Skip second stage
In-Reply-To: <20180526202946.7606-2-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-2-fabiano@fidencio.org>
Message-ID: <20180531091114.GB4148@natto.ory.fergeau.eu>

On Sat, May 26, 2018 at 10:29:38PM +0200, Fabiano Fid?ncio wrote:
> As we don't do anything in the second stage, we can just skip it
> entirely without any issues.
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
> index 6554eb6..537c266 100644
> --- a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
> +++ b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
> @@ -144,6 +144,7 @@
>                <ask-list config:type="list"/>
>                <mode>
>                  <confirm config:type="boolean">false</confirm>
> +                <second_stage config:type="boolean">false</second_stage>

Are these 'config:type' parameters something which is exposed to the
library user, right? Or Are they something purley internal?
If they are public, what happens in libosinfo if we try to set a
non-existent parameter? In other word, should we consider this an
API/ABI break, or are we fine with dropping it?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/180c0c46/attachment.sig>

From cfergeau at redhat.com  Thu May 31 09:11:38 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 11:11:38 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust
 upgrades/derives-from for leap 15.0
In-Reply-To: <20180526202946.7606-5-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-5-fabiano@fidencio.org>
Message-ID: <20180531091138.GC4148@natto.ory.fergeau.eu>

On Sat, May 26, 2018 at 10:29:41PM +0200, Fabiano Fid?ncio wrote:
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  data/os/opensuse.org/opensuse-unknown.xml.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
> index 195ea4a..1292372 100644
> --- a/data/os/opensuse.org/opensuse-unknown.xml.in
> +++ b/data/os/opensuse.org/opensuse-unknown.xml.in
> @@ -8,8 +8,8 @@
>      <_vendor>openSUSE</_vendor>
>      <family>linux</family>
>      <distro>opensuse</distro>
> -    <upgrades id="http://opensuse.org/opensuse/42.2"/>
> -    <derives-from id="http://opensuse.org/opensuse/42.2"/>
> +    <upgrades id="http://opensuse.org/opensuse/15.0"/>
> +    <derives-from id="http://opensuse.org/opensuse/15.0"/>

Huhu, 15.0 being newer than 42.2 is odd ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/b08e33ee/attachment.sig>

From cfergeau at redhat.com  Thu May 31 09:16:36 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 11:16:36 +0200
Subject: [Libosinfo] [libosinfo][PATCH] opensuse: Add Leap 15.0 isodata
In-Reply-To: <20180526202946.7606-1-fabiano@fidencio.org>
References: <20180526202946.7606-1-fabiano@fidencio.org>
Message-ID: <20180531091636.GD4148@natto.ory.fergeau.eu>

Hey,

Commented on some of the patches, but for the series,

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Sat, May 26, 2018 at 10:29:37PM +0200, Fabiano Fid?ncio wrote:
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  .../openSUSE-Leap-15.0-DVD-x86_64.iso.txt          | 29 ++++++++++++++++++++++
>  .../openSUSE-Leap-15.0-NET-x86_64.iso.txt          | 29 ++++++++++++++++++++++
>  2 files changed, 58 insertions(+)
>  create mode 100644 tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
>  create mode 100644 tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
> 
> diff --git a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
> new file mode 100644
> index 0000000..e89a0de
> --- /dev/null
> +++ b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: openSUSE-Leap-15.0-DVD-x86_64267
> +Volume set id: 
> +Publisher id: SUSE LINUX GmbH
> +Data preparer id: KIWI - http://opensuse.github.com/kiwi
> +Application id: openSUSE-Leap-15.0-DVD-x86_64-Build267.2-Media
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 1912564
> +El Torito VD version 1 found, boot catalog is in sector 20
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID 'SUSE LINUX GmbH'
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff 145C 5212
> diff --git a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
> new file mode 100644
> index 0000000..d6e6619
> --- /dev/null
> +++ b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
> @@ -0,0 +1,29 @@
> +CD-ROM is in ISO 9660 format
> +System id: LINUX
> +Volume id: openSUSE-Leap-15.0-NET-x86_64267
> +Volume set id: 
> +Publisher id: SUSE LINUX GmbH
> +Data preparer id: KIWI - http://opensuse.github.com/kiwi
> +Application id: openSUSE-Leap-15.0-NET-x86_64-Build267.2-Media
> +Copyright File id: 
> +Abstract File id: 
> +Bibliographic File id: 
> +Volume set size is: 1
> +Volume set sequence number is: 1
> +Logical block size is: 2048
> +Volume size is: 60205
> +El Torito VD version 1 found, boot catalog is in sector 20
> +Joliet with UCS level 3 found
> +Rock Ridge signatures version 1 found
> +Eltorito validation header:
> +    Hid 1
> +    Arch 0 (x86)
> +    ID 'SUSE LINUX GmbH'
> +    Key 55 AA
> +    Eltorito defaultboot header:
> +        Bootid 88 (bootable)
> +        Boot media 0 (No Emulation Boot)
> +        Load segment 0
> +        Sys type 0
> +        Nsect 4
> +        Bootoff FC8 4040
> -- 
> 2.14.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/5b4d06f5/attachment.sig>

From fabiano at fidencio.org  Thu May 31 09:57:51 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 31 May 2018 11:57:51 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the
 volume-id regex
In-Reply-To: <20180531085434.GA4148@natto.ory.fergeau.eu>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-7-fabiano@fidencio.org>
	<20180531085434.GA4148@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9+5HFT8yQr-WDR51g16HZ6YiiMB4oxZqn4DwBmWS0WrJQ@mail.gmail.com>

On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fid?ncio wrote:
>> The regex to match unknown openSUSE prereleases is becoming
>> bigger and harder to read.
>>
>> Basically, what it's doing is:
>>
>> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])
>> ---------   -----  ----------------   ---- -------------
>>     |         |         |                |       |
>>     v         v         v                |       v
>>   15.1+      16     20, 30, 50 - 90      v     43.0+
>>                                   .0, .1, ..., .9
>>
>> I'm desconsidering both the 13.x series or older and 42.x series as
>> those are not going to have new releases anymore.
>
> "desconsidering"? Dropping?

I'll change it to "Dropping" before pushing.

> Note that
> https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the
> door on another 42.x release "There are currently no plans to release an
> openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but
> that's close enough.
> Are they really going to release 43.x in parallel to/after 15.x?

No, they have no intention to release 43.x. I've talked to Richard
Brown about this during openSUSE conference last weekend and
explanation he gave me is that they're moving back to a number that
would match SLES.
The whole 42.x series was in order to totally distinguish between the
old base they had with the new shiny system that Leap was supposed to
be.

So, they're now following 15.x ... if at some point SLES will have a
16.x opensuse 16.x will come to the playground as well.

>
> Christophe
>
>>
>> Also, (DVD|NET|Kubic) was introduced as this is the naming chosen for
>> DVD or NET installation or whether it's a Kubic  DVD installation.
>>
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  data/os/opensuse.org/opensuse-unknown.xml.in | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
>> index 06ae67a..6a8a3b2 100644
>> --- a/data/os/opensuse.org/opensuse-unknown.xml.in
>> +++ b/data/os/opensuse.org/opensuse-unknown.xml.in
>> @@ -14,7 +14,7 @@
>>
>>      <media arch="x86_64">
>>        <iso>
>> -        <volume-id>openSUSE-Leap-([1-9][4-9]\.[0-9]+|13\.[3-9])-DVD-x86_64</volume-id>
>> +        <volume-id>openSUSE-Leap-(15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])-(DVD|NET|Kubic)-x86_64*</volume-id>
>>          <system-id>LINUX</system-id>
>>          <publisher-id>SUSE LINUX GmbH</publisher-id>
>>        </iso>
>> --
>> 2.14.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Thu May 31 10:00:22 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 31 May 2018 12:00:22 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
 install-script: Skip second stage
In-Reply-To: <20180531091114.GB4148@natto.ory.fergeau.eu>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-2-fabiano@fidencio.org>
	<20180531091114.GB4148@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9+x9fSuhAy5pHQ4hptJxA_C=zwnWaK+CNLwMT4ysyuYQA@mail.gmail.com>

On Thu, May 31, 2018 at 11:11 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Sat, May 26, 2018 at 10:29:38PM +0200, Fabiano Fid?ncio wrote:
>> As we don't do anything in the second stage, we can just skip it
>> entirely without any issues.
>>
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>> index 6554eb6..537c266 100644
>> --- a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>> +++ b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>> @@ -144,6 +144,7 @@
>>                <ask-list config:type="list"/>
>>                <mode>
>>                  <confirm config:type="boolean">false</confirm>
>> +                <second_stage config:type="boolean">false</second_stage>
>
> Are these 'config:type' parameters something which is exposed to the
> library user, right? Or Are they something purley internal?

Those are public. They're used for specialized scripts, they're still
supported we just never used it.
It's going to work without issues with the Leap series. For the older
ones, we don't even support express installation.

> If they are public, what happens in libosinfo if we try to set a
> non-existent parameter? In other word, should we consider this an
> API/ABI break, or are we fine with dropping it?

We're totally fine dropping it.
If we try to set a non-existent parameter (or pattern) autoyast is
smart enough to not break the installation because of that.

>
> Christophe



-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Thu May 31 10:00:43 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 31 May 2018 12:00:43 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust
 upgrades/derives-from for leap 15.0
In-Reply-To: <20180531091138.GC4148@natto.ory.fergeau.eu>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-5-fabiano@fidencio.org>
	<20180531091138.GC4148@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9K2zB-VKmB-ueE0046-A2DK+MBMCTNFucN_bMXYAQJfGw@mail.gmail.com>

On Thu, May 31, 2018 at 11:11 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Sat, May 26, 2018 at 10:29:41PM +0200, Fabiano Fid?ncio wrote:
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  data/os/opensuse.org/opensuse-unknown.xml.in | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in b/data/os/opensuse.org/opensuse-unknown.xml.in
>> index 195ea4a..1292372 100644
>> --- a/data/os/opensuse.org/opensuse-unknown.xml.in
>> +++ b/data/os/opensuse.org/opensuse-unknown.xml.in
>> @@ -8,8 +8,8 @@
>>      <_vendor>openSUSE</_vendor>
>>      <family>linux</family>
>>      <distro>opensuse</distro>
>> -    <upgrades id="http://opensuse.org/opensuse/42.2"/>
>> -    <derives-from id="http://opensuse.org/opensuse/42.2"/>
>> +    <upgrades id="http://opensuse.org/opensuse/15.0"/>
>> +    <derives-from id="http://opensuse.org/opensuse/15.0"/>
>
> Huhu, 15.0 being newer than 42.2 is odd ;)
>
> Christophe

Indeed :-)

-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Thu May 31 10:01:25 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 31 May 2018 12:01:25 +0200
Subject: [Libosinfo] [libosinfo][PATCH] opensuse: Add Leap 15.0 isodata
In-Reply-To: <20180531091636.GD4148@natto.ory.fergeau.eu>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180531091636.GD4148@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9J1B-GnS7VcMuu2dC5DXk87+OstfVcz-vPZ1xrbQ_aYKw@mail.gmail.com>

On Thu, May 31, 2018 at 11:16 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> Hey,
>
> Commented on some of the patches, but for the series,
>
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Thanks for the review, I'll address your comments, push the patches
and do a release later Today.

>
> On Sat, May 26, 2018 at 10:29:37PM +0200, Fabiano Fid?ncio wrote:
>> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
>> ---
>>  .../openSUSE-Leap-15.0-DVD-x86_64.iso.txt          | 29 ++++++++++++++++++++++
>>  .../openSUSE-Leap-15.0-NET-x86_64.iso.txt          | 29 ++++++++++++++++++++++
>>  2 files changed, 58 insertions(+)
>>  create mode 100644 tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
>>  create mode 100644 tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
>>
>> diff --git a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
>> new file mode 100644
>> index 0000000..e89a0de
>> --- /dev/null
>> +++ b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: openSUSE-Leap-15.0-DVD-x86_64267
>> +Volume set id:
>> +Publisher id: SUSE LINUX GmbH
>> +Data preparer id: KIWI - http://opensuse.github.com/kiwi
>> +Application id: openSUSE-Leap-15.0-DVD-x86_64-Build267.2-Media
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 1912564
>> +El Torito VD version 1 found, boot catalog is in sector 20
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID 'SUSE LINUX GmbH'
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff 145C 5212
>> diff --git a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
>> new file mode 100644
>> index 0000000..d6e6619
>> --- /dev/null
>> +++ b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt
>> @@ -0,0 +1,29 @@
>> +CD-ROM is in ISO 9660 format
>> +System id: LINUX
>> +Volume id: openSUSE-Leap-15.0-NET-x86_64267
>> +Volume set id:
>> +Publisher id: SUSE LINUX GmbH
>> +Data preparer id: KIWI - http://opensuse.github.com/kiwi
>> +Application id: openSUSE-Leap-15.0-NET-x86_64-Build267.2-Media
>> +Copyright File id:
>> +Abstract File id:
>> +Bibliographic File id:
>> +Volume set size is: 1
>> +Volume set sequence number is: 1
>> +Logical block size is: 2048
>> +Volume size is: 60205
>> +El Torito VD version 1 found, boot catalog is in sector 20
>> +Joliet with UCS level 3 found
>> +Rock Ridge signatures version 1 found
>> +Eltorito validation header:
>> +    Hid 1
>> +    Arch 0 (x86)
>> +    ID 'SUSE LINUX GmbH'
>> +    Key 55 AA
>> +    Eltorito defaultboot header:
>> +        Bootid 88 (bootable)
>> +        Boot media 0 (No Emulation Boot)
>> +        Load segment 0
>> +        Sys type 0
>> +        Nsect 4
>> +        Bootoff FC8 4040
>> --
>> 2.14.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fid?ncio



From cfergeau at redhat.com  Thu May 31 10:08:49 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 12:08:49 +0200
Subject: [Libosinfo] [libosinfo][PATCH v2] tests: Add test-os-resources
In-Reply-To: <20180504203409.20560-1-fidencio@redhat.com>
References: <20180504203409.20560-1-fidencio@redhat.com>
Message-ID: <20180531100849.GF4148@natto.ory.fergeau.eu>


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Fri, May 04, 2018 at 10:34:09PM +0200, Fabiano Fid?ncio wrote:
> From: Fabiano Fid?ncio <fabiano at fidencio.org>
> 
> test-os-resources has been written to avoid bug as having minimum
> resources greater than the recommended resources in osinfo-db.
> 
> This problem was exposed by RHEL/CentOS data files, which caused some
> really bad UI effect in clientes using those two attributes (as GNOME
> Boxes).
> 
> Signed-off-by: Fabiano Fid?ncio <fabiano at fidencio.org>
> ---
>  tests/Makefile.am         |   5 ++
>  tests/test-os-resources.c | 184 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 189 insertions(+)
>  create mode 100644 tests/test-os-resources.c
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 7566d3c..06f81bf 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -17,6 +17,7 @@ check_PROGRAMS = \
>  	test-loader \
>  	test-isodetect \
>  	test-install-script \
> +	test-os-resources \
>          $(NULL)
>  
>  if HAVE_CURL
> @@ -111,6 +112,10 @@ test_install_script_LDADD = $(COMMON_LDADD)
>  test_install_script_CFLAGS = $(COMMON_CFLAGS)
>  test_install_script_SOURCES = test-install-script.c
>  
> +test_os_resources_LDADD = $(COMMON_LDADD)
> +test_os_resources_CFLAGS = $(COMMON_CFLAGS)
> +test_os_resources_SOURCES = test-os-resources.c
> +
>  TESTS = $(check_PROGRAMS) \
>  	$(NULL)
>  
> diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c
> new file mode 100644
> index 0000000..f7a8039
> --- /dev/null
> +++ b/tests/test-os-resources.c
> @@ -0,0 +1,184 @@
> +/*
> + * Copyright (C) 2017 Fabiano Fid?ncio
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, write to the Free Software Foundation,
> + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> + *
> + * Authors:
> + *   Fabiano Fid?ncio <fabiano at fidencio.org>
> + */
> +
> +#include <config.h>
> +
> +#include <stdlib.h>
> +#include <osinfo/osinfo.h>
> +
> +
> +static void test_n_cpus(OsinfoResources *minimum, OsinfoResources *recommended)
> +{
> +    gint minimum_cpus, recommended_cpus;
> +
> +    minimum_cpus = osinfo_resources_get_n_cpus(minimum);
> +    recommended_cpus = osinfo_resources_get_n_cpus(recommended);
> +
> +    if (recommended_cpus >= 0 && minimum_cpus >= 0)
> +        g_assert_true(recommended_cpus >= minimum_cpus);
> +}
> +
> +
> +static void test_cpu(OsinfoResources *minimum, OsinfoResources *recommended)
> +{
> +    gint64 minimum_cpu, recommended_cpu;
> +
> +    minimum_cpu = osinfo_resources_get_cpu(minimum);
> +    recommended_cpu = osinfo_resources_get_cpu(recommended);
> +
> +    if (recommended_cpu >= 0 && minimum_cpu >= 0)
> +        g_assert_true(recommended_cpu >= minimum_cpu);
> +}
> +
> +
> +static void test_ram(OsinfoResources *minimum, OsinfoResources *recommended)
> +{
> +    gint64 minimum_ram, recommended_ram;
> +
> +    minimum_ram = osinfo_resources_get_ram(minimum);
> +    recommended_ram = osinfo_resources_get_ram(recommended);
> +
> +    if (recommended_ram >= 0 && minimum_ram >= 0)
> +        g_assert_true(recommended_ram >= minimum_ram);
> +}
> +
> +
> +static void test_storage(OsinfoResources *minimum, OsinfoResources *recommended)
> +{
> +    gint64 minimum_storage, recommended_storage;
> +
> +    minimum_storage = osinfo_resources_get_storage(minimum);
> +    recommended_storage = osinfo_resources_get_storage(recommended);
> +
> +    if (recommended_storage >= 0 && minimum_storage >= 0)
> +        g_assert_true(recommended_storage >= minimum_storage);
> +}
> +
> +static void
> +test_minimum_recommended_resources(void)
> +{
> +    OsinfoLoader *loader = osinfo_loader_new();
> +    OsinfoDb *db = osinfo_loader_get_db(loader);
> +    OsinfoOsList *oslist;
> +    GList *oses;
> +    GList *oses_it;
> +    GError *error = NULL;
> +
> +    g_assert_true(OSINFO_IS_LOADER(loader));
> +    g_assert_true(OSINFO_IS_DB(db));
> +
> +    osinfo_loader_process_default_path(loader, &error);
> +    g_assert_no_error(error);
> +
> +    oslist = osinfo_db_get_os_list(db);
> +    oses = osinfo_list_get_elements(OSINFO_LIST(oslist));
> +
> +    for (oses_it = oses; oses_it != NULL; oses_it = oses_it->next) {
> +        OsinfoOs *os = oses->data;
> +        OsinfoResourcesList *minimum_list, *recommended_list;
> +        GList *minimum_resources, *recommended_resources;
> +        GList *resources_it;
> +        const gchar *minimum_arch, *recommended_arch;
> +
> +        minimum_list = osinfo_os_get_minimum_resources(os);
> +        minimum_resources = osinfo_list_get_elements(OSINFO_LIST(minimum_list));
> +
> +        recommended_list = osinfo_os_get_recommended_resources(os);
> +        recommended_resources = osinfo_list_get_elements(OSINFO_LIST(recommended_list));
> +
> +        /* That's fine as not all OSes have those fields filled */
> +        if (minimum_resources == NULL || recommended_resources == NULL)
> +            goto next;
> +
> +        for (resources_it = minimum_resources; resources_it != NULL; resources_it = resources_it->next) {
> +            OsinfoResources *minimum = resources_it->data;
> +            GList *tmp = recommended_resources;
> +
> +            minimum_arch = osinfo_resources_get_architecture(minimum);
> +
> +            for (; tmp != NULL; tmp = tmp->next) {
> +                OsinfoResources *recommended = tmp->data;
> +
> +                recommended_arch = osinfo_resources_get_architecture(recommended);
> +
> +                 if (g_str_equal(minimum_arch, recommended_arch)) {
> +                    const gchar *name;
> +
> +                    name = osinfo_product_get_name(OSINFO_PRODUCT(os));
> +
> +                    g_test_message("checking %s (architecture: %s)",
> +                                   name, minimum_arch);
> +
> +                    test_n_cpus(minimum, recommended);
> +                    test_cpu(minimum, recommended);
> +                    test_ram(minimum, recommended);
> +                    test_storage(minimum, recommended);
> +                    break;
> +                }
> +            }
> +        }
> +
> +next:
> +        g_list_free(minimum_resources);
> +        g_list_free(recommended_resources);
> +        g_object_unref(minimum_list);
> +        g_object_unref(recommended_list);
> +    }
> +
> +    g_object_unref(oslist);
> +    g_list_free(oses);
> +
> +    g_object_unref(loader);
> +}
> +
> +
> +int
> +main(int argc, char *argv[])
> +{
> +    int ret;
> +
> +    g_test_init(&argc, &argv, NULL);
> +
> +    g_test_add_func("/os/resources/minimum_recommended", test_minimum_recommended_resources);
> +
> +    /* Upfront so we don't confuse valgrind */
> +    osinfo_entity_get_type();
> +    osinfo_db_get_type();
> +    osinfo_device_get_type();
> +    osinfo_platform_get_type();
> +    osinfo_os_get_type();
> +    osinfo_list_get_type();
> +    osinfo_devicelist_get_type();
> +    osinfo_platformlist_get_type();
> +    osinfo_oslist_get_type();
> +    osinfo_filter_get_type();
> +
> +    ret = g_test_run();
> +
> +    return ret;
> +}
> +/*
> + * Local variables:
> + *  indent-tabs-mode: nil
> + *  c-indent-level: 4
> + *  c-basic-offset: 4
> + * End:
> + */
> -- 
> 2.14.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/f7c75ac6/attachment.sig>

From cfergeau at redhat.com  Thu May 31 12:23:23 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 14:23:23 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the
 volume-id regex
In-Reply-To: <CAK9pz9+5HFT8yQr-WDR51g16HZ6YiiMB4oxZqn4DwBmWS0WrJQ@mail.gmail.com>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-7-fabiano@fidencio.org>
	<20180531085434.GA4148@natto.ory.fergeau.eu>
	<CAK9pz9+5HFT8yQr-WDR51g16HZ6YiiMB4oxZqn4DwBmWS0WrJQ@mail.gmail.com>
Message-ID: <20180531122323.GI4148@natto.ory.fergeau.eu>

On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fid?ncio wrote:
> On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau
> <cfergeau at redhat.com> wrote:
> > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fid?ncio wrote:
> >> The regex to match unknown openSUSE prereleases is becoming
> >> bigger and harder to read.
> >>
> >> Basically, what it's doing is:
> >>
> >> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])
> >> ---------   -----  ----------------   ---- -------------
> >>     |         |         |                |       |
> >>     v         v         v                |       v
> >>   15.1+      16     20, 30, 50 - 90      v     43.0+
> >>                                   .0, .1, ..., .9
> >>
> >> I'm desconsidering both the 13.x series or older and 42.x series as
> >> those are not going to have new releases anymore.
> >
> > "desconsidering"? Dropping?
> 
> I'll change it to "Dropping" before pushing.
> 
> > Note that
> > https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the
> > door on another 42.x release "There are currently no plans to release an
> > openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but
> > that's close enough.
> > Are they really going to release 43.x in parallel to/after 15.x?
> 
> No, they have no intention to release 43.x. I've talked to Richard
> Brown about this during openSUSE conference last weekend and
> explanation he gave me is that they're moving back to a number that
> would match SLES.
> The whole 42.x series was in order to totally distinguish between the
> old base they had with the new shiny system that Leap was supposed to
> be.
> 
> So, they're now following 15.x ... if at some point SLES will have a
> 16.x opensuse 16.x will come to the playground as well.

Your regexp in the commit log and in your patch has a 43.x part, so this
can be dropped.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/247be170/attachment.sig>

From cfergeau at redhat.com  Thu May 31 12:24:18 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 14:24:18 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
 install-script: Skip second stage
In-Reply-To: <CAK9pz9+x9fSuhAy5pHQ4hptJxA_C=zwnWaK+CNLwMT4ysyuYQA@mail.gmail.com>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-2-fabiano@fidencio.org>
	<20180531091114.GB4148@natto.ory.fergeau.eu>
	<CAK9pz9+x9fSuhAy5pHQ4hptJxA_C=zwnWaK+CNLwMT4ysyuYQA@mail.gmail.com>
Message-ID: <20180531122418.GJ4148@natto.ory.fergeau.eu>

On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fid?ncio wrote:
> > If they are public, what happens in libosinfo if we try to set a
> > non-existent parameter? In other word, should we consider this an
> > API/ABI break, or are we fine with dropping it?
> 
> We're totally fine dropping it.
> If we try to set a non-existent parameter (or pattern) autoyast is
> smart enough to not break the installation because of that.

My worry was in libosinfo API, what happens to code using libosinfo and
trying to set this config parameter? Is this going to cause problems? Or
will it just be ignored?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/c8cb6609/attachment.sig>

From fabiano at fidencio.org  Thu May 31 12:55:18 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 31 May 2018 14:55:18 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
 install-script: Skip second stage
In-Reply-To: <20180531122418.GJ4148@natto.ory.fergeau.eu>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-2-fabiano@fidencio.org>
	<20180531091114.GB4148@natto.ory.fergeau.eu>
	<CAK9pz9+x9fSuhAy5pHQ4hptJxA_C=zwnWaK+CNLwMT4ysyuYQA@mail.gmail.com>
	<20180531122418.GJ4148@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9+Oj91Z0CU7+Zx-JaL-zWWvtWmTL8mQoUs1CDGeXhQ1nA@mail.gmail.com>

On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fid?ncio wrote:
>> > If they are public, what happens in libosinfo if we try to set a
>> > non-existent parameter? In other word, should we consider this an
>> > API/ABI break, or are we fine with dropping it?
>>
>> We're totally fine dropping it.
>> If we try to set a non-existent parameter (or pattern) autoyast is
>> smart enough to not break the installation because of that.
>
> My worry was in libosinfo API, what happens to code using libosinfo and
> trying to set this config parameter? Is this going to cause problems? Or
> will it just be ignored?

I see. About this, we don't actually set this parameter never ever.
It's been only internal so far.
Sorry, just now I understood your question :-/

>
> Christophe



-- 
Fabiano Fid?ncio



From fabiano at fidencio.org  Thu May 31 12:57:14 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 31 May 2018 14:57:14 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the
 volume-id regex
In-Reply-To: <20180531122323.GI4148@natto.ory.fergeau.eu>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-7-fabiano@fidencio.org>
	<20180531085434.GA4148@natto.ory.fergeau.eu>
	<CAK9pz9+5HFT8yQr-WDR51g16HZ6YiiMB4oxZqn4DwBmWS0WrJQ@mail.gmail.com>
	<20180531122323.GI4148@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9+eN88q=cP6+zcmr0WhR1JQutXdyGVy+wRF+=viH_Rwew@mail.gmail.com>

On Thu, May 31, 2018 at 2:23 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fid?ncio wrote:
>> On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau
>> <cfergeau at redhat.com> wrote:
>> > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fid?ncio wrote:
>> >> The regex to match unknown openSUSE prereleases is becoming
>> >> bigger and harder to read.
>> >>
>> >> Basically, what it's doing is:
>> >>
>> >> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])
>> >> ---------   -----  ----------------   ---- -------------
>> >>     |         |         |                |       |
>> >>     v         v         v                |       v
>> >>   15.1+      16     20, 30, 50 - 90      v     43.0+
>> >>                                   .0, .1, ..., .9
>> >>
>> >> I'm desconsidering both the 13.x series or older and 42.x series as
>> >> those are not going to have new releases anymore.
>> >
>> > "desconsidering"? Dropping?
>>
>> I'll change it to "Dropping" before pushing.
>>
>> > Note that
>> > https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the
>> > door on another 42.x release "There are currently no plans to release an
>> > openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but
>> > that's close enough.
>> > Are they really going to release 43.x in parallel to/after 15.x?
>>
>> No, they have no intention to release 43.x. I've talked to Richard
>> Brown about this during openSUSE conference last weekend and
>> explanation he gave me is that they're moving back to a number that
>> would match SLES.
>> The whole 42.x series was in order to totally distinguish between the
>> old base they had with the new shiny system that Leap was supposed to
>> be.
>>
>> So, they're now following 15.x ... if at some point SLES will have a
>> 16.x opensuse 16.x will come to the playground as well.
>
> Your regexp in the commit log and in your patch has a 43.x part, so this
> can be dropped.

I see where the confusion came from.
So, if you don't mind I'd prefer to keep it there because the regex is
keep everything:
15.1+, 16-41,  NOT 42, 43-99

>
> Christophe

If you have some strong feelings about this, then I'll drop it.

-- 
Fabiano Fid?ncio



From cfergeau at redhat.com  Thu May 31 13:33:56 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 15:33:56 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the
 volume-id regex
In-Reply-To: <CAK9pz9+eN88q=cP6+zcmr0WhR1JQutXdyGVy+wRF+=viH_Rwew@mail.gmail.com>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-7-fabiano@fidencio.org>
	<20180531085434.GA4148@natto.ory.fergeau.eu>
	<CAK9pz9+5HFT8yQr-WDR51g16HZ6YiiMB4oxZqn4DwBmWS0WrJQ@mail.gmail.com>
	<20180531122323.GI4148@natto.ory.fergeau.eu>
	<CAK9pz9+eN88q=cP6+zcmr0WhR1JQutXdyGVy+wRF+=viH_Rwew@mail.gmail.com>
Message-ID: <20180531133356.GL4148@natto.ory.fergeau.eu>

On Thu, May 31, 2018 at 02:57:14PM +0200, Fabiano Fid?ncio wrote:
> On Thu, May 31, 2018 at 2:23 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fid?ncio wrote:
> >> On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau
> >> <cfergeau at redhat.com> wrote:
> >> > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fid?ncio wrote:
> >> >> The regex to match unknown openSUSE prereleases is becoming
> >> >> bigger and harder to read.
> >> >>
> >> >> Basically, what it's doing is:
> >> >>
> >> >> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])
> >> >> ---------   -----  ----------------   ---- -------------
> >> >>     |         |         |                |       |
> >> >>     v         v         v                |       v
> >> >>   15.1+      16     20, 30, 50 - 90      v     43.0+
> >> >>                                   .0, .1, ..., .9
> >> >>
> >> >> I'm desconsidering both the 13.x series or older and 42.x series as
> >> >> those are not going to have new releases anymore.
> >> >
> >> > "desconsidering"? Dropping?
> >>
> >> I'll change it to "Dropping" before pushing.
> >>
> >> > Note that
> >> > https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the
> >> > door on another 42.x release "There are currently no plans to release an
> >> > openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but
> >> > that's close enough.
> >> > Are they really going to release 43.x in parallel to/after 15.x?
> >>
> >> No, they have no intention to release 43.x. I've talked to Richard
> >> Brown about this during openSUSE conference last weekend and
> >> explanation he gave me is that they're moving back to a number that
> >> would match SLES.
> >> The whole 42.x series was in order to totally distinguish between the
> >> old base they had with the new shiny system that Leap was supposed to
> >> be.
> >>
> >> So, they're now following 15.x ... if at some point SLES will have a
> >> 16.x opensuse 16.x will come to the playground as well.
> >
> > Your regexp in the commit log and in your patch has a 43.x part, so this
> > can be dropped.
> 
> I see where the confusion came from.
> So, if you don't mind I'd prefer to keep it there because the regex is
> keep everything:
> 15.1+, 16-41,  NOT 42, 43-99

Ah ok, you want to match all version numbers which never corresponded to
something which was released.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/3af0e809/attachment.sig>

From cfergeau at redhat.com  Thu May 31 13:35:54 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 15:35:54 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
 install-script: Skip second stage
In-Reply-To: <CAK9pz9+Oj91Z0CU7+Zx-JaL-zWWvtWmTL8mQoUs1CDGeXhQ1nA@mail.gmail.com>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-2-fabiano@fidencio.org>
	<20180531091114.GB4148@natto.ory.fergeau.eu>
	<CAK9pz9+x9fSuhAy5pHQ4hptJxA_C=zwnWaK+CNLwMT4ysyuYQA@mail.gmail.com>
	<20180531122418.GJ4148@natto.ory.fergeau.eu>
	<CAK9pz9+Oj91Z0CU7+Zx-JaL-zWWvtWmTL8mQoUs1CDGeXhQ1nA@mail.gmail.com>
Message-ID: <20180531133554.GM4148@natto.ory.fergeau.eu>

On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fid?ncio wrote:
> On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fid?ncio wrote:
> >> > If they are public, what happens in libosinfo if we try to set a
> >> > non-existent parameter? In other word, should we consider this an
> >> > API/ABI break, or are we fine with dropping it?
> >>
> >> We're totally fine dropping it.
> >> If we try to set a non-existent parameter (or pattern) autoyast is
> >> smart enough to not break the installation because of that.
> >
> > My worry was in libosinfo API, what happens to code using libosinfo and
> > trying to set this config parameter? Is this going to cause problems? Or
> > will it just be ignored?
> 
> I see. About this, we don't actually set this parameter never ever.
> It's been only internal so far.

"we"? My question was more if hypothetical "unknown" libosinfo users
could try to use that, and get failures after it gets removed. I agree
it's very far fetched, I was just trying to assess the impact of this
removal ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/558dae8d/attachment.sig>

From fabiano at fidencio.org  Thu May 31 14:19:54 2018
From: fabiano at fidencio.org (=?UTF-8?Q?Fabiano_Fid=C3=AAncio?=)
Date: Thu, 31 May 2018 16:19:54 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
 install-script: Skip second stage
In-Reply-To: <20180531133554.GM4148@natto.ory.fergeau.eu>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-2-fabiano@fidencio.org>
	<20180531091114.GB4148@natto.ory.fergeau.eu>
	<CAK9pz9+x9fSuhAy5pHQ4hptJxA_C=zwnWaK+CNLwMT4ysyuYQA@mail.gmail.com>
	<20180531122418.GJ4148@natto.ory.fergeau.eu>
	<CAK9pz9+Oj91Z0CU7+Zx-JaL-zWWvtWmTL8mQoUs1CDGeXhQ1nA@mail.gmail.com>
	<20180531133554.GM4148@natto.ory.fergeau.eu>
Message-ID: <CAK9pz9+Gxt0YogbVHMwxMPqek3Sted9cJ3hQkfHg3-nBJUjQ9g@mail.gmail.com>

On Thu, May 31, 2018 at 3:35 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fid?ncio wrote:
>> On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fid?ncio wrote:
>> >> > If they are public, what happens in libosinfo if we try to set a
>> >> > non-existent parameter? In other word, should we consider this an
>> >> > API/ABI break, or are we fine with dropping it?
>> >>
>> >> We're totally fine dropping it.
>> >> If we try to set a non-existent parameter (or pattern) autoyast is
>> >> smart enough to not break the installation because of that.
>> >
>> > My worry was in libosinfo API, what happens to code using libosinfo and
>> > trying to set this config parameter? Is this going to cause problems? Or
>> > will it just be ignored?
>>
>> I see. About this, we don't actually set this parameter never ever.
>> It's been only internal so far.
>
> "we"? My question was more if hypothetical "unknown" libosinfo users
> could try to use that, and get failures after it gets removed. I agree
> it's very far fetched, I was just trying to assess the impact of this
> removal ;)
>

"We" :-)
I meant, libosinfo doesn't even expose this option, never ever.
May be the case, at some point in the future, that we'll need to
expose it and leave it to the user decide whether they want or not to
add some additional scripts to configure something post installation,

That's not the case for now.

> Christophe

Thanks a lot for the review, Christophe!

-- 
Fabiano Fid?ncio



From cfergeau at redhat.com  Thu May 31 15:15:09 2018
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 31 May 2018 17:15:09 +0200
Subject: [Libosinfo] [osinfo-db][PATCH] opensuse,
 install-script: Skip second stage
In-Reply-To: <CAK9pz9+Gxt0YogbVHMwxMPqek3Sted9cJ3hQkfHg3-nBJUjQ9g@mail.gmail.com>
References: <20180526202946.7606-1-fabiano@fidencio.org>
	<20180526202946.7606-2-fabiano@fidencio.org>
	<20180531091114.GB4148@natto.ory.fergeau.eu>
	<CAK9pz9+x9fSuhAy5pHQ4hptJxA_C=zwnWaK+CNLwMT4ysyuYQA@mail.gmail.com>
	<20180531122418.GJ4148@natto.ory.fergeau.eu>
	<CAK9pz9+Oj91Z0CU7+Zx-JaL-zWWvtWmTL8mQoUs1CDGeXhQ1nA@mail.gmail.com>
	<20180531133554.GM4148@natto.ory.fergeau.eu>
	<CAK9pz9+Gxt0YogbVHMwxMPqek3Sted9cJ3hQkfHg3-nBJUjQ9g@mail.gmail.com>
Message-ID: <20180531151509.GO4148@natto.ory.fergeau.eu>

On Thu, May 31, 2018 at 04:19:54PM +0200, Fabiano Fid?ncio wrote:
> On Thu, May 31, 2018 at 3:35 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fid?ncio wrote:
> >> On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> >> > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fid?ncio wrote:
> >> >> > If they are public, what happens in libosinfo if we try to set a
> >> >> > non-existent parameter? In other word, should we consider this an
> >> >> > API/ABI break, or are we fine with dropping it?
> >> >>
> >> >> We're totally fine dropping it.
> >> >> If we try to set a non-existent parameter (or pattern) autoyast is
> >> >> smart enough to not break the installation because of that.
> >> >
> >> > My worry was in libosinfo API, what happens to code using libosinfo and
> >> > trying to set this config parameter? Is this going to cause problems? Or
> >> > will it just be ignored?
> >>
> >> I see. About this, we don't actually set this parameter never ever.
> >> It's been only internal so far.
> >
> > "we"? My question was more if hypothetical "unknown" libosinfo users
> > could try to use that, and get failures after it gets removed. I agree
> > it's very far fetched, I was just trying to assess the impact of this
> > removal ;)
> >
> 
> "We" :-)
> I meant, libosinfo doesn't even expose this option, never ever.

Ah ok, I was not fully sure if tihs was the case or not, thanks for
bearing with me. And sorry for spending time on something that did not
need discussing!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180531/d52c1bc7/attachment.sig>