[Libosinfo] [libosinfo PATCH v2 2/2] tests: Fix `make check` breakage for FreeBSD 11

Fabiano Fidêncio fidencio at redhat.com
Tue Nov 20 14:11:24 UTC 2018


Let's take advantage of the newly added libosinfo-impl.la that contains
all the symbols that we need and link our tests against it.

By doing so, we can remove the referrence to osinfo_product.c when
building test-os, which has been causing test-os binary to contain 2
copies of the very same code, one linked in the test and the other from
libosinfo.so.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
---
 tests/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index b239ecd..00dcc9c 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -31,7 +31,7 @@ COMMON_LDADD = \
 	$(COVERAGE_LDFLAGS) \
 	$(GLIB_LIBS) \
 	$(GOBJECT_LIBS) \
-	../osinfo/libosinfo-1.0.la
+	../osinfo/libosinfo-impl.la
 COMMON_CFLAGS = \
 	$(WARN_CFLAGS) \
 	$(COVERAGE_CFLAGS) \
@@ -60,7 +60,7 @@ test_product_SOURCES = test-product.c
 
 test_os_LDADD = $(COMMON_LDADD)
 test_os_CFLAGS = $(COMMON_CFLAGS)
-test_os_SOURCES = test-os.c ../osinfo/osinfo_product.c
+test_os_SOURCES = test-os.c
 
 test_productfilter_LDADD = $(COMMON_LDADD)
 test_productfilter_CFLAGS = $(COMMON_CFLAGS)
-- 
2.19.1




More information about the Libosinfo mailing list