[Libosinfo] [PATCH osinfo-db v2 3/5] device: Add chipset q35

[Fabiano Fidêncio]

On Thu, 2018-10-04 at 09:31 +0200, Fabiano Fidêncio wrote:
> On Fri, 2018-09-28 at 18:55 -0400, Cole Robinson wrote:
> > Introduce a new URI scheme and class chipset.virtual, rather
> > than attach this to any particular PCI ID.
> > 
> > Signed-off-by: Cole Robinson <crobinso at redhat.com>
> > ---
> >  data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in | 8
> > ++++++++
> >  data/schema/osinfo.rng.in                              | 1 +
> >  2 files changed, 9 insertions(+)
> >  create mode 100644 data/device/qemu.org/chipset-x86_64-
> > q35.d/class.xml.in
> > 
> > diff --git a/data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in
> > b/data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in
> > new file mode 100644
> > index 0000000..6920c67
> > --- /dev/null
> > +++ b/data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in
> > @@ -0,0 +1,8 @@
> > +<libosinfo version="0.0.1">
> > +<!-- Licensed under the GNU General Public License version 2 or
> > later.
> > +     See http://www.gnu.org/licenses/ for a copy of the license
> > text
> > -->
> > +  <device id="http://qemu.org/chipset/x86_64/q35">
> > +    <name>q35</name>
> > +    <class>chipset.virtual</class>
> > +  </device>
> > +</libosinfo>
> > diff --git a/data/schema/osinfo.rng.in b/data/schema/osinfo.rng.in
> > index fa09249..fc45dbd 100644
> > --- a/data/schema/osinfo.rng.in
> > +++ b/data/schema/osinfo.rng.in
> > @@ -77,6 +77,7 @@
> >                <value>audio</value>
> >                <value>block</value>
> >                <value>console</value>
> > +              <value>chipset.virtual</value>
> >                <value>controller.usb</value>
> >                <value>filesystem</value>
> >                <value>input</value>
> 
> Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

Ooops, sorry, the "Reviewed-by" has been added by mistake in this
patch.

I can't ACK this patch yet at least not before we have a better idea on
the discussion your started in the cover-letter.

Before having this ACK'ed, I really would like to have an agreement
whether we're going to also add the <arch>/<platform> fields as well
and have a bug opened for that as I don't believe that's something
strictly needed for now!