[Libosinfo] [PATCH osinfo-db] centos: Add Live{GNOME, KDE} media info

[Fabiano Fidêncio]

On Wed, Sep 5, 2018 at 12:52 AM, Cole Robinson <crobinso at redhat.com> wrote:
> On 09/03/2018 04:23 AM, Fabiano Fidêncio wrote:
>>
>> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
>> ---
>>   data/os/centos.org/centos-7.0.xml.in | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/data/os/centos.org/centos-7.0.xml.in
>> b/data/os/centos.org/centos-7.0.xml.in
>> index cdeb28a..c42f66f 100644
>> --- a/data/os/centos.org/centos-7.0.xml.in
>> +++ b/data/os/centos.org/centos-7.0.xml.in
>> @@ -22,6 +22,15 @@
>>         <initrd>isolinux/initrd.img</initrd>
>>       </media>
>>   +    <media arch="x86_64" live="true">
>> +      <iso>
>> +        <system-id>LINUX</system-id>
>> +        <volume-id>CentOS-7-x86_64-Live.*</volume-id>
>> +      </iso>
>> +      <kernel>isolinux/vmlinuz</kernel>
>> +      <initrd>isolinux/initrd.img</initrd>
>> +    </media>
>> +
>>       <resources arch="all">
>>         <minimum>
>>           <n-cpus>1</n-cpus>
>>
>
> Reviewed-by: Cole Robinson <crobinso at redhat.com>

Cole,

Firstly, thanks for the review.
Unfortunately, I've noticed that the kernel/initrd are not correct (sorry!).

[fidencio at dahmer osinfo-db]$ ls
/run/media/fidencio/CentOS-7-x86_64-LiveGNOME-1804/isolinux/
boot.cat  initrd0.img  isolinux.bin  isolinux.cfg  vesamenu.c32  vmlinuz0
[fidencio at dahmer osinfo-db]$ ls
/run/media/fidencio/CentOS-7-x86_64-LiveKDE-1804/isolinux/
boot.cat  initrd0.img  isolinux.bin  isolinux.cfg  vesamenu.c32  vmlinuz0

So, the correct values should be:
      <kernel>isolinux/vmlinuz0</kernel>
      <initrd>isolinux/initrd0.img</initrd>

May I ask for a second Ack for these fixes before pushing the patches? :-)

Best Regards,
--
Fabiano Fidêncio