[Libosinfo] [libosinfo PATCH 1/3] db: Set the os to the detected tree

[Fabiano Fidêncio]

On Fri, Apr 12, 2019 at 10:23 AM Daniel P. Berrangé <berrange at redhat.com> wrote:
>
> On Fri, Apr 12, 2019 at 10:19:52AM +0200, Fabiano Fidêncio wrote:
> > When detecting a tree, let's also its OS.
>
>                                   ^^^^  word missing ?

Fixed locally.
"When detecting a tree, let's also set its OS".

May I consider your comments a R-b for patches 1 and 3?

>
> >
> > https://gitlab.com/libosinfo/libosinfo/issues/25
> >
> > Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> > ---
> >  osinfo/osinfo_db.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/osinfo/osinfo_db.c b/osinfo/osinfo_db.c
> > index 1089644..b7da2b7 100644
> > --- a/osinfo/osinfo_db.c
> > +++ b/osinfo/osinfo_db.c
> > @@ -829,8 +829,10 @@ static gboolean compare_tree(OsinfoTree *tree,
> >          g_list_free(trees);
> >          g_object_unref(tree_list);
> >
> > -        if (*ret_os != NULL)
> > +        if (*ret_os != NULL) {
> > +            osinfo_tree_set_os(*matched, *ret_os);
> >              return TRUE;
> > +        }
> >      }
> >
> >      return FALSE;
> > --
> > 2.20.1
> >
> > _______________________________________________
> > Libosinfo mailing list
> > Libosinfo at redhat.com
> > https://www.redhat.com/mailman/listinfo/libosinfo
>
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|