[Libosinfo] [osinfo-db PATCH v2 0/8] Various fixes and improvements

Fabiano Fidêncio fidencio at redhat.com
Tue Apr 23 07:19:16 UTC 2019


Andrea,

On Thu, 2019-04-18 at 10:02 +0200, Andrea Bolognani wrote:
> Changes from [v1]:
> 
>   * don't add <codename> to <name>;
>   * make <codename>s for Debian releases lowercase, as they
>     should be;
>   * sync information for Debian releases further with what is
>     used by the Debian Project;
>   * fix issues spotted during review.
> 
> [v1] 
> https://www.redhat.com/archives/libosinfo/2019-April/msg00126.html
> 
> Andrea Bolognani (8):
>   ubuntu19.04: Fix <short-id>
>   macosx: Add <codename>s for all releases
>   debian: Add <codename>s for all releases
>   debian: Fix <name> for Debian testing
>   debian: Update <name>s for all releases
>   debian: Fix <version>s for several releases

Based on the reviews from Dan I'm pushing all the patches above.

>   debian: Add new <short-id>s for several releases

This one, as it's right now, is going to backward compatibility.
What I'd like to do, if you agree, is to change the order and introduce
the short-ids you added *after* the current ones. With this change,
absolutely nothing is going to change *for* *now*.

I'm working on having support for multiple short-ids on libosinfo side
and once this work lands upstream, then your patches will actually be
used.

Does this make sense? Do you agree with the approach?

>   debian: Update <id>s for several releases

This one, as mentioned by Dan, is a no-go. :-)

> 
>  data/os/apple.com/macosx-10.0.xml.in                 |  1 +
>  data/os/apple.com/macosx-10.1.xml.in                 |  1 +
>  data/os/apple.com/macosx-10.2.xml.in                 |  1 +
>  data/os/apple.com/macosx-10.3.xml.in                 |  1 +
>  data/os/apple.com/macosx-10.4.xml.in                 |  1 +
>  data/os/apple.com/macosx-10.5.xml.in                 |  1 +
>  data/os/apple.com/macosx-10.6.xml.in                 |  1 +
>  data/os/apple.com/macosx-10.7.xml.in                 |  1 +
>  data/os/debian.org/debian-1.1.xml.in                 |  3 ++-
>  data/os/debian.org/debian-1.2.xml.in                 |  3 ++-
>  data/os/debian.org/debian-1.3.xml.in                 |  3 ++-
>  data/os/debian.org/debian-2.0.xml.in                 |  3 ++-
>  data/os/debian.org/debian-2.1.xml.in                 |  3 ++-
>  data/os/debian.org/debian-2.2.xml.in                 |  3 ++-
>  .../{debian-3.xml.in => debian-3.0.xml.in}           |  8 +++++---
>  data/os/debian.org/debian-3.1.xml.in                 |  7 ++++---
>  .../{debian-4.xml.in => debian-4.0.xml.in}           |  8 +++++---
>  .../{debian-5.xml.in => debian-5.0.xml.in}           | 12 +++++++---
> --
>  .../{debian-6.xml.in => debian-6.0.xml.in}           | 12 +++++++---
> --
>  data/os/debian.org/debian-7.xml.in                   |  7 ++++---
>  data/os/debian.org/debian-8.xml.in                   |  3 ++-
>  data/os/debian.org/debian-9.xml.in                   |  3 ++-
>  data/os/debian.org/debian-testing.xml.in             |  2 +-
>  data/os/ubuntu.com/ubuntu-19.04.xml.in               |  2 +-
>  24 files changed, 58 insertions(+), 32 deletions(-)
>  rename data/os/debian.org/{debian-3.xml.in => debian-3.0.xml.in}
> (75%)
>  rename data/os/debian.org/{debian-4.xml.in => debian-4.0.xml.in}
> (75%)
>  rename data/os/debian.org/{debian-5.xml.in => debian-5.0.xml.in}
> (77%)
>  rename data/os/debian.org/{debian-6.xml.in => debian-6.0.xml.in}
> (89%)
> 

Best Regards and thanks for your contributions!
-- 
Fabiano Fidêncio




More information about the Libosinfo mailing list