[Libosinfo] [osinfo-db PATCH 2/3] windows, unattend: Set password as plain text

[Daniel P. Berrangé]

On Wed, Feb 06, 2019 at 12:40:32PM +0100, Fabiano Fidêncio wrote:
> On Wed, Feb 6, 2019 at 10:13 AM Daniel P. Berrangé <berrange at redhat.com> wrote:
> >
> > On Tue, Feb 05, 2019 at 08:40:35PM +0100, Fabiano Fidêncio wrote:
> > > Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> > > ---
> > >  data/install-script/microsoft.com/windows-unattend-jeos.xml.in | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/data/install-script/microsoft.com/windows-unattend-jeos.xml.in b/data/install-script/microsoft.com/windows-unattend-jeos.xml.in
> > > index f738b86..27acc7f 100644
> > > --- a/data/install-script/microsoft.com/windows-unattend-jeos.xml.in
> > > +++ b/data/install-script/microsoft.com/windows-unattend-jeos.xml.in
> > > @@ -171,7 +171,7 @@
> > >                     <LocalAccount wcm:action="add">
> > >                       <Password>
> > >                         <Value><xsl:value-of select="config/user-password"/></Value>
> > > -                       <PlainText>false</PlainText>
> > > +                       <PlainText>true</PlainText>
> >
> > Surely this is going to break existing applications that are using
> > this template & passing an already encrypted password.
> 
> Yep, but keep in mind that there's no existing applications using this
> template. Boxes doesn't use JeOS at all and support for virt-install
> is something that I'm working on right now (and thus, having those
> bits tested).

Ah I missed that. I also see this is the outlier - all the other
cases of <PlainText>..</PlainText> are already set to true.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|