[Libosinfo] [osinfo-db PATCH v2 14/29] ubuntu, jeos: Tune extra installed softwares

[Fabiano Fidêncio]

On Wed, 2019-02-27 at 14:09 -0500, Cole Robinson wrote:
> On 2/19/19 11:27 AM, Fabiano Fidêncio wrote:
> > Seems that although openssh-server is present in all ubuntu
> > servers,
> > python-software-properties is not.
> > 
> > For newer versions of ubuntu, let's just install
> > python3-software-properties.
> > 
> > For 12.04, let's install python-software-properties.
> > 
> > For 12.10, let's avoid installing as it'd raise an error during
> > installation.
> > 
> > Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> > ---
> >  .../ubuntu.com/ubuntu-preseed-jeos.xml.in            | 12
> > +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> 
> I think the deliberate omission of 12.10 could use a comment in the
> XML

The following fixup will be squashed to the original one:
diff --git a/data/install-script/ubuntu.com/ubuntu-preseed-jeos.xml.in
b/data/install-script/ubuntu.com/ubuntu-preseed-jeos.xml.in
index 7031a14..1a9ed95 100644
--- a/data/install-script/ubuntu.com/ubuntu-preseed-jeos.xml.in
+++ b/data/install-script/ubuntu.com/ubuntu-preseed-jeos.xml.in
@@ -88,6 +88,8 @@ d-i pkgsel/include string openssh-server
       <xsl:if test="os/version = 12.04">
 d-i pkgsel/include string python-software-properties
       </xsl:if>
+      <!-- Let's avoid installating python-software-properties
+           for 12.10 as it'd raise an error during installation. -->
   </xsl:when>
   <xsl:otherwise>
 d-i pkgsel/include string python3-software-properties

[snip]