[Libosinfo] [osinfo-db | libosinfo PATCH 0/4] Don't assume media identifiers are null terminated strings

Fabiano Fidêncio fidencio at redhat.com
Wed Feb 13 19:19:23 UTC 2019


While working on something completely unrelated, I've noticed that one
Ubuntu ISO was not being recognized by libosinfo.

After spending some time trying to understand why, I've noticed that
libosinfo is considering that the maximum size of the volume-id would
be '\0', which is not the case.

So, this patch series provide:
- Improvement for Ubuntu's volume-id regex;
- Fixes for libosinfo in order to properly deal with the media
  identifiers in case those have the maximum allowed size;
- Adding test data for Ubuntu that covers the fixed case;

osinfo-db:
  Fabiano Fidêncio (1):
    ubuntu: Improve the volume-id regex

   data/os/ubuntu.com/ubuntu-10.04.xml.in |  4 ++--
   data/os/ubuntu.com/ubuntu-12.04.xml.in |  8 ++++----
   data/os/ubuntu.com/ubuntu-14.04.xml.in |  8 ++++----
   data/os/ubuntu.com/ubuntu-14.10.xml.in |  8 ++++----
   data/os/ubuntu.com/ubuntu-15.04.xml.in |  8 ++++----
   data/os/ubuntu.com/ubuntu-15.10.xml.in |  8 ++++----
   data/os/ubuntu.com/ubuntu-16.04.xml.in | 14 ++++++-------
   data/os/ubuntu.com/ubuntu-16.10.xml.in | 16 +++++++--------
   data/os/ubuntu.com/ubuntu-17.04.xml.in | 14 ++++++-------
   data/os/ubuntu.com/ubuntu-17.10.xml.in | 12 +++++------
   data/os/ubuntu.com/ubuntu-18.04.xml.in | 10 ++++-----
   data/os/ubuntu.com/ubuntu-18.10.xml.in | 12 +++++------
   data/os/ubuntu.com/ubuntu-19.04.xml.in | 10 ++++-----
   data/os/ubuntu.com/ubuntu-6.06.xml.in  | 28 +++++++++++++-------------
   data/os/ubuntu.com/ubuntu-8.04.xml.in  | 12 +++++------
   data/os/ubuntu.com/ubuntu-9.04.xml.in  |  8 ++++----
   16 files changed, 90 insertions(+), 90 deletions(-)

libosinfo:
  Fabiano Fidêncio (3):
    media: Don't assume identifiers are null terminated
    tests: Add ubuntu 18.04.1 test data
    tests: Add ubuntu 18.04.1.0 test data

   osinfo/osinfo_media.c                         | 37 ++++++++++++-------
   .../ubuntu-18.04.1-desktop-amd64.iso.txt      | 29 +++++++++++++++
   ...ubuntu-18.04.1.0-live-server-amd64.iso.txt | 29 +++++++++++++++
   3 files changed, 81 insertions(+), 14 deletions(-)
   create mode 100644 tests/isodata/ubuntu/ubuntu18.04/ubuntu-18.04.1-desktop-amd64.iso.txt
   create mode 100644 tests/isodata/ubuntu/ubuntu18.04/ubuntu-18.04.1.0-live-server-amd64.iso.txt

-- 
2.20.1




More information about the Libosinfo mailing list