[Libosinfo] [osinfo-db PATCH v2 1/2] win: add Windows Server 2019 data

[Fabiano Fidêncio]

On Wed, Feb 27, 2019 at 4:14 PM Pino Toscano <ptoscano at redhat.com> wrote:

> https://docs.microsoft.com/en-us/windows-server/get-started-19/whats-new-19
>
> This new OS does not include any <media>, and this is done on purpose:
> sadly, the ISOs have the same metadata (like Volume ID, etc) as win2k16
> (Windows Server 2016), and thus it is not possible to distinguish them.
>

Although there are workarounds for detecting medias with the same
volume-id, as setting the media's volume-size, it doesn't look like the way
to go for the Windows(es) medias, as we'd have to add the volume-size for
each one of the supported languages (and also do the same for the 2k16
ones).

Would be nice to have that^ mentioned in the commit log as well.

Do you reword/add that before pushing or shall I do that before I push? :-)


> Regardless, having this OS is still useful for users to match an OS with
> an osinfo ID.
>
---
>  data/os/microsoft.com/win-2k19.xml.in | 32 +++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 data/os/microsoft.com/win-2k19.xml.in
>
> diff --git a/data/os/microsoft.com/win-2k19.xml.in b/data/os/
> microsoft.com/win-2k19.xml.in
> new file mode 100644
> index 0000000..0f291b6
> --- /dev/null
> +++ b/data/os/microsoft.com/win-2k19.xml.in
> @@ -0,0 +1,32 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <os id="http://microsoft.com/win/2k19">
> +    <short-id>win2k19</short-id>
> +    <_name>Microsoft Windows Server 2019</_name>
> +    <version>10.0</version>
> +    <_vendor>Microsoft Corporation</_vendor>
> +    <family>winnt</family>
> +    <distro>win</distro>
> +    <derives-from id="http://microsoft.com/win/2k16"/>
> +    <upgrades id="http://microsoft.com/win/2k16"/>
> +
> +    <release-date>2018-10-02</release-date>
> +
> +    <resources arch="x86_64">
> +      <minimum>
> +        <cpu>1400000000</cpu>
> +        <n-cpus>1</n-cpus>
> +        <ram>536870912</ram>
> +        <storage>34359738368</storage>
> +      </minimum>
> +
> +      <recommended>
> +        <cpu>2000000000</cpu>
> +        <ram>2147483648</ram>
> +        <storage>42949672960</storage>
> +      </recommended>
> +    </resources>
> +
> +  </os>
> +</libosinfo>
> --
> 2.20.1
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

... for both patches.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20190227/d867d236/attachment.htm>