[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libosinfo] [osinfo-db-tools PATCH] tests: Unset OSINFO_LOCAL_DIR envvar



On 7/9/19 4:00 AM, Fabiano Fidêncio wrote:
> Commit 1df4c0dbede tried to unset all OSINFO_*_DIR envvars but instead
> of unsetting OSINFO_LOCAL_DIR it unset OSINFO_DATA_DIR, which doesn't
> exist.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio redhat com>
> ---
>  tests/test_osinfo_db_path.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test_osinfo_db_path.py b/tests/test_osinfo_db_path.py
> index b0b6aff..c862b7a 100755
> --- a/tests/test_osinfo_db_path.py
> +++ b/tests/test_osinfo_db_path.py
> @@ -30,8 +30,8 @@ def test_osinfo_db_path_local():
>      """
>      Test osinfo-db-path --local
>      """
> -    if "OSINFO_DATA_DIR" in os.environ:
> -        del os.environ["OSINFO_DATA_DIR"]
> +    if "OSINFO_LOCAL_DIR" in os.environ:
> +        del os.environ["OSINFO_LOCAL_DIR"]
>      cmd = [util.Tools.db_path, util.ToolsArgs.LOCAL]
>      output = util.get_output(cmd)
>      expected_output = os.path.join(SYSCONFDIR, "osinfo\n")
> 

Reviewed-by: Cole Robinson <crobinso redhat com>

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]